topjohnwu/Magisk

Decorative Section Separators33 hits · 119 pts

Severity	File	Line	Snippet
MEDIUM	native/src/core/zygisk/hook.cpp	31	// ┌───────┐
MEDIUM	native/src/core/zygisk/hook.cpp	34	// │ │ ┌────────────────┐
MEDIUM	native/src/core/zygisk/hook.cpp	35	// │ └────────────────────────────────────────►│LoadNativeBridge│
MEDIUM	native/src/core/zygisk/hook.cpp	36	// │ └───────┬────────┘
MEDIUM	native/src/core/zygisk/hook.cpp	37	// ┌────────────────┐ │ │
MEDIUM	native/src/core/zygisk/hook.cpp	38	// │LoadNativeBridge│◄────────────┼───────────────────────────────────────────────────┘
MEDIUM	native/src/core/zygisk/hook.cpp	39	// └───────┬────┬───┘ │
MEDIUM	native/src/core/zygisk/hook.cpp	40	// │ │ │ ┌───────────────┐
MEDIUM	native/src/core/zygisk/hook.cpp	41	// │ └─────────────────┼────────────────────►│NativeBridgeItf│
MEDIUM	native/src/core/zygisk/hook.cpp	42	// │ │ └──────┬────────┘
MEDIUM	native/src/core/zygisk/hook.cpp	45	// │ │ ┌────────┐
MEDIUM	native/src/core/zygisk/hook.cpp	47	// ▼ │ └────────┘
MEDIUM	native/src/core/zygisk/hook.cpp	48	// ┌───────┐ │
MEDIUM	native/src/core/zygisk/hook.cpp	52	// │ │ ┌───────────────────────┐
MEDIUM	native/src/core/zygisk/hook.cpp	53	// └──────────────────────┼────────────────►│post_native_bridge_load│
MEDIUM	native/src/core/zygisk/hook.cpp	54	// │ └───────────────────────┘
MEDIUM	native/src/core/zygisk/hook.cpp	56	// ┌──────────────────────┐
MEDIUM	native/src/core/zygisk/hook.cpp	58	// └───────────┬────┬─────┘
MEDIUM	native/src/core/zygisk/hook.cpp	59	// │ │ ┌───────────────┐
MEDIUM	native/src/core/zygisk/hook.cpp	60	// │ └───────────────►│hook_zygote_jni│
MEDIUM	native/src/core/zygisk/hook.cpp	61	// │ └───────────────┘ ┌─────────┐
MEDIUM	native/src/core/zygisk/hook.cpp	63	// └────────────────────────────────────────────►│ JVM │
MEDIUM	native/src/core/zygisk/hook.cpp	66	// ┌───────────────────┐ │ │
MEDIUM	native/src/core/zygisk/hook.cpp	67	// │nativeXXXSpecialize│◄─────────────────────────────────────┘ │
MEDIUM	native/src/core/zygisk/hook.cpp	68	// └─────────────┬─────┘ │
MEDIUM	native/src/core/zygisk/hook.cpp	69	// │ ┌─────────────┐ │
MEDIUM	native/src/core/zygisk/hook.cpp	70	// └────────────────►│ZygiskContext│ │
MEDIUM	native/src/core/zygisk/hook.cpp	71	// └─────────────┘ ▼
MEDIUM	native/src/core/zygisk/hook.cpp	72	// ┌────────────────────┐
MEDIUM	native/src/core/zygisk/hook.cpp	74	// └─────────┬──────────┘
MEDIUM	native/src/core/zygisk/hook.cpp	75	// ┌────────────────┐ │
MEDIUM	native/src/core/zygisk/hook.cpp	76	// │restore_plt_hook│◄───────────┘
MEDIUM	native/src/core/zygisk/hook.cpp	77	// └────────────────┘

Over-Commented Block79 hits · 74 pts

Severity	File	Line	Snippet
LOW	native/src/init/twostage.rs	41	}
LOW	native/src/init/selinux.rs	21	const SELINUX_ENFORCE: &Utf8CStr = cstr!(concatcp!(SELINUX_MNT, "/enforce"));
LOW	native/src/core/logging.rs	141	}
LOW	native/src/core/magisk.rs	81	#[derive(FromArgs)]
LOW	native/src/core/zygisk/zygisk.hpp	1	#pragma once
LOW	native/src/core/zygisk/hook.cpp	1	#include <sys/mman.h>
LOW	native/src/core/zygisk/hook.cpp	21	//
LOW	native/src/core/zygisk/hook.cpp	41	// │ └─────────────────┼────────────────────►│NativeBridgeItf│
LOW	native/src/core/zygisk/hook.cpp	61	// │ └───────────────┘ ┌─────────┐
LOW	native/src/core/zygisk/api.hpp	121	// AppSpecializeArgs object. You can read and overwrite these arguments to change how the app
LOW	native/src/core/zygisk/api.hpp	181	struct api_table;
LOW	native/src/core/zygisk/api.hpp	201
LOW	native/src/core/zygisk/api.hpp	221	// function that would be called in the root process with REGISTER_ZYGISK_COMPANION(func).
LOW	native/src/core/zygisk/api.hpp	241	//
LOW	native/src/core/zygisk/api.hpp	261
LOW	native/src/core/include/core.hpp	1	#pragma once
LOW	native/src/core/su/su.cpp	1	/*
LOW	native/src/core/deny/utils.cpp	1	#include <sys/types.h>
LOW	native/src/boot/bootimg.hpp	101	// https://android.googlesource.com/platform/system/tools/mkbootimg/+/refs/heads/android12-release/include/bootimg/booti
LOW	native/src/boot/bootimg.cpp	1	#include <bit>
LOW	native/src/boot/magiskboot.hpp	1	#pragma once
LOW	native/src/boot/magiskboot.hpp	21	#define BOOT_MAGIC "ANDROID!"
LOW	native/src/include/consts.hpp	1	#pragma once
LOW	native/src/include/consts.hpp	21
LOW	native/src/external/xz_config/config.h	401	# define _GNU_SOURCE 1
LOW	native/src/external/xz_config/config.h	421	significant byte first (like Motorola and SPARC, unlike Intel). */
LOW	native/src/external/xz-embedded/xz_config.h	121	# define get_le32 get_unaligned_le32
LOW	native/src/external/xz-embedded/xz_private.h	21	# include <linux/string.h>
LOW	native/src/external/xz-embedded/xz_private.h	41	# define memzero(buf, size) memset(buf, 0, size)
LOW	native/src/external/xz-embedded/xz_private.h	61	/*
LOW	native/src/external/xz-embedded/xz_private.h	81	# define DEC_IS_DYNALLOC(mode) (false)
LOW	native/src/external/lz4-sys/src/wasm_shim.rs	1	//! A shim for the libc functions used in lz4-rs that are not available when building for wasm
LOW	native/src/external/lz4-sys/src/lib.rs	201	// This is achieved using LZ4F_createCompressionContext(), which takes as argument a version
LOW	native/src/external/lz4-sys/src/lib.rs	221	// LZ4F_compressBegin() :
LOW	native/src/external/lz4-sys/src/lib.rs	241	// LZ4F_compressBound() :
LOW	native/src/external/lz4-sys/src/lib.rs	261	// meaning input data was just buffered.
LOW	native/src/external/lz4-sys/src/lib.rs	281	// to be be filled, you can call LZ4_flush(), which will immediately compress any remaining
LOW	native/src/external/lz4-sys/src/lib.rs	301	// It will flush whatever data remained within compressionContext (like LZ4_flush())
LOW	native/src/external/lz4-sys/src/lib.rs	321	// The first thing to do is to create a decompressionContext object, which will be used
LOW	native/src/external/lz4-sys/src/lib.rs	341
LOW	native/src/external/lz4-sys/src/lib.rs	361	srcBuffer: *const u8,
LOW	native/src/external/lz4-sys/src/lib.rs	381	//
LOW	native/src/sepolicy/include/sepolicy.hpp	1	#pragma once
LOW	native/src/base/argh.rs	1	// Copyright (c) 2020 Google LLC All rights reserved.
LOW	native/src/base/argh.rs	21	//! /// whether or not to jump
LOW	native/src/base/argh.rs	41	//!
LOW	native/src/base/argh.rs	61	//! `#[argh(default = "<your_code_here>")]` attribute, and in this case an
LOW	native/src/base/argh.rs	81	//! height: usize,
LOW	native/src/base/argh.rs	101	//! #[derive(FromArgs)]
LOW	native/src/base/argh.rs	121	//! /// A command with positional arguments.
LOW	native/src/base/argh.rs	141	//! #[argh(option)]
LOW	native/src/base/argh.rs	161	//! over each command:
LOW	native/src/base/argh.rs	181	//! /// First subcommand.
LOW	native/src/base/argh.rs	201	//! `dynamic` attribute. Instead of deriving `FromArgs`, the value inside the
LOW	native/src/base/argh.rs	221	//! Normal(NormalSubCommand),
LOW	native/src/base/argh.rs	241	//! impl DynamicSubCommand for Dynamic {
LOW	native/src/base/argh.rs	261	//! }
LOW	native/src/base/argh.rs	281	//! for command in Self::commands() {
LOW	native/src/base/argh.rs	301	//! # use argh::FromArgs;
LOW	native/src/base/argh.rs	341	}
19 more matches not shown…

Hallucination Indicators3 hits · 30 pts

Severity	File	Line	Snippet
CRITICAL	…/src/main/java/com/topjohnwu/magisk/ui/MainActivity.kt	268	val invalidDialog = com.topjohnwu.magisk.ui.component.rememberConfirmDialog(
CRITICAL	…/src/main/java/com/topjohnwu/magisk/ui/MainActivity.kt	289	com.topjohnwu.magisk.ui.component.rememberConfirmDialog(
CRITICAL	…/src/main/java/com/topjohnwu/magisk/ui/MainActivity.kt	301	val shortcutDialog = com.topjohnwu.magisk.ui.component.rememberConfirmDialog(

Verbosity Indicators13 hits · 21 pts

Severity	File	Line	Snippet
LOW	native/src/init/selinux.rs	102	// Step 0: determine strategy
LOW	native/src/init/selinux.rs	126	// Step 1: setup for intercepting init boot control flow
LOW	native/src/init/selinux.rs	187	// Step 2: wait for selinuxfs to be mounted (only for LEGACY)
LOW	native/src/init/selinux.rs	219	// Step 3: obtain sepolicy, patch, and load the patched sepolicy
LOW	native/src/core/sqlite.cpp	111	// Step 1: prepare statement
LOW	native/src/core/sqlite.cpp	119	// Step 2: bind arguments
LOW	native/src/core/sqlite.cpp	129	// Step 3: execute
LOW	native/src/core/module.rs	848	// Step 1: Create virtual filesystem tree
LOW	native/src/core/module.rs	878	// Step 2: Inject custom files
LOW	native/src/core/module.rs	897	// Step 3: Extract all supported read-only partition roots
LOW	native/src/core/module.rs	925	// Step 4: Convert virtual filesystem tree into concrete operations
LOW	native/src/core/zygisk/hook.cpp	267	// On arm32, we need to check if the pc is in thumb mode,
LOW	native/src/boot/bootimg.cpp	318	// We need to check if it is LZ4_LG

Redundant / Tautological Comments2 hits · 3 pts

Severity	File	Line	Snippet
LOW	scripts/flash_script.sh	60	# Check if system root is installed and remove
LOW	scripts/boot_patch.sh	58	# Check if 64-bit

AI Slop Vocabulary1 hit · 2 pts

Severity	File	Line	Snippet
LOW	scripts/live_setup.sh	7	# For developing Magisk, just use:

Unused Imports1 hit · 1 pts

Severity	File	Line	Snippet
LOW	build.py	17

Hyper-Verbose Identifiers1 hit · 1 pts

Severity	File	Line	Snippet
LOW	…/java/com/topjohnwu/magisk/core/su/SuRequestHandler.kt	25	class SuRequestHandler(

Score History

Severity Breakdown

Pattern Findings