simonw/llm

Pattern Findings

434 matches across 9 categories. Click a row to expand file-level details.

Hyper-Verbose Identifiers356 hits · 323 pts

Severity	File	Line	Snippet
LOW	llm/hookspecs.py	19	def register_embedding_models(register):
LOW	llm/hookspecs.py	24	def register_template_loaders(register):
LOW	llm/hookspecs.py	29	def register_fragment_loaders(register):
LOW	llm/models.py	186	def _get_arguments_input_schema(function, name):
LOW	llm/models.py	3115	def _remove_titles_recursively(obj):
LOW	llm/__init__.py	232	def get_embedding_models_with_aliases() -> List["EmbeddingModelWithAliases"]:
LOW	llm/__init__.py	274	def get_embedding_model_aliases() -> Dict[str, EmbeddingModel]:
LOW	llm/__init__.py	496	def get_default_embedding_model():
LOW	llm/__init__.py	500	def set_default_embedding_model(model):
LOW	llm/embeddings.py	173	def embed_multi_with_metadata(
LOW	llm/cli.py	111	async def display_async_stream_events(events, *, show_reasoning=True):
LOW	llm/cli.py	206	def process_fragments_in_chat(
LOW	llm/cli.py	297	def resolve_attachment_with_type(value: str, mimetype: str) -> Attachment:
LOW	llm/cli.py	313	def attachment_types_callback(ctx, param, values) -> List[Attachment]:
LOW	llm/cli.py	2300	def model_matches_id_or_alias(model_with_aliases, model_ids):
LOW	llm/cli.py	2307	def render_model_with_aliases(
LOW	llm/cli.py	2375	def render_model_with_options(model_id, *, async_=False):
LOW	llm/utils.py	182	def extract_fenced_code_block(text: str, last: bool = False) -> Optional[str]:
LOW	llm/default_plugins/openai_models.py	382	def register_embedding_models(register):
LOW	llm/default_plugins/openai_models.py	1409	def _reasoning_text_from_item(self, item):
LOW	tests/test_cli_openai_models.py	46	def test_openai_options_min_max():
LOW	tests/test_cli_openai_models.py	205	def test_openai_image_detail_option_description(model_id, expected_description):
LOW	tests/test_cli_openai_models.py	210	def test_openai_image_detail_option_is_sent_on_image_attachments(httpx_mock):
LOW	tests/test_cli_openai_models.py	357	def test_openai_image_detail_original_is_rejected_for_other_models():
LOW	tests/test_async_parity.py	16	def test_echo_registered_for_both():
LOW	tests/test_async_parity.py	25	async def test_async_to_dict_captures_chain_and_output():
LOW	tests/test_async_parity.py	39	async def test_async_to_dict_raises_before_awaited():
LOW	tests/test_async_parity.py	47	async def test_async_from_dict_rehydrates():
LOW	tests/test_async_parity.py	65	async def test_async_from_dict_then_reply_continues():
LOW	tests/test_async_parity.py	89	async def test_async_from_row_response_messages_synthesized(tmp_path):
LOW	tests/test_async_parity.py	121	async def test_async_load_conversation_follow_up_preserves_chain(tmp_path):
LOW	tests/test_async_parity.py	172	async def test_sync_and_async_produce_identical_chain():
LOW	tests/test_async_parity.py	191	async def test_async_chain_tool_result_turn_has_full_chain():
LOW	tests/test_async_parity.py	230	async def test_astream_events_matches_stream_events_for_text_only():
LOW	tests/test_async_parity.py	260	async def test_async_from_dict_model_override():
LOW	tests/test_async_parity.py	272	def test_sync_from_dict_model_override():
LOW	tests/test_async_parity.py	284	async def test_async_to_dict_preserves_datetime():
LOW	tests/test_async_parity.py	294	async def test_async_to_dict_preserves_usage_when_set(async_mock_model):
LOW	tests/test_async_parity.py	312	async def test_async_reply_messages_kwarg_appends():
LOW	tests/test_async_parity.py	325	async def test_async_full_chain_to_dict_round_trip_three_turns():
LOW	tests/test_async_parity.py	365	async def test_async_reply_chains_three_turns():
LOW	tests/test_utils.py	112	def test_extract_fenced_code_block(input, last, expected):
LOW	tests/test_utils.py	318	def test_test_truncate_string_keep_end(
LOW	tests/test_utils.py	386	def test_backtick_count_adjustment(content: str, backtick_count: int):
LOW	tests/test_utils.py	471	def test_toolbox_config_capture():
LOW	tests/conftest.py	31	def user_path_with_embeddings(user_path):
LOW	tests/conftest.py	199	def register_embed_demo_model(embed_demo, mock_model, async_mock_model):
LOW	tests/conftest.py	204	def register_embedding_models(self, register):
LOW	tests/conftest.py	252	def mocked_openai_chat_returning_fenced_code(httpx_mock):
LOW	tests/conftest.py	296	def mocked_openai_chat_stream(httpx_mock):
LOW	tests/conftest.py	402	def mocked_openai_completion_logprobs_stream(httpx_mock):
LOW	tests/conftest.py	413	def mocked_openai_completion_logprobs(httpx_mock):
LOW	tests/test_llm_logs.py	138	def test_logs_text_with_options(user_path):
LOW	tests/test_llm_logs.py	217	def test_logs_extract_first_code(args, log_path):
LOW	tests/test_llm_logs.py	236	def test_logs_extract_last_code(args, log_path):
LOW	tests/test_llm_logs.py	418	def test_logs_schema_data_ids(schema_log_path):
LOW	tests/test_llm_logs.py	713	def test_logs_fragments_markdown(fragments_fixture):
LOW	tests/test_llm_logs.py	896	def test_expand_fragment_json(fragments_fixture, arg):
LOW	tests/test_llm_logs.py	916	def test_expand_fragment_markdown(fragments_fixture):
LOW	tests/test_llm_logs.py	1017	def test_log_to_db_persists_visible_reasoning(logs_db, mock_model):
296 more matches not shown…

Cross-Language Confusion5 hits · 30 pts

Severity	File	Line	Snippet
HIGH	llm/utils.py	668	if re.match(r'\s*(["\[\d\-]\|true\|false\|null)', arg_body, re.I):
HIGH	tests/test_llm_logs.py	1075	"""When reasoning is empty/null, no heading appears (existing
HIGH	tests/test_plugins.py	460	'[{"id": 2, "tool_id": 1, "name": "upper", "output": "ONE", "tool_call_id": null, "exception": null, "at
HIGH	tests/test_plugins.py	465	'[{"id": 3, "tool_id": 1, "name": "upper", "output": "TWO", "tool_call_id": null, "exception": null, "at
HIGH	tests/test_plugins.py	473	'[{"id": 4, "tool_id": 1, "name": "upper", "output": "THREE", "tool_call_id": null, "exception": null, "

Deep Nesting27 hits · 27 pts

Severity	File	Line
LOW	llm/plugins.py	21
LOW	llm/models.py	476
LOW	llm/models.py	1041
LOW	llm/models.py	1335
LOW	llm/models.py	1753
LOW	llm/models.py	2074
LOW	llm/cli.py	131
LOW	llm/cli.py	519
LOW	llm/cli.py	1086
LOW	llm/cli.py	1657
LOW	llm/cli.py	2694
LOW	llm/cli.py	3180
LOW	llm/cli.py	3310
LOW	llm/cli.py	3505
LOW	llm/cli.py	3405
LOW	llm/utils.py	77
LOW	llm/utils.py	312
LOW	llm/utils.py	554
LOW	llm/parts.py	253
LOW	llm/default_plugins/openai_models.py	2029
LOW	llm/default_plugins/openai_models.py	775
LOW	llm/default_plugins/openai_models.py	942
LOW	llm/default_plugins/openai_models.py	1060
LOW	llm/default_plugins/openai_models.py	1223
LOW	llm/default_plugins/openai_models.py	1511
LOW	llm/default_plugins/openai_models.py	1738
LOW	tests/test_templates.py	464

Unused Imports23 hits · 20 pts

Severity	File	Line
LOW	llm/__init__.py	1
LOW	llm/__init__.py	2
LOW	llm/__init__.py	2
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	6
LOW	llm/__init__.py	29
LOW	llm/__init__.py	29
LOW	llm/__init__.py	29
LOW	llm/__init__.py	29
LOW	llm/__init__.py	29
LOW	llm/__init__.py	36
LOW	llm/__init__.py	37

Excessive Try-Catch Wrapping11 hits · 11 pts

Severity	File	Line	Snippet
LOW	llm/models.py	1828	except Exception as ex:
LOW	llm/models.py	2139	except Exception as ex:
LOW	llm/models.py	2202	except Exception as ex:
MEDIUM	llm/cli.py	290	def convert(self, value, param, ctx):
LOW	llm/cli.py	187	except Exception as ex:
LOW	llm/cli.py	961	except Exception as ex:
LOW	llm/cli.py	1477	except Exception as ex:
LOW	llm/cli.py	4034	except Exception as ex:
LOW	llm/default_plugins/openai_models.py	1445	except Exception:
LOW	docs/plugins/plugin-hooks.md	221	except Exception as e:
LOW	docs/plugins/plugin-hooks.md	271	except Exception as ex:

Self-Referential Comments4 hits · 10 pts

Severity	File	Line	Snippet
MEDIUM	llm/cli.py	3784	# Create a test Options object to validate
MEDIUM	tests/test_templates.py	158	# Create a file to test attachment
MEDIUM	tests/test_chat_templates.py	35	# Create a system fragment file
MEDIUM	docs/conf.py	6	# This file is execfile()d with the current directory set to its

Redundant / Tautological Comments4 hits · 6 pts

Severity	File	Line	Snippet
LOW	llm/cli.py	3446	# Read the file twice - first time is to get a count
LOW	llm/utils.py	377	# Check if the schema is newline-separated or comma-separated
LOW	tests/test_utils.py	392	# Check if the correct number of backticks is used
LOW	.github/workflows/stable-docs.yml	52	# Check if the list of files is non-empty

Over-Commented Block3 hits · 3 pts

Severity	File	Line	Snippet
LOW	llm/models.py	881	# str yields are wrapped as text events (with part_index resolved
LOW	docs/conf.py	1	#!/usr/bin/env python3
LOW	docs/conf.py	121	# -- Options for LaTeX output ---------------------------------------------

Overly Generic Function Names1 hit · 1 pts

Severity	File	Line	Snippet
LOW	llm/utils.py	108	def handle_request(self, request: httpx.Request) -> httpx.Response:

Score History

Severity Breakdown

Pattern Findings