signalapp/Signal-Desktop

Pattern Findings

1472 matches across 6 categories. Click a row to expand file-level details.

Hyper-Verbose Identifiers1354 hits · 1318 pts

Severity	File	Line	Snippet
LOW	sticker-creator/src/util/apng.ts	33	export function getAnimatedPngDataIfExists(
LOW	app/permissions.std.ts	83	export function installPermissionsHandler({
LOW	app/main.main.ts	452	function getPreferredSystemLocales(): Array<string> {
LOW	app/main.main.ts	466	function getResolvedMessagesLocale(): LocaleType {
LOW	app/main.main.ts	1258	function stageLocalBackupForImport() {
LOW	app/main.main.ts	1485	function doShowCallDiagnosticWindow() {
LOW	app/main.main.ts	1542	function showPermissionsPopupWindow(forCalling: boolean, forCamera: boolean) {
LOW	app/main.main.ts	1757	function handleSafeStorageDecryptionError(): 'continue' \| 'quit' {
LOW	app/main.main.ts	2012	function loadPreferredSystemLocales(): Array<string> {
LOW	app/main.main.ts	2029	async function getDefaultLoginItemSettings(): Promise<Settings> {
LOW	app/main.main.ts	2475	async function maybeRequestCloseConfirmation(): Promise<boolean> {
LOW	app/main.main.ts	3035	function maybeGetIncomingSignalRoute(argv: Array<string>) {
LOW	app/SystemTrayService.main.ts	257	function getDisplaysMaxScaleFactor(): number {
LOW	app/attachment_channel.main.ts	294	async function cleanupOrphanedAttachments({
LOW	app/attachment_channel.main.ts	404	function deleteOrphanedAttachments({
LOW	ts/setAppLoadingScreenMessage.dom.ts	20	export function setAppLoadingScreenMessage(
LOW	ts/LibsignalNetRemoteConfig.preload.ts	23	export function bindRemoteConfigToLibsignalNet(
LOW	ts/ConversationController.preload.ts	89	function applyChangeToConversation(
LOW	ts/Crypto.node.ts	204	function getAssociatedDataForDeviceCreatedAt(
LOW	ts/Crypto.node.ts	649	export function encryptProfileItemWithPadding(
LOW	ts/groups.preload.ts	266	export function generateGroupInviteLinkPassword(): Uint8Array<ArrayBuffer> {
LOW	ts/groups.preload.ts	420	function buildGroupDescriptionBuffer(
LOW	ts/groups.preload.ts	739	export async function buildUpdateAttributesChange(
LOW	ts/groups.preload.ts	825	export function buildDisappearingMessagesTimerChange({
LOW	ts/groups.preload.ts	854	export function buildInviteLinkPasswordChange(
LOW	ts/groups.preload.ts	882	export function buildAccessControlAddFromInviteLinkChange(
LOW	ts/groups.preload.ts	894	export function buildAnnouncementsOnlyChange(
LOW	ts/groups.preload.ts	906	export function buildAccessControlAttributesChange(
LOW	ts/groups.preload.ts	918	export function buildAccessControlMembersChange(
LOW	ts/groups.preload.ts	930	export function buildAccessControlMemberLabelChange(
LOW	ts/groups.preload.ts	1045	export function buildDeletePendingAdminApprovalMemberChange({
LOW	ts/groups.preload.ts	1082	export function buildAddPendingAdminApprovalMemberChange({
LOW	ts/groups.preload.ts	1177	export function buildDeletePendingMemberChange({
LOW	ts/groups.preload.ts	1232	export function buildAddBannedMemberChange({
LOW	ts/groups.preload.ts	1270	export function buildModifyMemberRoleChange({
LOW	ts/groups.preload.ts	1321	export function buildModifyMemberLabelChange({
LOW	ts/groups.preload.ts	1391	export function buildPromotePendingAdminApprovalMemberChange({
LOW	ts/groups.preload.ts	3788	async function updateGroupViaPreJoinInfo({
LOW	ts/groups.preload.ts	3945	async function updateGroupViaSingleChange({
LOW	ts/groups.preload.ts	4023	function getLastRevisionFromChanges(
LOW	ts/groups.preload.ts	7106	function decryptModifyMemberLabelAction(
LOW	ts/groups.preload.ts	7465	function decryptMemberPendingProfileKey(
LOW	ts/groups.preload.ts	7545	function decryptMemberPendingAdminApproval(
LOW	ts/groups.preload.ts	7627	function setLastSuccessfulGroupFetch(
LOW	ts/routineProfileRefresh.preload.ts	204	function getConversationsToRefresh(
LOW	ts/routineProfileRefresh.preload.ts	241	function hasRefreshedProfileRecently(
LOW	ts/background.preload.ts	1614	function setupNetworkChangeListeners() {
LOW	ts/background.preload.ts	1840	async function maybeDownloadAndImportBackup(): Promise<{
LOW	ts/background.preload.ts	1895	async function afterEveryLinkedStartupOnNewVersion({
LOW	ts/background.preload.ts	1995	function pauseQueuesAndNotificationsOnSocketConnect() {
LOW	ts/background.preload.ts	2006	function restartQueuesAndNotificationsOnEmpty() {
LOW	ts/background.preload.ts	2368	async function handleMessageReceivedProfileUpdate({
LOW	ts/background.preload.ts	2427	function setInboxEnvelopeTimestamp(timestamp: number): void {
LOW	ts/background.preload.ts	2826	async function handleMessageSentProfileUpdate({
LOW	ts/background.preload.ts	3390	function handleGroupCallUpdateMessage(
LOW	ts/background.preload.ts	4039	async function onAttachmentBackfillResponseSync(
LOW	ts/CI.preload.ts	215	async function stageLocalBackupForImport(snapshotDir: string): Promise<void> {
LOW	ts/CI.preload.ts	244	async function resetReleaseNoteAndMegaphoneFetcher() {
LOW	ts/CI.preload.ts	268	function getAndResetMaxAudioLevel(): number \| undefined {
LOW	ts/updateConversationsWithUuidLookup.dom.ts	19	export async function updateConversationsWithUuidLookup({
1294 more matches not shown…

Over-Commented Block62 hits · 60 pts

Severity	File	Line	Snippet
LOW	.oxlintrc.json	81
LOW	.oxlintrc.json	201	"eslint/use-isnan": "error",
LOW	.oxlintrc.json	221	// [correctness] (🛠️ autofix) Disallow focused tests
LOW	.oxlintrc.json	241	// [correctness] (🚧 planned autofix) Requires that all @typedef and @namespace tags have @property when their type i
LOW	.oxlintrc.json	321	// [correctness] (⚠️ 💡 dangerous suggestion) Enforce tabIndex value is not greater than zero.
LOW	.oxlintrc.json	341	// [correctness] Prevent duplicate usage of <Head> in pages/_document.js.
LOW	.oxlintrc.json	361	// [correctness] (🚧 planned autofix) Prevent common typos in Next.js's data fetching functions
LOW	.oxlintrc.json	521	// [correctness] Enforce using .each or .for consistently
LOW	.oxlintrc.json	541	// [correctness] (🛠️ autofix) Enforce import from 'vue' instead of import from '@vue/*'
LOW	.oxlintrc.json	681	"import/max-dependencies": "off", // DECIDEME (errors: 476)
LOW	.oxlintrc.json	881	// Category: Restriction
LOW	.oxlintrc.json	1081	// [restriction] (🚧 planned autofix) Disallow process.exit().
LOW	.oxlintrc.json	1101	// Category: Style
LOW	.oxlintrc.json	1221	"import/no-namespace": "off", // DECIDEME (errors: 743)
LOW	.oxlintrc.json	1241	// [style] Disallow confusing usages of jest.setTimeout
LOW	.oxlintrc.json	1261	// [style] Disallow specific jest. methods
LOW	.oxlintrc.json	1281	// [style] (🚧 planned autofix) Suggest using the built-in equality matchers
LOW	.oxlintrc.json	1301	// [style] (🛠️ autofix) Suggest using toBe() for primitive literals
LOW	.oxlintrc.json	1481	// [style] (🛠️ autofix) Require new when creating an error.
LOW	.oxlintrc.json	1501	// [style] (🛠️ autofix) Enforce using toBeFalsy()
LOW	.oxlintrc.json	1541	// [suspicious] (🛠️ autofix) Disallow losing originally caught error when re-throwing custom errors
LOW	.oxlintrc.json	1601	// [suspicious] (🚧 planned autofix) Move function definitions to the highest possible scope.
LOW	sticker-creator/src/vite-env.d.ts	1	// Copyright 2023 Signal Messenger, LLC
LOW	.github/stale.yml	61	# pulls:
LOW	.github/workflows/ci.yml	101	path: ~/.electron-gyp
LOW	.github/workflows/ci.yml	181
LOW	reproducible-builds/build.sh	1	#!/bin/sh
LOW	reproducible-builds/docker-entrypoint.sh	1	#!/usr/bin/env bash
LOW	ts/SignalProtocolStore.preload.ts	901	//
LOW	ts/SignalProtocolStore.preload.ts	1141	}
LOW	ts/challenge.dom.ts	1	// Copyright 2021 Signal Messenger, LLC
LOW	ts/types/InstallScreen.std.ts	41	// This is the string's `.length`, which is the number of UTF-16 code points. Instead, we
LOW	ts/types/Message2.preload.ts	101	data: Uint8Array<ArrayBuffer>
LOW	ts/types/Message2.preload.ts	121	// - Attachments: Write attachment data to disk and store relative path to it.
LOW	ts/types/Message2.preload.ts	141	// full-size screenshot for video.
LOW	ts/textsecure/SocketManager.preload.ts	81	// activity on the socket).
LOW	ts/util/TaskDeduplicator.std.ts	1	// Copyright 2026 Signal Messenger, LLC
LOW	ts/util/Attachment.std.ts	61	// flags: null
LOW	ts/util/missingCaseError.std.ts	1	// Copyright 2018 Signal Messenger, LLC
LOW	ts/util/missingCaseError.std.ts	21	// If we extended `AttachmentType` to `'media' \| 'documents' \| 'links'` the code
LOW	ts/util/lint/types.std.ts	1	// Copyright 2018 Signal Messenger, LLC
LOW	ts/util/lint/types.std.ts	21	// "regexMatchedSafeCode"
LOW	ts/axo/AriaClickable.dom.tsx	121	<div
LOW	ts/models/conversations.preload.ts	5661	// [-] identityKey
LOW	ts/components/CallingToast.dom.tsx	241	);
LOW	ts/components/GroupCallRemoteParticipants.dom.tsx	101	//
LOW	ts/components/LeftPane.dom.tsx	321	// Ideally, this would render subcomponents such as `<LeftPaneInbox>` or
LOW	ts/test-helpers/generateConfigMatrix.std.ts	1	// Copyright 2024 Signal Messenger, LLC
LOW	ts/test-mock/bootstrap.node.ts	201	// tests/benchmarks.
LOW	ts/test-mock/bootstrap.node.ts	221	// All phone numbers and uuids for all contacts and ourselves are random and not
LOW	ts/test-mock/storage/fixtures.node.ts	41
LOW	…on/backup/backup_groupv2_notifications_test.preload.ts	661	// pni: OUR_PNI,
LOW	…on/backup/backup_groupv2_notifications_test.preload.ts	681	// aci: CONTACT_A,
LOW	…on/backup/backup_groupv2_notifications_test.preload.ts	701	// {
LOW	…on/backup/backup_groupv2_notifications_test.preload.ts	1681	// aci: CONTACT_A,
LOW	ts/quill/signal-clipboard/util.dom.ts	141	// <div class="ql-editor ql-editor--loaded" contenteditable="plaintext-only" ... >
LOW	ts/quill/signal-clipboard/util.dom.ts	161	// <span class="MessageTextRenderer__formatting--spoiler--revealed">
LOW	ts/services/profiles.preload.ts	61	type JobType = {
LOW	ts/services/notifications.preload.ts	81	// Electron, at least on Windows and macOS, only shows one notification at a time (see
LOW	ts/services/calling.preload.ts	761	await ensureSystemPermissions({ hasLocalAudio, hasLocalVideo });
2 more matches not shown…

Fake / Example Data52 hits · 56 pts

Severity	File	Line	Snippet
LOW	ts/test-node/util/isConversationNameKnown_test.std.ts	14	name: 'Jane Doe',
LOW	ts/test-node/util/isConversationNameKnown_test.std.ts	23	profileName: 'Jane Doe',
LOW	ts/test-node/util/isInSystemContacts_test.std.ts	13	name: 'Jane Doe',
LOW	ts/test-node/util/isInSystemContacts_test.std.ts	19	name: 'Jane Doe',
LOW	ts/axo/AxoRadioGroup.dom.stories.tsx	26	Lorem ipsum dolor, sit amet consectetur adipisicing elit. Veniam
LOW	ts/axo/AxoTheme.dom.stories.tsx	22	<AxoTooltip.Root label="Lorem ipsum">
LOW	ts/axo/AxoTheme.dom.stories.tsx	107	<p>Lorem ipsum, dolor sit amet consectetur adipisicing elit.</p>
LOW	ts/axo/AxoTheme.dom.stories.tsx	107	<p>Lorem ipsum, dolor sit amet consectetur adipisicing elit.</p>
LOW	ts/axo/AxoTheme.dom.stories.tsx	136	Lorem ipsum, dolor sit amet consectetur adipisicing elit.
LOW	ts/axo/AxoTheme.dom.stories.tsx	136	Lorem ipsum, dolor sit amet consectetur adipisicing elit.
LOW	ts/axo/AxoStackedButton.dom.stories.tsx	38	label="Lorem ipsum dolor sit amet consectetur adipisicing elit"
LOW	ts/axo/AxoStackedButton.dom.stories.tsx	38	label="Lorem ipsum dolor sit amet consectetur adipisicing elit"
LOW	ts/axo/AxoDropdownMenu.dom.stories.tsx	154	'Lorem ipsum dolor sit amet consectetur adipisicing elit. Cum nostrum, inventore quia tenetur sunt non ab fuga explica
LOW	ts/axo/AxoDropdownMenu.dom.stories.tsx	154	'Lorem ipsum dolor sit amet consectetur adipisicing elit. Cum nostrum, inventore quia tenetur sunt non ab fuga explica
LOW	ts/axo/AxoAlertDialog.dom.stories.tsx	17	Lorem ipsum dolor, sit amet consectetur adipisicing elit. Est vel
LOW	ts/axo/AxoAlertDialog.dom.stories.tsx	31	Lorem ipsum dolor sit amet consectetur adipisicing elit. Nobis, amet aut
LOW	ts/axo/AxoAlertDialog.dom.stories.tsx	31	Lorem ipsum dolor sit amet consectetur adipisicing elit. Nobis, amet aut
LOW	ts/axo/AxoAlertDialog.dom.stories.tsx	47	veritatis eligendi dicta asperiores minus quisquam! Odit dolorem ipsum
LOW	ts/axo/AxoAlertDialog.dom.stories.tsx	68	const EXAMPLE_CANCEL_LONG = <>Lorem ipsum dolor sit amet</>;
LOW	ts/axo/AxoAlertDialog.dom.stories.tsx	68	const EXAMPLE_CANCEL_LONG = <>Lorem ipsum dolor sit amet</>;
LOW	ts/axo/AxoTooltip.dom.stories.tsx	19	Lorem ipsum dolor sit amet, consectetur adipisicing elit. Dolore nesciunt
LOW	ts/axo/AxoTooltip.dom.stories.tsx	19	Lorem ipsum dolor sit amet, consectetur adipisicing elit. Dolore nesciunt
LOW	ts/axo/AxoDialog.dom.stories.tsx	16	const TEXT_SHORT = <>Lorem ipsum dolor</>;
LOW	ts/axo/AxoDialog.dom.stories.tsx	20	Lorem ipsum dolor sit amet consectetur, adipisicing elit. Eum repudiandae
LOW	ts/axo/AxoDialog.dom.stories.tsx	20	Lorem ipsum dolor sit amet consectetur, adipisicing elit. Eum repudiandae
LOW	ts/axo/AxoDialog.dom.stories.tsx	102	Lorem ipsum dolor sit amet consectetur adipisicing elit. Laboriosam est
LOW	ts/axo/AxoDialog.dom.stories.tsx	102	Lorem ipsum dolor sit amet consectetur adipisicing elit. Laboriosam est
LOW	ts/axo/AxoButton.dom.stories.tsx	134	Lorem ipsum dolor sit amet consectetur adipisicing elit. Id dicta dolorum
LOW	ts/axo/AxoButton.dom.stories.tsx	134	Lorem ipsum dolor sit amet consectetur adipisicing elit. Id dicta dolorum
LOW	ts/axo/AriaClickable.dom.tsx	30	* Lorem ipsum dolor sit amet consectetur adipisicing elit...
LOW	ts/axo/AriaClickable.dom.tsx	30	* Lorem ipsum dolor sit amet consectetur adipisicing elit...
LOW	ts/axo/AriaClickable.dom.stories.tsx	90	Lorem ipsum dolor, sit amet consectetur adipisicing elit...{' '}
LOW	ts/CI/benchmarkConversationOpen.preload.ts	69	body: `Message ${i}: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam venenatis nec sapien id portti
LOW	ts/CI/benchmarkConversationOpen.preload.ts	69	body: `Message ${i}: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam venenatis nec sapien id portti
LOW	ts/components/Toast.dom.stories.tsx	47	Lorem ipsum dolor sit amet, consectetur adipisicing elit. Debitis deserunt
LOW	ts/components/Toast.dom.stories.tsx	47	Lorem ipsum dolor sit amet, consectetur adipisicing elit. Debitis deserunt
LOW	ts/components/Modal.dom.stories.tsx	24	'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec a diam lectus. Sed sit amet ipsum mauris. Maecenas con
LOW	ts/components/Modal.dom.stories.tsx	24	'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec a diam lectus. Sed sit amet ipsum mauris. Maecenas con
LOW	ts/components/LeftPaneDialog.dom.stories.tsx	65	title: 'Lorem ipsum dolor sit amet',
LOW	ts/components/LeftPaneDialog.dom.stories.tsx	65	title: 'Lorem ipsum dolor sit amet',
LOW	ts/components/ListTile.dom.stories.tsx	16	'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam feugiat quam vitae semper facilisis. Praesent eu effic
LOW	ts/components/ListTile.dom.stories.tsx	16	'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam feugiat quam vitae semper facilisis. Praesent eu effic
LOW	ts/components/LeftPane.dom.stories.tsx	230	body="Lorem ipsum wow"
LOW	ts/components/ConversationList.dom.stories.tsx	43	text: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec a diam lectus. Sed sit amet ipsum mauris. Ma
LOW	ts/components/ConversationList.dom.stories.tsx	43	text: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec a diam lectus. Sed sit amet ipsum mauris. Ma
LOW	ts/components/ConversationList.dom.stories.tsx	86	body="Lorem ipsum wow"
LOW	ts/components/ConversationList.dom.stories.tsx	196	'🤠 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec a diam lectus. Sed sit amet ipsum mauris
LOW	ts/components/ConversationList.dom.stories.tsx	196	'🤠 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec a diam lectus. Sed sit amet ipsum mauris
LOW	ts/components/fun/FunEmoji.dom.stories.tsx	126	Lorem, ipsum dolor sit amet consectetur adipisicing elit. Repellat
LOW	…mponents/conversation/GroupDescription.dom.stories.tsx	33	text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas sed vehicula urna. Ut rhoncus, justo a ves
LOW	…mponents/conversation/GroupDescription.dom.stories.tsx	33	text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas sed vehicula urna. Ut rhoncus, justo a ves
LOW	…tion/pinned-messages/PinnedMessagesBar.dom.stories.tsx	140	const SHORT_TEXT = 'Lorem, ipsum dolor sit amet';

AI Slop Vocabulary2 hits · 6 pts

Severity	File	Line	Snippet
MEDIUM	.oxlintrc.json	884	// [restriction] Enforce that class methods utilize this
MEDIUM	stylesheets/components/CompositionTextArea.scss	65	// remove background, should be seamless with modal

Example Usage Blocks1 hit · 2 pts

Severity	File	Line	Snippet
LOW	reproducible-builds/build.sh	5	# Usage:

Verbosity Indicators1 hit · 2 pts

Severity	File	Line	Snippet
LOW	ts/util/findStoryMessage.preload.ts	83	// For 1:1 stories, we need to check if they can be replied to

Score History

Severity Breakdown

Pattern Findings