sherlock-project/sherlock

Pattern Findings

46 matches across 6 categories. Click a row to expand file-level details.

Cross-File Repetition5 hits · 25 pts

Severity	File	Snippet
HIGH	sherlock_project/notify.py	convert object to string. keyword arguments: self -- this object. return value: nicely formatted string to get informati
HIGH	sherlock_project/notify.py	convert object to string. keyword arguments: self -- this object. return value: nicely formatted string to get informati
HIGH	sherlock_project/result.py	convert object to string. keyword arguments: self -- this object. return value: nicely formatted string to get informati
HIGH	sherlock_project/result.py	convert object to string. keyword arguments: self -- this object. return value: nicely formatted string to get informati
HIGH	sherlock_project/sites.py	convert object to string. keyword arguments: self -- this object. return value: nicely formatted string to get informati

Excessive Try-Catch Wrapping14 hits · 18 pts

Severity	File	Line	Snippet
MEDIUM	devel/summarize_site_validation.py	68	print(f"Error: File '{xml_path}' does not exist.")
LOW	sherlock_project/sherlock.py	373	except Exception:
LOW	sherlock_project/sherlock.py	377	except Exception:
LOW	sherlock_project/sherlock.py	469	except Exception:
LOW	sherlock_project/sherlock.py	478	except Exception:
LOW	sherlock_project/sherlock.py	714	except Exception as error:
LOW	sherlock_project/sherlock.py	768	except Exception as error:
MEDIUM	sherlock_project/sherlock.py	798	print(f"Error: Desired sites not found: {', '.join(site_missing)}.")
LOW	sherlock_project/sites.py	128	except Exception as error:
LOW	sherlock_project/sites.py	139	except Exception as error:
LOW	sherlock_project/sites.py	150	except Exception as error:
LOW	sherlock_project/sites.py	179	except Exception:
MEDIUM	.github/workflows/validate_modified_targets.yml	67	print(f"Error: Could not find {e.filename}", file=sys.stderr)
MEDIUM	.github/workflows/validate_modified_targets.yml	70	print(f"Error: Could not decode JSON from a file - {e}", file=sys.stderr)

Hyper-Verbose Identifiers17 hits · 17 pts

Severity	File	Line	Snippet
LOW	tests/test_unicode.py	8	def _make_future_with_exception(exc):
LOW	tests/test_unicode.py	15	def test_get_response_handles_unicode_decode_error():
LOW	tests/test_unicode.py	35	def test_get_response_handles_unicode_encode_error():
LOW	tests/few_test_basic.py	6	def test_username_via_message():
LOW	tests/test_probes.py	30	def test_known_positives_via_message(self, sites_info, site, username):
LOW	tests/test_probes.py	41	def test_known_positives_via_status_code(self, sites_info, site, username):
LOW	tests/test_probes.py	50	def test_known_positives_via_response_url(self, sites_info, site, username):
LOW	tests/test_probes.py	62	def test_likely_negatives_via_message(self, sites_info, site, random_len):
LOW	tests/test_probes.py	84	def test_likely_negatives_via_status_code(self, sites_info, site, random_len):
LOW	tests/test_probes.py	98	def test_username_illegal_regex(sites_info):
LOW	tests/test_manifest.py	6	def test_validate_manifest_against_local_schema():
LOW	tests/test_manifest.py	23	def test_validate_manifest_against_remote_schema(remote_schema):
LOW	tests/test_manifest.py	38	def test_site_list_iterability (sites_info, target_name, target_expected_err_type):
LOW	tests/sherlock_interactives.py	23	def walk_sherlock_for_files_with(pattern: str) -> list[str]:
LOW	tests/test_ux.py	18	def test_nsfw_explicit_selection(sites_obj, nsfwsites):
LOW	tests/test_ux.py	26	def test_wildcard_username_expansion():
LOW	tests/test_ux.py	41	def test_no_usernames_provided(cliargs):

Redundant / Tautological Comments4 hits · 6 pts

Severity	File	Line	Snippet
LOW	sherlock_project/sherlock.py	341	# Open the file containing account links
LOW	sherlock_project/sherlock.py	728	# Check if both output methods are entered as input.
LOW	sherlock_project/sherlock.py	755	# Check if it's a valid pull request
LOW	sherlock_project/__main__.py	14	# Check if the user is using the correct version of Python

Deep Nesting5 hits · 5 pts

Severity	File	Line
LOW	tests/sherlock_interactives.py	23
LOW	sherlock_project/sherlock.py	173
LOW	sherlock_project/sherlock.py	541
LOW	sherlock_project/notify.py	176
LOW	sherlock_project/sites.py	79

Unused Imports1 hit · 1 pts

Severity	File	Line	Snippet
LOW	sherlock_project/sherlock.py	13