rust-lang/rust-analyzer

Pattern Findings

946 matches across 8 categories. Click a row to expand file-level details.

Over-Commented Block905 hits · 896 pts

Severity	File	Line	Snippet
LOW	crates/hir-def/src/item_scope.rs	181	/// and only normal scoped `macros` will be searched in.
LOW	crates/hir-def/src/import_map.rs	41	#[derive(Default)]
LOW	crates/hir-def/src/dyn_map.rs	1	//! This module defines a `DynMap` -- a container for heterogeneous maps.
LOW	crates/hir-def/src/expr_store.rs	121	/// top level expression, it will not be listed in here.
LOW	crates/hir-def/src/expr_store.rs	141	/// // this repeat expr is anon const #1, and only it appears in this list.
LOW	crates/hir-def/src/lib.rs	1	//! `hir_def` crate contains everything between macro expansion and type
LOW	crates/hir-def/src/lib.rs	1061	// manual impls that do not have a ModuleId container...
LOW	crates/hir-def/src/lib.rs	1081	self.lookup(db).container
LOW	crates/hir-def/src/lib.rs	1361	// with `"type": "always"`.
LOW	crates/hir-def/src/hir.rs	1	//! This module describes hir-level representation of expressions.
LOW	crates/hir-def/src/hir.rs	621	MacroDef(Box<MacroDefId>),
LOW	crates/hir-def/src/item_tree.rs	1	//! A simplified AST that only contains items.
LOW	crates/hir-def/src/item_tree.rs	21	//! resolution has not yet been performed. `ItemTree`s are per-file, while rustc's AST and HIR are
LOW	crates/hir-def/src/nameres.rs	1	//! This module implements import-resolution/macro expansion algorithm.
LOW	crates/hir-def/src/nameres.rs	21	//!
LOW	crates/hir-def/src/nameres.rs	161	}
LOW	crates/hir-def/src/nameres.rs	181	pub modules: ModulesMap,
LOW	crates/hir-def/src/attrs.rs	1	//! Attributes for anything that is not name resolution.
LOW	crates/hir-def/src/resolver.rs	541	/// doesn't necessary follow a strict scoping discipline. Rather, it just
LOW	crates/hir-def/src/resolver.rs	561	///
LOW	crates/hir-def/src/macro_expansion_tests/mbe.rs	541	// STMT_LIST@7..17
LOW	crates/hir-def/src/macro_expansion_tests/mbe.rs	661	// L_CURLY@9..10 "{"
LOW	crates/hir-def/src/macro_expansion_tests/mbe.rs	741	a = 10+1;
LOW	crates/hir-def/src/macro_expansion_tests/mbe.rs	761	// BIN_EXPR@9..13
LOW	crates/hir-def/src/macro_expansion_tests/mbe.rs	1741	/* parse error: expected SEMICOLON */
LOW	crates/hir-def/src/macro_expansion_tests/mbe.rs	1761	// PATH_SEGMENT@6..7
LOW	crates/hir-def/src/macro_expansion_tests/proc_macros.rs	1	//! Tests for user-defined procedural macros.
LOW	crates/hir-def/src/macro_expansion_tests/proc_macros.rs	41	#![cfg_attr(true, doc = "123...", attr2)]
LOW	crates/hir-def/src/macro_expansion_tests/proc_macros.rs	61	);
LOW	…es/hir-def/src/macro_expansion_tests/mbe/regression.rs	941	// PARAM_LIST@8..10
LOW	…es/hir-def/src/macro_expansion_tests/mbe/regression.rs	961	// GENERIC_ARG_LIST@22..28
LOW	crates/hir-def/src/attrs/docs.rs	41	#[derive(Debug, Clone, PartialEq, Eq, Hash)]
LOW	crates/hir-def/src/expr_store/body.rs	21	/// The body of an item (function, const etc.).
LOW	crates/hir-def/src/expr_store/body.rs	41	type Target = ExpressionStore;
LOW	crates/hir-def/src/expr_store/path.rs	61	/// This specifies whether the args contain a Self type as the first
LOW	crates/hir-def/src/expr_store/lower.rs	961	// captured and so that the drop order matches the equivalent non-async functions.
LOW	crates/hir-def/src/expr_store/lower.rs	2101	/// }
LOW	crates/hir-def/src/expr_store/lower.rs	2141
LOW	crates/hir-def/src/expr_store/lower.rs	2241	/// Desugar `ast::TryExpr` from: `<expr>?` into:
LOW	crates/hir-def/src/expr_store/lower/format_args.rs	921	///
LOW	crates/hir-def/src/nameres/collector.rs	261	///
LOW	crates/hir-def/src/nameres/collector.rs	461	self.unresolved_imports = unresolved_imports;
LOW	crates/hir-def/src/nameres/collector.rs	601	///
LOW	crates/hir-def/src/nameres/collector.rs	641	crate_data.exported_derives.insert(proc_macro_id.into(), helpers);
LOW	crates/hir-def/src/nameres/collector.rs	661	/// macro_rules! foo { () => {} }
LOW	crates/hir-def/src/nameres/collector.rs	1721	// of that item (but not derive or fn like macros).
LOW	crates/hir-def/src/nameres/path_resolution.rs	1	//! This modules implements a function to resolve a path `foo::bar::baz` to a
LOW	crates/hir-def/src/nameres/tests/incremental.rs	321	"file_item_tree_query",
LOW	crates/hir-def/src/nameres/tests/incremental.rs	341	// $0
LOW	crates/hir-def/src/nameres/tests/incremental.rs	461
LOW	crates/hir-def/src/item_tree/attrs.rs	121	// `AttrsOrCfg::Enabled`. It contains the concatenation of `self`'s attributes followed by
LOW	crates/base-db/src/editioned_file_id.rs	21	// impl EditionedFileId {
LOW	crates/base-db/src/input.rs	81	#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
LOW	crates/base-db/src/input.rs	321	"" \| "stable" => ReleaseChannel::Stable,
LOW	crates/base-db/src/input.rs	361	/// The working directory to run proc-macros in invoked in the context of this crate.
LOW	crates/base-db/src/input.rs	941	/// can enable additional features, and is typically used when a
LOW	crates/hir-ty/src/display.rs	141	/// T: Foo,
LOW	crates/hir-ty/src/variance.rs	1	//! Module for inferring the variance of type and lifetime parameters. See the [rustc dev guide]
LOW	crates/hir-ty/src/specialization.rs	21	// cannot create a cycle, but a cycle handler is required nevertheless.
LOW	crates/hir-ty/src/infer.rs	1	//! Type inference, i.e. the process of walking through the code and determining
845 more matches not shown…

Hallucination Indicators6 hits · 60 pts

Severity	File	Line	Snippet
CRITICAL	crates/hir-ty/src/infer/coerce.rs	1087	if !coerce.delegate.0.result.expr_adjustments.contains_key(&new) {
CRITICAL	crates/hir-ty/src/next_solver/infer/snapshot/fudge.rs	186	let idx = vid.as_usize() - self.snapshot_vars.type_vars.0.start.as_usize();
CRITICAL	crates/hir-ty/src/next_solver/infer/snapshot/fudge.rs	231	let idx = vid.index() - self.snapshot_vars.region_vars.0.start.index();
CRITICAL	crates/hir-ty/src/next_solver/infer/snapshot/fudge.rs	247	let idx = vid.index() - self.snapshot_vars.const_vars.0.start.index();
CRITICAL	crates/hir-ty/src/lower/path.rs	817	GenericParamId::ConstParamId(_) => self.ctx.ctx.types.consts.error.into(),
CRITICAL	crates/hir-ty/src/lower/path.rs	818	GenericParamId::LifetimeParamId(_) => self.ctx.ctx.types.regions.error.into(),

Decorative Section Separators5 hits · 15 pts

Severity	File	Line	Snippet
MEDIUM	crates/ide/src/extend_selection.rs	664	r#"fn main() { let x = "═$0═══════"; }"#,
MEDIUM	crates/ide/src/extend_selection.rs	666	r#""════════""#,
MEDIUM	crates/ide/src/extend_selection.rs	667	r#"let x = "════════";"#,
MEDIUM	crates/ide/src/extend_selection.rs	668	r#"{ let x = "════════"; }"#,
MEDIUM	crates/ide/src/extend_selection.rs	669	r#"fn main() { let x = "════════"; }"#,

AI Slop Vocabulary6 hits · 14 pts

Severity	File	Line	Snippet
MEDIUM	crates/hir-ty/src/next_solver/ty.rs	340	// Definitely absolutely not copy.
MEDIUM	crates/ide-assists/src/lib.rs	40	//! * Make assists robust. If the assist depends on results of type-inference too
MEDIUM	crates/rust-analyzer/src/config.rs	1003	/// [custom test harness](https://doc.rust-lang.org/cargo/reference/cargo-targets.html#the-harness-field),
LOW	crates/hir-expand/src/builtin/derive_macro.rs	1072	// Regardless of the only type param being designed as `#[pointee]` or not, we can just use it as such.
MEDIUM	editors/code/package-lock.json	6183	"resolved": "https://registry.npmjs.org/robust-predicates/-/robust-predicates-3.0.2.tgz",
MEDIUM	editors/code/package.json	2982	"markdownDescription": "Additional arguments to be passed through Cargo to launched tests, bench

Excessive Try-Catch Wrapping8 hits · 10 pts

Severity	File	Line	Snippet
LOW	lib/smol_str/src/gdb_smolstr_printer.py	32	except Exception:
LOW	lib/smol_str/src/gdb_smolstr_printer.py	54	except Exception:
LOW	lib/smol_str/src/gdb_smolstr_printer.py	71	except Exception as e:
LOW	lib/smol_str/src/gdb_smolstr_printer.py	78	except Exception as e:
LOW	lib/smol_str/src/gdb_smolstr_printer.py	97	except Exception as e:
LOW	lib/smol_str/src/gdb_smolstr_printer.py	117	except Exception:
MEDIUM	lib/smol_str/src/gdb_smolstr_printer.py	29	def _read_utf8(mem):
MEDIUM	lib/smol_str/src/gdb_smolstr_printer.py	51	def to_string(self):

Hyper-Verbose Identifiers9 hits · 9 pts

Severity	File	Line	Snippet
LOW	editors/code/src/commands.ts	517	function viewFileUsingTextDocumentContentProvider(
LOW	editors/code/src/commands.ts	1100	export function applySnippetWorkspaceEditCommand(_ctx: CtxInit): Cmd {
LOW	editors/code/src/main.ts	222	function checkConflictingExtensions() {
LOW	editors/code/src/snippets.ts	7	export async function applySnippetWorkspaceEdit(
LOW	editors/code/src/debug.ts	410	async function recompileTestFromDebuggingSession(session: vscode.DebugSession, ctx: Ctx) {
LOW	editors/code/src/debug.ts	432	export function initializeDebugSessionTrackingAndRebuild(ctx: Ctx) {
LOW	editors/code/src/client.ts	372	function assertIsCodeActionWithoutEditsAndCommands(
LOW	editors/code/src/config.ts	557	function substituteVSCodeVariableInString(val: string): string {
LOW	editors/code/src/bootstrap.ts	179	async function hasToolchainFileWithRaDeclared(uri: vscode.Uri): Promise<boolean> {

Slop Phrases5 hits · 8 pts

Severity	File	Line	Snippet
LOW	crates/hir-ty/src/infer.rs	1542	// don't forget to handle them here.
LOW	crates/ide/src/typing.rs	36	// Don't forget to add new trigger characters to `server_capabilities` in `caps.rs`.
LOW	crates/ide/src/syntax_highlighting/tags.rs	44	// Don't forget to adjust the feature description in crates/ide/src/syntax_highlighting.rs.
LOW	…s/src/handlers/convert_named_struct_to_tuple_struct.rs	60	// are to lift this limitation, don't forget to make `edit_struct_def()` consider macro files
LOW	.vscode/launch.json	105	// Don't forget to set `debug = 2` in `Cargo.toml` before building the server

Redundant / Tautological Comments2 hits · 3 pts

Severity	File	Line	Snippet
LOW	Cargo.toml	30	# Set this to 1 or 2 to get more useful backtraces in debugger.
LOW	.github/workflows/ci.yaml	359	# Check if all jobs that we depend on (in the needs array) were successful (or have been skipped).

Score History

Severity Breakdown

Pattern Findings