rui314/mold

Pattern Findings

1412 matches across 12 categories. Click a row to expand file-level details.

Over-Commented Block1282 hits · 1172 pts

Severity	File	Line	Snippet
LOW	CMakeLists.txt	1	# You can customize a build by specifying CMake options. An option may be
LOW	CMakeLists.txt	21	# Specifies the build type. The default is `Release`, which is the right
LOW	CMakeLists.txt	321	# Almost all functions are template in mold which take a target type
LOW	dist.sh	1	#!/bin/bash
LOW	dist.sh	21	# The mold executable created by this script is statically linked to
LOW	dist.sh	81	# Debian 9 (Stretch) released in June 2017.
LOW	test/lto-archive4.sh	1	#!/bin/bash
LOW	lib/lib.h	1	#pragma once
LOW	lib/lib.h	21	#include <sstream>
LOW	lib/lib.h	341	}
LOW	lib/gentoo-test.sh	1	#!/bin/bash
LOW	lib/integers.h	1	// This file defines integral types for file input/output. We need to use
LOW	lib/integers.h	21	// Note that in C/C++, memcpy is a portable and efficient way to access
LOW	third-party/blake3/Cargo.toml	21	# The Wasm SIMD implementation does not participate in dynamic feature detection,
LOW	third-party/blake3/Cargo.toml	41	rayon = ["dep:rayon-core"]
LOW	third-party/blake3/Cargo.toml	61	# The following features are mainly intended for testing and benchmarking, and
LOW	third-party/blake3/Cargo.toml	81	# BLAKE3_CI environment variable, which instructs build.rs to error out rather
LOW	third-party/blake3/b3sum/src/main.rs	21
LOW	third-party/blake3/b3sum/src/main.rs	61	///
LOW	third-party/blake3/b3sum/src/main.rs	281
LOW	third-party/blake3/reference_impl/reference_impl.rs	1	//! This is the reference implementation of BLAKE3. It is used for testing and
LOW	third-party/blake3/c/blake3.h	1	#ifndef BLAKE3_H
LOW	third-party/blake3/c/blake3.h	21	# define BLAKE3_API __attribute__((visibility("default")))
LOW	third-party/blake3/c/blake3_dispatch.c	1	#include <stdbool.h>
LOW	third-party/blake3/c/blake3_dispatch.c	21	#if !defined(BLAKE3_ATOMICS)
LOW	third-party/blake3/c/main.c	1	/*
LOW	third-party/blake3/c/blake3.c	261	// wouldn't be able to implement extendable output.) Note that this function is
LOW	third-party/blake3/c/blake3.c	281	// With more than simd_degree chunks, we need to recurse. Start by dividing
LOW	third-party/blake3/c/blake3.c	361	// The following loop never executes when MAX_SIMD_DEGREE_OR_2 is 2, because
LOW	third-party/blake3/c/blake3.c	441	// If the user gives us 64 KiB, we want to parallelize over all 64 KiB at once
LOW	third-party/blake3/c/blake3.c	501	uint8_t chunk_cv[32];
LOW	third-party/blake3/c/blake3.c	521	// Because we might need to break up the input to form powers of 2, or to
LOW	third-party/blake3/c/blake3_impl.h	1	#ifndef BLAKE3_IMPL_H
LOW	third-party/blake3/c/blake3_impl.h	21	ROOT = 1 << 3,
LOW	third-party/blake3/c/blake3_impl.h	41	#if (defined(__x86_64__) \|\| defined(_M_X64)) && !defined(_M_ARM64EC)
LOW	third-party/blake3/c/blake3_impl.h	61	#if !defined(BLAKE3_USE_NEON)
LOW	third-party/blake3/src/join.rs	1	//! The multi-threading abstractions used by `Hasher::update_with_join`.
LOW	third-party/blake3/src/test.rs	701	assert_eq!(_result.to_string(), "invalid hex character: 'Z'");
LOW	third-party/blake3/src/io.rs	21	}
LOW	third-party/blake3/src/io.rs	41	// some raw pointer reads from it. Those reads should be volatile if you don't want the compiler to
LOW	third-party/blake3/src/lib.rs	1	//! The official Rust implementation of the [BLAKE3] cryptographic hash
LOW	third-party/blake3/src/lib.rs	21	//! let mut output = [0; 1000];
LOW	third-party/blake3/src/lib.rs	41	//! will not be portable to other machines.
LOW	third-party/blake3/src/lib.rs	61	//! [`serde::Deserialize`](https://docs.rs/serde/latest/serde/trait.Deserialize.html)
LOW	third-party/blake3/src/lib.rs	81	//! [`Hasher::update_rayon`]: struct.Hasher.html#method.update_rayon
LOW	third-party/blake3/src/lib.rs	101	/// Undocumented and unstable, for benchmarks only.
LOW	third-party/blake3/src/lib.rs	221	/// `[u8; 32]`. However, byte arrays and slices don't provide constant-time
LOW	third-party/blake3/src/lib.rs	621	flags.zeroize();
LOW	third-party/blake3/src/lib.rs	761	//
LOW	third-party/blake3/src/lib.rs	901	/// let hash = blake3::hash(b"foo");
LOW	third-party/blake3/src/lib.rs	921	/// replace an HMAC instance. In that use case, the constant-time equality
LOW	third-party/blake3/src/lib.rs	941	/// This function is always single-threaded. For multithreading support, see
LOW	third-party/blake3/src/lib.rs	961	///
LOW	third-party/blake3/src/lib.rs	981	/// # let key1 = key;
LOW	third-party/blake3/src/lib.rs	1021	platform,
LOW	third-party/blake3/src/lib.rs	1041	/// # fn main() -> Result<(), Box<dyn std::error::Error>> {
LOW	third-party/blake3/src/lib.rs	1121
LOW	third-party/blake3/src/lib.rs	1161	//
LOW	third-party/blake3/src/lib.rs	1181	// compress_subtree_to_parent_node(). That function always returns the top
LOW	third-party/blake3/src/lib.rs	1241	// the largest whole subtree we can, with the full benefits of SIMD and
1222 more matches not shown…

Decorative Section Separators31 hits · 98 pts

Severity	File	Line	Snippet
MEDIUM	third-party/tbb/CMakeLists.txt	77	# ---------------------------------------------------------------------------------------------------------
MEDIUM	third-party/tbb/CMakeLists.txt	99	# ---------------------------------------------------------------------------------------------------------
MEDIUM	third-party/tbb/CMakeLists.txt	104	# ---------------------------------------------------------------------------------------------------------
MEDIUM	third-party/tbb/CMakeLists.txt	163	# -------------------------------------------------------------------
MEDIUM	third-party/tbb/CMakeLists.txt	218	# -------------------------------------------------------------------
MEDIUM	third-party/tbb/CMakeLists.txt	220	# -------------------------------------------------------------------
MEDIUM	third-party/tbb/CMakeLists.txt	229	# -------------------------------------------------------------------
MEDIUM	third-party/tbb/CMakeLists.txt	290	# -------------------------------------------------------------------
MEDIUM	third-party/tbb/CMakeLists.txt	320	# -------------------------------------------------------------------
MEDIUM	third-party/tbb/test/CMakeLists.txt	645	# ----------------------------------------------------------------------------------------
MEDIUM	third-party/tbb/test/CMakeLists.txt	680	# ------------------------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	94	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	96	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	153	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	155	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	504	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	506	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	567	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	569	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	697	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	699	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	741	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/CMakeLists.txt	743	# -----------------------------------------------------------------------------
MEDIUM	third-party/mimalloc/azure-pipelines.yml	168	# ----------------------------------------------------------
MEDIUM	third-party/mimalloc/azure-pipelines.yml	170	# ----------------------------------------------------------
MEDIUM	third-party/zlib/CMakeLists.txt	88	#============================================================================
MEDIUM	third-party/zlib/CMakeLists.txt	90	#============================================================================
MEDIUM	third-party/zlib/CMakeLists.txt	197	#============================================================================
MEDIUM	third-party/zlib/CMakeLists.txt	199	#============================================================================
MEDIUM	third-party/zstd/tests/gzip/init.sh	19	# =========================
MEDIUM	third-party/zstd/tests/gzip/init.sh	40	# ====================================

Self-Referential Comments15 hits · 45 pts

Severity	File	Line	Snippet
MEDIUM	dist.sh	68	# Create a Podman image.
MEDIUM	test/shuffle-sections.sh	11	# Create a lot of sections to lower the probability that
MEDIUM	test/shuffle-sections-seed.sh	11	# Create a lot of sections to lower the probability that
MEDIUM	test/lto-unclaimed.sh	7	# Create a fake LLVM bitcode file
MEDIUM	lib/gentoo-test.sh	23	# Create a Podman image
MEDIUM	third-party/zlib/os400/make.sh	164	# Create the OS/400 library if it does not exist.
MEDIUM	third-party/zlib/os400/make.sh	172	# Create the DOCS source file if it does not exist.
MEDIUM	third-party/zlib/os400/make.sh	194	# Create the OS/400 source program file for the C header files.
MEDIUM	third-party/zlib/os400/make.sh	205	# Create the IFS directory for the C header files.
MEDIUM	third-party/zstd/tests/gzip/init.cfg	1	# This file is sourced by init.sh, before its initialization.
MEDIUM	third-party/zstd/tests/gzip/init.sh	136	# The following code attempts to find a shell with support for these features.
MEDIUM	third-party/zstd/tests/gzip/init.sh	451	# Create an alias, FOO, for each FOO.exe in this directory.
MEDIUM	third-party/zstd/tests/gzip/init.sh	495	# Create a temporary directory, much like mktemp -d does.
MEDIUM	third-party/zstd/tests/gzip/help-version.sh	147	# Create a file in the current directory, not in $TMPDIR.
MEDIUM	third-party/zstd/tests/gzip/test-driver.sh	26	# This file is maintained in Automake, please report

Cross-File Repetition6 hits · 30 pts

Severity	File	Snippet
HIGH	third-party/tbb/python/tbb/pool.py	used to identify which results we're waiting for. will always be called before the jobs get submitted to the work queue,
HIGH	third-party/tbb/python/tbb/pool.py	used to identify which results we're waiting for. will always be called before the jobs get submitted to the work queue,
HIGH	third-party/tbb/python/tbb/pool.py	used to identify which results we're waiting for. will always be called before the jobs get submitted to the work queue,
HIGH	third-party/tbb/python/tbb/pool.py	called by the applyresult object (already registered via register_result()) that it is now ready (ie. the job's result i
HIGH	third-party/tbb/python/tbb/pool.py	called by the applyresult object (already registered via register_result()) that it is now ready (ie. the job's result i
HIGH	third-party/tbb/python/tbb/pool.py	called by the applyresult object (already registered via register_result()) that it is now ready (ie. the job's result i

Excessive Try-Catch Wrapping20 hits · 26 pts

Severity	File	Line	Snippet
LOW	third-party/tbb/python/tbb/__init__.py	233	except Exception as e:
MEDIUM	third-party/tbb/python/tbb/__init__.py	228	def init_sem_name():
LOW	third-party/zstd/tests/DEPRECATED-test-zstd-speed.py	74	except Exception:
LOW	third-party/zstd/tests/DEPRECATED-test-zstd-speed.py	370	except Exception as e:
MEDIUM	third-party/zstd/tests/DEPRECATED-test-zstd-speed.py	71	def does_command_exist(command):
LOW	third-party/zstd/tests/fuzz/fuzz.py	397	except Exception as e:
LOW	third-party/zstd/tests/fuzz/fuzz.py	583	except Exception as e:
LOW	third-party/zstd/tests/fuzz/fuzz.py	636	except Exception as e:
LOW	third-party/zstd/tests/fuzz/fuzz.py	660	except Exception as e:
LOW	third-party/zstd/tests/fuzz/fuzz.py	739	except Exception as e:
LOW	third-party/zstd/tests/fuzz/fuzz.py	814	except Exception as e:
LOW	third-party/zstd/tests/fuzz/fuzz.py	839	except Exception as e:
MEDIUM	third-party/zstd/tests/fuzz/fuzz.py	905	print("Error: No such command {} (pass -h for help)".format(command))
MEDIUM	third-party/zstd/tests/fuzz/fuzz.py	394	def build(args):
MEDIUM	third-party/zstd/tests/fuzz/fuzz.py	580	def libfuzzer_cmd(args):
MEDIUM	third-party/zstd/tests/fuzz/fuzz.py	633	def afl(args):
MEDIUM	third-party/zstd/tests/fuzz/fuzz.py	651	def regression(args):
MEDIUM	third-party/zstd/tests/fuzz/fuzz.py	736	def gen(args):
MEDIUM	third-party/zstd/tests/fuzz/fuzz.py	807	def minimize(args):
MEDIUM	third-party/zstd/tests/fuzz/fuzz.py	833	def zip_cmd(args):

Fake / Example Data16 hits · 23 pts

Severity	File	Line	Snippet
LOW	third-party/zstd/tests/loremOut.h	12	* Generate @size bytes of compressible data using lorem ipsum generator into
LOW	third-party/zstd/tests/fullbench.c	932	* if @compressibility < 0.0, use Lorem Ipsum generator
LOW	third-party/zstd/tests/loremOut.c	12	* Generates a stream of Lorem ipsum paragraphs to stdout,
LOW	…ty/zstd/contrib/seekable_format/tests/seekable_tests.c	272	{ char const inBuffer[] = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididu
LOW	…ty/zstd/contrib/seekable_format/tests/seekable_tests.c	272	{ char const inBuffer[] = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididu
LOW	third-party/zstd/programs/lorem.h	11	/* lorem ipsum generator */
LOW	third-party/zstd/programs/lorem.h	17	* Generate @size bytes of compressible data using lorem ipsum generator
LOW	third-party/zstd/programs/benchzstd.h	128	* if @compressibility < 0.0, uses the lorem ipsum generator
LOW	third-party/zstd/programs/README.md	133	If no file is provided, the benchmark will use a procedurally generated "lorem ipsum" content.
LOW	third-party/zstd/programs/zstd.1.md	674	When no `FILE` is provided, the benchmark will use a procedurally generated `lorem ipsum` text.
LOW	third-party/zstd/programs/benchzstd.c	1015	name = "Lorem ipsum";
LOW	third-party/zstd/programs/lorem.c	13	* This is a very simple lorem ipsum generator
LOW	third-party/zstd/programs/lorem.c	20	* The resulting compression / ratio curve of the lorem ipsum generator
LOW	third-party/zstd/programs/lorem.c	25	* The compression ratio achievable on the generated lorem ipsum
LOW	third-party/zstd/programs/lorem.c	240	/* It's "common" for lorem ipsum generators to start with the same first
LOW	third-party/zstd/programs/zstdcli.c	872	double compressibility = -1.0; /* lorem ipsum generator */

Unused Imports14 hits · 14 pts

Severity	File	Line
LOW	third-party/tbb/python/setup.py	20
LOW	third-party/tbb/python/TBB.py	16
LOW	third-party/tbb/python/TBB.py	17
LOW	third-party/tbb/python/TBB.py	17
LOW	third-party/tbb/python/tbb/__init__.py	32
LOW	third-party/tbb/python/tbb/__init__.py	34
LOW	third-party/tbb/python/tbb/test.py	49
LOW	third-party/tbb/python/tbb/test.py	50
LOW	third-party/tbb/python/tbb/pool.py	70
LOW	third-party/zstd/tests/check_size.py	13
LOW	third-party/zstd/tests/test-zstd-versions.py	19
LOW	third-party/zstd/tests/DEPRECATED-test-zstd-speed.py	20
LOW	third-party/zstd/tests/test-license.py	13
LOW	…rd-party/zstd/contrib/freestanding_lib/freestanding.py	13

Deep Nesting14 hits · 14 pts

Severity	File	Line
LOW	third-party/tbb/python/tbb/__init__.py	248
LOW	third-party/tbb/python/tbb/pool.py	506
LOW	third-party/tbb/python/tbb/pool.py	599
LOW	third-party/zstd/tests/automated_benchmarking.py	260
LOW	third-party/zstd/tests/test-license.py	136
LOW	third-party/zstd/tests/fuzz/fuzz.py	736
LOW	third-party/zstd/tests/cli-tests/run.py	132
LOW	third-party/zstd/tests/cli-tests/run.py	583
LOW	…rd-party/zstd/contrib/freestanding_lib/freestanding.py	115
LOW	…rd-party/zstd/contrib/freestanding_lib/freestanding.py	149
LOW	…rd-party/zstd/contrib/freestanding_lib/freestanding.py	261
LOW	…rd-party/zstd/contrib/freestanding_lib/freestanding.py	523
LOW	…rd-party/zstd/contrib/freestanding_lib/freestanding.py	573
LOW	…rd-party/zstd/contrib/freestanding_lib/freestanding.py	614

AI Slop Vocabulary4 hits · 12 pts

Severity	File	Line	Snippet
MEDIUM	third-party/tbb/test/tbb/test_openmp.cpp	138	// For the purpose of testing, assume that OpenMP and TBB should utilize the same # of threads.
MEDIUM	third-party/tbb/src/tbb/task_stream.h	42	//! Essentially, this is just a pair of a queue and a mutex to protect the queue.
MEDIUM	third-party/tbb/src/tbb/task_dispatcher.cpp	115	// into. Therefore, no need to utilize mandatory concurrency here.
MEDIUM	third-party/mimalloc/src/prim/osx/alloc-override-zone.c	402	// it seems less robust than using interpose.

Cross-Language Confusion2 hits · 8 pts

Severity	File	Line	Snippet
HIGH	third-party/zstd/tests/automated_benchmarking.py	103	os.system("cd ../ && make -j && cd tests")
HIGH	…rd-party/zstd/contrib/freestanding_lib/freestanding.py	55	Handles && and \|\|.

Hyper-Verbose Identifiers6 hits · 6 pts

Severity	File	Line	Snippet
LOW	third-party/tbb/python/tbb/test.py	92	def prepare_timeout_exception():
LOW	third-party/zstd/tests/automated_benchmarking.py	73	def get_builds_for_latest_hash():
LOW	third-party/zstd/tests/automated_benchmarking.py	145	def benchmark_dictionary_single(executable, filenames_directory, dictionary_filename, level, iterations):
LOW	third-party/zstd/tests/automated_benchmarking.py	172	def parse_regressions_and_labels(old_cspeed, new_cspeed, old_dspeed, new_dspeed, baseline_build, test_build):
LOW	third-party/zstd/tests/automated_benchmarking.py	221	def get_regressions_dictionary(baseline_build, test_build, filenames_directory, dictionary_filename, levels, iterations)
LOW	third-party/zstd/tests/DEPRECATED-test-zstd-speed.py	92	def send_email_with_attachments(branch, commit, last_commit, args, text, results_files,

Redundant / Tautological Comments2 hits · 3 pts

Severity	File	Line	Snippet
LOW	test/arch-x86_64-z-rewrite-endbr3.sh	7	# Check if Intel SDE CPU emulator is available
LOW	third-party/zlib/os400/make.sh	66	# Set LINK to "YES" if the module has been compiled.

Score History

Severity Breakdown

Pattern Findings