official-stockfish/Stockfish

Pattern Findings

123 matches across 8 categories. Click a row to expand file-level details.

Over-Commented Block95 hits · 95 pts

Severity	File	Line	Snippet
LOW	scripts/get_native_properties.sh	1	#!/bin/sh
LOW	src/memory.cpp	21	#include <cstdlib>
LOW	src/memory.cpp	41	#include <stdlib.h>
LOW	src/thread.cpp	21	#include <algorithm>
LOW	src/engine.h	21
LOW	src/shm_linux.h	21
LOW	src/numa.h	21
LOW	src/numa.h	41
LOW	src/numa.h	501	// Use system-reported L3 domains
LOW	src/numa.h	521	// As a special case, when performing system-wide replication of read-only data
LOW	src/numa.h	601	// This is needed between Windows 10 Build 20348 and Windows 11, because
LOW	src/numa.h	901	if (SetThreadSelectedCpuSetMasks_f == nullptr \|\| STARTUP_USE_OLD_AFFINITY_API)
LOW	src/types.h	21
LOW	src/types.h	41	#include <cstdint>
LOW	src/types.h	61	// Enforce minimum GCC version
LOW	src/types.h	81	#endif
LOW	src/types.h	221
LOW	src/types.h	421	EN_PASSANT = 2 << 14,
LOW	src/misc.cpp	21	#include <array>
LOW	src/misc.cpp	241	compiler += " AVX512ICL";
LOW	src/misc.cpp	261	#endif
LOW	src/tune.h	61	// and a my_range() function to set custom Option's min-max values, then you just
LOW	src/misc.h	21
LOW	src/misc.h	321	};
LOW	src/misc.h	521	#elif defined(__GNUC__)
LOW	src/misc.h	541	#elif defined(_MSC_VER)
LOW	src/benchmark.cpp	381	// are five parameters: TT size in MB, number of search threads that
LOW	src/evaluate.cpp	21	#include <algorithm>
LOW	src/thread.h	21
LOW	src/history.h	21
LOW	src/search.cpp	21	#include <algorithm>
LOW	src/search.cpp	41	#include "movepick.h"
LOW	src/search.cpp	381	// Adjust the effective depth searched, but ensure at least one
LOW	src/shm.h	21
LOW	src/shm.h	41	#endif
LOW	src/shm.h	61	#endif
LOW	src/shm.h	81	#elif defined(__FreeBSD__)
LOW	src/memory.h	21
LOW	src/engine.cpp	21	#include <algorithm>
LOW	src/attacks.h	21
LOW	src/attacks.h	81	// file, diagonal, unused, antidiagonal
LOW	src/movegen.cpp	21	#include <cassert>
LOW	src/tt.cpp	21	#include <algorithm>
LOW	src/tt.cpp	41	// depth 8 bit
LOW	src/search.h	21
LOW	src/tt.h	21
LOW	src/position.h	21
LOW	src/position.cpp	21	#include <algorithm>
LOW	src/uci.cpp	21	#include <algorithm>
LOW	src/universal/patch_x86_slice.sh	1	#!/bin/sh
LOW	src/universal/nnue_embed.cpp	21	#include "../evaluate.h"
LOW	src/nnue/network.cpp	21	#include <cstdlib>
LOW	src/nnue/network.cpp	41	// data in the engine binary (using incbin.h, by Dale Weiler).
LOW	src/nnue/nnue_accumulator.cpp	21	#include <cassert>
LOW	src/nnue/nnue_common.h	21	#ifndef NNUE_COMMON_H_INCLUDED
LOW	src/nnue/nnue_feature_transformer.h	21	#ifndef NNUE_FEATURE_TRANSFORMER_H_INCLUDED
LOW	src/nnue/nnue_feature_transformer.h	101	#if defined(USE_AVX512)
LOW	src/nnue/nnue_feature_transformer.h	241	#endif
LOW	src/nnue/nnue_feature_transformer.h	261	// means our pairwise product is zero. If we perform packus and
LOW	src/nnue/nnue_feature_transformer.h	281	// might occupy the signed bit, resulting in some positive
35 more matches not shown…

Decorative Section Separators6 hits · 18 pts

Severity	File	Line	Snippet
MEDIUM	scripts/get_native_properties.sh	10	# ---------------------------
MEDIUM	scripts/get_native_properties.sh	12	# ---------------------------
MEDIUM	scripts/get_native_properties.sh	180	# ---------------------------
MEDIUM	scripts/get_native_properties.sh	182	# ---------------------------
MEDIUM	scripts/get_native_properties.sh	253	# ---------------------------
MEDIUM	scripts/get_native_properties.sh	255	# ---------------------------

Hyper-Verbose Identifiers11 hits · 14 pts

Severity	File	Line	Snippet
LOW	tests/instrumented.py	167	def test_export_net_verify_nnue(self):
LOW	tests/instrumented.py	232	def test_ucinewgame_and_startpos_moves(self):
LOW	tests/instrumented.py	314	def test_fen_position_fixed_node(self):
LOW	tests/instrumented.py	322	def test_fen_position_with_mate_go_depth(self):
LOW	tests/instrumented.py	332	def test_fen_position_with_mate_go_mate(self):
LOW	tests/instrumented.py	342	def test_fen_position_with_mate_go_nodes(self):
LOW	tests/instrumented.py	362	def test_fen_position_with_mate_go_depth_and_promotion(self):
LOW	tests/instrumented.py	371	def test_fen_position_with_mate_go_depth_and_searchmoves(self):
LOW	tests/instrumented.py	381	def test_fen_position_with_moves_with_mate_go_depth_and_searchmoves(self):
LOW	tests/instrumented.py	407	def test_fen_position_with_skill_level(self):
LOW	tests/testing.py	42	def get_valgrind_thread_command():

Cross-Language Confusion2 hits · 10 pts

Severity	File	Line	Snippet
HIGH	tests/instrumented.py	221	self.stockfish.equals("uciok")
HIGH	tests/instrumented.py	303	self.stockfish.equals("bestmove d5e6")

AI Slop Vocabulary3 hits · 9 pts

Severity	File	Line	Snippet
MEDIUM	src/shm_linux.h	605	// TODO: Not robust. Need to avoid residual pages if the process
MEDIUM	src/numa.h	1062	// node. On Windows we utilize GetNumaProcessorNodeEx, which has its quirks, see
MEDIUM	src/search.cpp	1299	// std::clamp has been replaced by a more robust implementation.

Deep Nesting3 hits · 3 pts

Severity	File	Line
LOW	tests/instrumented.py	42
LOW	tests/testing.py	92
LOW	tests/testing.py	167

Self-Referential Comments1 hit · 3 pts

Severity	File	Line	Snippet
MEDIUM	.github/workflows/stockfish.yml	85	# Create a new pre-release, the other upload_binaries.yml will upload the binaries

Excessive Try-Catch Wrapping2 hits · 2 pts

Severity	File	Line	Snippet
LOW	tests/testing.py	180	except Exception as e:
LOW	tests/testing.py	233	except Exception as e:

Score History

Severity Breakdown

Pattern Findings