microsoft/WSL

Pattern Findings

360 matches across 11 categories. Click a row to expand file-level details.

Over-Commented Block321 hits · 321 pts

Severity	File	Line	Snippet
LOW	test/linux/unit_tests/lxtlog.c	61	//
LOW	test/linux/unit_tests/lxtfs.c	21	#include <sys/inotify.h>
LOW	test/linux/unit_tests/lxtfs.c	41	#define FS_SECONDS_PER_DAY (86400)
LOW	test/linux/unit_tests/lxtfs.c	61	//
LOW	test/linux/unit_tests/lxtfs.c	1921	// Renaming a symlink with a trailing slash should fail with ENOTDIR.
LOW	test/linux/unit_tests/lxtfs.c	3421	{
LOW	test/linux/unit_tests/dev_pt_2.c	8241	// Ubuntu16 asynchronous pty processing needs some time to process stop.
LOW	test/linux/unit_tests/lxtutil.c	21	#include <sched.h>
LOW	test/linux/unit_tests/splice.c	21	#include <sys/wait.h>
LOW	test/linux/unit_tests/ioprio.c	21
LOW	test/linux/unit_tests/ioprio.c	41
LOW	test/linux/unit_tests/timer.c	21	#include <sys/wait.h>
LOW	test/linux/unit_tests/auxv.c	21	#include <unistd.h>
LOW	test/linux/unit_tests/get_set_id.c	21	#include <sys/syscall.h>
LOW	test/linux/unit_tests/inotify.c	21	#include <sys/time.h>
LOW	test/linux/unit_tests/xattr.c	21	#include <sys/wait.h>
LOW	test/linux/unit_tests/xattr.c	41	#include <sys/capability.h>
LOW	test/linux/unit_tests/pipe.c	21	#include <sys/ioctl.h>
LOW	test/linux/unit_tests/pipe.c	41	#define _4KB (4 * 1024)
LOW	test/linux/unit_tests/fork.c	21	#include <sys/time.h>
LOW	test/linux/unit_tests/fork.c	41	#endif
LOW	test/linux/unit_tests/shm.c	21	#include <sys/xattr.h>
LOW	test/linux/unit_tests/shm.c	41
LOW	test/linux/unit_tests/shm.c	1821	}
LOW	test/linux/unit_tests/shm.c	1841	// succeed with only IPC_EXCL.
LOW	test/linux/unit_tests/timerfd.c	21	#include <sys/stat.h>
LOW	test/linux/unit_tests/lxtcommon.h	21
LOW	test/linux/unit_tests/unittests.h	21	#define AUXV_TESTNAME "auxv"
LOW	test/linux/unit_tests/unittests.h	41	#define IOPRIO_TESTNAME "ioprio"
LOW	test/linux/unit_tests/unittests.h	61	#define SYSFS_TESTNAME "sysfs"
LOW	test/linux/unit_tests/socket_nonblock.c	21	#include <stdio.h>
LOW	test/linux/unit_tests/select.c	21	#include <sys/types.h>
LOW	test/linux/unit_tests/dev_pt_common.h	21	#include <sys/wait.h>
LOW	test/linux/unit_tests/random.c	21	#include <sys/stat.h>
LOW	test/linux/unit_tests/socket.c	21	#include <sys/un.h>
LOW	test/linux/unit_tests/sem.c	21	#include <sys/stat.h>
LOW	test/linux/unit_tests/sem.c	41
LOW	test/linux/unit_tests/sem.c	441	// Wait for the child to exit.
LOW	test/linux/unit_tests/vnet.c	21	#include <sys/stat.h>
LOW	test/linux/unit_tests/vnet.c	41	#include <linux/rtnetlink.h>
LOW	test/linux/unit_tests/vnet.c	1001	// Open file descriptor of default network namespace.
LOW	test/linux/unit_tests/vnet.c	2361	//
LOW	test/linux/unit_tests/vnet.c	2601	// Open file descriptor of the new network namespace.
LOW	test/linux/unit_tests/vnet.c	2921	// Open file descriptor of default network namespace.
LOW	test/linux/unit_tests/lxtutil.h	21
LOW	test/linux/unit_tests/lxtutil.h	121	void* LxtAlloc(size_t Size);
LOW	test/linux/unit_tests/lxtutil.h	141	#define LxtCapSet(_header, _data) (syscall(SYS_capset, _header, _data))
LOW	test/linux/unit_tests/lxtutil.h	161	#define LxtShmDt(_address) syscall(SYS_shmdt, (_address))
LOW	test/linux/unit_tests/lxtutil.h	181	(syscall(SYS_lsetxattr, (_path), (_name), (_buffer), (_size), (_flags)))
LOW	test/linux/unit_tests/lxtutil.h	201	#elif !defined(__amd64__)
LOW	test/linux/unit_tests/lxtfs.h	21	#define FS_9P_NAME "9p"
LOW	test/linux/unit_tests/lxtfs.h	41	//
LOW	test/linux/unit_tests/drvfs.c	21
LOW	test/linux/unit_tests/drvfs.c	41	#include "lxtmount.h"
LOW	test/linux/unit_tests/drvfs.c	61	#define DRVFS_REPARSE_PREFIX DRVFS_PREFIX "/reparsetest"
LOW	test/linux/unit_tests/drvfs.c	81	#define DRVFS_HARDLINK_TEST_DIR DRVFS_PREFIX "/hardlink_test"
LOW	test/linux/unit_tests/drvfs.c	101	#define DRVFS_INOTIFY_FILE_1 DRVFS_INOTIFY_DIR_3 DRVFS_INOTIFY_FILE_1_NAME_ONLY
LOW	test/linux/unit_tests/drvfs.c	821
LOW	test/linux/unit_tests/drvfs.c	1701	//
LOW	test/linux/unit_tests/drvfs.c	1721	//
261 more matches not shown…

Verbosity Indicators9 hits · 14 pts

Severity	File	Line	Snippet
LOW	src/linux/plan9/p9handler.cpp	891	// Step 1: Find the parent of the final item.
LOW	src/linux/plan9/p9handler.cpp	914	// Step 2: Find the item, unless it's an exclusive create.
LOW	src/linux/plan9/p9handler.cpp	948	// Step 3: Create the item if it didn't exist and the user wants to create it.
LOW	src/linux/plan9/p9handler.cpp	996	// Step 4: Check the file type.
LOW	src/linux/plan9/p9handler.cpp	1008	// Step 5: Check for delete access.
LOW	src/linux/plan9/p9handler.cpp	1018	// Step 6: Check how to handle leaf symlinks.
LOW	src/linux/plan9/p9handler.cpp	1033	// Step 7: Open if needed. This is only needed if:
LOW	src/linux/plan9/p9handler.cpp	1055	// Step 8: Get the attributes and reply
LOW	src/windows/wslc/services/ContainerModel.cpp	212	// This is where we need to check if the user is referencing a named volume.

Deep Nesting12 hits · 12 pts

Severity	File	Line
LOW	tools/devops/validate-localization.py	146
LOW	tools/devops/validate-localization.py	232
LOW	tools/test/loop-tests.py	198
LOW	tools/test/loop-tests.py	356
LOW	tools/test/gh-release-server.py	21
LOW	tools/test/gh-release-server.py	38
LOW	distributions/validate-modern.py	94
LOW	distributions/validate-modern.py	236
LOW	distributions/validate-modern.py	292
LOW	distributions/validate-modern.py	357
LOW	distributions/validate-modern.py	372
LOW	distributions/validate-modern.py	483

Decorative Section Separators3 hits · 9 pts

Severity	File	Line	Snippet
MEDIUM	.pipelines/build-stage.yml	68	# ── x64 build stage ──────────────────────────────────────────────────
MEDIUM	.pipelines/build-stage.yml	88	# ── arm64 build stage (runs in parallel with build_x64) ──────────────
MEDIUM	.pipelines/build-stage.yml	145	# ── package stage (release and nightly only) ─────────────────────────

Unused Imports7 hits · 7 pts

Severity	File	Line
LOW	tools/devops/find-release.py	11
LOW	tools/test/gh-release-server.py	5
LOW	tools/test/gh-release-server.py	9
LOW	distributions/validate-modern.py	3
LOW	distributions/validate-modern.py	14
LOW	distributions/validate.py	1
LOW	distributions/validate.py	8

Cross-Language Confusion1 hit · 5 pts

Severity	File	Line	Snippet
HIGH	tools/devops/create-change.py	41	repo.git.push('origin', branch)

Self-Referential Comments1 hit · 3 pts

Severity	File	Line	Snippet
MEDIUM	.pipelines/flight-stage.yml	112	# Create a draft github release

Hyper-Verbose Identifiers3 hits · 3 pts

Severity	File	Line	Snippet
LOW	tools/test/gh-release-server.py	34	class ReleaseRequestHandler(SimpleHTTPRequestHandler):
LOW	distributions/validate-modern.py	236	def read_systemd_enabled_units(node, tar) -> dict:
LOW	distributions/validate.py	11	def download_and_get_manifest(url: str):

AI Slop Vocabulary1 hit · 3 pts

Severity	File	Line	Snippet
MEDIUM	test/linux/unit_tests/fork.c	427	// Set and get the robust list.

Example Usage Blocks1 hit · 2 pts

Severity	File	Line	Snippet
LOW	tools/devops/find-release.py	3	# Usage:

Excessive Try-Catch Wrapping1 hit · 1 pts

Severity	File	Line	Snippet
LOW	distributions/validate-modern.py	510	except Exception as e:

Score History

Severity Breakdown

Pattern Findings