magic-wormhole/magic-wormhole

Pattern Findings

230 matches across 8 categories. Click a row to expand file-level details.

Hyper-Verbose Identifiers133 hits · 138 pts

Severity	File	Line	Snippet
LOW	versioneer.py	691	def git_versions_from_keywords(
LOW	versioneer.py	1222	def git_versions_from_keywords(
LOW	misc/demo-journal.py	217	def wormhole_dispatch_got_code(self, code, iid):
LOW	misc/demo-journal.py	225	def wormhole_dispatch_got_verifier(self, verifier, iid):
LOW	misc/demo-journal.py	228	def wormhole_dispatch_verified(self, _, iid):
LOW	misc/demo-journal.py	231	def wormhole_dispatch_got_data(self, data, iid):
LOW	src/wormhole/_rlcompleter.py	67	def _commit_and_build_completions(self, text):
LOW	src/wormhole/_rlcompleter.py	153	def _input_code_with_completion(prompt, input_helper, reactor):
LOW	src/wormhole/transit.py	83	def build_sided_relay_handshake(key, side):
LOW	src/wormhole/_version.py	184	def git_versions_from_keywords(
LOW	src/wormhole/_nameplate.py	164	def send_status_code_allocated(self):
LOW	src/wormhole/_nameplate.py	170	def send_status_code_consumed(self):
LOW	src/wormhole/_interfaces.py	59	def wormhole_got_unverified_key(key: bytes) -> None: # XXX definitely bytes?
LOW	src/wormhole/_interfaces.py	416	def get_nameplate_completions(prefix):
LOW	src/wormhole/_interfaces.py	451	def when_wordlist_is_available():
LOW	src/wormhole/_rendezvous.py	178	def _initial_connection_failed(self, f):
LOW	src/wormhole/_rendezvous.py	287	def _response_handle_allocated(self, msg):
LOW	src/wormhole/_rendezvous.py	292	def _response_handle_nameplates(self, msg):
LOW	src/wormhole/_rendezvous.py	332	def _response_handle_released(self, msg):
LOW	src/wormhole/_key.py	120	def deliver_code_and_stashed_pake(self, code):
LOW	src/wormhole/_boss.py	402	def send_status_confirmed_key(self, plaintext):
LOW	src/wormhole/_input.py	46	def when_wordlist_is_available(self):
LOW	src/wormhole/_input.py	94	def get_nameplate_completions(self, prefix):
LOW	src/wormhole/_input.py	129	def _get_nameplate_completions(self, prefix):
LOW	src/wormhole/_input.py	316	def get_nameplate_completions(self, prefix):
LOW	src/wormhole/_input.py	326	def when_wordlist_is_available(self):
LOW	src/wormhole/test/test_machines.py	822	def test_close_while_idle_nameplate():
LOW	src/wormhole/test/test_machines.py	828	def test_close_while_idle_connected():
LOW	src/wormhole/test/test_machines.py	836	def test_close_while_unclaimed():
LOW	src/wormhole/test/test_machines.py	842	def test_close_while_claiming():
LOW	src/wormhole/test/test_machines.py	1185	def test_close_while_idle_but_connected():
LOW	src/wormhole/test/test_machines.py	1191	def test_close_while_mailbox_disconnected():
LOW	src/wormhole/test/test_machines.py	1197	def test_close_while_reconnecting():
LOW	src/wormhole/test/test_machines.py	504	def test_connect_first_lister():
LOW	src/wormhole/test/test_machines.py	531	def test_connect_first_ask_twice():
LOW	src/wormhole/test/test_machines.py	627	def test_connect_first_allocator():
LOW	src/wormhole/test/test_machines.py	700	def test_connect_first_nameplate():
LOW	src/wormhole/test/test_machines.py	726	def test_reconnect_while_claiming():
LOW	src/wormhole/test/test_machines.py	740	def test_reconnect_while_claimed():
LOW	src/wormhole/test/test_machines.py	763	def test_reconnect_while_releasing():
LOW	src/wormhole/test/test_machines.py	790	def test_reconnect_while_done():
LOW	src/wormhole/test/test_machines.py	857	def test_close_while_claiming_but_disconnected():
LOW	src/wormhole/test/test_machines.py	901	def test_close_while_claimed_but_disconnected():
LOW	src/wormhole/test/test_machines.py	928	def test_close_while_releasing():
LOW	src/wormhole/test/test_machines.py	954	def test_close_while_releasing_but_disconnecteda():
LOW	src/wormhole/test/test_machines.py	1017	def test_close_while_done_but_disconnected():
LOW	src/wormhole/test/test_machines.py	1069	def test_connect_first_mailbox(): # connect before got_mailbox
LOW	src/wormhole/test/test_transit.py	39	async def test_there_might_also_be_none():
LOW	src/wormhole/test/test_transit.py	74	async def test_cancel_after_one_failure():
LOW	src/wormhole/test/test_transit.py	124	async def test_not_forever_cancel_early(forever):
LOW	src/wormhole/test/test_transit.py	152	def test_allocate_port_no_reuseaddr():
LOW	src/wormhole/test/test_transit.py	204	async def test_ignore_localhost_hint_orig():
LOW	src/wormhole/test/test_transit.py	219	async def test_ignore_localhost_hint():
LOW	src/wormhole/test/test_transit.py	234	async def test_keep_only_localhost_hint():
LOW	src/wormhole/test/test_transit.py	270	async def test_transit_key_already_set():
LOW	src/wormhole/test/test_transit.py	464	async def test_one_fail_one_success():
LOW	src/wormhole/test/test_transit.py	669	async def test_handshake_other_error():
LOW	src/wormhole/test/test_transit.py	812	async def test_receiver_rejected_politely():
LOW	src/wormhole/test/test_transit.py	844	async def test_receiver_rejected_rudely():
LOW	src/wormhole/test/test_transit.py	875	async def test_cancel_during_negotiation():
73 more matches not shown…

Over-Commented Block38 hits · 38 pts

Severity	File	Line	Snippet
LOW	.appveyor.yml	41	after_test:
LOW	versioneer.py	1881	# this fixes the "python setup.py develop" case (also 'install' and
LOW	versioneer.py	1921	#
LOW	misc/demo-journal.py	201	return b"ok"
LOW	misc/web/timeline.js	101	// [id], details={} }
LOW	docs/conf.py	1
LOW	docs/conf.py	141	# The paper size ('letterpaper' or 'a4paper').
LOW	src/wormhole/_rlcompleter.py	101	if not self._committed_nameplate:
LOW	src/wormhole/_rlcompleter.py	181	# user into satisfying the blocking read so we can exit.
LOW	src/wormhole/transit.py	41
LOW	src/wormhole/transit.py	281
LOW	src/wormhole/transit.py	921	# how should the Listener be managed? we want to shut it down when the
LOW	src/wormhole/_rendezvous.py	241	# CLOSE_STATUS_CODE_ABNORMAL_CLOSE, and delivers onClose() without
LOW	src/wormhole/_boss.py	201
LOW	src/wormhole/wormhole.py	21
LOW	src/wormhole/wormhole.py	301	client_version = ("python", v)
LOW	src/wormhole/test/test_machines.py	1701	# #Terminator
LOW	src/wormhole/test/test_cli.py	241	f.write(b"fail")
LOW	src/wormhole/test/test_cli.py	321	return pytest.skip(
LOW	src/wormhole/test/dilate/test_record.py	141	assert n.mock_calls == [mock.call.start_handshake(),
LOW	src/wormhole/test/dilate/test_record.py	161	# \| 3 \| \| write_message \| handshake \| \|
LOW	src/wormhole/cli/cmd_receive.py	81	tor=self._tor,
LOW	src/wormhole/cli/cmd_send.py	181	notify.cancel()
LOW	src/wormhole/cli/cmd_send.py	301	# os.path.joined with the unicode args.what .
LOW	src/wormhole/cli/cmd_send.py	321	# * we're running on windows
LOW	src/wormhole/_dilation/inbound.py	141
LOW	src/wormhole/_dilation/connection.py	21	# The next object up knows whether it's expecting a Handshake or a message. It
LOW	src/wormhole/_dilation/connection.py	61	# * send "sided relay handshake": "please relay TOKEN for side SIDE\n"
LOW	src/wormhole/_dilation/outbound.py	21	# to reestablish a new one), registered subchannels will be paused, but
LOW	src/wormhole/_dilation/outbound.py	41	# unusual because we have multiple Subchannels that get merged into the
LOW	src/wormhole/_dilation/outbound.py	61	# Producers will be paused, and others will be resumed
LOW	src/wormhole/_dilation/outbound.py	81	# queues some data on the TCP connection (and then might call
LOW	src/wormhole/_dilation/outbound.py	101	#
LOW	src/wormhole/_dilation/outbound.py	121	# * keep a set of IPushProducers which are paused, a second set of
LOW	src/wormhole/_dilation/outbound.py	141	#
LOW	src/wormhole/_dilation/subchannel.py	21	# length prefix itself), so the padded message must be less than 2**32 bytes
LOW	src/wormhole/_dilation/connector.py	341	made_direct = True
LOW	src/wormhole/_dilation/manager.py	141	# in WANTING, then we process all previously-queued inbound DILATE-n

Excessive Try-Catch Wrapping18 hits · 22 pts

Severity	File	Line	Snippet
LOW	src/wormhole/_rlcompleter.py	43	except Exception as e:
MEDIUM	src/wormhole/_rlcompleter.py	40	def completer(self, text, state):
LOW	src/wormhole/transit.py	138	except Exception as e:
MEDIUM	src/wormhole/transit.py	135	def dataReceived(self, data):
LOW	src/wormhole/_rendezvous.py	32	except Exception:
LOW	src/wormhole/_rendezvous.py	204	except Exception as e:
LOW	src/wormhole/_rendezvous.py	231	except Exception as e:
LOW	src/wormhole/tor_manager.py	107	except Exception:
LOW	src/wormhole/eventual.py	32	except Exception:
LOW	src/wormhole/ipaddrs.py	60	except Exception:
LOW	src/wormhole/cli/cmd_receive.py	114	except Exception:
MEDIUM	src/wormhole/cli/cmd_receive.py	111	def _bad(f):
LOW	src/wormhole/cli/cmd_ssh.py	52	except Exception:
LOW	src/wormhole/cli/cmd_send.py	94	except Exception:
MEDIUM	src/wormhole/cli/cmd_send.py	91	def _bad(f):
LOW	src/wormhole/cli/cli.py	179	except Exception as e:
LOW	src/wormhole/_dilation/outbound.py	353	except Exception:
LOW	src/wormhole/_dilation/outbound.py	360	except Exception:

Deep Nesting18 hits · 18 pts

Severity	File	Line
LOW	versioneer.py	1194
LOW	versioneer.py	1427
LOW	versioneer.py	1752
LOW	versioneer.py	2172
LOW	src/wormhole/transit.py	681
LOW	src/wormhole/_version.py	156
LOW	src/wormhole/_version.py	602
LOW	src/wormhole/tor_manager.py	32
LOW	src/wormhole/test/test_ssh.py	44
LOW	src/wormhole/test/test_cli.py	416
LOW	src/wormhole/test/test_cli.py	808
LOW	src/wormhole/cli/cmd_receive.py	406
LOW	src/wormhole/cli/cmd_ssh.py	15
LOW	src/wormhole/cli/cmd_send.py	273
LOW	src/wormhole/_dilation/connection.py	213
LOW	src/wormhole/_dilation/connection.py	635
LOW	src/wormhole/_dilation/manager.py	460
LOW	src/wormhole/_dilation/manager.py	583

AI Slop Vocabulary7 hits · 15 pts

Severity	File	Line	Snippet
LOW	versioneer.py	533	# each be defined on a line of their own. _version.py will just call
LOW	src/wormhole/transit.py	483	# close-on-exec because we close it right away. So just add SO_REUSEADDR.
MEDIUM	src/wormhole/_status.py	108	# note that the tests (e.g. test_api.py) leverage the order of these
LOW	src/wormhole/_version.py	26	# each be defined on a line of their own. _version.py will just call
MEDIUM	src/wormhole/test/dilate/test_record.py	302	# structures can be set up and paired properly. Essentially
MEDIUM	src/wormhole/_dilation/manager.py	29	# note that these are strings, not numbers, to facilitate
LOW	src/wormhole/_dilation/manager.py	975	# invoked; upstream calls are basically just call-through -- so

Unused Imports12 hits · 12 pts

Severity	File	Line
LOW	versioneer.py	318
LOW	versioneer.py	318
LOW	versioneer.py	318
LOW	misc/dump-timing.py	5
LOW	misc/dump-timing.py	5
LOW	src/wormhole/__init__.py	1
LOW	src/wormhole/__init__.py	2
LOW	src/wormhole/__init__.py	3
LOW	src/wormhole/__init__.py	3
LOW	src/wormhole/__init__.py	4
LOW	src/wormhole/_dilation/_noise.py	5
LOW	src/wormhole/_dilation/_noise.py	11

Hallucination Indicators1 hit · 10 pts

Severity	File	Line	Snippet
CRITICAL	src/wormhole/test/test_wormhole.py	715	w1._boss._RC._ws.transport.loseConnection()

Self-Referential Comments3 hits · 9 pts

Severity	File	Line	Snippet
MEDIUM	versioneer.py	514	# This file is released into the public domain.
MEDIUM	docs/conf.py	5	# This file is execfile()d with the current directory set to its
MEDIUM	src/wormhole/_version.py	7	# This file is released into the public domain.

Score History

Severity Breakdown

Pattern Findings