kovidgoyal/kitty

Pattern Findings

1408 matches across 10 categories. Click a row to expand file-level details.

Hyper-Verbose Identifiers510 hits · 414 pts

Severity	File	Line	Snippet
LOW	setup.py	778	def get_source_specific_defines(env: Env, src: str) -> Tuple[str, List[str], Optional[List[str]]]:
LOW	setup.py	797	def get_source_specific_cflags(env: Env, src: str) -> List[str]:
LOW	setup.py	1228	def update_go_generated_files(args: Options, kitty_exe: str) -> None:
LOW	setup.py	1780	def create_quick_access_bundle(kapp: str, quake_desc: str = 'Quick access to kitty') -> None:
LOW	setup.py	1798	def create_minimal_macos_bundle(args: Options, launcher_dir: str, relocate: bool = False) -> None:
LOW	publish.py	311	def make_request_with_retries(
LOW	publish.py	348	def update_nightly_description(self, release_id: int) -> None:
LOW	publish.py	397	def print_failed_response_details(self, r: HTTPResponse, msg: str) -> None:
LOW	publish.py	411	def existing_assets_for_release(self, release: Dict[str, Any]) -> List[Dict[str, Any]]:
LOW	publish.py	521	def remove_pycache_only_folders() -> None:
LOW	kittens/runner.py	53	def import_kitten_main_module(config_dir: str, kitten: str) -> dict[str, Any]:
LOW	kittens/runner.py	214	def get_kitten_extra_cli_parsers(kitten: str) -> dict[str,str]:
LOW	kittens/panel/main.py	44	def panel_kitten_options_spec() -> str:
LOW	kittens/panel/main.py	101	def cli_option_to_lsc_configs_map() -> MappingProxyType[str, tuple[str, ...]]:
LOW	kittens/panel/main.py	119	def incrementally_update_layer_shell_config(existing: dict[str, Any], cli_options: Iterable[str]) -> LayerShellConfig:
LOW	kittens/panel/main.py	144	def have_config_files_been_updated(config_files: Iterable[str]) -> bool:
LOW	kittens/panel/main.py	157	def handle_single_instance_command(boss: BossType, sys_args: Sequence[str], environ: Mapping[str, str], notify_on_os_win
LOW	kittens/tui/handler.py	89	def allow_indiscriminate_remote_control(self, enable: bool = True) -> None:
LOW	kittens/tui/handler.py	236	def perform_default_key_action(self, key_event: KeyEventType) -> bool:
LOW	kittens/tui/handler.py	290	def on_file_transfer_response(self, ftc: 'FileTransmissionCommand') -> None:
LOW	kittens/tui/loop.py	364	def total_pending_bytes_to_write(self) -> int:
LOW	kittens/choose_files/main.py	174	def relative_path_if_possible(path: str, base: str) -> str:
LOW	kittens/ssh/utils.py	84	def remove_env_var_from_cmdline(key: str, argv: list[str]) -> None:
LOW	kittens/ssh/utils.py	97	def set_single_env_var_in_cmdline(key: str, val: str, argv: list[str]) -> None:
LOW	kittens/ssh/utils.py	122	def read_data_from_shared_memory(shm_name: str) -> Any:
LOW	kittens/ssh/utils.py	218	def set_server_args_in_cmdline(
LOW	kittens/command_palette/main.py	125	def collect_keyboard_bindings(
LOW	kittens/command_palette/main.py	158	def relocate_mode_entry_bindings(
LOW	docs/conf.py	318	def write_remote_control_protocol_docs() -> None: # {{{
LOW	docs/notifications.py	21	def on_notification_activated(nc: NotificationCommand, which: int) -> None:
LOW	gen/go_code.py	224	def generate_kittens_completion() -> None:
LOW	gen/go_code.py	255	def completion_for_launch_wrappers(*names: str) -> None:
LOW	gen/go_code.py	261	def generate_completions_for_kitty() -> None:
LOW	gen/go_code.py	364	def go_code_for_remote_command(name: str, cmd: RemoteCommand, template: str) -> str:
LOW	gen/go_code.py	461	def generate_extra_cli_parser(name: str, spec: str) -> None:
LOW	gen/go_code.py	481	def kittens_needing_cli_parsers() -> Iterator[str]:
LOW	gen/go_code.py	784	def generate_readline_actions() -> str:
LOW	gen/go_code.py	855	def generate_textual_mimetypes() -> str:
LOW	gen/wcwidth.py	206	def parse_flag_emoji_sequence(spec: str) -> None:
LOW	gen/wcwidth.py	223	def parse_emoji_modifier_sequence(spec: str) -> None:
LOW	gen/wcwidth.py	272	def parse_grapheme_segmentation() -> None:
LOW	gen/wcwidth.py	689	def bitfield_declaration_as_c(name: str, fields: dict[str, int], *alternate_fields: dict[str, int]) -> str:
LOW	gen/wcwidth.py	833	def split_into_graphemes_with_table(
LOW	gen/wcwidth.py	848	def test_grapheme_segmentation(split_into_graphemes: Callable[[str], Iterator[str]]) -> None:
LOW	gen/key_constants.py	304	def generate_functional_table() -> None:
LOW	gen/key_constants.py	351	def generate_legacy_text_key_maps() -> None:
LOW	.github/workflows/macos_crash_report.py	363	def application_specific_information(self) -> Optional[str]:
LOW	.github/workflows/macos_crash_report.py	426	def get_crash_report_from_file(crash_report_file: IO) -> CrashReportBase:
LOW	glad/generate.py	32	def strip_trailing_whitespace(c):
LOW	shell-integration/ssh/bootstrap.py	244	def exec_zsh_with_integration():
LOW	shell-integration/ssh/bootstrap.py	259	def exec_fish_with_integration():
LOW	shell-integration/ssh/bootstrap.py	268	def exec_bash_with_integration():
LOW	shell-integration/ssh/bootstrap.py	277	def exec_with_shell_integration():
LOW	kitty/config.py	20	def option_names_for_completion() -> tuple[str, ...]:
LOW	kitty/config.py	66	def commented_out_default_config() -> str:
LOW	kitty/config.py	71	def prepare_config_file_for_editing() -> str:
LOW	kitty/config.py	171	def add_effective_config_line(key: str, line: str) -> None:
LOW	kitty/window.py	178	def modify_argv_for_launch_with_cwd(self, argv: list[str], env: dict[str, str] \| None=None, hold_after_ssh: bool = F
LOW	kitty/window.py	525	def transparent_background_color_control(cp: ColorProfile, responses: dict[str, str], index: int, key: str, sep: str, va
LOW	kitty/window.py	696	def set_ignore_focus_changes_for_new_windows(cls, value: bool = True) -> Generator[None, None, None]:
450 more matches not shown…

Over-Commented Block351 hits · 326 pts

Severity	File	Line	Snippet
LOW	dev.sh	1	#!/bin/sh
LOW	kittens/tui/dircolors.py	1	#!/usr/bin/env python
LOW	kittens/tui/dircolors.py	41	TERM vt100
LOW	kittens/dnd/drop_test.go	141	// sub/
LOW	kittens/diff/diff.go	21	// Diff returns an anchored diff of the two texts old and new
LOW	kittens/diff/diff.go	181	// tgs returns the pairs of indexes of the longest common subsequence
LOW	tools/rsync/api.go	1	// License: GPLv3 Copyright: 2023, Kovid Goyal, <kovid at kovidgoyal.net>
LOW	tools/utils/file_at_fd_test.go	461	// base/
LOW	tools/utils/humanize/times.go	21	// Time formats a time into a relative string.
LOW	tools/simdstring/generate.sh	1	#!/bin/sh
LOW	tools/simdstring/benchmark.sh	1	#!/bin/sh
LOW	tools/simdstring/test.sh	1	#!/bin/sh
LOW	tools/fzf/types.go	121
LOW	docs/conf.py	81	#
LOW	gen/rowcolumn-diacritics.txt	1	# This file lists the diacritics used to indicate row/column numbers for
LOW	3rdparty/verstable.h	261	KEY_TY, and (optionally) VAL_TY, CTX_TY, and header guards, and including the library, e.g.:
LOW	3rdparty/verstable.h	441	#define VT_CAT( a, b ) VT_CAT_( a, b )
LOW	3rdparty/verstable.h	601	// In summary, instantiating a template also defines wrappers for the template's types and functions with names in the
LOW	3rdparty/verstable.h	621
LOW	3rdparty/verstable.h	641	#define VT_R3_0( ty, fn )
LOW	3rdparty/verstable.h	741	// indicating whether the key in this bucket begins a chain associated with the bucket (Y), and
LOW	3rdparty/verstable.h	841
LOW	3rdparty/verstable.h	861	#else
LOW	3rdparty/verstable.h	881	_Pragma( "warning( pop )" )
LOW	3rdparty/verstable.h	921	#endif
LOW	3rdparty/verstable.h	1461	}
LOW	3rdparty/verstable.h	1861	#elif VT_TEMPLATE_COUNT_D1 == 2
LOW	3rdparty/verstable.h	1881	#define VT_TEMPLATE_COUNT_D2 1
LOW	3rdparty/verstable.h	1901	#undef VT_TEMPLATE_COUNT_D2
LOW	3rdparty/verstable.h	1921	#elif VT_TEMPLATE_COUNT_D3 == 6
LOW	3rdparty/verstable.h	1941	#undef CTX_TY
LOW	3rdparty/base64/include/libbase64.h	1	#ifndef LIBBASE64_H
LOW	3rdparty/base64/include/libbase64.h	21	#endif
LOW	3rdparty/base64/lib/env.h	1	#ifndef BASE64_ENV_H
LOW	3rdparty/base64/lib/env.h	21	#endif
LOW	3rdparty/base64/lib/env.h	41	# define BASE64_HTOBE32(x) (x)
LOW	3rdparty/base64/lib/env.h	61	#define BASE64_AEOF 1
LOW	3rdparty/base64/lib/lib.c	1	#include <stdint.h>
LOW	3rdparty/base64/lib/codec_choose.c	1	#include <stdbool.h>
LOW	3rdparty/base64/lib/codec_choose.c	41	return ((uint64_t)edx << 32) \| eax;
LOW	3rdparty/base64/lib/codec_choose.c	61	#ifndef bit_SSE41
LOW	3rdparty/base64/lib/lib_openmp.c	1	// This code makes some assumptions on the implementation of
LOW	3rdparty/base64/lib/arch/avx2/codec.c	1	#include <stdint.h>
LOW	3rdparty/base64/lib/arch/avx2/codec.c	21	#endif
LOW	3rdparty/base64/lib/arch/avx2/enc_reshuffle.c	21	5, 6, 4, 5));
LOW	3rdparty/base64/lib/arch/avx2/enc_reshuffle.c	41	// 0000eeee FF000000 DDDDDD00 00000000
LOW	3rdparty/base64/lib/arch/avx2/enc_reshuffle.c	61	// 00000000 00ffffff 000000dd EEEE0000
LOW	3rdparty/base64/lib/arch/avx2/enc_loop_asm.c	1	// Apologies in advance for combining the preprocessor with inline assembly,
LOW	3rdparty/base64/lib/arch/avx2/enc_loop_asm.c	41	LOAD("a", 0, -4) \
LOW	3rdparty/base64/lib/arch/avx2/enc_loop_asm.c	101
LOW	3rdparty/base64/lib/arch/avx2/dec_reshuffle.c	1	static inline __m256i
LOW	3rdparty/base64/lib/arch/sse41/codec.c	1	#include <stdint.h>
LOW	3rdparty/base64/lib/arch/sse41/codec.c	21	#endif
LOW	3rdparty/base64/lib/arch/neon32/codec.c	1	#include <stdint.h>
LOW	3rdparty/base64/lib/arch/neon32/codec.c	41
LOW	3rdparty/base64/lib/arch/neon32/enc_reshuffle.c	1	static inline uint8x16x4_t
LOW	3rdparty/base64/lib/arch/sse42/codec.c	1	#include <stdint.h>
LOW	3rdparty/base64/lib/arch/sse42/codec.c	21	#endif
LOW	3rdparty/base64/lib/arch/avx512/codec.c	1	#include <stdint.h>
LOW	3rdparty/base64/lib/arch/ssse3/codec.c	1	#include <stdint.h>
291 more matches not shown…

Deep Nesting249 hits · 230 pts

Severity	File	Line
LOW	setup.py	265
LOW	setup.py	317
LOW	setup.py	369
LOW	setup.py	728
LOW	setup.py	797
LOW	setup.py	840
LOW	setup.py	865
LOW	setup.py	914
LOW	setup.py	1348
LOW	setup.py	1371
LOW	setup.py	2185
LOW	setup.py	2270
LOW	publish.py	150
LOW	publish.py	311
LOW	kittens/tui/handler.py	252
LOW	kittens/tui/dircolors.py	294
LOW	kittens/tui/operations.py	291
LOW	kittens/tui/utils.py	18
LOW	kittens/tui/images.py	485
LOW	kittens/tui/loop.py	273
LOW	kittens/tui/loop.py	292
LOW	kittens/tui/loop.py	307
LOW	kittens/remote_file/main.py	53
LOW	kittens/remote_file/main.py	311
LOW	kittens/ssh/utils.py	84
LOW	kittens/ssh/utils.py	218
LOW	kittens/ssh/utils.py	282
LOW	kittens/choose_fonts/backend.py	151
LOW	kittens/choose_fonts/backend.py	204
LOW	kittens/hints/main.py	283
LOW	kittens/hints/main.py	339
LOW	kittens/command_palette/main.py	158
LOW	docs/conf.py	233
LOW	docs/conf.py	318
LOW	docs/conf.py	721
LOW	docs/conf.py	322
LOW	docs/conf.py	381
LOW	docs/extract-rst-targets.py	23
LOW	gen/go_code.py	100
LOW	gen/go_code.py	364
LOW	gen/go_code.py	492
LOW	gen/wcwidth.py	99
LOW	gen/wcwidth.py	232
LOW	gen/wcwidth.py	763
LOW	gen/cursors.py	60
LOW	gen/key_constants.py	351
LOW	gen/key_constants.py	356
LOW	gen/__main__.py	9
LOW	.github/workflows/ci.py	48
LOW	.github/workflows/ci.py	178
LOW	.github/workflows/ci.py	270
LOW	.github/workflows/macos_crash_report.py	272
LOW	.github/workflows/macos_crash_report.py	307
LOW	.github/workflows/macos_crash_report.py	363
LOW	bypy/macos/__main__.py	245
LOW	bypy/macos/__main__.py	344
LOW	bypy/linux/__main__.py	52
LOW	bypy/linux/__main__.py	68
LOW	shell-integration/ssh/bootstrap.py	115
LOW	shell-integration/ssh/bootstrap.py	172
189 more matches not shown…

Excessive Try-Catch Wrapping202 hits · 185 pts

Severity	File	Line	Snippet
LOW	setup.py	311	except Exception:
LOW	setup.py	352	except Exception:
LOW	setup.py	746	except Exception as e:
LOW	setup.py	868	except Exception:
LOW	publish.py	337	except Exception as e:
LOW	publish.py	401	except Exception:
LOW	kittens/runner.py	226	except Exception:
MEDIUM	kittens/runner.py	222	def main() -> None:
LOW	kittens/panel/main.py	128	except Exception as e:
LOW	kittens/tui/images.py	25	except Exception:
LOW	kittens/tui/images.py	269	except Exception:
LOW	kittens/tui/images.py	493	except Exception:
LOW	kittens/tui/images.py	529	except Exception as e:
LOW	kittens/tui/images.py	545	except Exception as e:
LOW	kittens/tui/loop.py	241	except Exception:
LOW	kittens/tui/loop.py	266	except Exception:
LOW	kittens/tui/loop.py	303	except Exception:
LOW	kittens/tui/loop.py	314	except Exception:
LOW	kittens/tui/loop.py	327	except Exception:
LOW	kittens/tui/loop.py	458	except Exception:
LOW	kittens/remote_file/main.py	247	except Exception:
LOW	kittens/ssh/utils.py	146	except Exception:
LOW	kittens/ssh/utils.py	156	except Exception as e:
MEDIUM	kittens/ssh/utils.py	17	def ssh_options() -> dict[str, str]:
LOW	kittens/choose_fonts/backend.py	40	except Exception:
LOW	kittens/hints/main.py	359	except Exception:
LOW	docs/conf.py	218	except Exception:
LOW	.github/workflows/ci.py	76	except Exception as err:
LOW	bypy/macos/__main__.py	206	except Exception as e:
LOW	shell-integration/ssh/bootstrap.py	316	except Exception as err:
LOW	kitty/config.py	41	except Exception as err:
LOW	kitty/config.py	54	except Exception as err:
LOW	kitty/config.py	62	except Exception as err:
LOW	kitty/config.py	89	except Exception as err:
LOW	kitty/config.py	129	except Exception as err:
LOW	kitty/os_window_size.py	65	except Exception:
LOW	kitty/window.py	220	except Exception:
LOW	kitty/window.py	479	except Exception as e:
LOW	kitty/window.py	541	except Exception:
LOW	kitty/window.py	920	except Exception:
LOW	kitty/window.py	1284	except Exception:
LOW	kitty/window.py	1340	except Exception:
LOW	kitty/window.py	1350	except Exception:
LOW	kitty/window.py	1416	except Exception:
LOW	kitty/window.py	1589	except Exception:
LOW	kitty/window.py	1611	except Exception:
LOW	kitty/window.py	1642	except Exception:
LOW	kitty/window.py	1770	except Exception:
LOW	kitty/window.py	1921	except Exception:
LOW	kitty/update_check.py	45	except Exception:
LOW	kitty/update_check.py	65	except Exception:
LOW	kitty/update_check.py	114	except Exception as e:
MEDIUM	kitty/update_check.py	42	def get_released_version() -> str:
MEDIUM	kitty/update_check.py	108	def update_check() -> bool:
LOW	kitty/tabs.py	790	except Exception:
LOW	kitty/tabs.py	1255	except Exception:
LOW	kitty/tabs.py	1263	except Exception:
LOW	kitty/tabs.py	1350	except Exception:
LOW	kitty/tabs.py	1574	except Exception:
LOW	kitty/render_cache.py	36	except Exception:
142 more matches not shown…

Cross-Language Confusion17 hits · 89 pts

Severity	File	Line	Snippet
HIGH	setup.py	1464	make && make docs
HIGH	setup.py	1482	make && make docs
HIGH	gen/apc_parsers.py	210	int64_t n = parser_buf[i] - '0'; if (n < 0 \|\| n > 9) break; \\
HIGH	logo/make.py	137	run('ssh', 'ox', 'zsh', '-ilc', '~/bin/update-kitty && python3 ~/kitty-src/logo/make.py remote-macos')
HIGH	kitty/options/types.py	785	val = options_dict.get(key, null)
HIGH	kitty/conf/generate.py	219	a(' val = options_dict.get(key, null)')
HIGH	kitty/rc/set_spacing.py	69	settings+/dict.spacing: An object mapping margins/paddings using canonical form {'margin-top': 50, 'padding-left': n
HIGH	kitty_tests/dnd.py	804	"""URI file request for a non-regular file (e.g. /dev/null) returns EINVAL."""
HIGH	kitty_tests/__init__.py	236	ans.push(lb.line(i))
HIGH	kitty_tests/datatypes.py	705	hb.push(lb.line(1))
HIGH	kitty_tests/datatypes.py	706	hb.push(lb.line(2))
HIGH	kitty_tests/datatypes.py	713	hb.push(lb.line(2))
HIGH	kitty_tests/datatypes.py	722	hb.push(line)
HIGH	kitty_tests/multicell.py	382	# Erase characters (aka replace with null)
HIGH	kitty_tests/shell_integration.py	224	pty.send_cmd_to_child('mkdir test && ls -a')
HIGH	kitty_tests/shell_integration.py	227	self.ae(pty.callbacks.titlebuf[-2:], ['mkdir test && ls -a', '~'])
HIGH	kitty_tests/shell_integration.py	396	cmd = 'mkdir test && ls -a'

Unused Imports74 hits · 70 pts

Severity	File	Line
LOW	kittens/tui/handler.py	33
LOW	kittens/tui/utils.py	15
LOW	kittens/tui/images.py	17
LOW	kittens/choose_fonts/backend.py	34
LOW	docs/conf.py	31
LOW	kitty/window.py	139
LOW	kitty/window.py	141
LOW	kitty/render_cache.py	6
LOW	kitty/constants.py	14
LOW	kitty/session.py	22
LOW	kitty/session.py	27
LOW	kitty/file_transmission.py	17
LOW	kitty/file_transmission.py	23
LOW	kitty/keys.py	30
LOW	kitty/boss.py	155
LOW	kitty/boss.py	182
LOW	kitty/boss.py	183
LOW	kitty/types.py	10
LOW	kitty/remote_control.py	39
LOW	kitty/marks.py	7
LOW	kitty/cli.py	8
LOW	kitty/utils.py	13
LOW	kitty/utils.py	13
LOW	kitty/utils.py	51
LOW	kitty/utils.py	51
LOW	kitty/utils.py	54
LOW	kitty/utils.py	56
LOW	kitty/child.py	21
LOW	kitty/notifications.py	12
LOW	kitty/notifications.py	13
LOW	kitty/open_actions.py	11
LOW	kitty/options/parse.py	5
LOW	kitty/conf/types.py	11
LOW	kitty/rc/get_colors.py	13
LOW	kitty/rc/new_window.py	9
LOW	kitty/rc/run.py	26
LOW	kitty/rc/set_font_size.py	9
LOW	kitty/rc/detach_window.py	9
LOW	kitty/rc/send_key.py	20
LOW	kitty/rc/remove_marker.py	10
LOW	kitty/rc/get_text.py	10
LOW	kitty/rc/set_window_logo.py	28
LOW	kitty/rc/set_tab_color.py	12
LOW	kitty/rc/kitten.py	9
LOW	kitty/rc/last_used_layout.py	10
LOW	kitty/rc/close_tab.py	10
LOW	kitty/rc/scroll_window.py	10
LOW	kitty/rc/create_marker.py	11
LOW	kitty/rc/disable_ligatures.py	10
LOW	kitty/rc/resize_os_window.py	20
LOW	kitty/rc/goto_layout.py	10
LOW	kitty/rc/detach_tab.py	9
LOW	kitty/rc/resize_window.py	9
LOW	kitty/rc/focus_tab.py	10
LOW	kitty/rc/set_background_image.py	28
LOW	kitty/rc/ls.py	13
LOW	kitty/rc/set_user_vars.py	9
LOW	kitty/rc/action.py	21
LOW	kitty/rc/select_window.py	11
LOW	kitty/rc/select_window.py	12
14 more matches not shown…

AI Slop Vocabulary2 hits · 4 pts

Severity	File	Line	Snippet
LOW	kitty/utils.py	978	# platform.mac_ver does not work thanks to Apple's stupid "hardening", so just use sw_vers
MEDIUM	glfw/cocoa_init.m	1078	// avoid killing helpers from other processes. This is obviously not robust

Decorative Section Separators1 hit · 3 pts

Severity	File	Line	Snippet
MEDIUM	kittens/command_palette/main.go	238	// sectionHeader returns a separator line like " ── label ─────────".

Self-Referential Comments1 hit · 3 pts

Severity	File	Line	Snippet
MEDIUM	kitty_tests/dnd.py	3103	# Create a directory entry (X=2 means directory handle=2)

Redundant / Tautological Comments1 hit · 1 pts

Severity	File	Line	Snippet
LOW	kitty_tests/dnd.py	2205	# Read file from directory

Score History

Severity Breakdown

Pattern Findings