imputnet/helium

Pattern Findings

68 matches across 6 categories. Click a row to expand file-level details.

Hyper-Verbose Identifiers22 hits · 26 pts

Severity	File	Line	Snippet
LOW	utils/downloads.py	242	def _chromium_hashes_generator(hashes_path):
LOW	utils/patches.py	153	def generate_patches_from_series(patches_dir, resolve=False):
LOW	utils/make_domsub_script.py	17	def make_domain_substitution_script(regex_path, files_path, backup_type, output_path):
LOW	utils/name_substitution_utils.py	37	def strip_message_text_for_fp(text):
LOW	utils/name_substitution_utils.py	147	def dedup_translations_in_place(translation, seen):
LOW	utils/tests/test_patches.py	16	def test_find_and_check_patch():
LOW	devutils/validate_patches.py	146	def _download_googlesource_file(download_session, repo_url, version, relative_path):
LOW	devutils/validate_patches.py	225	def _get_last_chromium_modification():
LOW	devutils/validate_patches.py	234	def _get_gitiles_git_log_date(log_entry):
LOW	devutils/validate_patches.py	239	def _get_gitiles_commit_before_date(repo_url, target_branch, target_datetime):
LOW	devutils/validate_patches.py	318	def _get_target_file_deps_node(download_session, root_deps_tree, target_file):
LOW	devutils/_lint_tests.py	30	def a_all_patches_in_series_exist():
LOW	devutils/_lint_tests.py	36	def a_all_patches_in_tree_are_in_series():
LOW	devutils/_lint_tests.py	45	def b_all_patches_have_meaningful_contents():
LOW	devutils/_lint_tests.py	51	def b_all_patches_have_no_trailing_whitespace():
LOW	devutils/_lint_tests.py	61	def c_all_new_files_have_license_header():
LOW	devutils/_lint_tests.py	76	def c_all_new_headers_have_correct_guard():
LOW	devutils/_lint_tests.py	120	def d_no_whitespace_only_changes():
LOW	devutils/i18n_generate.py	61	def extract_strings_from_hunk(hunk):
LOW	devutils/tests/test_check_patch_files.py	24	def test_check_series_duplicates():
LOW	devutils/third_party/unidiff/patch.py	281	def _add_no_newline_marker_to_last_hunk(self):
LOW	devutils/third_party/unidiff/patch.py	289	def _append_trailing_empty_line(self):

Deep Nesting25 hits · 25 pts

Severity	File	Line
LOW	utils/filescfg.py	52
LOW	utils/prune_binaries.py	176
LOW	utils/generate_resources.py	32
LOW	utils/downloads.py	294
LOW	utils/downloads.py	333
LOW	utils/downloads.py	93
LOW	utils/domain_substitution.py	186
LOW	utils/clone.py	48
LOW	utils/_extraction.py	148
LOW	utils/third_party/schema.py	234
LOW	devutils/validate_patches.py	183
LOW	devutils/validate_patches.py	406
LOW	devutils/validate_patches.py	486
LOW	devutils/validate_patches.py	553
LOW	devutils/validate_patches.py	610
LOW	devutils/validate_patches.py	623
LOW	devutils/run_other_pylint.py	33
LOW	devutils/update_lists.py	259
LOW	devutils/update_lists.py	284
LOW	devutils/i18n_translate.py	152
LOW	devutils/check_patch_files.py	50
LOW	devutils/_lint_tests.py	76
LOW	devutils/_lint_tests.py	120
LOW	devutils/i18n_generate.py	61
LOW	devutils/third_party/unidiff/patch.py	217

Unused Imports12 hits · 12 pts

Severity	File	Line
LOW	devutils/third_party/unidiff/patch.py	27
LOW	devutils/third_party/unidiff/constants.py	27
LOW	devutils/third_party/unidiff/__init__.py	27
LOW	devutils/third_party/unidiff/__init__.py	30
LOW	devutils/third_party/unidiff/__init__.py	30
LOW	devutils/third_party/unidiff/__init__.py	30
LOW	devutils/third_party/unidiff/__init__.py	30
LOW	devutils/third_party/unidiff/__init__.py	30
LOW	devutils/third_party/unidiff/__init__.py	30
LOW	devutils/third_party/unidiff/__init__.py	30
LOW	devutils/third_party/unidiff/__init__.py	30
LOW	devutils/third_party/unidiff/errors.py	27

Over-Commented Block6 hits · 6 pts

Severity	File	Line	Snippet
LOW	devutils/pytest.ini	1	[pytest]
LOW	devutils/third_party/unidiff/patch.py	1	# -- coding: utf-8 --
LOW	devutils/third_party/unidiff/constants.py	1	# -- coding: utf-8 --
LOW	devutils/third_party/unidiff/__init__.py	1	# -- coding: utf-8 --
LOW	devutils/third_party/unidiff/__version__.py	1	# -- coding: utf-8 --
LOW	devutils/third_party/unidiff/errors.py	1	# -- coding: utf-8 --

Redundant / Tautological Comments2 hits · 3 pts

Severity	File	Line	Snippet
LOW	utils/downloads.py	316	# Read file in chunks. Default is 262144 bytes.
LOW	devutils/validate_patches.py	541	# Write file to patch

Excessive Try-Catch Wrapping1 hit · 1 pts

Severity	File	Line	Snippet
LOW	devutils/lint.py	40	except Exception:

Score History

Severity Breakdown

Pattern Findings