golang/go

Pattern Findings

7169 matches across 14 categories. Click a row to expand file-level details.

Over-Commented Block7014 hits · 6434 pts

Severity	File	Line	Snippet
LOW	test/fibo.go	1	// skip
LOW	test/import6.go	1	// errorcheck
LOW	test/rangegen.go	1	// runoutput
LOW	test/nilptr_aix.go	1	// run
LOW	test/import2.go	1	// compiledir
LOW	test/mergemul.go	1	// runoutput
LOW	test/mergemul.go	41	}
LOW	test/live_uintptrkeepalive.go	1	// errorcheck -0 -m -live -std
LOW	test/nilptr.go	1	// run
LOW	test/divmod.go	1	// run
LOW	test/live1.go	1	// compile
LOW	test/closure3.go	1	// errorcheckandrundir -0 -m -d=inlfuncswithclosures=1
LOW	test/runtime.go	1	// errorcheck
LOW	test/linkname3.go	21	// ERROR "//go:linkname must refer to declared function or variable"
LOW	test/cmplxdivide.c	1	// Copyright 2010 The Go Authors. All rights reserved.
LOW	test/escape_alias.go	1	// errorcheck -0 -d=escapealias=1
LOW	test/eof.go	1	// compile
LOW	test/nosplit.go	21	"strconv"
LOW	test/nosplit.go	41	# Within a stanza, ; can be used instead of \n to separate lines.
LOW	test/eof1.go	1	// compile
LOW	test/solitaire.go	1	// build
LOW	test/live.go	1	// errorcheckwithauto -0 -l -live -wb=0 -d=ssa/insert_resched_checks/off
LOW	test/method4.go	1	// rundir
LOW	test/inline_sync.go	1	// errorcheck -0 -m
LOW	test/map.go	321	panic(fmt.Sprintf("tuple existence assign: mit[%d]\n", i))
LOW	test/recover4.go	1	// run
LOW	test/recover.go	441	panic(112)
LOW	test/import4.go	1	// errorcheckdir
LOW	test/closure5.go	1	// compiledir
LOW	test/interface/private.go	1	// errorcheckdir
LOW	test/chan/select5.go	421	// it wants to choose between n possibilities.
LOW	test/chan/powser2.go	1	// run
LOW	test/chan/powser1.go	1	// run
LOW	test/chan/powser1.go	61	d2[0] = mkdch()
LOW	test/chan/powser1.go	561	// Exponential of a power series with constant term 0
LOW	test/typeparam/absdiff.go	41	// For now, a lone type parameter is not permitted as RHS in a type declaration (issue #45639).
LOW	test/typeparam/absdiff.go	61	// return complexAbs[T](complex(d, 0))
LOW	test/typeparam/absdiff.go	81	// if got, want := orderedAbsDifference(-1.0, 2.0), 3.0; got != want {
LOW	test/typeparam/issue47892.go	1	// rundir
LOW	test/typeparam/boundmethod.go	81	// stringify on a normal type, whose bound method is associated with the base type.
LOW	test/typeparam/issue47708.go	21	// type Bob[T any] T
LOW	test/typeparam/gencrawler.go	1	// rundir
LOW	test/typeparam/dedup.go	1	// rundir
LOW	test/typeparam/nested.go	1	// run
LOW	test/typeparam/nested.go	21	// From this data it tests two things:
LOW	test/typeparam/issue48094.dir/a.go	21	// a T
LOW	test/typeparam/absdiffimp.dir/a.go	41	// // ordered numeric types.
LOW	test/typeparam/absdiffimp.dir/a.go	61	//
LOW	test/typeparam/absdiffimp.dir/main.go	1	// Copyright 2021 The Go Authors. All rights reserved.
LOW	test/typeparam/absdiffimp.dir/main.go	21	// }
LOW	test/codegen/comparisons.go	221	c2 := a^b < 0
LOW	test/codegen/atomics.go	21	// arm64/v8.0:"LDADDALW"
LOW	test/codegen/atomics.go	41	// arm64/v8.0:".*arm64HasATOMICS"
LOW	test/codegen/atomics.go	61	}
LOW	test/codegen/atomics.go	81	// arm64/v8.1:"LDORALW"
LOW	test/codegen/mapaccess.go	21
LOW	test/codegen/mapaccess.go	41	// amd64:-".*mapaccess"
LOW	test/codegen/mapaccess.go	81	// 386:-".*mapaccess"
LOW	test/codegen/mapaccess.go	101	// arm:-".*mapaccess"
LOW	test/codegen/mapaccess.go	141	// amd64:-".*mapaccess"
6954 more matches not shown…

AI Slop Vocabulary61 hits · 176 pts

Severity	File	Line	Snippet
MEDIUM	test/codegen/comparisons.go	309	// CMN and CMP for subtraction expressions to make the pattern robust.
LOW	src/make.bash	61	# (Or just pass them to the make.bash command line.)
MEDIUM	src/cmd/go/alldocs.go	2285	// Consumers should be robust to this.
MEDIUM	src/cmd/go/internal/work/exec.go	2476	// Definitely want -fPIC but on Windows gcc complains
MEDIUM	src/cmd/trace/pprof.go	243	// Because slices aren't comparable and we want to leverage maps for deduplication,
MEDIUM	src/cmd/internal/obj/dwarf.go	98	// https://github.com/go-delve/delve/issues/1694), however the bug
LOW	src/cmd/internal/test2json/testdata/benchshort.json	5	{"Action":"output","Output":"# but to avoid questions of timing, we just use a file with no \\n at all.\n"}
MEDIUM	src/cmd/internal/src/pos.go	391	// Depending on the debugger (gdb or delve) it may or may not be displayed.
MEDIUM	src/cmd/internal/src/xpos.go	73	// gdb chooses not to display the bogus line; delve shows it with a complaint, but the
MEDIUM	src/cmd/compile/internal/noder/reader.go	2681	// TODO(mdempsky): Is there a more robust way to get the
MEDIUM	src/cmd/compile/internal/noder/reader.go	2974	// TODO(mdempsky): Is there a more robust way to get the
MEDIUM	src/cmd/compile/internal/noder/reader.go	3073	// TODO(mark): It's not ideal to rely on string naming here. Find a more robust solution.
MEDIUM	src/cmd/compile/internal/noder/reader.go	4256	// https://github.com/go-delve/delve/blob/cb91509630529e6055be845688fd21eb89ae8714/pkg/proc/eval.go#L28
MEDIUM	src/cmd/compile/internal/types2/context_test.go	21	// make them robust to internal type assertions, but could equally well use
MEDIUM	src/cmd/compile/internal/types2/context.go	31	// Nevertheless, in the future it could be helpful to allow users to leverage
MEDIUM	src/cmd/compile/internal/ssa/debug.go	1884	// #yield is used by delve.
MEDIUM	src/cmd/compile/internal/ssa/debug.go	1884	// #yield is used by delve.
MEDIUM	src/cmd/compile/internal/ssa/known_bits.go	294	// We also leverage known bits of the shift amount to remove "branches" in the switch that are proved to be impossible.
MEDIUM	src/cmd/compile/internal/ssa/dom.go	22	// This seems to make loop-finding more robust.
MEDIUM	src/cmd/compile/internal/ssa/debug_test.go	50	// TestNexting go-builds a file, then uses a debugger (default delve, optionally gdb)
MEDIUM	src/cmd/compile/internal/ssa/testdata/scopes.go	33	for x := 0; x <= 1; x++ { // From delve scopetest.go
MEDIUM	src/cmd/compile/internal/ssa/testdata/scopes.go	51	{ // From delve testnextprog.go
MEDIUM	src/cmd/cgo/out.go	1089	// string.h for memset, and is also robust to C++
MEDIUM	src/cmd/cgo/gcc.go	469	// but usually it does. Certainly if we don't see the completed:1 error, we did
MEDIUM	src/cmd/covdata/tool_test.go	29	// TestMain used here so that we can leverage the test executable
MEDIUM	src/cmd/cover/cover_test.go	48	// TestMain used here so that we can leverage the test executable
MEDIUM	src/net/dnsclient_unix_test.go	1356	// Return NXDOMAIN to utilize the search list.
MEDIUM	src/net/http/serve_test.go	894	// TODO(panjf2000): sleep is not so robust, maybe find a better way to test this?
MEDIUM	src/go/token/position.go	548	// The iterator is robust to modification by yield.
MEDIUM	src/go/types/context_test.go	24	// make them robust to internal type assertions, but could equally well use
MEDIUM	src/go/types/context.go	34	// Nevertheless, in the future it could be helpful to allow users to leverage
MEDIUM	src/go/printer/testdata/parser.go	579	// it here for more robust parsing and better error messages
MEDIUM	src/go/printer/testdata/parser.go	637	// accept them all for more robust parsing and complain
MEDIUM	src/go/internal/gcimporter/gcimporter_test.go	173	// the files we consider in an attempt to make this test more robust to
MEDIUM	src/go/parser/parser.go	748	// it here for more robust parsing and better error messages
MEDIUM	src/runtime/proc.go	38	// We need to balance between keeping enough running worker threads to utilize
MEDIUM	src/runtime/metrics.go	1027	// Broken out for more robust testing. metricsLock must be held and
MEDIUM	src/runtime/proc_test.go	490	// fairly large factor here to make this robust: if the
MEDIUM	src/runtime/mpagealloc_test.go	622	// Test to check for issue #40191. Essentially, the candidate searchAddr
MEDIUM	src/runtime/mpagealloc_test.go	622	// Test to check for issue #40191. Essentially, the candidate searchAddr
MEDIUM	src/runtime/mgcpacer_test.go	404	// Provide a lot of room for the limit. Essentially, this should behave just like
MEDIUM	src/runtime/export_test.go	1677	// a bit more robust.
MEDIUM	src/runtime/mpagealloc.go	165	// This is slightly more nuanced than just a shift for the exclusive
MEDIUM	src/runtime/symtabinl_test.go	48	// this robust.
MEDIUM	src/runtime/complex.go	20	// Algorithm for robust complex division as described in
MEDIUM	src/runtime/mprof.go	965	// Absolutely no data, suggesting that a garbage collection
MEDIUM	src/runtime/mgcscavenge.go	28	// Essentially, we wish to have the application's RSS track the heap goal, but
MEDIUM	src/runtime/pprof/label.go	96	// Currently only the CPU and goroutine profiles utilize any labels
MEDIUM	src/internal/trace/gc.go	131	// It will show up very early in the trace, but we need to be robust to
MEDIUM	src/internal/trace/event.go	839	// may be tracked in the future, and callers must be robust to this
MEDIUM	src/internal/trace/resources.go	35	// New GoStates may be added in the future. Users of this type must be robust
MEDIUM	src/internal/trace/resources.go	77	// New ProcStates may be added in the future. Users of this type must be robust
MEDIUM	src/internal/trace/resources.go	113	// New ResourceKinds may be added in the future. Users of this type must be robust
MEDIUM	src/internal/trace/value.go	32	// New ValueKinds may be added in the future. Users of this type must be robust
MEDIUM	src/internal/runtime/gc/scan/mkasm.go	128	// shuffle those bytes together. Certainly for f >= 16 this makes sense
MEDIUM	src/simd/archsimd/_gen/unify/closure.go	119	// Essentially the same as Def.
LOW	…d/archsimd/_gen/simdgen/ops/BitwiseLogic/go_amd64.yaml	28	# for unmasked operations, right now we don't realize that we can just use the
MEDIUM	src/time/time.go	32	// time.Now().Before(deadline), are similarly robust against wall clock
MEDIUM	src/testing/testing.go	117	// statistically robust A/B comparisons.
MEDIUM	src/testing/testing.go	147	// New benchmarks should prefer using [B.Loop], which is more robust
1 more matches not shown…

Synthetic Comment Markers9 hits · 68 pts

Severity	File	Line	Snippet
HIGH	src/cmd/asm/internal/asm/parse.go	1721	// at reports whether the next tokens are as requested.
HIGH	src/cmd/go/internal/modload/load.go	1229	// add them as requested.
HIGH	src/cmd/go/internal/modload/load.go	1823	// add them as requested.
HIGH	src/cmd/internal/obj/util.go	745	// AlignmentPadding bytes to add to align code as requested.
HIGH	src/cmd/internal/obj/util.go	760	// AlignmentPaddingLength is the number of bytes to add to align code as requested.
HIGH	src/cmd/internal/obj/ppc64/asm9.go	590	// padding bytes to add to align code as requested.
HIGH	src/cmd/compile/internal/ssa/debug_test.go	711	// Normalize value as requested.
HIGH	src/crypto/internal/sysrand/rand_netbsd.go	13	// as many as requested up to 256, derived from the system entropy pool;
HIGH	src/fmt/print.go	405	// not, as requested, by temporarily setting the sharp flag.

Decorative Section Separators15 hits · 51 pts

Severity	File	Line	Snippet
MEDIUM	src/cmd/go/testdata/script/cover_build_pkg_select.txt	6	#-------------------------------------------
MEDIUM	src/cmd/go/testdata/script/cover_build_pkg_select.txt	37	#-------------------------------------------
MEDIUM	src/cmd/go/testdata/script/cover_build_pkg_select.txt	79	#-------------------------------------------
MEDIUM	…go/testdata/script/cgo_suspect_flag_force_external.txt	29	#-----------------------
MEDIUM	src/cmd/compile/internal/ssa/looprotate.go	68	// │ │ └─►It─┘ │ │ │ └─────┘ │
MEDIUM	src/cmd/compile/internal/ssa/looprotate.go	71	// │ └─►Ot───┘ │ └───────┘
MEDIUM	src/crypto/cipher/gcm.go	142	// ┌───────────────────────────┬ ─ ─
MEDIUM	src/crypto/cipher/gcm.go	144	// └▽─────────────────────────▲┴ ─ ─
MEDIUM	src/crypto/cipher/gcm.go	147	// ┌───▼─────────────────────────△──┐
MEDIUM	src/crypto/cipher/gcm.go	149	// └────────────────────────────────┘
MEDIUM	src/runtime/mprof.go	107	// ┠┅┅┅┅┅┅┅┅┅┅┅P
MEDIUM	src/runtime/mprof.go	111	// ┠┅┅┅┅┅┅┅┅┅┅┅P
MEDIUM	src/encoding/json/jsontext/token.go	65	// ╔══════════════════╦════════════╤════════════╤════════════╗
MEDIUM	src/encoding/json/jsontext/token.go	67	// ╠══════════════════╬════════════╪════════════╪════════════╣
MEDIUM	src/encoding/json/jsontext/token.go	80	// ╚══════════════════╩════════════╧════════════╧════════════╝

Fake / Example Data28 hits · 32 pts

Severity	File	Line	Snippet
LOW	src/compress/flate/deflate_test.go	466	dict = "hello world Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labor
LOW	src/compress/flate/deflate_test.go	466	dict = "hello world Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labor
LOW	src/compress/flate/deflate_test.go	467	text = "hello world again Lorem ipsum dolor sit amet"
LOW	src/compress/flate/deflate_test.go	467	text = "hello world again Lorem ipsum dolor sit amet"
LOW	src/compress/flate/inflate_test.go	17	"lorem ipsum izzle fo rizzle",
LOW	src/compress/flate/inflate_test.go	73	"lorem ipsum izzle fo rizzle",
LOW	src/compress/gzip/fuzz_test.go	18	inp := []byte("Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et d
LOW	src/compress/gzip/fuzz_test.go	18	inp := []byte("Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et d
LOW	src/compress/lzw/writer_test.go	118	data = []byte(`lorem ipsum dolor sit amet`)
LOW	src/compress/lzw/writer_test.go	118	data = []byte(`lorem ipsum dolor sit amet`)
LOW	src/compress/zlib/writer_test.go	210	var input = []byte("Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labor
LOW	src/compress/zlib/writer_test.go	210	var input = []byte("Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labor
LOW	src/net/mail/message_test.go	381	7: {"John Doe", "no angle-addr"},
LOW	src/net/mail/message_test.go	436	Name: "John Doe",
LOW	src/net/mail/message_test.go	452	Name: "John Doe",
LOW	src/net/mail/message_test.go	740	Name: "John Doe",
LOW	src/net/mail/message_test.go	750	Name: "John Doe",
LOW	src/net/mail/message_test.go	760	Name: "John Doe",
LOW	src/net/mail/message_test.go	825	Name: "John Doe",
LOW	src/net/mail/message_test.go	869	Name: "John Doe",
LOW	src/net/mail/message_test.go	989	Name: "John Doe",
LOW	src/net/smtp/example_test.go	60	auth := smtp.PlainAuth("", "user@example.com", "password", hostname)
LOW	src/net/smtp/example_test.go	70	auth := smtp.PlainAuth("", "user@example.com", "password", "mail.example.com")
LOW	src/archive/tar/fuzz_test.go	16	inp := []byte("Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et d
LOW	src/archive/tar/fuzz_test.go	16	inp := []byte("Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et d
LOW	src/encoding/xml/atom_test.go	14	Author: Person{Name: "John Doe"},
LOW	src/encoding/xml/marshal_test.go	534	contentsAttr = "lorem ipsum"
LOW	src/encoding/xml/marshal_test.go	1059	ExpectXML: `<dummy name="Sarah" age="12">lorem ipsum</dummy>`,

Slop Phrases12 hits · 25 pts

Severity	File	Line	Snippet
MEDIUM	src/cmd/internal/obj/dwarf.go	30	// It's worth noting that this function doesn't generate the full debug_lines
LOW	src/cmd/compile/internal/ir/func.go	55	// if you add or remove a field, don't forget to update sizeof_test.go
LOW	src/cmd/compile/internal/base/debug.go	15	// Don't forget to note that concurrency is "ok" when it is,
LOW	src/bufio/example_test.go	20	w.Flush() // Don't forget to flush!
LOW	src/net/http/example_test.go	30	// Don't forget to close the connection:
LOW	src/net/http/internal/httpcommon/httpcommon.go	554	// but this ensures we don't forget to include a CountError reason.
MEDIUM	src/net/rpc/server.go	58	Here is a simple example. A server wishes to export an object of type Arith:
MEDIUM	src/runtime/arena.go	744	// assist the GC proportionally (and it's worth noting that the arena
MEDIUM	src/runtime/metrics/doc.go	39	As mentioned earlier, metric keys are strings. Their format is simple and well-defined,
MEDIUM	src/internal/syscall/windows/registry/key.go	9	// Here is a simple example, opening a registry key and reading a string value from it.
MEDIUM	src/os/file.go	16	// Here is a simple example, opening a file and reading some of it.
MEDIUM	src/text/template/doc.go	463	constant. Here is a simple example:

Hallucination Indicators2 hits · 20 pts

Severity	File	Line	Snippet
CRITICAL	…c/cmd/compile/internal/test/testdata/addressed_test.go	129	if which != v3.p.p.p.p.p.p.p.val() {
CRITICAL	…c/cmd/compile/internal/test/testdata/addressed_test.go	130	output += fmt.Sprintln("Expected which=", which, "got v3.p.p.p.p.p.p.p.val()=", v3.p.p.p.p.p.p.p.val())

Verbosity Indicators8 hits · 16 pts

Severity	File	Line	Snippet
LOW	src/cmd/compile/internal/ssa/shortcircuit.go	12	// Step 1: Replace a phi arg with a constant if that arg
LOW	src/cmd/compile/internal/ssa/shortcircuit.go	53	// Step 2: Redirect control flow around known branches.
LOW	src/net/http/server.go	1156	// The purpose of this function is to provide more helpful error messages.
LOW	src/runtime/secret/secret.go	74	// Step 1: increment the nesting count.
LOW	src/runtime/secret/secret.go	77	// Step 2: call helper. The helper just calls f
LOW	src/runtime/secret/secret.go	81	// Step 3: erase everything used by f (stack, registers).
LOW	src/runtime/secret/secret.go	84	// Step 4: decrement the nesting count.
LOW	src/runtime/secret/secret.go	87	// Step 5: re-raise any caught panic.

Example Usage Blocks6 hits · 9 pts

Severity	File	Line	Snippet
LOW	lib/hg/goreposum.py	24	# Usage:
LOW	src/database/sql/sql.go	105	// Example usage:
LOW	src/database/sql/sql.go	478	// Example usage:
LOW	src/database/sql/sql.go	2877	// Example usage:
LOW	src/encoding/json/v2/options.go	86	// Example usage:
LOW	src/encoding/json/jsontext/encode.go	905	// Example usage:

Excessive Try-Catch Wrapping7 hits · 9 pts

Severity	File	Line	Snippet
LOW	src/runtime/runtime-gdb.py	36	except Exception:
LOW	src/runtime/runtime-gdb.py	322	except Exception:
LOW	src/runtime/runtime-gdb.py	445	except Exception:
LOW	src/runtime/runtime-gdb.py	454	except Exception:
LOW	src/runtime/runtime-gdb.py	673	except Exception as e:
MEDIUM	src/runtime/runtime-gdb.py	33	def read_runtime_const(varname, default):
MEDIUM	src/runtime/runtime-gdb.py	316	def matcher(val):

Self-Referential Comments1 hit · 3 pts

Severity	File	Line	Snippet
MEDIUM	src/simd/archsimd/_gen/simdgen/types.yaml	1	# This file defines the possible types of each operand and result.

Redundant / Tautological Comments2 hits · 3 pts

Severity	File	Line	Snippet
LOW	src/syscall/mksyscall_libc.pl	166	# Check if err return available
LOW	src/syscall/mksyscall.pl	155	# Check if err return available

Unused Imports2 hits · 2 pts

Severity	File	Line	Snippet
LOW	lib/hg/goreposum.py	28
LOW	src/runtime/runtime-gdb.py	18

Deep Nesting2 hits · 2 pts

Severity	File	Line	Snippet
LOW	src/runtime/runtime-gdb.py	166
LOW	src/runtime/runtime-gdb.py	478

Score History

Severity Breakdown

Pattern Findings