fortra/impacket

Pattern Findings

1958 matches across 14 categories. Click a row to expand file-level details.

Excessive Try-Catch Wrapping556 hits · 582 pts

Severity	File	Line	Snippet
LOW	setup.py	41	except Exception:
LOW	impacket/IP6_Address.py	249	except Exception:
MEDIUM	impacket/IP6_Address.py	244	def is_a_valid_text_representation(cls, text_representation):
LOW	impacket/ntlm.py	54	except Exception:
MEDIUM	impacket/tds.py	1282	def disconnect(self):
LOW	impacket/tds.py	1110	except Exception as e:
LOW	impacket/tds.py	1274	except Exception:
LOW	impacket/tds.py	1553	except Exception as e:
LOW	impacket/tds.py	1563	except Exception:
LOW	impacket/tds.py	1663	except Exception as e:
LOW	impacket/smb.py	3091	except Exception:
MEDIUM	impacket/smbserver.py	2896	def _kerberos_auth(token, connData, smbServer):
LOW	impacket/smbserver.py	1515	except Exception as e:
LOW	impacket/smbserver.py	1526	except Exception as e:
LOW	impacket/smbserver.py	3529	except Exception as e:
LOW	impacket/smbserver.py	3543	except Exception as e:
LOW	impacket/smbserver.py	178	except Exception as e:
LOW	impacket/smbserver.py	321	except Exception as e:
LOW	impacket/smbserver.py	642	except Exception as e:
LOW	impacket/smbserver.py	918	except Exception as e:
LOW	impacket/smbserver.py	1112	except Exception as e:
LOW	impacket/smbserver.py	1250	except Exception as e:
LOW	impacket/smbserver.py	1387	except Exception as e:
LOW	impacket/smbserver.py	1574	except Exception as e:
LOW	impacket/smbserver.py	1609	except Exception as e:
LOW	impacket/smbserver.py	1657	except Exception as e:
LOW	impacket/smbserver.py	1855	except Exception as e:
LOW	impacket/smbserver.py	1901	except Exception as e:
LOW	impacket/smbserver.py	1954	except Exception as e:
LOW	impacket/smbserver.py	2141	except Exception as e:
LOW	impacket/smbserver.py	2241	except Exception as e:
LOW	impacket/smbserver.py	2271	except Exception as e:
LOW	impacket/smbserver.py	2681	except Exception as e:
LOW	impacket/smbserver.py	2804	except Exception as e:
LOW	impacket/smbserver.py	3174	except Exception as e:
LOW	impacket/smbserver.py	3405	except Exception as e:
LOW	impacket/smbserver.py	3435	except Exception as e:
LOW	impacket/smbserver.py	3702	except Exception as e:
LOW	impacket/smbserver.py	3773	except Exception as e:
LOW	impacket/smbserver.py	3824	except Exception as e:
LOW	impacket/smbserver.py	3852	except Exception as e:
LOW	impacket/smbserver.py	4126	except Exception as e:
LOW	impacket/smbserver.py	4199	except Exception as e:
LOW	impacket/smbserver.py	4736	except Exception as e:
LOW	impacket/smbserver.py	4799	except Exception as e:
LOW	impacket/mqtt.py	279	except Exception:
LOW	impacket/mqtt.py	356	except Exception as e:
LOW	impacket/ese.py	952	except Exception:
LOW	impacket/acl.py	382	except Exception as e:
LOW	impacket/crypto.py	30	except Exception:
LOW	impacket/structure.py	144	except Exception as e:
LOW	impacket/structure.py	170	except Exception as e:
LOW	impacket/structure.py	491	except Exception:
LOW	impacket/winregistry.py	233	except Exception as e:
LOW	impacket/winregistry.py	805	except Exception:
LOW	impacket/nmb.py	554	except Exception as e:
LOW	impacket/nmb.py	990	except Exception as ex:
MEDIUM	impacket/dpapi.py	474	print('Error decrypting entry #%d' % i)
LOW	impacket/dcerpc/v5/drsuapi.py	50	except Exception:
LOW	impacket/dcerpc/v5/dcomrt.py	1066	except Exception as e:
496 more matches not shown…

Over-Commented Block437 hits · 429 pts

Severity	File	Line	Snippet
LOW	setup.py	1	#!/usr/bin/env python
LOW	impacket/ICMP6.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/eap.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/hresult_errors.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/dns.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/dns.py	21	# - 2181 - Clarifications to the DNS Specification [https://www.ietf.org/rfc/rfc2181.txt]
LOW	impacket/dns.py	421	# Preference Unsigned 16-bit integer.
LOW	impacket/smb3.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/smb3.py	21	#
LOW	impacket/smb3.py	901	self._Connection['SupportsEncryption'] = False
LOW	impacket/smb3.py	1601	return True
LOW	impacket/IP6_Address.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/ntlm.py	61	NTLM_AUTH_PKT = 4
LOW	impacket/ntlm.py	101	# If set, requests the usage of the LMOWF (section 3.3). An alternate name for this field is
LOW	impacket/ntlm.py	121	# TargetName field of the CHALLENGE_MESSAGE. If this bit is set, then NTLMSSP_TARGET_TYPE_DOMAIN MUST NOT be set.
LOW	impacket/ntlm.py	161	NTLMSSP_RESERVED_8 = 0x00000100
LOW	impacket/ntlm.py	701	if ntlmChallenge['flags'] & NTLMSSP_NEGOTIATE_KEY_EXCH:
LOW	impacket/NDP.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/tds.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/tds.py	21	# ToDo:
LOW	impacket/tds.py	1461	# Here comes the important part, MSSQL server does not expect a raw TLS socket
LOW	impacket/smb.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/smb.py	21	#
LOW	impacket/smb.py	41	# [ ] Try [SMB]transport fragmentation using Transact requests
LOW	impacket/smb.py	2881	if paramcnt + paramds < totparamcnt or datacnt + datads < totdatacnt:
LOW	impacket/smb.py	2901	# CALL MD5Init( md5context )
LOW	impacket/smbserver.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/smbserver.py	4441	del (self.__smbTransCommands[transCommand])
LOW	impacket/smbserver.py	4461	# data : the transaction data
LOW	impacket/smbserver.py	4521	# If smbCommand doesn't not exist, it is added
LOW	impacket/smbserver.py	4541	# errorCode: the NT error code
LOW	impacket/smbserver.py	4621
LOW	impacket/smbserver.py	4681	# We might have compound requests
LOW	impacket/smbserver.py	4801	# traceback.print_exc()
LOW	impacket/system_errors.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/ImpactDecoder.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/__init__.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/cdp.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/Dot11Crypto.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/mqtt.py	1	#!/usr/bin/env python
LOW	impacket/ese.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/ese.py	801	return self.getNextRow(cursor, filter_tables = filter_tables)
LOW	impacket/Dot11KeyManager.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/dot11.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/dot11.py	41	# +---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+
LOW	impacket/dot11.py	1921	def get_dB_ant_noise( self ):
LOW	impacket/spnego.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/spnego.py	161	# reject (2),
LOW	impacket/acl.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/crypto.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/crypto.py	41	# + Algorithm Generate_Subkey +
LOW	impacket/crypto.py	101
LOW	impacket/crypto.py	121	# + +
LOW	impacket/crypto.py	181	def AES_CMAC_PRF_128(VK, M, VKlen, Mlen):
LOW	impacket/http.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/wps.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/helper.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/msada_guids.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/ImpactPacket.py	1	# Impacket - Collection of Python classes for working with network protocols.
LOW	impacket/winregistry.py	1	# Impacket - Collection of Python classes for working with network protocols.
377 more matches not shown…

Unused Imports347 hits · 341 pts

Severity	File	Line
LOW	setup.py	20
LOW	impacket/smb3.py	33
LOW	impacket/smb3.py	34
LOW	impacket/smb3.py	48
LOW	impacket/dpapi_ng.py	12
LOW	impacket/ntlm.py	12
LOW	impacket/ntlm.py	13
LOW	impacket/tds.py	33
LOW	impacket/tds.py	34
LOW	impacket/tds.py	47
LOW	impacket/smb.py	52
LOW	impacket/smb.py	53
LOW	impacket/mqtt.py	27
LOW	impacket/ese.py	29
LOW	impacket/ese.py	30
LOW	impacket/spnego.py	18
LOW	impacket/spnego.py	19
LOW	impacket/crypto.py	25
LOW	impacket/crypto.py	26
LOW	impacket/http.py	30
LOW	impacket/structure.py	12
LOW	impacket/structure.py	13
LOW	impacket/ImpactPacket.py	21
LOW	impacket/ImpactPacket.py	22
LOW	impacket/winregistry.py	25
LOW	impacket/winregistry.py	26
LOW	impacket/nmb.py	37
LOW	impacket/nmb.py	38
LOW	impacket/nmb.py	39
LOW	impacket/smbconnection.py	31
LOW	impacket/smb3structs.py	18
LOW	impacket/smb3structs.py	19
LOW	impacket/dpapi.py	27
LOW	impacket/dpapi.py	28
LOW	impacket/uuid.py	19
LOW	impacket/uuid.py	20
LOW	impacket/dcerpc/v5/srvs.py	26
LOW	impacket/dcerpc/v5/srvs.py	27
LOW	impacket/dcerpc/v5/drsuapi.py	27
LOW	impacket/dcerpc/v5/drsuapi.py	28
LOW	impacket/dcerpc/v5/dcomrt.py	33
LOW	impacket/dcerpc/v5/dcomrt.py	34
LOW	impacket/dcerpc/v5/bkrp.py	30
LOW	impacket/dcerpc/v5/bkrp.py	31
LOW	impacket/dcerpc/v5/even.py	27
LOW	impacket/dcerpc/v5/even.py	28
LOW	impacket/dcerpc/v5/transport.py	17
LOW	impacket/dcerpc/v5/transport.py	18
LOW	impacket/dcerpc/v5/transport.py	32
LOW	impacket/dcerpc/v5/dhcpm.py	27
LOW	impacket/dcerpc/v5/dhcpm.py	28
LOW	impacket/dcerpc/v5/tsts.py	29
LOW	impacket/dcerpc/v5/tsts.py	34
LOW	impacket/dcerpc/v5/tsts.py	36
LOW	impacket/dcerpc/v5/lsad.py	26
LOW	impacket/dcerpc/v5/lsad.py	27
LOW	impacket/dcerpc/v5/dtypes.py	18
LOW	impacket/dcerpc/v5/dtypes.py	19
LOW	impacket/dcerpc/v5/rpch.py	19
LOW	impacket/dcerpc/v5/rpch.py	20
287 more matches not shown…

Deep Nesting329 hits · 288 pts

Severity	File	Line
LOW	impacket/dns.py	372
LOW	impacket/smb3.py	412
LOW	impacket/smb3.py	953
LOW	impacket/smb3.py	1784
LOW	impacket/IP6_Address.py	129
LOW	impacket/IP6_Address.py	203
LOW	impacket/ntlm.py	907
LOW	impacket/tds.py	849
LOW	impacket/tds.py	1581
LOW	impacket/tds.py	1988
LOW	impacket/tds.py	2059
LOW	impacket/tds.py	2119
LOW	impacket/tds.py	2440
LOW	impacket/tds.py	2559
LOW	impacket/smb.py	325
LOW	impacket/smb.py	1038
LOW	impacket/smb.py	2948
LOW	impacket/smb.py	3612
LOW	impacket/smb.py	3982
LOW	impacket/smb.py	4083
LOW	impacket/smb.py	4240
LOW	impacket/smbserver.py	329
LOW	impacket/smbserver.py	383
LOW	impacket/smbserver.py	520
LOW	impacket/smbserver.py	664
LOW	impacket/smbserver.py	763
LOW	impacket/smbserver.py	816
LOW	impacket/smbserver.py	945
LOW	impacket/smbserver.py	993
LOW	impacket/smbserver.py	1060
LOW	impacket/smbserver.py	1204
LOW	impacket/smbserver.py	1342
LOW	impacket/smbserver.py	1495
LOW	impacket/smbserver.py	1546
LOW	impacket/smbserver.py	1628
LOW	impacket/smbserver.py	1674
LOW	impacket/smbserver.py	1721
LOW	impacket/smbserver.py	1769
LOW	impacket/smbserver.py	1816
LOW	impacket/smbserver.py	1874
LOW	impacket/smbserver.py	1920
LOW	impacket/smbserver.py	2110
LOW	impacket/smbserver.py	2158
LOW	impacket/smbserver.py	2339
LOW	impacket/smbserver.py	2476
LOW	impacket/smbserver.py	2984
LOW	impacket/smbserver.py	3199
LOW	impacket/smbserver.py	3333
LOW	impacket/smbserver.py	3497
LOW	impacket/smbserver.py	3567
LOW	impacket/smbserver.py	3628
LOW	impacket/smbserver.py	3736
LOW	impacket/smbserver.py	3785
LOW	impacket/smbserver.py	4164
LOW	impacket/smbserver.py	4664
LOW	impacket/ImpactDecoder.py	73
LOW	impacket/ImpactDecoder.py	130
LOW	impacket/ImpactDecoder.py	163
LOW	impacket/ImpactDecoder.py	435
LOW	impacket/ImpactDecoder.py	525
269 more matches not shown…

Hyper-Verbose Identifiers161 hits · 169 pts

Severity	File	Line	Snippet
LOW	impacket/ICMP6.py	151	def __get_message_description(self):
LOW	impacket/ICMP6.py	339	def get_neighbor_advertisement_flags(self):
LOW	impacket/ICMP6.py	342	def set_neighbor_advertisement_flags(self, flags):
LOW	impacket/ICMP6.py	388	def __build_node_information_message(class_object, type, code, payload = None):
LOW	impacket/ICMP6.py	505	def set_node_information_data(self, data):
LOW	impacket/ICMP6.py	510	def get_note_information_data(self):
LOW	impacket/ICMP6.py	529	def get_originating_packet_data(self):
LOW	impacket/dns.py	372	def __process_answer_structure(self, offset, num):
LOW	impacket/smb3.py	2096	def perform_hostname_validation(self):
LOW	impacket/IP6_Address.py	129	def get_human_readable_address_type(self):
LOW	impacket/IP6_Address.py	148	def __is_address_in_compressed_form(self, address):
LOW	impacket/IP6_Address.py	163	def __count_compressed_groups(self, address):
LOW	impacket/IP6_Address.py	168	def __count_compression_marker(self, address):
LOW	impacket/IP6_Address.py	185	def __expand_compressed_address(self, address):
LOW	impacket/IP6_Address.py	203	def __trim_longest_zero_chain(self, address):
LOW	impacket/IP6_Address.py	244	def is_a_valid_text_representation(cls, text_representation):
LOW	impacket/dpapi_ng.py	281	def generate_kek_secret_from_pubkey(gke: GroupKeyEnvelope, key_id: KeyIdentifier,l2_key: bytes):
LOW	impacket/tds.py	1235	def _has_active_tls_channel_binding(self):
LOW	impacket/tds.py	1434	def generate_cbt_from_tls_unique(self):
LOW	impacket/smb.py	3397	def get_server_dns_domain_name(self):
LOW	impacket/smb.py	3434	def perform_hostname_validation(self):
LOW	impacket/Dot11KeyManager.py	22	def __get_bssid_hasheable_type(self, bssid):
LOW	impacket/dot11.py	2219	def __calculate_elements_length(self, elements):
LOW	impacket/dot11.py	2658	def get_authentication_algorithm(self):
LOW	impacket/dot11.py	2662	def set_authentication_algorithm(self, algorithm):
LOW	impacket/dot11.py	2666	def get_authentication_sequence(self):
LOW	impacket/dot11.py	2670	def set_authentication_sequence(self, seq):
LOW	impacket/dot11.py	2674	def get_authentication_status(self):
LOW	impacket/dot11.py	2678	def set_authentication_status(self, status):
LOW	impacket/acl.py	166	def get_readable_standard_rights(self):
LOW	impacket/acl.py	184	def get_readable_specific_rights(self):
LOW	impacket/IP6_Extension_Headers.py	125	def get_header_extension_length(self):
LOW	impacket/IP6_Extension_Headers.py	131	def set_header_extension_length(self, header_extension_length):
LOW	impacket/nmb.py	609	def name_registration_request(self, nbname, destaddr, qtype, scope, nb_flags=0, nb_address='0.0.0.0'):
LOW	impacket/dcerpc/v5/rpcrt.py	1373	def set_default_max_fragment_size(self):
LOW	impacket/dcerpc/v5/transport.py	255	def set_default_max_fragment_size(self):
LOW	impacket/dcerpc/v5/rpch.py	783	def handle_out_of_sequence_rts(self, response_data):
LOW	impacket/krb5/pac.py	340	def _normalize_pac_checksum_type(signature_type, signature_length, aes_key, infer_aes_signature_type):
LOW	impacket/krb5/crypto.py	731	def get_kerberos_key_for_enctype(enctype, nt_hash=None, generic_aes_key=None, aes128_key=None, aes256_key=None):
LOW	impacket/krb5/asn1.py	74	def _sequence_optional_component(name, tag_value, type, **subkwargs):
LOW	impacket/examples/secretsdump.py	1556	def __decrypt_history_entries_aes(self, rid_int, entries):
LOW	impacket/examples/secretsdump.py	1594	def __decode_aes_history_block(self, rid_int, data, offset, length):
LOW	impacket/examples/ldap_shell.py	384	def toggle_account_enable_disable(self, user_name, enable):
LOW	impacket/examples/__init__.py	13	def _insecure_create_default_context(purpose=ssl.Purpose.SERVER_AUTH, *, cafile=None, capath=None, cadata=None):
LOW	impacket/examples/__init__.py	21	def monkeypatch_ssl_create_default_context():
LOW	impacket/examples/__init__.py	35	def monkeypatch_readline_backend():
LOW	impacket/examples/regsecrets.py	423	def __decrypt_history_entries_aes(self, rid_int, entries):
LOW	impacket/examples/regsecrets.py	461	def __decode_aes_history_block(self, rid_int, data, offset, length):
LOW	impacket/examples/ntlmrelayx/clients/ldaprelayclient.py	178	def create_authenticate_message(self):
LOW	impacket/examples/ntlmrelayx/utils/rdp_ssl.py	52	def generate_self_signed_cert(common_name="RDP-Server"):
LOW	impacket/examples/ntlmrelayx/servers/rdprelayserver.py	372	def build_tsrequest_challenge(self, challenge_data):
LOW	impacket/examples/ntlmrelayx/servers/socksserver.py	284	class SocksRequestHandler(socketserver.BaseRequestHandler):
LOW	…cket/examples/ntlmrelayx/servers/socksplugins/mssql.py	98	def _should_wrap_sql_batch_for_backend(self):
LOW	impacket/examples/ntlmrelayx/attacks/ldapattack.py	650	def is_template_for_authentification(entry):
LOW	impacket/examples/ntlmrelayx/attacks/ldapattack.py	667	def get_enrollment_principals(entry):
LOW	…/examples/ntlmrelayx/attacks/httpattacks/adcsattack.py	230	def _extract_certificate_identity(cls, cert):
LOW	…s/ntlmrelayx/attacks/httpattacks/sccmpoliciesattack.py	147	def generate_registration_request_payload(management_point, public_key, private_key, client_name):
LOW	…s/ntlmrelayx/attacks/httpattacks/sccmpoliciesattack.py	178	def generate_policies_request_payload(management_point, private_key, client_guid, client_name):
LOW	…s/ntlmrelayx/attacks/httpattacks/sccmpoliciesattack.py	287	def deobfuscate_secret_policy_blob(output):
LOW	…xamples/ntlmrelayx/attacks/httpattacks/sccmdpattack.py	184	def recursive_package_directory_fetch(self, object, directory, depth):
101 more matches not shown…

Self-Referential Comments35 hits · 104 pts

Severity	File	Line	Snippet
MEDIUM	impacket/tds.py	1298	# This function is the generic sendTDS packet which is used to embed data into a regular TDS packet
MEDIUM	impacket/tds.py	1327	# This function is a wrapper that is used to dispatch packets to send depending of the TLS context
MEDIUM	impacket/tds.py	1363	# This function is the generic recvTDS packet which is used to extract data from a regular TDS packet
MEDIUM	impacket/tds.py	1401	# This function is a wrapper that is used to dispatch packets to read depending of the TLS context
MEDIUM	impacket/tds.py	1451	# This function is used to set the TLS context, process the handshak in memory
MEDIUM	impacket/smb.py	127	SMB_O_CREAT = 0x10 # Create the file if file does not exists. Otherwise, operation fails.
MEDIUM	impacket/examples/serviceinstall.py	97	# Create the service
MEDIUM	impacket/examples/ntlmrelayx/clients/dcsyncclient.py	265	# Initialize NTDSHashes object
MEDIUM	impacket/examples/ntlmrelayx/utils/ssl.py	34	# Create a private key
MEDIUM	impacket/examples/ntlmrelayx/utils/ssl.py	38	# Create the certificate
MEDIUM	impacket/examples/ntlmrelayx/utils/ssl.py	57	# Create a context, we don't really care about the SSL/TLS
MEDIUM	impacket/examples/ntlmrelayx/attacks/ldapattack.py	966	# Create a nice shiny new user for the escalation
MEDIUM	impacket/examples/ntlmrelayx/attacks/ldapattack.py	992	# Create a nice shiny new user for the escalation
MEDIUM	impacket/examples/ntlmrelayx/attacks/ldapattack.py	1139	# Create an object ACE with the specified privguid and our sid
MEDIUM	impacket/examples/ntlmrelayx/attacks/ldapattack.py	1156	# Create an ALLOW ACE with the specified sid
MEDIUM	tests/SMB_RPC/test_acl.py	114	# Create a new ACE for a different user with R,W permissions
MEDIUM	examples/secretsdump.py	145	# Create the baseDN
MEDIUM	examples/GetADComputers.py	64	# Create the baseDN
MEDIUM	examples/dacledit.py	379	# This function is called before any writing action (write, remove or restore)
MEDIUM	examples/badsuccessor.py	83	# Create the baseDN if not provided
MEDIUM	examples/GetLAPSPassword.py	87	# Create the baseDN
MEDIUM	examples/raiseChild.py	209	# Create the pipes threads
MEDIUM	examples/GetNPUsers.py	90	# Create the baseDN
MEDIUM	examples/findDelegation.py	97	# Create the baseDN
MEDIUM	examples/rbcd.py	56	# Create an ALLOW ACE with the specified sid
MEDIUM	examples/goldenPac.py	162	# Create the pipes threads
MEDIUM	examples/addcomputer.py	116	# Create the baseDN
MEDIUM	examples/GetADUsers.py	60	# Create the baseDN
MEDIUM	examples/changepasswd.py	945	# Create a password management session
MEDIUM	examples/ping6.py	47	# Create a new IP packet and set its source and destination addresses.
MEDIUM	examples/GetUserSPNs.py	23	# This module provides a Python implementation for this attack, adding also the ability to PtH/Ticket/Key.
MEDIUM	examples/GetUserSPNs.py	103	# Create the baseDN
MEDIUM	examples/ping.py	46	# Create a new IP packet and set its source and destination addresses.
MEDIUM	examples/ping.py	52	# Create a new ICMP packet of type ECHO.
MEDIUM	examples/psexec.py	183	# Create the pipes threads

Redundant / Tautological Comments48 hits · 76 pts

Severity	File	Line	Snippet
LOW	impacket/smb.py	129	SMB_O_OPEN = 0x01 # Open the file if the file exists
LOW	impacket/smbserver.py	1519	# Check if the file was marked for removal
LOW	impacket/smbserver.py	3533	# Check if the file was marked for removal
LOW	impacket/smbserver.py	2068	# Check if the Tid matches the Tid trying to disconnect
LOW	impacket/smbserver.py	2092	# Check if the Uid matches the user trying to logoff
LOW	impacket/smbserver.py	3973	# Check if the next data will exceed the OutputBufferLength
LOW	impacket/smb3structs.py	179	FILE_OPEN_IF = 0x00000003 # Open the file if it already exists; otherwise, create the file. This value SHOULD
LOW	impacket/dcerpc/v5/transport.py	515	# Check if we have a smb connection already setup
LOW	impacket/dcerpc/v5/rpch.py	678	# Check if the previous chunk is still there
LOW	impacket/examples/secretsdump.py	767	# Check if remoteName is FQDN, otherwise it will likely be the hostname only
LOW	impacket/examples/secretsdump.py	2395	# Check if old LSA secrets values are also need to be shown
LOW	impacket/examples/regsecrets.py	81	# Check if remoteName is FQDN, otherwise it will likely be the hostname only and we can't build the salt
LOW	impacket/examples/regsecrets.py	1029	# Check if old LSA secrets values are also need to be shown
LOW	impacket/examples/regsecrets.py	1065	# Check if old LSA secrets values are also need to be shown
LOW	impacket/examples/ntlmrelayx/clients/httprelayclient.py	58	#Check if server wants auth
LOW	impacket/examples/ntlmrelayx/utils/targetsutils.py	70	# Check if we have a single target, with no URI form
LOW	impacket/examples/ntlmrelayx/servers/rdprelayserver.py	339	# Check if SOCKS is enabled and if we support the target scheme
LOW	impacket/examples/ntlmrelayx/servers/rpcrelayserver.py	396	# Check if SOCKS is enabled and if we support the target scheme
LOW	…acket/examples/ntlmrelayx/servers/winrmsrelayserver.py	531	# Check if SOCKS is enabled and if we support the target scheme
LOW	…packet/examples/ntlmrelayx/servers/winrmrelayserver.py	517	# Check if SOCKS is enabled and if we support the target scheme
LOW	impacket/examples/ntlmrelayx/servers/rawrelayserver.py	187	# Check if SOCKS is enabled and if we support the target scheme
LOW	impacket/examples/ntlmrelayx/servers/smbrelayserver.py	934	# Check if SOCKS is enabled and if we support the target scheme
LOW	impacket/examples/ntlmrelayx/servers/httprelayserver.py	524	# Check if SOCKS is enabled and if we support the target scheme
LOW	impacket/examples/ntlmrelayx/servers/wcfrelayserver.py	327	# Check if SOCKS is enabled and if we support the target scheme
LOW	…packet/examples/ntlmrelayx/servers/mssqlrelayserver.py	424	# Check if SOCKS is enabled and if we support the target scheme
LOW	…cket/examples/ntlmrelayx/servers/socksplugins/mssql.py	166	# Check if we have a connection for the user
LOW	…packet/examples/ntlmrelayx/servers/socksplugins/smb.py	360	# Check if we have a connection for the user
LOW	…packet/examples/ntlmrelayx/servers/socksplugins/smb.py	514	# Check if we have a connection for the user
LOW	…acket/examples/ntlmrelayx/servers/socksplugins/http.py	65	# Check if we have a connection for the user
LOW	…acket/examples/ntlmrelayx/servers/socksplugins/http.py	179	# Check if the body is larger than 1 packet
LOW	…acket/examples/ntlmrelayx/servers/socksplugins/smtp.py	102	# Check if we have a connection for the user
LOW	…acket/examples/ntlmrelayx/servers/socksplugins/imap.py	95	# Check if we have a connection for the user
LOW	impacket/examples/ntlmrelayx/attacks/imapattack.py	47	#Check if search worked
LOW	impacket/examples/ntlmrelayx/attacks/ldapattack.py	577	# Check if the ACE has restrictions on object type (inherited case)
LOW	impacket/examples/ntlmrelayx/attacks/ldapattack.py	581	# Verify if the ACE applies to this object type
LOW	impacket/examples/ntlmrelayx/attacks/ldapattack.py	587	# Check if this applies to our objecttype
LOW	impacket/examples/ntlmrelayx/attacks/ldapattack.py	619	# Check if the ACE is an OBJECT ACE, if so the WRITE_DACL is applied to
LOW	impacket/examples/ntlmrelayx/attacks/ldapattack.py	1187	# Check if an ACE allows for creation of users
LOW	impacket/examples/ntlmrelayx/attacks/ldapattack.py	1195	# Check if an ACE allows for adding members
LOW	examples/badsuccessor.py	292	# Check if ACE has relevant rights
LOW	examples/GetLAPSPassword.py	111	# Check if item is in cache
LOW	examples/raiseChild.py	184	# Check if we need to copy a file for execution
LOW	examples/findDelegation.py	40	# Check if SPN exists
LOW	examples/rpcdump.py	112	# Display results.
LOW	examples/samrdump.py	91	# Display results.
LOW	examples/split.py	130	# Open file
LOW	examples/goldenPac.py	137	# Check if we need to copy a file for execution
LOW	examples/psexec.py	158	# Check if we need to copy a file for execution

Cross-File Repetition10 hits · 50 pts

Severity	File	Snippet
HIGH	impacket/dcerpc/v5/transport.py	this method only makes sense before connection for most protocols.
HIGH	impacket/dcerpc/v5/transport.py	this method only makes sense before connection for most protocols.
HIGH	impacket/dcerpc/v5/transport.py	this method only makes sense before connection for most protocols.
HIGH	impacket/dcerpc/v5/transport.py	this method only makes sense before connection for most protocols.
HIGH	…acket/examples/ntlmrelayx/servers/winrmsrelayserver.py	<?xml version="1.0"?><d:multistatus xmlns:d="dav:"><d:response><d:href>http://webdavrelay/file/image.jpg/</d:href><d:pro
HIGH	…packet/examples/ntlmrelayx/servers/winrmrelayserver.py	<?xml version="1.0"?><d:multistatus xmlns:d="dav:"><d:response><d:href>http://webdavrelay/file/image.jpg/</d:href><d:pro
HIGH	impacket/examples/ntlmrelayx/servers/httprelayserver.py	<?xml version="1.0"?><d:multistatus xmlns:d="dav:"><d:response><d:href>http://webdavrelay/file/image.jpg/</d:href><d:pro
HIGH	…acket/examples/ntlmrelayx/servers/winrmsrelayserver.py	<?xml version="1.0"?><d:multistatus xmlns:d="dav:"><d:response><d:href>http://webdavrelay/file/</d:href><d:propstat><d:p
HIGH	…packet/examples/ntlmrelayx/servers/winrmrelayserver.py	<?xml version="1.0"?><d:multistatus xmlns:d="dav:"><d:response><d:href>http://webdavrelay/file/</d:href><d:propstat><d:p
HIGH	impacket/examples/ntlmrelayx/servers/httprelayserver.py	<?xml version="1.0"?><d:multistatus xmlns:d="dav:"><d:response><d:href>http://webdavrelay/file/</d:href><d:propstat><d:p

Decorative Section Separators12 hits · 36 pts

Severity	File	Line	Snippet
MEDIUM	impacket/mapi_constants.py	869	# ====================
MEDIUM	impacket/mapi_constants.py	1565	# ====================
MEDIUM	impacket/examples/utils.py	64	# ----------
MEDIUM	impacket/examples/utils.py	249	# ----------
MEDIUM	impacket/examples/utils.py	296	# ----------
MEDIUM	impacket/examples/utils.py	321	# ----------
MEDIUM	tests/misc/test_ntfs_read.py	21	# ---------------------------------------------------------------------------
MEDIUM	tests/misc/test_ntfs_read.py	23	# ---------------------------------------------------------------------------
MEDIUM	tests/misc/test_ntfs_read.py	43	# ===========================================================================
MEDIUM	tests/misc/test_ntfs_read.py	45	# ===========================================================================
MEDIUM	tests/misc/test_ntfs_read.py	190	# ===========================================================================
MEDIUM	tests/misc/test_ntfs_read.py	192	# ===========================================================================

Cross-Language Confusion7 hits · 34 pts

Severity	File	Line	Snippet
HIGH	impacket/hresult_errors.py	2908	0xC026250A: ("ERROR_GRAPHICS_OPM_INVALID_POINTER", "The function failed because an invalid pointer parameter was
HIGH	impacket/hresult_errors.py	2908	0xC026250A: ("ERROR_GRAPHICS_OPM_INVALID_POINTER", "The function failed because an invalid pointer parameter was
HIGH	impacket/nt_errors.py	1598	0xC01E050A: ("STATUS_GRAPHICS_OPM_INVALID_POINTER","The function failed because an invalid pointer parameter was
HIGH	impacket/nt_errors.py	1598	0xC01E050A: ("STATUS_GRAPHICS_OPM_INVALID_POINTER","The function failed because an invalid pointer parameter was
HIGH	impacket/nt_errors.py	1639	0xC01E05E4: ("STATUS_GRAPHICS_INVALID_POINTER","The function failed because an invalid pointer parameter was pas
HIGH	impacket/nt_errors.py	1639	0xC01E05E4: ("STATUS_GRAPHICS_INVALID_POINTER","The function failed because an invalid pointer parameter was pas
HIGH	tests/SMB_RPC/test_wmi.py	326	# PowerShell "gwmi win32_currenttime" command output shows it empty indicating it is $null, so it should be None

Hallucination Indicators3 hits · 22 pts

Severity	File	Line	Snippet
CRITICAL	tests/SMB_RPC/test_wmi.py	336	The following lines were added in the impacket.dcerpc.v5.dcom.wmi.IWbemClassObject.SpawnInstance():
CRITICAL	tests/SMB_RPC/test_wmi.py	342	# NOTE: I think these shouldn't be strings, see impacket.dcerpc.v5.dcom.wmi.ENCODED_VALUE.getValue() and
CRITICAL	tests/SMB_RPC/test_wmi.py	343	# impacket.dcerpc.v5.dcom.wmi.CLASS_PART.getProperties() (links below). I won't change that code since I

AI Slop Vocabulary7 hits · 11 pts

Severity	File	Line	Snippet
LOW	impacket/smbserver.py	649	# For now we just return fake values
LOW	impacket/smbserver.py	2945	# just use the same key
LOW	impacket/examples/secretsdump.py	549	# If dwExtCaps is not included in the answer, let's just add it so we can unpack DRS_EXTENSIONS_INT right.
LOW	impacket/examples/ntlmrelayx/clients/dcsyncclient.py	236	# If dwExtCaps is not included in the answer, let's just add it so we can unpack DRS_EXTENSIONS_INT right.
LOW	tests/dcerpc/test_drsuapi.py	58	# If dwExtCaps is not included in the answer, let's just add it so we can unpack DRS_EXTENSIONS_INT right.
LOW	examples/raiseChild.py	686	# If dwExtCaps is not included in the answer, let's just add it so we can unpack DRS_EXTENSIONS_INT right.
MEDIUM	examples/smbexec.py	21	# Certainly not a stealthy way.

Slop Phrases5 hits · 9 pts

Severity	File	Line	Snippet
MEDIUM	impacket/dcerpc/v5/transport.py	440	# But you can use set_rpc_proxy_url method to set any URL / query you want.
LOW	impacket/examples/secretsdump.py	2291	LOG.warning("Don't forget to remove sensitive content before sending the data in a Github issue.")
LOW	impacket/examples/regsecrets.py	925	LOG.warning("Don't forget to remove sensitive content before sending the data in a Github issue.")
MEDIUM	examples/GetADUsers.py	17	# If no entries are returned that means users don't have email addresses specified. If so, you can use the
LOW	examples/ntlmrelayx.py	289	"are optional, and don't forget to escape the '\\'). If unspecified, it will relay bac

Dead Code1 hit · 2 pts

Severity	File	Line	Snippet
MEDIUM	impacket/dcerpc/v5/enum.py	671

Score History

Severity Breakdown

Pattern Findings