fish-shell/fish-shell

Pattern Findings

202 matches across 13 categories. Click a row to expand file-level details.

Over-Commented Block111 hits · 111 pts

Severity	File	Line	Snippet
LOW	crates/gettext-mo-file-parser/src/lib.rs	21	}
LOW	crates/gettext-extraction/src/lib.rs	81	/// the message ID is written into a new file in this directory,
LOW	crates/wgetopt/src/lib.rs	41	/// regardless of [Ordering].
LOW	crates/wgetopt/src/lib.rs	61	/// Indicates whether an option takes an argument, and whether that argument
LOW	crates/wgetopt/src/lib.rs	121	shortopts: &'opts wstr,
LOW	crates/util/src/lib.rs	21	/// file12.txt
LOW	crates/color/src/lib.rs	141	} else {
LOW	crates/printf/src/lib.rs	21	/// let s = sprintf!("%0.5g", 123456.0);
LOW	crates/printf/src/lib.rs	61	};
LOW	crates/printf/src/lib.rs	81	/// let mut output = String::new();
LOW	crates/printf/src/printf_impl.rs	321	/// Formats a string using the provided format specifiers, arguments, and locale,
LOW	crates/printf/src/locale.rs	1	/// The numeric locale. Note this is a pure value type.
LOW	crates/printf/src/fmt_fp/decimal.rs	241	// which is given by remainder (that is, remainder = self[digit_idx] % mod_base).
LOW	crates/printf/src/fmt_fp/mod.rs	101
LOW	crates/common/src/lib.rs	1201	impl<T: Copy> ScopedCell<T> {
LOW	crates/common/src/lib.rs	1261	///
LOW	crates/common/src/lib.rs	1301	///
LOW	crates/common/src/lib.rs	1321	/// A RAII cleanup object. Unlike in C++ where there is no borrow checker, we can't just provide a
LOW	crates/common/src/lib.rs	1381
LOW	crates/common/src/lib.rs	1401	/// ];
LOW	crates/widestring/src/lib.rs	41	//
LOW	crates/widestring/src/lib.rs	121
LOW	crates/widestring/src/lib.rs	341	/// PUA-encoded chars into a char iterator where each encoded non-UTF-8 byte is replaced by the
LOW	crates/widestring/src/lib.rs	361	/// non-empty. In the [`Self::next`] and [`Self::next_back`] implementations, this logic is
LOW	crates/widestring/src/lib.rs	581
LOW	crates/xtask/src/gettext.rs	21
LOW	crates/xtask/src/main.rs	41	/// [`clap_complete`] is not built to account for the situation we have here, where the CLI does not
LOW	doc_src/conf.py	141
LOW	doc_src/conf.py	161	# -- Options for HTML output -------------------------------------------------
LOW	doc_src/conf.py	281
LOW	tests/fish_test_helper.c	1	// fish_test_helper is a little program with no fish dependencies that acts like certain other
LOW	tests/pexpects/commandline.py	121	# send(control("u") * 6)
LOW	tests/pexpects/bind.py	141	# Delay needed to allow fish to transition to vi "normal" mode.
LOW	tests/pexpects/history.py	1	#!/usr/bin/env python3
LOW	src/job_group.rs	61	pub struct JobGroup {
LOW	src/timer.rs	1	//! This module houses `TimerSnapshot` which can be used to calculate the elapsed time (system CPU
LOW	src/exec.rs	121	return false;
LOW	src/exec.rs	361	false
LOW	src/exec.rs	461	// To avoid the race between the caller calling tcsetpgrp() and the client checking the
LOW	src/exec.rs	1241	j: &Job,
LOW	src/exec.rs	1261	// echo alpha \| cat < beta.txt
LOW	src/tty_handoff.rs	341
LOW	src/tty_handoff.rs	441	// Check who own the tty now. There's four cases of interest:
LOW	src/tty_handoff.rs	461	}
LOW	src/parse_util.rs	121	/// \param str the string to search for subshells
LOW	src/parse_util.rs	161
LOW	src/parse_util.rs	981	// Here's a hack. Consider:
LOW	src/fds.rs	161
LOW	src/terminal.rs	341	}
LOW	src/proc.rs	341	impl fish_printf::ToArg<'static> for Pid {
LOW	src/proc.rs	361	/// array and `actual_cmd` is the absolute path of the command to execute.
LOW	src/proc.rs	1141
LOW	src/screen.rs	221
LOW	src/screen.rs	1281	}
LOW	src/screen.rs	1881	commandline_before_suggestion,
LOW	src/topic_monitor.rs	281	}
LOW	src/topic_monitor.rs	321
LOW	src/expand.rs	41	/// Set of flags controlling expansions.
LOW	src/expand.rs	61	/// Allow fuzzy matching.
LOW	src/expand.rs	101	}
51 more matches not shown…

Cross-Language Confusion15 hits · 74 pts

Severity	File	Line	Snippet
HIGH	tests/pexpects/wildcard_tab.py	67	sendline(r"mkdir benchmarks && mkdir benchmarks/somedir && touch benchmarks/somefile")
HIGH	tests/pexpects/pipeline.py	28	# 'not' because we expect to have no jobs, in which case `jobs` will return false
HIGH	tests/pexpects/isatty.py	20	test -t 0 && echo stdin
HIGH	tests/pexpects/isatty.py	21	test -t 1 && echo stdout
HIGH	tests/pexpects/isatty.py	22	test -t 2 && echo stderr
HIGH	tests/pexpects/isatty.py	60	sendline("isatty stdin && echo yes")
HIGH	tests/pexpects/isatty.py	64	sendline("cat </dev/null \| isatty stdin \|\| echo no")
HIGH	tests/pexpects/autosuggest.py	77	run("touch configure && chmod +x configure")
HIGH	tests/pexpects/status.py	28	sendline("true 7 && status current-commandline")
HIGH	tests/pexpects/status.py	29	expect_prompt("\r\n.*true 7 && status current-commandline\r\n")
HIGH	tests/pexpects/read.py	58	sendline(r"read -c init_text somevar && echo $somevar")
HIGH	tests/pexpects/read.py	63	sendline(r"read --command='some other text' somevar && echo $somevar")
HIGH	share/tools/web_config/webconfig.py	807	+ "if set -q __fish_initialized && test $__fish_initialized -lt 4300\n"
HIGH	share/tools/web_config/webconfig.py	999	+ "funcsave fish_prompt && funcsave fish_right_prompt 2>/dev/null"
HIGH	share/tools/web_config/webconfig.py	1019	+ '" \n false \n functions -q fish_right_prompt && fish_right_prompt\n'

Decorative Section Separators13 hits · 54 pts

Severity	File	Line	Snippet
MEDIUM	tests/pexpects/read.py	126	# ==========
MEDIUM	tests/pexpects/history.py	32	# ==========
MEDIUM	tests/pexpects/history.py	37	# ==========
MEDIUM	tests/pexpects/history.py	39	# ==========
MEDIUM	tests/pexpects/history.py	41	# ==========
MEDIUM	tests/pexpects/history.py	50	# ==========
MEDIUM	tests/pexpects/history.py	52	# ==========
MEDIUM	tests/pexpects/history.py	54	# ==========
MEDIUM	tests/pexpects/history.py	60	# ==========
MEDIUM	tests/pexpects/history.py	65	# ==========
MEDIUM	tests/pexpects/history.py	72	# ==========
MEDIUM	tests/pexpects/history.py	99	# ==========
MEDIUM	tests/pexpects/history.py	106	# ==========

Deep Nesting25 hits · 25 pts

Severity	File	Line
LOW	doc_src/fish_synopsis.py	85
LOW	doc_src/conf.py	219
LOW	tests/test_driver.py	111
LOW	tests/test_driver.py	306
LOW	tests/pexpect_helper.py	75
LOW	tests/littlecheck.py	796
LOW	tests/littlecheck.py	207
LOW	share/tools/create_manpage_completions.py	1251
LOW	share/tools/create_manpage_completions.py	1872
LOW	share/tools/create_manpage_completions.py	2088
LOW	share/tools/create_manpage_completions.py	468
LOW	share/tools/create_manpage_completions.py	517
LOW	share/tools/create_manpage_completions.py	588
LOW	share/tools/create_manpage_completions.py	655
LOW	share/tools/create_manpage_completions.py	680
LOW	share/tools/create_manpage_completions.py	885
LOW	share/tools/create_manpage_completions.py	930
LOW	share/tools/create_manpage_completions.py	1092
LOW	share/tools/create_manpage_completions.py	1708
LOW	share/tools/web_config/webconfig.py	229
LOW	share/tools/web_config/webconfig.py	1429
LOW	share/tools/web_config/webconfig.py	1125
LOW	share/tools/web_config/webconfig.py	1146
LOW	share/tools/web_config/webconfig.py	1183
LOW	share/tools/web_config/webconfig.py	267

Synthetic Comment Markers2 hits · 15 pts

Severity	File	Line	Snippet
HIGH	src/ast.rs	2362	// exhausted the stream as requested.
HIGH	src/builtins/read.rs	306	/// Read from the fd in chunks until we see newline or null, as requested, is seen. This is only

Hyper-Verbose Identifiers14 hits · 12 pts

Severity	File	Line	Snippet
LOW	tests/pexpect_helper.py	197	def send_cursor_position_report(self, *, y: int, x: int):
LOW	tests/pexpect_helper.py	202	def send_primary_device_attribute(self):
LOW	tests/pexpect_helper.py	285	def report_exception_and_exit(self, pat, unmatched, err):
LOW	share/tools/create_manpage_completions.py	1851	def cleanup_autogenerated_completions_in_directory(dir):
LOW	share/tools/create_manpage_completions.py	1864	def cleanup_autogenerated_file(path):
LOW	share/tools/create_manpage_completions.py	2018	def parse_and_output_man_pages(paths, output_directory, show_progress):
LOW	share/tools/create_manpage_completions.py	2088	def get_paths_from_man_locations():
LOW	share/tools/web_config/webconfig.py	356	def html_color_for_ansi_color_index(val):
LOW	share/tools/web_config/webconfig.py	625	def append_html_for_ansi_escape(full_val, result, span_open):
LOW	share/tools/web_config/webconfig.py	800	class FishConfigHTTPRequestHandler(SimpleHTTPServer.SimpleHTTPRequestHandler):
LOW	share/tools/web_config/webconfig.py	963	def do_set_color_for_variable(self, name, color):
LOW	share/tools/web_config/webconfig.py	1053	def parse_one_sample_prompt_hash(self, line, result_dict):
LOW	share/tools/web_config/webconfig.py	1094	def do_get_sample_prompts_list(self):
LOW	share/tools/web_config/webconfig.py	1125	def font_size_for_ansi_prompt(self, prompt_demo_ansi):

AI Slop Vocabulary4 hits · 8 pts

Severity	File	Line	Snippet
MEDIUM	tests/littlecheck.py	838	# To facilitate integration with testing frameworks, use exit code 125 to indicate that all
MEDIUM	tests/pexpects/history.py	8	# meant to be a comprehensive test of the history subsystem. Those types of
LOW	build_tools/make_linux_packages.sh	72	# just use dpkg-buildpackage directly
LOW	share/tools/create_manpage_completions.py	2104	# If we can't have the OS interpret $MANPATH, just use it as-is (gulp).

Self-Referential Comments4 hits · 8 pts

Severity	File	Line	Snippet
MEDIUM	src/env_universal_common.rs	631	const SAVE_MSG: &[u8] = b"# This file contains fish universal variable definitions.\n";
MEDIUM	src/env_universal_common.rs	932	"# This file contains fish universal variable definitions.\n",
MEDIUM	src/env_universal_common.rs	950	"# This file contains fish universal variable definitions.\n",
MEDIUM	src/env_universal_common.rs	1002	"# This file contains fish universal variable definitions.\n",

Slop Phrases4 hits · 8 pts

Severity	File	Line	Snippet
LOW	Cargo.toml	10	# don't forget to update COPYING and debian/copyright too
LOW	Cargo.toml	10	# don't forget to update COPYING and debian/copyright too
LOW	src/parser_keywords.rs	40	// Don't forget to add any new reserved keywords to the documentation
MEDIUM	src/builtins/string/shorten.rs	155	// This should work for most cases considering the combiners typically have width 0.

Unused Imports7 hits · 7 pts

Severity	File	Line
LOW	doc_src/fish_indent_lexer.py	7
LOW	doc_src/conf.py	19
LOW	tests/test_driver.py	21
LOW	tests/pexpect_helper.py	16
LOW	tests/littlecheck.py	5
LOW	tests/littlecheck.py	6
LOW	share/tools/web_config/webconfig.py	4

Example Usage Blocks1 hit · 2 pts

Severity	File	Line	Snippet
LOW	doc_src/fish_synopsis.py	3	# Example usage:

Redundant / Tautological Comments1 hit · 2 pts

Severity	File	Line	Snippet
LOW	src/fs.rs	281	/// # Return value

Excessive Try-Catch Wrapping1 hit · 1 pts

Severity	File	Line	Snippet
LOW	tests/test_driver.py	233	except Exception as e:

Score History

Severity Breakdown

Pattern Findings