firefly-iii/firefly-iii

Pattern Findings

404 matches across 9 categories. Click a row to expand file-level details.

Hyper-Verbose Identifiers303 hits · 312 pts

Severity	File	Line	Snippet
LOW	app/User.php	343	public function routeNotificationForPushover(): PushoverReceiver
LOW	app/User.php	354	public function routeNotificationForSlack(Notification $notification): ?string
LOW	app/User.php	405	public function sendPasswordResetNotification(#[SensitiveParameter] $token): void
LOW	app/TransactionRules/Actions/SetDestinationAccount.php	144	private function findWithdrawalDestinationAccount(string $accountName): Account
LOW	app/TransactionRules/Engine/SearchRuleEngine.php	485	private function hasSpecificJournalTrigger(array $array): bool
LOW	app/TransactionRules/Engine/SearchRuleEngine.php	576	private function processTransactionJournal(Rule $rule, array $transaction): void
LOW	app/TransactionRules/Engine/SearchRuleEngine.php	593	private function setDateFromJournalTrigger(array $array): Carbon
LOW	app/Repositories/Journal/JournalRepositoryInterface.php	78	public function getAllUncompletedJournals(): Collection;
LOW	app/Repositories/Journal/JournalRepositoryInterface.php	120	public function searchJournalDescriptions(string $search, int $limit): Collection;
LOW	app/Repositories/Journal/JournalRepository.php	138	public function getAllUncompletedJournals(): Collection
LOW	app/Repositories/Journal/JournalRepository.php	256	public function searchJournalDescriptions(string $search, int $limit): Collection
LOW	app/Repositories/UserGroup/UserGroupRepository.php	158	public function getMembershipsFromGroupId(int $groupId): Collection
LOW	…epositories/UserGroup/UserGroupRepositoryInterface.php	53	public function getMembershipsFromGroupId(int $groupId): Collection;
LOW	…epositories/Category/OperationsRepositoryInterface.php	83	public function sumCollectedTransactionsByCategory(array $expenses, Category $category, string $method, bool $conver
LOW	app/Repositories/Category/OperationsRepository.php	397	public function sumCollectedTransactionsByCategory(array $expenses, Category $category, string $method, bool $conver
LOW	app/Repositories/Rule/RuleRepository.php	115	public function getHighestOrderInRuleGroup(RuleGroup $ruleGroup): int
LOW	app/Repositories/Rule/RuleRepositoryInterface.php	63	public function getHighestOrderInRuleGroup(RuleGroup $ruleGroup): int;
LOW	…epositories/PiggyBank/PiggyBankRepositoryInterface.php	81	public function getCurrentPrimaryCurrencyAmount(PiggyBank $piggyBank, ?Account $account = null): string;
LOW	app/Repositories/PiggyBank/PiggyBankRepository.php	160	public function getCurrentPrimaryCurrencyAmount(PiggyBank $piggyBank, ?Account $account = null): string
LOW	…tories/TransactionGroup/TransactionGroupRepository.php	448	private function getFormattedForeignAmount(TransactionJournal $journal): string
LOW	app/Repositories/RuleGroup/RuleGroupRepository.php	167	public function getAllRuleGroupsWithRules(?string $filter): Collection
LOW	…epositories/RuleGroup/RuleGroupRepositoryInterface.php	79	public function getAllRuleGroupsWithRules(?string $filter): Collection;
LOW	app/Repositories/Account/AccountRepositoryInterface.php	94	public function getCreditTransactionGroup(Account $account): ?TransactionGroup;
LOW	app/Repositories/Account/AccountRepositoryInterface.php	96	public function getInactiveAccountsByType(array $types): Collection;
LOW	app/Repositories/Account/AccountRepositoryInterface.php	159	public function searchAccountIncludingInactive(string $query, array $types, int $limit): Collection;
LOW	app/Repositories/Account/AccountTasker.php	175	private function groupExpenseByDestination(array $array): array
LOW	app/Repositories/Account/AccountRepository.php	305	public function getCreditTransactionGroup(Account $account): ?TransactionGroup
LOW	app/Repositories/Account/AccountRepository.php	316	public function getInactiveAccountsByType(array $types): Collection
LOW	app/Repositories/Account/AccountRepository.php	667	public function searchAccountIncludingInactive(string $query, array $types, int $limit): Collection
LOW	…PeriodStatistic/PeriodStatisticRepositoryInterface.php	41	public function deleteStatisticsForCollection(Collection $set): void;
LOW	…PeriodStatistic/PeriodStatisticRepositoryInterface.php	45	public function deleteStatisticsForPrefix(string $prefix, Collection $dates): void;
LOW	…sitories/PeriodStatistic/PeriodStatisticRepository.php	65	public function deleteStatisticsForCollection(Collection $set): void
LOW	…sitories/PeriodStatistic/PeriodStatisticRepository.php	99	public function deleteStatisticsForPrefix(string $prefix, Collection $dates): void
LOW	…Repositories/Budget/BudgetLimitRepositoryInterface.php	72	public function getAllBudgetLimitsByCurrency(TransactionCurrency $currency, ?Carbon $start = null, ?Carbon $end = nu
LOW	app/Repositories/Budget/BudgetRepository.php	138	public function budgetedInPeriodForBudget(Budget $budget, Carbon $start, Carbon $end): array
LOW	…sitories/Budget/AvailableBudgetRepositoryInterface.php	81	public function getAvailableBudgetsByCurrency(TransactionCurrency $currency): Collection;
LOW	…sitories/Budget/AvailableBudgetRepositoryInterface.php	86	public function getAvailableBudgetsByDate(?Carbon $start, ?Carbon $end): Collection;
LOW	…sitories/Budget/AvailableBudgetRepositoryInterface.php	88	public function getAvailableBudgetsByExactDate(Carbon $start, Carbon $end): Collection;
LOW	…sitories/Budget/AvailableBudgetRepositoryInterface.php	90	public function getAvailableBudgetWithCurrency(Carbon $start, Carbon $end): array;
LOW	…/Repositories/Budget/OperationsRepositoryInterface.php	81	public function sumCollectedExpensesByBudget(array $expenses, Budget $budget, bool $convertToPrimary = false): array
LOW	app/Repositories/Budget/BudgetRepositoryInterface.php	56	public function budgetedInPeriodForBudget(Budget $budget, Carbon $start, Carbon $end): array;
LOW	app/Repositories/Budget/OperationsRepository.php	291	public function sumCollectedExpensesByBudget(array $expenses, Budget $budget, bool $convertToPrimary = false): array
LOW	app/Repositories/Budget/AvailableBudgetRepository.php	177	public function getAvailableBudgetsByCurrency(TransactionCurrency $currency): Collection
LOW	app/Repositories/Budget/AvailableBudgetRepository.php	185	public function getAvailableBudgetsByDate(?Carbon $start, ?Carbon $end): Collection
LOW	app/Repositories/Budget/AvailableBudgetRepository.php	202	public function getAvailableBudgetsByExactDate(Carbon $start, Carbon $end): Collection
LOW	app/Repositories/Budget/AvailableBudgetRepository.php	207	public function getAvailableBudgetWithCurrency(Carbon $start, Carbon $end): array
LOW	app/Repositories/Budget/BudgetLimitRepository.php	201	public function getAllBudgetLimitsByCurrency(TransactionCurrency $currency, ?Carbon $start = null, ?Carbon $end = nu
LOW	app/Models/RecurrenceTransaction.php	70	public function recurrenceTransactionMeta(): HasMany
LOW	app/Models/PiggyBankRepetition.php	49	public function setCurrentAmountAttribute($value): void
LOW	app/Models/Account.php	134	public function setVirtualBalanceAttribute(mixed $value): void
LOW	app/Models/Webhook.php	74	public static function getDeliveriesForValidation(): array
LOW	app/Models/Webhook.php	97	public static function getResponsesForValidation(): array
LOW	app/Transformers/TransactionGroupTransformer.php	183	private function getDestinationTransaction(TransactionJournal $journal): Transaction
LOW	app/Support/Steam.php	72	public function accountsBalancesOptimized(
LOW	app/Support/Steam.php	423	public function finalAccountBalanceInRange(Account $account, Carbon $start, Carbon $end, bool $convertToPrimary): ar
LOW	app/Support/Amount.php	226	public function getAmountFromJournalObject(TransactionJournal $journal): string
LOW	app/Support/Amount.php	294	public function getPrimaryCurrencyByUserGroup(UserGroup $userGroup): TransactionCurrency
LOW	app/Support/Amount.php	320	public function getTransactionCurrencyByCode(string $code): TransactionCurrency
LOW	app/Support/Amount.php	342	public function getTransactionCurrencyById(int $currencyId): TransactionCurrency
LOW	app/Support/Navigation.php	565	public function preferredCarbonFormatByPeriod(string $period): string
243 more matches not shown…

Over-Commented Block81 hits · 74 pts

Severity	File	Line	Snippet
LOW	app/Providers/RouteServiceProvider.php	41	#[Override]
LOW	app/Providers/EventServiceProvider.php	41	// UpdatedTransactionGroup::class => ['FireflyIII\Handlers\Events\UpdatedGroupEventHandler@ru
LOW	…sitories/PeriodStatistic/PeriodStatisticRepository.php	61	;
LOW	…sitories/PeriodStatistic/PeriodStatisticRepository.php	81	// $this->deleteStatisticsForPrefix('no_category', $dates);
LOW	app/Repositories/Budget/BudgetRepository.php	701	// start1 = $start
LOW	app/Support/Search/OperatorQuerySearch.php	401	}
LOW	app/Http/Middleware/Authenticate.php	101	// foreach ($guards as $guard) {
LOW	app/Api/V1/Controllers/Summary/BasicController.php	421	// // $days
LOW	app/Notifications/ReturnsAvailableChannels.php	61
LOW	app/Notifications/ReturnsAvailableChannels.php	101	}
LOW	app/Notifications/Test/OwnerTestNotificationNtfy.php	41	* @SuppressWarnings("PHPMD.UnusedFormalParameter")
LOW	app/Notifications/Test/UserTestNotificationNtfy.php	41	* @SuppressWarnings("PHPMD.UnusedFormalParameter")
LOW	app/Notifications/Admin/VersionCheckResult.php	61	->markdown('emails.new-version', ['message' => $this->message])
LOW	app/Notifications/Admin/UserRegistration.php	81	// /**
LOW	app/Notifications/Admin/UnknownUserLoginAttempt.php	81	//
LOW	app/Notifications/Admin/UserInvitation.php	81	// /**
LOW	…p/Console/Commands/Correction/CorrectsUnevenAmount.php	161	$destination->saveQuietly();
LOW	.ci/phpstan.sh	1	#!/usr/bin/env bash
LOW	.ci/phpcs.sh	1	#!/usr/bin/env bash
LOW	.ci/rector.sh	1	#!/usr/bin/env bash
LOW	.ci/all.sh	1	#!/usr/bin/env bash
LOW	.ci/firefly-iii-standard.yml	161
LOW	.ci/phpmd.sh	1	#!/usr/bin/env bash
LOW	config/translations.php	121	'account_role_sharedAsset',
LOW	public/v1/js/lib/vue.js	1941	// However, it has subtle problems when state is changed right before repaint
LOW	public/v1/js/lib/moment/en_US.js	1	// default
LOW	public/v1/lib/fc/fullcalendar.js	10301	return {
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	1901	// @property pointer: Boolean
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	3041	options: {
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	3061
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	3081	// or `L.Canvas` by default depending on browser support.
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	3101	// Whether markers animate their zoom with the zoom animation, if disabled
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	3561	this._enforcingBounds = false;
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	4021	var projectedPoint = this.project(toLatLng(latlng))._round();
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	4141	},
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	4161
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	4301	this._targets = {};
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	4321	// Fired when the user pushes the right mouse button on the map, prevents
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	5761	return this;
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	7441	// @option riseOffset: Number = 250
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	7781	// @section
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	9081	options: {
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	9721	// Max width of the popup, in pixels.
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	9761	// @option autoClose: Boolean = true
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	10221
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	10721	// @aka GridLayer options
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	10761
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	11601	// @aka TileLayer options
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	13221	// @section Handlers
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	13241	Map.mergeOptions({
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	13261
LOW	public/v1/lib/leaflet/leaflet-src.esm.js	13641	// @section Interaction Options
LOW	public/v1/lib/leaflet/leaflet-src.js	1561	//
LOW	public/v1/lib/leaflet/leaflet-src.js	3061
LOW	public/v1/lib/leaflet/leaflet-src.js	3081	// outside the view. To set the restriction dynamically, use
LOW	public/v1/lib/leaflet/leaflet-src.js	3101	// @option fadeAnimation: Boolean = true
LOW	public/v1/lib/leaflet/leaflet-src.js	3121	// right after a [`fitBounds()`](#map-fitbounds) or a pinch-zoom.
LOW	public/v1/lib/leaflet/leaflet-src.js	3641
LOW	public/v1/lib/leaflet/leaflet-src.js	4041	// @method wrapLatLngBounds(bounds: LatLngBounds): LatLngBounds
LOW	public/v1/lib/leaflet/leaflet-src.js	4161	//
21 more matches not shown…

Hallucination Indicators3 hits · 30 pts

Severity	File	Line	Snippet
CRITICAL	…s/v1/src/components/transactions/CreateTransaction.vue	570	response.data.data.attributes.transactions = response.data.data.attributes.transactions.reverse();
CRITICAL	…ets/v1/src/components/transactions/EditTransaction.vue	894	let transactions = response.data.data.attributes.transactions.reverse();
CRITICAL	public/v1/js/lib/jquery-ui.min.js	6	(t=>{"function"==typeof define&&define.amd?define(["jquery"],t):t(jQuery)})(function(V){V.ui=V.ui\|\|{};V.ui.version="1.14

Self-Referential Comments6 hits · 18 pts

Severity	File	Line	Snippet
MEDIUM	.ci/phpstan.sh	7	# This file is part of Firefly III (https://github.com/firefly-iii).
MEDIUM	.ci/phpcs.sh	7	# This file is part of Firefly III (https://github.com/firefly-iii).
MEDIUM	.ci/rector.sh	7	# This file is part of Firefly III (https://github.com/firefly-iii).
MEDIUM	.ci/all.sh	7	# This file is part of Firefly III (https://github.com/firefly-iii).
MEDIUM	.ci/phpmd.sh	7	# This file is part of Firefly III (https://github.com/firefly-iii).
MEDIUM	.github/workflows/release.yml	387	# Create a production release.

AI Slop Vocabulary4 hits · 10 pts

Severity	File	Line	Snippet
LOW	app/Services/Internal/Support/JournalServiceTrait.php	248	Log::debug(sprintf('Was given %s account #%d ("%s") so will simply return that.', $account->accountType->typ
MEDIUM	public/v1/js/lib/bootstrap-sortable.js	249	// If there is one more row in header, delve deeper
MEDIUM	public/v1/lib/leaflet/leaflet-src.esm.js	11632	// If `true` and user is on a retina display, it will request four tiles of half the specified size and a bigger zoom
MEDIUM	public/v1/lib/leaflet/leaflet-src.js	11638	// If `true` and user is on a retina display, it will request four tiles of half the specified size and a bigger zoom

Slop Phrases4 hits · 9 pts

Severity	File	Line	Snippet
LOW	app/Api/V1/Controllers/Summary/BasicController.php	185	// don't forget to add it to newExpenses and newIncome
LOW	config/firefly.php	783	// if you add fields to this array, don't forget to update the export routine (ExportDataGenerator).
MEDIUM	public/v1/lib/leaflet/leaflet-src.esm.js	7479	* In addition to [shared layer methods](#Layer) like `addTo()` and `remove()` and [popup methods](#Popup) like bindPop
MEDIUM	public/v1/lib/leaflet/leaflet-src.js	7485	* In addition to [shared layer methods](#Layer) like `addTo()` and `remove()` and [popup methods](#Popup) like bindPop

Synthetic Comment Markers1 hit · 8 pts

Severity	File	Line	Snippet
HIGH	.github/security.md	6	## AI-generated security advisories

Fake / Example Data1 hit · 1 pts

Severity	File	Line	Snippet
LOW	config/mail.php	45	'username' => env_default_when_empty(env('MAIL_USERNAME'), 'user@example.com'),

Overly Generic Function Names1 hit · 1 pts

Severity	File	Line	Snippet
LOW	public/v1/js/lib/vue.js	4755	function getData (data, vm) {

Score History

Severity Breakdown

Pattern Findings