firecracker-microvm/firecracker

Pattern Findings

656 matches across 13 categories. Click a row to expand file-level details.

Over-Commented Block377 hits · 377 pts

Severity	File	Line	Snippet
LOW	rust-toolchain.toml	1	# Copyright 2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tools/ab_test.py	321	), "A and B run produced incomparable data. This is a bug in the test!"
LOW	tools/ab_test.py	341	# of the parameterization.
LOW	resources/rootfs/overlay/usr/local/bin/readmem.c	1	// Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	resources/rootfs/overlay/usr/local/bin/init.c	1	// Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	resources/rootfs/overlay/usr/local/bin/fillmem.c	1	// Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	…/rootfs/overlay/usr/local/bin/fast_page_fault_helper.c	1	// Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tests/conftest.py	541	# Tests get a microVM by requesting one of:
LOW	…sts/integration_tests/security/test_vulnerabilities.py	141	# =============================
LOW	tests/integration_tests/security/__init__.py	1	# Copyright 2025 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tests/integration_tests/style/__init__.py	1	# Copyright 2025 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tests/integration_tests/style/test_licenses.py	141
LOW	tests/integration_tests/performance/__init__.py	1	# Copyright 2025 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tests/integration_tests/performance/test_huge_pages.py	21
LOW	tests/integration_tests/performance/test_huge_pages.py	41	# Referenced: 0 kB
LOW	…tegration_tests/functional/test_cpu_template_helper.py	101	return cpu_config_dict
LOW	…tegration_tests/functional/test_cpu_template_helper.py	121	# is 0 on all tested platforms. On the other hand, the userspace cpuid
LOW	…tegration_tests/functional/test_cpu_template_helper.py	141	# CPUID.20000000h is not documented in Intel SDM and AMD APM. KVM doesn't
LOW	…tegration_tests/functional/test_cpu_template_helper.py	181	# List of MSR indices that should not be tested due to its mutability or inavailablility
LOW	…tegration_tests/functional/test_cpu_template_helper.py	201	# SYSENTER.
LOW	…tegration_tests/functional/test_cpu_template_helper.py	221	# MSR_KVM_STEAL_TIME indicates CPU steal time filled in by the hypervisor
LOW	…/integration_tests/functional/test_net_config_space.py	201	#
LOW	tests/integration_tests/functional/__init__.py	1	# Copyright 2025 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tests/integration_tests/functional/test_vsock.py	101
LOW	…on_tests/functional/test_cpu_features_host_vs_guest.py	161	}
LOW	…on_tests/functional/test_cpu_features_host_vs_guest.py	301	# physical memory of a system. TME is enabled by system BIOS/hardware and applies to
LOW	…on_tests/functional/test_cpu_features_host_vs_guest.py	321	# (resource control) capabilities including Cache Allocation Technology (CAT) and
LOW	…on_tests/functional/test_cpu_features_host_vs_guest.py	361	# Hardware Feedback Interface (HFI) is a feature that gives OSes a performance
LOW	…tegration_tests/functional/test_cpu_features_x86_64.py	201	# Assert the guest frequency matches the host frequency
LOW	tests/framework/utils_vsock.py	201	# Link the listening Unix socket into the VM's jail, so that
LOW	tests/framework/http_api.py	21	def __init__(self):
LOW	tests/host_tools/sysgenid.c	1	// Copyright 2026 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tests/host_tools/change_net_config_space.c	1	// Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tests/host_tools/vmclock.c	1	// Copyright 2025 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tests/host_tools/vsock_helper.c	1	// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tests/host_tools/test_syscalls.c	1	// Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	tests/host_tools/devmem.c	1	// Copyright 2026 Amazon.com, Inc. or its affiliates. All Rights Reserved.
LOW	.cargo/audit.toml	1	[advisories]
LOW	src/jailer/src/env.rs	41	const DEV_NET_TUN_MINOR: u32 = 200;
LOW	src/jailer/src/env.rs	81	// pid namespace, we will call clone with a NULL stack pointer. We can do this because we will
LOW	src/jailer/src/env.rs	321	NO_FILE_ARG => resource_limits.set_no_file(limit_value),
LOW	src/jailer/src/env.rs	681	.iter()
LOW	src/jailer/src/cgroup.rs	41	// search PROC_MOUNTS for cgroup mount points
LOW	src/jailer/src/cgroup.rs	241	}
LOW	src/jailer/src/cgroup.rs	261	// on the following helper function) helps with propagating the values.
LOW	src/jailer/src/resource_limits.rs	21	RlimitFsize,
LOW	src/jailer/src/resource_limits.rs	41	// c_uint (which is an u32)
LOW	src/clippy-tracing/src/main.rs	21	#[derive(Parser)]
LOW	src/acpi-tables/src/aml.rs	201	}
LOW	src/acpi-tables/src/aml.rs	1241
LOW	src/acpi-tables/src/aml.rs	1301	.unwrap()
LOW	src/acpi-tables/src/aml.rs	1321	// 0x0CF8, // Length
LOW	src/acpi-tables/src/aml.rs	1341	// 0x00000000, // Translation Offset
LOW	src/acpi-tables/src/aml.rs	1621	[0x14, 0x09, 0x5F, 0x53, 0x54, 0x41, 0x00, 0xA4, 0x0A, 0x0F]
LOW	src/acpi-tables/src/aml.rs	1861
LOW	src/acpi-tables/src/aml.rs	1981	// {
LOW	src/acpi-tables/src/fadt.rs	21
LOW	src/acpi-tables/src/rsdp.rs	1	// Copyright © 2019 Intel Corporation
LOW	src/utils/src/time.rs	181	/// Converts a timestamp in seconds to an equivalent one in nanoseconds.
LOW	src/vmm/src/persist.rs	101	/// This describes the mapping between Firecracker base virtual address and
317 more matches not shown…

Hyper-Verbose Identifiers191 hits · 192 pts

Severity	File	Line	Snippet
LOW	tests/conftest.py	95	def pytest_runtest_makereport(item, call): # pylint:disable=unused-argument
LOW	tests/conftest.py	225	def test_fc_session_root_path():
LOW	tests/conftest.py	263	def change_net_config_space_bin(test_fc_session_root_path):
LOW	tests/README.md	476	def test_with_any_microvm_and_my_init(test_microvm_any):
LOW	tests/integration_tests/security/test_fips.py	55	def test_fips_rng_reseed_on_snapshot_restore(uvm_with_fips, microvm_factory):
LOW	tests/integration_tests/security/test_fips.py	70	def test_fips_reseeded_kernel_csprng(fips_snapshot_pair):
LOW	tests/integration_tests/security/test_fips.py	83	def test_fips_reseeded_userspace_csprng(fips_snapshot_pair):
LOW	tests/integration_tests/security/test_seccomp.py	180	def test_default_seccomp_level(uvm):
LOW	tests/integration_tests/security/test_jail.py	114	def test_exec_destination_path_is_symlink(uvm):
LOW	tests/integration_tests/security/test_jail.py	134	def test_exec_destination_path_is_hardlink(uvm):
LOW	tests/integration_tests/security/test_jail.py	154	def test_default_chroot_hierarchy(uvm):
LOW	tests/integration_tests/security/test_jail.py	209	def test_arbitrary_usocket_location(uvm):
LOW	tests/integration_tests/security/test_jail.py	245	def enable_controller_in_subtree(self, cgname, controller):
LOW	tests/integration_tests/security/test_jail.py	372	def test_cgroups_custom_parent(uvm, cgroups_info):
LOW	tests/integration_tests/security/test_jail.py	427	def test_cgroups_without_numa(uvm, cgroups_info):
LOW	tests/integration_tests/security/test_jail.py	464	def test_cgroups_parent_cgroup_but_no_cgroup(
LOW	tests/integration_tests/security/test_jail.py	527	def test_args_default_resource_limits(uvm):
LOW	tests/integration_tests/security/test_jail.py	551	def test_args_resource_limits(uvm):
LOW	tests/integration_tests/security/test_jail.py	567	def test_positive_file_size_limit(uvm):
LOW	tests/integration_tests/security/test_jail.py	585	def test_negative_file_size_limit(uvm):
LOW	tests/integration_tests/security/test_jail.py	621	def test_negative_no_file_limit(uvm):
LOW	tests/integration_tests/security/test_jail.py	640	def test_new_pid_ns_resource_limits(uvm):
LOW	tests/integration_tests/security/test_jail.py	696	def test_firecracker_kill_by_pid(uvm, daemonize, new_pid_ns):
LOW	…sts/integration_tests/security/test_vulnerabilities.py	102	def download_spectre_meltdown_checker(tmp_path_factory):
LOW	…sts/integration_tests/security/test_vulnerabilities.py	116	def test_spectre_meltdown_checker_on_host(spectre_meltdown_checker):
LOW	…sts/integration_tests/security/test_vulnerabilities.py	127	def test_vulnerabilities_on_host():
LOW	…sts/integration_tests/security/test_vulnerabilities.py	134	def get_vuln_files_exception_dict(template):
LOW	…sts/integration_tests/security/test_vulnerabilities.py	167	def check_vulnerabilities_files_on_guest(microvm):
LOW	…sts/integration_tests/security/test_vulnerabilities.py	232	def test_check_vulnerability_files_ab(request, uvm_any):
LOW	…sts/integration_tests/security/test_vulnerabilities.py	246	def test_spectre_meltdown_checker_on_guest(
LOW	tests/integration_tests/security/test_nv.py	23	def test_no_nested_virtualization(uvm_booted):
LOW	tests/integration_tests/style/test_repo.py	15	def test_repo_no_spaces_in_paths():
LOW	tests/integration_tests/style/test_repo.py	39	def test_repo_validate_changelog():
LOW	tests/integration_tests/style/test_markdown.py	25	def test_markdown_internal_links():
LOW	tests/integration_tests/performance/test_boottime.py	70	def get_systemd_analyze_times(microvm):
LOW	tests/integration_tests/performance/test_boottime.py	101	def launch_vm_with_boot_timer(
LOW	…s/integration_tests/performance/test_hotplug_memory.py	255	def test_virtio_mem_hotplug_hotunplug(uvm_any_memhp):
LOW	…s/integration_tests/performance/test_hotplug_memory.py	313	def test_snapshot_restore_persistence(uvm, microvm_factory, snapshot_type):
LOW	…s/integration_tests/performance/test_hotplug_memory.py	353	def test_snapshot_restore_incremental(uvm, microvm_factory, snapshot_type):
LOW	…s/integration_tests/performance/test_hotplug_memory.py	474	def test_memory_hotplug_latency(
LOW	tests/integration_tests/performance/test_block.py	160	def test_block_vhost_user_performance(
LOW	tests/integration_tests/performance/test_vsock.py	99	def consume_vsock_ping_output(ping_output):
LOW	tests/integration_tests/performance/test_initrd.py	27	def test_microvm_initrd_with_serial(uvm_with_initrd, huge_pages):
LOW	tests/integration_tests/performance/test_network.py	98	def test_network_tcp_throughput(
LOW	…tegration_tests/performance/test_vhost_user_metrics.py	16	def test_vhost_user_block_metrics(uvm, vcpu_count, metrics):
LOW	tests/integration_tests/performance/test_steal_time.py	21	def test_pvtime_steal_time_increases(uvm):
LOW	…sts/integration_tests/performance/test_rate_limiter.py	97	def test_rx_rate_limiting_cpu_load(uvm):
LOW	…sts/integration_tests/performance/test_rate_limiter.py	235	def _check_tx_rate_limit_patch(test_microvm):
LOW	…sts/integration_tests/performance/test_rate_limiter.py	261	def _check_rx_rate_limit_patch(test_microvm):
LOW	…sts/integration_tests/performance/test_rate_limiter.py	337	def _start_iperf_server_on_guest(test_microvm):
LOW	…sts/integration_tests/performance/test_rate_limiter.py	354	def _start_iperf_server_on_host(netns_cmd_prefix):
LOW	tests/integration_tests/performance/test_snapshot.py	151	def test_post_restore_latency(
LOW	tests/integration_tests/performance/test_snapshot.py	264	def test_snapshot_create_latency(
LOW	tests/integration_tests/performance/test_pmem.py	155	def emit_fio_single_read_metrics(logs_dir, metrics):
LOW	tests/integration_tests/performance/test_balloon.py	51	def test_hinting_reporting_cpu(
LOW	tests/integration_tests/performance/test_balloon.py	131	def test_hinting_fault_latency(
LOW	…gration_tests/performance/test_process_startup_time.py	19	def test_startup_time_new_pid_ns(microvm_factory, guest_kernel, rootfs, metrics):
LOW	…gration_tests/performance/test_process_startup_time.py	31	def test_startup_time_daemonize(microvm_factory, guest_kernel, rootfs, metrics):
LOW	…gration_tests/performance/test_process_startup_time.py	42	def test_startup_time_custom_seccomp(microvm_factory, guest_kernel, rootfs, metrics):
LOW	tests/integration_tests/functional/test_rng.py	69	def assert_virtio_rng_is_current_hwrng_device(ssh_connection: SSHConnection):
131 more matches not shown…

Self-Referential Comments18 hits · 54 pts

Severity	File	Line	Snippet
MEDIUM	tools/release-tag.sh	12	# Create a tag for the specified release.
MEDIUM	resources/rebuild.sh	130	# Create a temporary branch where we can apply patches and then
MEDIUM	resources/rebuild.sh	305	# Create the directory in which we will store the kernels and rootfs
MEDIUM	tests/integration_tests/security/test_jail.py	487	# Create the parent cgroup.
MEDIUM	tests/integration_tests/performance/test_vsock.py	138	# Create a vsock device
MEDIUM	…/integration_tests/functional/test_net_config_space.py	32	# Create the control ssh connection.
MEDIUM	…/integration_tests/functional/test_drive_vhost_user.py	53	# Create a rw rootfs file that is unique to the microVM
MEDIUM	…/integration_tests/functional/test_drive_vhost_user.py	180	# Create a rw rootfs file that is unique to the microVM
MEDIUM	…/integration_tests/functional/test_drive_vhost_user.py	236	# Create a rootfs with partuuid unique to this microVM
MEDIUM	tests/integration_tests/functional/test_vsock.py	279	# Create a socat process in the guest which will connect to the host socat
MEDIUM	…sts/functional/test_snapshot_not_losing_dirty_pages.py	51	# Create a large file dynamically based on available space
MEDIUM	tests/integration_tests/functional/test_api.py	972	# Create a vsock device.
MEDIUM	tests/integration_tests/functional/test_api.py	1004	# Create a new entropy device should be OK.
MEDIUM	…ts/integration_tests/functional/test_snapshot_basic.py	158	# Create a snapshot from a microvm.
MEDIUM	tests/framework/utils.py	310	# Create the async process
MEDIUM	tests/framework/microvm.py	238	# Create the jailer context associated with this microvm.
MEDIUM	tests/host_tools/udp_offload.py	37	# Create a UDP socket
MEDIUM	tests/host_tools/network.py	276	# Create the tap device tap0 directly in the network namespace to avoid

Cross-Language Confusion5 hits · 25 pts

Severity	File	Line	Snippet
HIGH	tests/integration_tests/security/test_sec_audit.py	39	"cargo install --locked cargo-audit && cargo audit --deny warnings -q --json",
HIGH	…/integration_tests/functional/test_drive_vhost_user.py	305	mkfs_mount_cmd = "mkfs.ext4 /dev/vdb && mkdir -p /tmp/tmp && mount /dev/vdb /tmp/tmp && umount /tmp/tmp"
HIGH	tests/framework/utils.py	537	cmd = "cd ../src/firecracker && cargo pkgid \| cut -d# -f2 \| cut -d: -f2"
HIGH	.buildkite/pipeline_release_qa.py	69	"\| jq '(..\|select(.priority? != null).priority) += 100' "
HIGH	.buildkite/pipeline_pr.py	39	"./tools/devtool -y build_devctr && DEVCTR_IMAGE_TAG=latest ./tools/devtool test --no-build -- integration_tests

Deep Nesting21 hits · 21 pts

Severity	File	Line
LOW	tools/ab_plot.py	106
LOW	tools/ab_plot.py	184
LOW	tests/conftest.py	377
LOW	…ts/integration_tests/security/test_seccomp_validate.py	29
LOW	tests/integration_tests/functional/test_vsock.py	389
LOW	…tegration_tests/functional/test_cpu_features_x86_64.py	449
LOW	…tegration_tests/functional/test_cpu_features_x86_64.py	704
LOW	tests/framework/swagger_validator.py	52
LOW	tests/framework/swagger_validator.py	156
LOW	tests/framework/gitlint_rules.py	24
LOW	tests/framework/guest_stats.py	62
LOW	tests/framework/jailer.py	85
LOW	tests/framework/jailer.py	180
LOW	tests/framework/utils.py	378
LOW	tests/framework/microvm.py	591
LOW	tests/framework/static_analysis.py	441
LOW	tests/framework/utils_cpuid.py	103
LOW	tests/host_tools/fcmetrics.py	28
LOW	tests/host_tools/fcmetrics.py	437
LOW	.buildkite/pipeline_perf.py	176
LOW	.buildkite/common.py	305

Decorative Section Separators6 hits · 21 pts

Severity	File	Line	Snippet
MEDIUM	tests/conftest.py	537	# =============================================================================
MEDIUM	tests/conftest.py	539	# =============================================================================
MEDIUM	…sts/integration_tests/security/test_vulnerabilities.py	141	# =============================
MEDIUM	…sts/integration_tests/security/test_vulnerabilities.py	144	# --------------------------------------------
MEDIUM	src/vmm/src/logger/rate_limited.rs	16	//! ┌───────────────────┬────────────────────────────────────────┐
MEDIUM	src/vmm/src/logger/rate_limited.rs	18	//! └───────────────────┴────────────────────────────────────────┘

Hallucination Indicators2 hits · 20 pts

Severity	File	Line	Snippet
CRITICAL	src/vmm/src/devices/virtio/transport/pci/device.rs	576	let bar_offset: u32 = self.cap_pci_cfg_info.cap.cap.offset.into();
CRITICAL	src/vmm/src/devices/virtio/transport/pci/device.rs	601	let bar_offset: u32 = self.cap_pci_cfg_info.cap.cap.offset.into();

Redundant / Tautological Comments11 hits · 16 pts

Severity	File	Line	Snippet
LOW	tools/ab_plot.py	208	# Check if difference is significant
LOW	tests/integration_tests/performance/test_huge_pages.py	161	# Verify if guest can run commands, and also wake up the fast page fault helper to trigger page faults.
LOW	tests/integration_tests/functional/test_net.py	55	# Check if the high ingress traffic broke the net interface.
LOW	tests/integration_tests/functional/test_metrics.py	53	# Verify if guest can run commands.
LOW	tests/integration_tests/functional/test_error_code.py	35	# Check if FC process is closed
LOW	tests/integration_tests/functional/test_max_devices.py	54	# Verify if guest can run commands.
LOW	tests/integration_tests/functional/test_uffd.py	101	# Verify if the restored guest works.
LOW	tests/integration_tests/functional/test_uffd.py	107	# Verify if the restored guest works.
LOW	tests/integration_tests/functional/test_drive_virtio.py	49	# Check if reading from the entire disk results in a file of the same size
LOW	tests/integration_tests/functional/test_serial_io.py	180	# Check if the total memory size changed.
LOW	tests/framework/swagger_validator.py	176	# Check if it's a parameter placeholder or exact match

Excessive Try-Catch Wrapping11 hits · 12 pts

Severity	File	Line	Snippet
LOW	tests/framework/properties.py	123	except Exception:
LOW	tests/framework/utils_vsock.py	54	except Exception as err:
LOW	tests/framework/http_api.py	65	except Exception as e:
LOW	tests/framework/http_api.py	93	except Exception as e:
LOW	tests/framework/http_api.py	109	except Exception as e:
LOW	tests/framework/utils.py	74	except Exception as exc:
LOW	tests/framework/utils.py	83	except Exception as exc:
MEDIUM	tests/host_tools/udp_offload.py	57	eprint(f"Error sending message: {e}")
LOW	tests/host_tools/network.py	59	except Exception as exc:
LOW	tests/host_tools/network.py	149	except Exception:
LOW	tests/host_tools/network.py	225	except Exception as exc:

AI Slop Vocabulary4 hits · 10 pts

Severity	File	Line	Snippet
LOW	…ts/integration_tests/security/test_seccomp_validate.py	79	# We just add 1000000 to the allowed arg and assume it
MEDIUM	.github/codecov.yml	2	# We utilize optional statuses that are okay to fail, so
MEDIUM	src/vmm/src/vstate/vm.rs	734	// TODO: Once Host 5.10 goes out of support, we can make this more robust and work on
MEDIUM	src/firecracker/examples/uffd/uffd_utils.rs	80	// happening, but let's try to be a bit more robust and retry a few times

Fake / Example Data6 hits · 8 pts

Severity	File	Line	Snippet
LOW	tests/data/metadata.json	3	"meta-data": "Lorem ipsum dolor sit amet, consectetur adipiscing elit",
LOW	tests/data/metadata.json	3	"meta-data": "Lorem ipsum dolor sit amet, consectetur adipiscing elit",
LOW	tests/data/metadata.json	7	"meta-data": "Lorem ipsum dolor sit amet"
LOW	tests/data/metadata.json	7	"meta-data": "Lorem ipsum dolor sit amet"
LOW	tests/data/metadata_invalid.json	3	"meta-data": "Lorem ipsum dolor sit amet, consectetur adipiscing elit",
LOW	tests/data/metadata_invalid.json	3	"meta-data": "Lorem ipsum dolor sit amet, consectetur adipiscing elit",

Slop Phrases3 hits · 8 pts

Severity	File	Line	Snippet
MEDIUM	tests/pyproject.toml	29	# to run only the similarities checker, you can use "--disable=all
LOW	src/vmm/src/devices/virtio/balloon/util.rs	62	// Don't forget to push the last range to the result.
MEDIUM	src/firecracker/src/main.rs	134	// It's worth noting that the abort is caused by sending a SIG_ABORT signal to the process.

Verbosity Indicators1 hit · 2 pts

Severity	File	Line	Snippet
LOW	src/vmm/src/devices/virtio/queue.rs	991	// With firecracker's batching of used IRQs, we need to check if addition of the last

Score History

Severity Breakdown

Pattern Findings