facebook/zstd

Pattern Findings

300 matches across 9 categories. Click a row to expand file-level details.

Over-Commented Block235 hits · 228 pts

Severity	File	Line	Snippet
LOW	zlibWrapper/gzread.c	421	}
LOW	zlibWrapper/gzguts.h	21	#else
LOW	zlibWrapper/gzguts.h	41	#else
LOW	zlibWrapper/gzguts.h	61	# define NO_GZCOMPRESS
LOW	zlibWrapper/gzguts.h	81
LOW	zlibWrapper/gzguts.h	101	# endif
LOW	zlibWrapper/gzguts.h	121	# define local static
LOW	zlibWrapper/gzguts.h	141	# else
LOW	zlibWrapper/gzcompatibility.h	21	#else
LOW	zlibWrapper/gzcompatibility.h	41	#if defined(_WIN32) && !defined(Z_SOLO)
LOW	zlibWrapper/zstd_zlibwrapper.c	21	#include <stdarg.h> /* va_list, for z_gzprintf */
LOW	zlibWrapper/examples/example_original.c	21	*/
LOW	zlibWrapper/examples/zwrapbench.c	41	/-***********************************
LOW	zlibWrapper/examples/minigzip.c	21	#define _POSIX_SOURCE /* fileno */
LOW	zlibWrapper/examples/minigzip.c	41	# include <stdlib.h>
LOW	tests/paramgrill.c	21
LOW	tests/paramgrill.c	61	# define DEBUG 0
LOW	tests/fuzzer.c	21
LOW	tests/decodecorpus.c	21	#include "zstd.h"
LOW	tests/decodecorpus.c	161	* Constants and Structs
LOW	tests/zstreamtest.c	21
LOW	tests/DEPRECATED-test-zstd-speed.py	1	#! /usr/bin/env python3
LOW	tests/fullbench.c	21	#include <assert.h>
LOW	tests/roundTripCrash.c	21	#include <stddef.h> /* size_t */
LOW	tests/rateLimiter.py	1	#!/usr/bin/env python3
LOW	tests/gzip/mixed.sh	1	#!/bin/sh
LOW	tests/gzip/memcpy-abuse.sh	1	#!/bin/sh
LOW	tests/gzip/zdiff.sh	1	#!/bin/sh
LOW	tests/gzip/init.sh	1	# source this file; set up for tests
LOW	tests/gzip/init.sh	21	# The typical skeleton of a test looks like this:
LOW	tests/gzip/init.sh	41	#
LOW	tests/gzip/init.sh	61
LOW	tests/gzip/init.sh	121	NULLCMD=:
LOW	tests/gzip/init.sh	481	# As autoconf-generated configure scripts do, ensure that IFS
LOW	tests/gzip/init.sh	501	# Failing that, we'll roll our own mktemp-like function:
LOW	tests/gzip/trailing-nul.sh	1	#!/bin/sh
LOW	tests/gzip/help-version.sh	1	#! /bin/sh
LOW	tests/gzip/stdin.sh	1	#!/bin/sh
LOW	tests/gzip/zgrep-context.sh	1	#!/bin/sh
LOW	tests/gzip/znew-k.sh	1	#!/bin/sh
LOW	tests/gzip/zgrep-signal.sh	1	#!/bin/sh
LOW	tests/gzip/gzip-env.sh	1	#!/bin/sh
LOW	tests/gzip/null-suffix-clobber.sh	1	#!/bin/sh
LOW	tests/gzip/zgrep-f.sh	1	#!/bin/sh
LOW	tests/gzip/hufts.sh	1	#!/bin/sh
LOW	tests/gzip/z-suffix.sh	1	#!/bin/sh
LOW	tests/gzip/list.sh	1	#!/bin/sh
LOW	tests/gzip/keep.sh	1	#!/bin/sh
LOW	tests/gzip/unpack-invalid.sh	1	#!/bin/sh
LOW	tests/gzip/helin-segv.sh	1	#!/bin/sh
LOW	tests/gzip/test-driver.sh	1	#! /bin/sh
LOW	tests/gzip/test-driver.sh	141	# mode: shell-script
LOW	tests/fuzz/fuzz_helpers.h	21	#include "zstd.h"
LOW	tests/fuzz/fuzz_helpers.h	41	((cond) ? (void)0 \
LOW	contrib/pzstd/Pzstd.cpp	1	/*
LOW	contrib/pzstd/Pzstd.h	1	/*
LOW	contrib/pzstd/utils/Likely.h	21
LOW	contrib/linux-kernel/btrfs-benchmark.sh	1	# !/bin/sh
LOW	contrib/linux-kernel/btrfs-benchmark.sh	61	# none
LOW	contrib/linux-kernel/btrfs-benchmark.sh	81	# zstd 3
175 more matches not shown…

Fake / Example Data16 hits · 23 pts

Severity	File	Line	Snippet
LOW	tests/loremOut.h	12	* Generate @size bytes of compressible data using lorem ipsum generator into
LOW	tests/fullbench.c	933	* if @compressibility < 0.0, use Lorem Ipsum generator
LOW	tests/loremOut.c	12	* Generates a stream of Lorem ipsum paragraphs to stdout,
LOW	contrib/seekable_format/tests/seekable_tests.c	272	{ char const inBuffer[] = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididu
LOW	contrib/seekable_format/tests/seekable_tests.c	272	{ char const inBuffer[] = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididu
LOW	programs/lorem.h	11	/* lorem ipsum generator */
LOW	programs/lorem.h	17	* Generate @size bytes of compressible data using lorem ipsum generator
LOW	programs/benchzstd.h	128	* if @compressibility < 0.0, uses the lorem ipsum generator
LOW	programs/README.md	140	If no file is provided, the benchmark will use a procedurally generated "lorem ipsum" content.
LOW	programs/zstd.1.md	675	When no `FILE` is provided, the benchmark will use a procedurally generated `lorem ipsum` text.
LOW	programs/benchzstd.c	1004	name = "Lorem ipsum";
LOW	programs/lorem.c	13	* This is a very simple lorem ipsum generator
LOW	programs/lorem.c	20	* The resulting compression / ratio curve of the lorem ipsum generator
LOW	programs/lorem.c	25	* The compression ratio achievable on the generated lorem ipsum
LOW	programs/lorem.c	240	/* It's "common" for lorem ipsum generators to start with the same first
LOW	programs/zstdcli.c	906	double compressibility = -1.0; /* lorem ipsum generator */

Excessive Try-Catch Wrapping18 hits · 22 pts

Severity	File	Line	Snippet
LOW	tests/DEPRECATED-test-zstd-speed.py	74	except Exception:
LOW	tests/DEPRECATED-test-zstd-speed.py	370	except Exception as e:
MEDIUM	tests/DEPRECATED-test-zstd-speed.py	71	def does_command_exist(command):
LOW	tests/fuzz/fuzz.py	397	except Exception as e:
LOW	tests/fuzz/fuzz.py	583	except Exception as e:
LOW	tests/fuzz/fuzz.py	636	except Exception as e:
LOW	tests/fuzz/fuzz.py	660	except Exception as e:
LOW	tests/fuzz/fuzz.py	739	except Exception as e:
LOW	tests/fuzz/fuzz.py	814	except Exception as e:
LOW	tests/fuzz/fuzz.py	839	except Exception as e:
MEDIUM	tests/fuzz/fuzz.py	905	print("Error: No such command {} (pass -h for help)".format(command))
MEDIUM	tests/fuzz/fuzz.py	394	def build(args):
MEDIUM	tests/fuzz/fuzz.py	580	def libfuzzer_cmd(args):
MEDIUM	tests/fuzz/fuzz.py	633	def afl(args):
MEDIUM	tests/fuzz/fuzz.py	651	def regression(args):
MEDIUM	tests/fuzz/fuzz.py	736	def gen(args):
MEDIUM	tests/fuzz/fuzz.py	807	def minimize(args):
MEDIUM	tests/fuzz/fuzz.py	833	def zip_cmd(args):

Self-Referential Comments6 hits · 18 pts

Severity	File	Line	Snippet
MEDIUM	tests/gzip/init.cfg	1	# This file is sourced by init.sh, before its initialization.
MEDIUM	tests/gzip/init.sh	136	# The following code attempts to find a shell with support for these features.
MEDIUM	tests/gzip/init.sh	451	# Create an alias, FOO, for each FOO.exe in this directory.
MEDIUM	tests/gzip/init.sh	495	# Create a temporary directory, much like mktemp -d does.
MEDIUM	tests/gzip/help-version.sh	147	# Create a file in the current directory, not in $TMPDIR.
MEDIUM	tests/gzip/test-driver.sh	26	# This file is maintained in Automake, please report

Deep Nesting11 hits · 11 pts

Severity	File	Line
LOW	tests/automated_benchmarking.py	260
LOW	tests/test-license.py	136
LOW	tests/fuzz/fuzz.py	736
LOW	tests/cli-tests/run.py	132
LOW	tests/cli-tests/run.py	583
LOW	contrib/freestanding_lib/freestanding.py	115
LOW	contrib/freestanding_lib/freestanding.py	149
LOW	contrib/freestanding_lib/freestanding.py	261
LOW	contrib/freestanding_lib/freestanding.py	523
LOW	contrib/freestanding_lib/freestanding.py	573
LOW	contrib/freestanding_lib/freestanding.py	614

Cross-Language Confusion2 hits · 8 pts

Severity	File	Line	Snippet
HIGH	tests/automated_benchmarking.py	103	os.system("cd ../ && make -j && cd tests")
HIGH	contrib/freestanding_lib/freestanding.py	55	Handles && and \|\|.

Decorative Section Separators2 hits · 6 pts

Severity	File	Line	Snippet
MEDIUM	tests/gzip/init.sh	19	# =========================
MEDIUM	tests/gzip/init.sh	40	# ====================================

Unused Imports5 hits · 5 pts

Severity	File	Line
LOW	tests/check_size.py	13
LOW	tests/test-zstd-versions.py	19
LOW	tests/DEPRECATED-test-zstd-speed.py	20
LOW	tests/test-license.py	13
LOW	contrib/freestanding_lib/freestanding.py	13

Hyper-Verbose Identifiers5 hits · 5 pts

Severity	File	Line	Snippet
LOW	tests/automated_benchmarking.py	73	def get_builds_for_latest_hash():
LOW	tests/automated_benchmarking.py	145	def benchmark_dictionary_single(executable, filenames_directory, dictionary_filename, level, iterations):
LOW	tests/automated_benchmarking.py	172	def parse_regressions_and_labels(old_cspeed, new_cspeed, old_dspeed, new_dspeed, baseline_build, test_build):
LOW	tests/automated_benchmarking.py	221	def get_regressions_dictionary(baseline_build, test_build, filenames_directory, dictionary_filename, levels, iterations)
LOW	tests/DEPRECATED-test-zstd-speed.py	92	def send_email_with_attachments(branch, commit, last_commit, args, text, results_files,

Score History

Severity Breakdown

Pattern Findings