Build system, successor to Buck
This report summarizes scanner evidence for facebook/buck2, a Rust project with 4,465 GitHub stars. SynthScan examined 1,024,467 lines of code across 5654 source files, recording 3964 pattern matches distributed across 21 syntactic categories. The legacy adjusted pattern signal is 4.8 (Low pattern signal); it is not an authorship estimate.
Use the findings to ask whether maintainers can explain intent, verify dependencies, simplify unnecessary scaffolding, and focus review effort. Risk Payload v1 adds ownership, supply-chain, over-engineering, and review-effort vectors when available. These are prompts for human verification, not probabilities, security findings, or measured maintenance costs.
Use each vector to guide manual verification of the underlying findings.
Can maintainers explain intent, assumptions, and trade-offs? 3775 finding(s).
Are imports declared and package/API names verified? 106 finding(s).
Are wrappers, guards, and repeated structures necessary? 1835 finding(s).
Which changes need focused human review? 3964 finding(s).
This chart tracks the legacy adjusted pattern score across scan runs. Changes can reflect source changes, scan coverage, or detector/scoring versions; they do not measure AI adoption or prove that a team refactored code. Compare runs only when their scoring versions are compatible. The dashed line tracks the raw pattern-hit count.
Groups findings by configured severity weight. Severity is not a confidence estimate, security rating, or proof that a package is missing. Verify imports against the project's manifests and inspect each finding in its local design context.
This horizontal bar chart shows where configured pattern scores accumulate across directories. Treat the bars as locations to inspect, not as evidence of authorship or code quality. Use the file-level findings to decide whether a directory needs a focused ownership, dependency, complexity, or review check.
The scanner identified 3964 distinct pattern matches across 21 syntactic categories. Each entry below represents a discrete location in the source code where the engine recorded a detector match to inspect in context. Expand any category row to inspect the individual file paths, line numbers, code snippets, and the lexical context (CODE, COMMENT, or STRING) in which each match was detected.
Reading the findings table: The Severity column indicates the configured finding weight (CRITICAL / HIGH / MEDIUM / LOW). The Context column identifies whether the match occurred inside executable code, an inline comment, or a string literal — legacy comment-context matches receive a ×1.5 score weight. The ⚡ bolt icon marks clustered matches: three or more patterns within a 10-line window, each receiving an additional ×1.5 density multiplier under the legacy scoring model.
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | tools/starlark_fmt/lib/formatting.rs | 267 | def module_name_consistency_test(name, module): | CODE |
| LOW | …cam/js/src/components/invocation/useExpandedCommand.ts | 27 | function parseExpandedCommandArtifact(raw: string): string { | CODE |
| LOW | app/buck2_trailcam/js/src/lib/event-log-cache.ts | 464 | export async function writeCachedSummaryBatchesBulk( | CODE |
| LOW | app/buck2_trailcam/js/src/lib/critical-path.ts | 424 | export function parseCriticalPathFromBgInfo( | CODE |
| LOW | app/buck2_trailcam/js/src/lib/critical-path.ts | 478 | export async function extractCriticalPathDataAsync( | CODE |
| LOW | app/buck2_trailcam/js/src/lib/streaming-collectors.ts | 62 | function extractTargetLabelFromConfigured( | CODE |
| LOW | …buck2_interpreter_for_build/src/interpreter/testing.rs | 382 | def _assert_eq_ignore_hash_for_strings(a, b): | CODE |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/functions.rs | 119 | /// def _impl_get_path_without_materialization(ctx): | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/functions.rs | 170 | /// def _impl_get_paths_without_materialization(ctx): | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/functions.rs | 362 | /// def _impl_read_package_visibility(ctx): | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/functions.rs | 389 | /// def _impl_read_package_within_view(ctx): | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/functions.rs | 417 | /// def _impl_read_package_visibility_cap(ctx): | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/functions.rs | 445 | /// def _impl_read_package_visibility_intersection(ctx): | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/functions.rs | 479 | /// def _impl_read_package_within_view_cap(ctx): | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/uquery.rs | 478 | /// def _targets_in_buildfile_impl(ctx): | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/nodes/configured.rs | 483 | /// def _impl_resolved_attrs_lazy(ctx): | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/nodes/configured.rs | 512 | /// def _impl_resolved_attrs_eager(ctx): | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/nodes/configured.rs | 1064 | /// def _impl_resolved_attrs_lazy(ctx): | COMMENT |
| LOW | app/buck2_interpreter_for_build_tests/src/select.rs | 115 | def _test_concatenated_native(): | CODE |
| LOW | app/buck2_interpreter_for_build_tests/src/select.rs | 128 | def _test_concatenated_nested(): | CODE |
| LOW | starlark-rust/benchmark/benchmark.py | 38 | def benchmark_call_native_len(): | CODE |
| LOW⚡ | starlark-rust/starlark/src/typing/tests/callable.rs | 48 | def good_function_pos_or_named(x: str, y: int) -> None: | CODE |
| LOW⚡ | starlark-rust/starlark/src/typing/tests/callable.rs | 57 | def bad_function_missing_params(x: str) -> None: | CODE |
| LOW⚡ | starlark-rust/starlark/src/typing/tests/callable.rs | 60 | def bad_function_extra_params(x: str, y: int, z: int) -> None: | CODE |
| LOW | website/gen_docs.py | 58 | def generate_prelude_rules_docs(buck: str) -> None: | CODE |
| LOW | website/gen_docs.py | 106 | def generate_bxl_utils_api_docs(buck: str) -> None: | CODE |
| LOW⚡ | website/gen_docs.py | 163 | def generate_help_docs_subcommand(buck: str, args: List[str]) -> str: | CODE |
| LOW⚡ | website/gen_docs.py | 170 | def generate_subcommand_short_help(buck: str, args: List[str]) -> str: | CODE |
| LOW⚡ | website/gen_docs.py | 179 | def generate_help_docs_index_page(buck: str, subcommands: List[str]) -> str: | CODE |
| LOW | tests/core/interpreter/test_peak_allocated_bytes.py | 18 | async def test_peak_allocated_bytes(buck: Buck) -> None: | CODE |
| LOW⚡ | …rpreter/test_package_file_visibility_exempt_targets.py | 27 | async def test_off_mode_boundary_is_dormant(buck: Buck) -> None: | CODE |
| LOW⚡ | …rpreter/test_package_file_visibility_exempt_targets.py | 32 | async def test_enforce_mode_exempt_package_stays_visible(buck: Buck) -> None: | CODE |
| LOW⚡ | …rpreter/test_package_file_visibility_exempt_targets.py | 43 | async def test_audit_mode_reports_instead_of_failing(buck: Buck) -> None: | CODE |
| LOW⚡ | …rpreter/test_package_file_visibility_exempt_targets.py | 52 | async def test_exemption_does_not_weaken_ancestor_layer(buck: Buck) -> None: | CODE |
| LOW⚡ | …rpreter/test_package_file_visibility_exempt_targets.py | 60 | async def test_exemption_does_not_lift_inherited_default_visibility(buck: Buck) -> None: | CODE |
| LOW⚡ | …rpreter/test_package_file_visibility_exempt_targets.py | 69 | async def test_enforce_mode_nested_cell_inherits_parent_layer(buck: Buck) -> None: | CODE |
| LOW | …rpreter/test_package_file_visibility_exempt_targets.py | 90 | async def test_invalid_exemption_is_rejected( | CODE |
| LOW | …rpreter/test_package_file_visibility_exempt_targets.py | 100 | async def test_audit_visibility_lists_would_blocks(buck: Buck) -> None: | CODE |
| LOW | …rpreter/test_package_file_visibility_exempt_targets.py | 113 | async def test_audit_visibility_audit_mode_still_fails_real_violations( | CODE |
| LOW | tests/core/interpreter/test_infer_target_names.py | 23 | async def test_eponymous_dep_in_build_file_rejected_by_default(buck: Buck) -> None: | CODE |
| LOW | tests/core/interpreter/test_infer_target_names.py | 36 | async def test_eponymous_dep_in_build_file_inferred_when_enabled(buck: Buck) -> None: | CODE |
| LOW | tests/core/interpreter/test_infer_target_names.py | 44 | async def test_eponymous_source_in_build_file_rejected_by_default(buck: Buck) -> None: | CODE |
| LOW | tests/core/interpreter/test_infer_target_names.py | 55 | async def test_eponymous_source_in_build_file_inferred_when_enabled( | CODE |
| LOW | tests/core/interpreter/test_infer_target_names.py | 65 | async def test_eponymous_attr_default_in_bzl_rejected_by_default(buck: Buck) -> None: | CODE |
| LOW | tests/core/interpreter/test_infer_target_names.py | 79 | async def test_eponymous_attr_default_in_bzl_inferred_when_enabled( | CODE |
| LOW | tests/core/interpreter/test_cpu_instruction_count.py | 20 | async def test_cpu_instruction_count(buck: Buck) -> None: | CODE |
| LOW⚡ | …s/core/interpreter/test_package_file_package_values.py | 21 | async def test_package_file_package_values(buck: Buck) -> None: | CODE |
| LOW⚡ | …s/core/interpreter/test_package_file_package_values.py | 28 | async def test_audit_package_values(buck: Buck) -> None: | CODE |
| LOW⚡ | …s/core/interpreter/test_package_file_package_values.py | 37 | async def test_audit_package_values_select(buck: Buck) -> None: | CODE |
| LOW | …s/core/interpreter/test_package_file_package_values.py | 58 | async def test_audit_package_values_visibility_intersection( | CODE |
| LOW | …s/core/interpreter/test_package_file_package_values.py | 81 | async def test_audit_package_values_visibility_intersection_exempt( | CODE |
| LOW | …s/core/interpreter/test_package_file_package_values.py | 103 | async def test_targets_package_values(buck: Buck) -> None: | CODE |
| LOW | …s/core/interpreter/test_package_file_package_values.py | 112 | async def test_targets_package_values_regex(buck: Buck) -> None: | CODE |
| LOW | …s/core/interpreter/test_package_file_package_values.py | 166 | async def test_targets_streaming_package_values(buck: Buck) -> None: | CODE |
| LOW⚡ | tests/core/interpreter/test_relative_paths.py | 25 | async def test_relative_path_left_allowed_dir(buck: Buck) -> None: | CODE |
| LOW⚡ | tests/core/interpreter/test_relative_paths.py | 33 | async def test_relative_path_has_symlink(buck: Buck) -> None: | CODE |
| LOW⚡ | tests/core/interpreter/test_relative_paths.py | 42 | async def test_relative_path_in_attribute_default_current(buck: Buck) -> None: | CODE |
| LOW⚡ | tests/core/interpreter/test_relative_paths.py | 50 | async def test_relative_path_in_attribute_default_up(buck: Buck) -> None: | CODE |
| LOW | tests/core/interpreter/test_package_file_visibility.py | 17 | async def test_no_package_call_does_not_reset_visibility(buck: Buck) -> None: | CODE |
| LOW | tests/core/interpreter/test_package_file_alt_name.py | 19 | async def test_package_file_alt_name(buck: Buck) -> None: | CODE |
| 1687 more matches not shown… | ||||
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | rust-project.sh | 1 | #!/usr/bin/env bash | COMMENT |
| LOW | buck2.py | 1 | #!/usr/bin/env python3 | COMMENT |
| LOW | clippy.toml | 1 | # Copyright (c) Meta Platforms, Inc. and affiliates. | COMMENT |
| LOW | rust-toolchain.toml | 1 | [toolchain] | COMMENT |
| LOW | tools/starlark_fmt/lib/autofixes/sort_list_args.rs | 21 | //! blocklist (e.g., `genrule.srcs` where order may be significant). | COMMENT |
| LOW | tools/starlark_fmt/lib/autofixes/sort_dict_keys.rs | 21 | //! in a comment before or at the start of the dictionary literal: | COMMENT |
| LOW | tools/starlark_fmt/lib/autofixes/sort_dict_keys.rs | 521 | for stmt in stmts { | COMMENT |
| LOW | tools/starlark_fmt/lib/autofixes/sort_kwargs.rs | 21 | //! rust_library( | COMMENT |
| LOW | tools/starlark_fmt/lib/autofixes/sort_kwargs.rs | 121 | COMMENT | |
| LOW | tools/starlark_fmt/lib/autofixes/sort_kwargs.rs | 481 | #[test] | COMMENT |
| LOW | tools/starlark_fmt/lib/autofixes/unused_loads.rs | 21 | //! "Type", # @unused | COMMENT |
| LOW | tools/starlark_fmt/lib/autofixes/unused_loads.rs | 81 | for comment_text in module.comments_in_range(search_range) { | COMMENT |
| LOW | tools/starlark_fmt/lib/autofixes/utils.rs | 81 | } | COMMENT |
| LOW | tools/starlark_fmt/lib/autofixes/utils.rs | 181 | /// `"z": 1`), producing source that fails to re-parse. | COMMENT |
| LOW | tools/starlark_fmt/lib/formatting/join_plus_call.rs | 41 | /// How many `+` BinOps deep we are. Only `+` BinOps increment this | COMMENT |
| LOW | host_sharing/src/host_sharing.rs | 21 | COMMENT | |
| LOW | app/buck2_cli_proto/src/lib.rs | 201 | macro_rules! define_request { | COMMENT |
| LOW | app/buck2_file_watcher/src/watchman/core.rs | 61 | enum WatchmanClientError { | COMMENT |
| LOW | app/buck2_file_watcher/src/watchman/core.rs | 321 | watchman_version: Option<String>, | COMMENT |
| LOW | app/buck2_file_watcher/src/edenfs/interface.rs | 741 | FileSystemBaseline, | COMMENT |
| LOW | app/buck2_file_watcher/src/edenfs/sapling.rs | 321 | } | COMMENT |
| LOW | app/buck2_cmd_debug_client/src/heap_dump.rs | 21 | use buck2_client_ctx::events_ctx::EventsCtx; | COMMENT |
| LOW | app/buck2_cmd_debug_client/src/paranoid.rs | 21 | /// Configure paranoid mode. | COMMENT |
| LOW | app/buck2_cmd_debug_client/src/anon_targets.rs | 21 | use buck2_client_ctx::common::target_cfg::TargetCfgOptions; | COMMENT |
| LOW | app/buck2_cmd_debug_client/src/trace_io.rs | 41 | /// Enable I/O tracing in the buck daemon so we keep track of which files | COMMENT |
| LOW | app/buck2_build_signals_impl/src/lib.rs | 821 | // is how we discovered its existence. | COMMENT |
| LOW | …lcam/js/src/components/invocation/EventLogProvider.tsx | 521 | }); | COMMENT |
| LOW | …k2_trailcam/js/src/lib/parallel-decode/orchestrator.ts | 221 | onMessage({type: 'error', message: 'ParallelDecoder already terminated'}); | COMMENT |
| LOW | …trailcam/js/src/lib/parallel-decode/dispatch-worker.ts | 61 | else (self as unknown as Worker).postMessage(msg); | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 101 | { | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 121 | let path = AbsPath::new(p.as_ref())?; | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 141 | /// } else { | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 181 | /// Some(AbsNormPath::new("/")?), | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 201 | /// | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 221 | /// let path = AbsNormPath::new(r"C:\test\foo\bar.txt")?; | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 241 | /// shared_path.strip_prefix(AbsNormPath::new(r"\\server\share\")?)?, | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 301 | /// let abs_path = AbsNormPath::new("/some/foo")?; | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 341 | } | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 361 | /// # buck2_error::Ok(()) | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 381 | /// .join_normalized("../../baz.txt") | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 441 | #[cfg(windows)] | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 501 | #[cfg(windows)] | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 521 | /// assert_eq!( | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 621 | COMMENT | |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 661 | /// no allocation conversion | COMMENT |
| LOW | app/buck2_fs/src/paths/abs_norm_path.rs | 701 | /// ``` | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 181 | /// | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 201 | /// assert!(ForwardRelativePath::new(Path::new("normalize\\bar")).is_err()); | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 241 | COMMENT | |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 301 | /// Some(ForwardRelativePath::new("foo")?), | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 321 | } else { | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 341 | /// Some(FileName::unchecked_new("bin")), | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 401 | } | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 421 | /// ); | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 501 | } else { | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 521 | let path = self.as_str(); | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 541 | /// # buck2_error::Ok(()) | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 561 | /// ``` | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 581 | } | COMMENT |
| LOW | app/buck2_fs/src/paths/forward_rel_path.rs | 621 | } | COMMENT |
| 1611 more matches not shown… | ||||
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| CRITICAL | app/buck2_server/src/ctx.rs | 908 | self.cmd_ctx.base_context.daemon.memory_tracker.is_some(), | CODE |
| CRITICAL⚡ | app/buck2_server/src/ctx.rs | 1051 | self.cmd_ctx.base_context.daemon.forkserver.dupe(), | CODE |
| CRITICAL⚡ | app/buck2_server/src/ctx.rs | 1061 | self.cmd_ctx.base_context.daemon.memory_tracker.dupe(), | CODE |
| CRITICAL⚡ | app/buck2_server/src/ctx.rs | 1064 | self.cmd_ctx.base_context.daemon.daemon_id.dupe(), | CODE |
| CRITICAL⚡ | app/buck2_server/src/ctx.rs | 1067 | data.set_http_client(self.cmd_ctx.base_context.daemon.http_client.dupe()); | CODE |
| CRITICAL | app/buck2_server/src/ctx.rs | 1106 | data.spawner = self.cmd_ctx.base_context.daemon.spawner.dupe(); | CODE |
| CRITICAL | …/java/abi/source/TreeBackedAnnotatedConstructTest.java | 72 | "@com.facebook.buck.jvm.java.abi.source.AnnotationWithSingleClassForTreeBackedTest(single" | CODE |
| CRITICAL | …/java/abi/source/TreeBackedAnnotatedConstructTest.java | 100 | "@com.facebook.buck.jvm.java.abi.source.AnnotationWithClassArrayForTreeBackedTest(multi" | CODE |
| CRITICAL | …/java/abi/source/TreeBackedAnnotatedConstructTest.java | 127 | "@com.facebook.buck.jvm.java.abi.source.AnnotationWithSingleClassForTreeBackedTest(single" | CODE |
| CRITICAL | …/java/abi/source/TreeBackedAnnotatedConstructTest.java | 163 | "@com.facebook.buck.jvm.java.abi.source.AnnotationWithClassArrayForTreeBackedTest(multi" | CODE |
| CRITICAL | …serialization/kotlin/ActionMetadataSerializerTest.java | 57 | return com.facebook.buck.cd.model.kotlin.ActionMetadata.newBuilder() | CODE |
| CRITICAL | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 34 | com.facebook.buck.cd.model.java.BaseJarCommand.newBuilder() | CODE |
| CRITICAL | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 56 | com.facebook.buck.cd.model.java.BaseJarCommand.newBuilder() | CODE |
| CRITICAL | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 73 | com.facebook.buck.cd.model.java.BaseJarCommand.newBuilder() | CODE |
| CRITICAL | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 83 | com.facebook.buck.cd.model.java.BaseJarCommand.newBuilder() | CODE |
| CRITICAL | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 94 | com.facebook.buck.cd.model.java.BaseJarCommand.newBuilder() | CODE |
| CRITICAL | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 105 | com.facebook.buck.cd.model.java.JarParameters.newBuilder() | CODE |
| CRITICAL | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 150 | com.facebook.buck.cd.model.kotlin.KotlinExtraParams.newBuilder() | CODE |
| CRITICAL⚡ | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 184 | com.facebook.buck.cd.model.java.BaseJarCommand.newBuilder() | CODE |
| CRITICAL⚡ | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 186 | com.facebook.buck.cd.model.java.BuildTargetValue.newBuilder().setType(type)) | CODE |
| CRITICAL⚡ | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 189 | com.facebook.buck.cd.model.java.JarParameters.newBuilder().setJarPath("out.jar")) | CODE |
| CRITICAL⚡ | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 191 | com.facebook.buck.cd.model.common.RelPathMapEntry.newBuilder() | CODE |
| CRITICAL | …/serialization/kotlin/CompilerCommandDefaultsTest.java | 211 | com.facebook.buck.cd.model.kotlin.KotlinExtraParams.newBuilder() | CODE |
| CRITICAL | …d/src/com/facebook/buck/jvm/java/ClasspathChecker.java | 113 | com.google.common.io.Files.getFileExtension( | CODE |
| CRITICAL | …k/jvm/java/stepsbuilder/javacd/main/JavaCDCommand.java | 62 | com.facebook.buck.cd.model.java.BuildJavaCommand.newBuilder(); | CODE |
| CRITICAL | …n/src/main/kotlin/compose/ClassStabilityTransformer.kt | 206 | symbol = org.jetbrains.kotlin.ir.symbols.impl.IrFieldSymbolImpl(), | CODE |
| CRITICAL | …i-gen/src/main/kotlin/compose/ComposerParamInjector.kt | 192 | symbol = org.jetbrains.kotlin.ir.symbols.impl.IrValueParameterSymbolImpl(), | CODE |
| CRITICAL | …i-gen/src/main/kotlin/compose/ComposerParamInjector.kt | 215 | symbol = org.jetbrains.kotlin.ir.symbols.impl.IrValueParameterSymbolImpl(), | CODE |
| CRITICAL | …i-gen/src/main/kotlin/compose/ComposerParamInjector.kt | 239 | symbol = org.jetbrains.kotlin.ir.symbols.impl.IrValueParameterSymbolImpl(), | CODE |
| CRITICAL | …ook/buck/jvm/kotlin/cd/workertool/KotlinCDCommand.java | 108 | com.facebook.buck.cd.model.kotlin.BuildKotlinCommand.newBuilder(); | CODE |
| CRITICAL | …ook/buck/jvm/kotlin/cd/workertool/KotlinCDCommand.java | 159 | com.facebook.buck.cd.model.kotlin.ActionMetadata.newBuilder(); | CODE |
| CRITICAL | …/buck/android/resources/MergeAssetsExecutableMain.java | 117 | com.google.common.io.Files.hash(outputApkPath.toFile(), Hashing.sha1()).toString()); | CODE |
| CRITICAL | …roid/resources/ExoResourcesRewriterExecutableMain.java | 72 | com.google.common.io.Files.hash(Paths.get(exoResources).toFile(), Hashing.sha1()) | CODE |
| CRITICAL | …ebook/buck/android/exopackage/ExopackageInstaller.java | 574 | com.google.common.io.Files.write( | CODE |
| CRITICAL⚡ | …com/facebook/buck/android/exopackage/DexExoHelper.java | 94 | com.google.common.io.Files.toString(dexInfo.getMetadata().toFile(), StandardCharsets.UTF_8); | CODE |
| CRITICAL⚡ | …com/facebook/buck/android/exopackage/DexExoHelper.java | 98 | return com.google.common.io.Files.toString( | CODE |
| CRITICAL⚡ | …com/facebook/buck/android/exopackage/DexExoHelper.java | 105 | return com.google.common.io.Files.toString( | CODE |
| CRITICAL | …droid/src/com/facebook/buck/android/aapt/MiniAapt.java | 508 | com.google.common.io.Files.getFileExtension( | CODE |
| CRITICAL | …android/src/com/facebook/buck/android/dex/D8Utils.java | 248 | com.android.tools.r8.D8.run(d8Command); | CODE |
| CRITICAL | …android/src/com/facebook/buck/android/dex/D8Utils.java | 372 | com.google.common.io.Files.hash(secondaryDexPath.toFile(), Hashing.sha1()).toString(), | CODE |
| CRITICAL | …roid/src/com/facebook/buck/installer/InstallError.java | 60 | return com.facebook.buck.install.model.ErrorDetail.newBuilder() | CODE |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| MEDIUM | app/buck2_interpreter_for_build/src/plugins.rs | 229 | /// # Define a plugin kind for Rust proc macros | COMMENT |
| MEDIUM | …k2_action_impl/src/dynamic/dynamic_actions_callable.rs | 259 | /// # Create a DynamicActionsCallable | COMMENT |
| MEDIUM | app/buck2_daemon/src/daemon.rs | 208 | # This file is a cache directory tag created by Buck2. | COMMENT |
| MEDIUM | …reter/rule_defs/provider/builtin/configuration_info.rs | 435 | /// # Create a copy and modify it without affecting the original | COMMENT |
| MEDIUM | pagable/src/pagable_arc.rs | 148 | /// # Creating a PagableArc | COMMENT |
| MEDIUM | pagable/src/pagable_arc.rs | 482 | /// # Creating a PinnedPagableArc | COMMENT |
| MEDIUM | …lues_data/targets-streaming-package-values.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …e_package_values_data/audit-package-values.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …package_values_data/targets-package-values.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …ata/audit-package-values-missing-buck-file.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …_cell_data/audit-package-values-cross-cell.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …sibility_from_package_data/override/golden.uquery.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …visibility_from_package_data/simple/golden.uquery.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …isibility_from_package_data/inherit/golden.uquery.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …visibility_from_package_data/public/golden.uquery.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | tests/core/materializer/test_clean_stale.py | 331 | # Create a new daemon and build something else (could be any command that starts a daemon). | STRING |
| MEDIUM | tests/core/materializer/test_clean_stale.py | 381 | # Create a new daemon and build something else (could be any command that starts a daemon). | STRING |
| MEDIUM | tests/core/docs/test_docs_data/prelude_docs.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …l/test_dynamic_data/happy_path_dynamic_ctx.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | tests/core/common/io/file_watcher_scm_tests.py | 31 | # Create a file | COMMENT |
| MEDIUM | tests/core/common/io/file_watcher_scm_tests.py | 43 | # Create a file | COMMENT |
| MEDIUM | tests/core/common/io/file_watcher_scm_tests.py | 52 | # Create a file | COMMENT |
| MEDIUM⚡ | tests/core/common/io/file_watcher_scm_tests.py | 75 | # Create a file | COMMENT |
| MEDIUM⚡ | tests/core/common/io/file_watcher_scm_tests.py | 84 | # Create a file | COMMENT |
| MEDIUM | …argets_data/json/golden.deeply_nested_subs_of_sub.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …dit_subtargets_data/json/golden.has_no_subtargets.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …t_subtargets_data/json/golden.deeply_nested_basic.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …dit/test_audit_subtargets_data/json/golden.nested.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …udit/test_audit_subtargets_data/json/golden.basic.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …log/test_user_event_log_data/instant_event.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …/log/test_user_event_log_data/action_event.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …e/query/aquery/test_aquery_data/bxl_target.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …/core/query/aquery/test_aquery_data/target.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …ry/aquery/test_aquery_data/bxl_all_outputs.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …test_aquery_data/bxl_all_outputs_subtarget.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …ore/query/aquery/test_aquery_data/bxl_deps.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …ts/core/query/aquery/test_aquery_data/deps.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …ery/test_aquery_data/all_outputs_subtarget.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …ore/query/aquery/test_aquery_data/bxl_eval.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …/query/aquery/test_aquery_data/all_actions.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …s/core/query/aquery/test_aquery_data/rdeps.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …/query/aquery/test_aquery_data/all_outputs.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …e/query/aquery/test_aquery_data/bxl_filter.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …/core/query/aquery/test_aquery_data/filter.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …query/aquery/test_aquery_data/deps_bounded.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …ry/aquery/test_aquery_data/bxl_all_actions.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …/multi_query_universe/multi_query_universe.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …a/unsorted/multi_query_print_provider_json.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …ry_data/unsorted/query_print_provider_json.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …nd/test_target_metadata_data/test_metadata.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …ets_data/anon_targets_json_with_requesters.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | …targets_data/anon_targets_basic_attributes.golden.json | 1 | # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test comm | COMMENT |
| MEDIUM | tests/e2e_util/buck_workspace.py | 135 | # Create a temporary file to store all lines of extra buck config values. | COMMENT |
| MEDIUM | tests/e2e_util/helper/golden.py | 23 | f"# This file is {'@'}generated, " | CODE |
| MEDIUM | tests/e2e_util/helper/golden.py | 348 | # Create a new dict where the keys are 1 + a large number | COMMENT |
| MEDIUM | shim/third-party/rust/Cargo.toml | 10 | # This file is **not** used by cargo build of buck2. | COMMENT |
| MEDIUM | prelude/apple/tools/make_modulemap.py | 113 | # Create a tree of nested modules, one for each path component. | COMMENT |
| MEDIUM | …elude/apple/tools/info_plist_processor/process_test.py | 274 | # Create a temporary plist file to merge | COMMENT |
| MEDIUM⚡ | …elude/apple/tools/info_plist_processor/process_test.py | 329 | # Create a temporary plist file to merge with nested list of dicts | COMMENT |
| MEDIUM | …elude/apple/tools/info_plist_processor/process_test.py | 375 | # Create a non-trivial plist_data structure with nested dictionaries and arrays | COMMENT |
| 4 more matches not shown… | ||||
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | app/buck2_test/src/internal_runner.rs | 69 | // Step 1: Execute listing using the dedicated listing command | COMMENT |
| LOW⚡ | app/buck2_test/src/internal_runner.rs | 119 | // Step 2: Parse listing output via Starlark callback | COMMENT |
| LOW⚡ | app/buck2_test/src/internal_runner.rs | 124 | // Step 3: Report discovered tests | COMMENT |
| LOW⚡ | app/buck2_action_impl/src/context/dynamic_output.rs | 227 | /// # Step 1: Define the implementation function | COMMENT |
| LOW⚡ | app/buck2_action_impl/src/context/dynamic_output.rs | 236 | /// # Step 2: Create a factory | COMMENT |
| LOW⚡ | app/buck2_action_impl/src/context/unsorted.rs | 143 | /// # Step 1: Create a unique tag for tracking header dependencies | COMMENT |
| LOW⚡ | app/buck2_action_impl/src/context/unsorted.rs | 151 | /// # Step 2: Tag the inputs and depfile output | COMMENT |
| LOW⚡ | app/buck2_action_impl/src/context/unsorted.rs | 160 | /// # Step 3: Associate the tag with the "headers" label | COMMENT |
| LOW | app/buck2_build_api/src/configure_targets.rs | 34 | // NOTE: This function returns Result<(..., Vec<Error>)> to support keep-going: | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 69 | # Step 1: Run the test with a failure. TPX_PLAYGROUND_FAIL makes the | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 84 | # Step 2: Verify the report was written and contains the individual test | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 95 | # Step 3: Feed the report back as a BRR retry input (still with the | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 113 | # Step 4: The retry must actually run the test (not silently filter it | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 153 | # Step 1: Run with TPX_PLAYGROUND_FAIL=1 to get a failure. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_unmanaged_retry.py | 166 | # Step 2: Verify the report has the individual test name. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_unmanaged_retry.py | 173 | # Step 3: Feed the report back WITHOUT TPX_PLAYGROUND_FAIL — the test | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 190 | # Step 4: The retry must have produced a result — not "NO TESTS RAN". | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 218 | # Step 1: Run the test normally to get a valid run_id from the test infra | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 224 | # Step 2: Create BRR file with suite-level "- main" entry, simulating a | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 295 | # Step 1: Run the unmanaged type-check target normally to get a valid run_id. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 301 | # Step 2: BRR file with a real existing unmanaged entry plus a synthetic new | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 570 | # Step 1: a normal run of the real target just to get a valid run_id. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 577 | # Step 2: BRR file naming a `- unmanaged` entry for a target that does not | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 665 | # Step 2: Verify the report was written and contains a "- main" entry. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 672 | # Step 3: Feed the report back as a BRR retry input, saving the retry | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 807 | # Step 2: Verify the report has "- listing". | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 814 | # Step 3: Feed the report back WITHOUT TPX_PLAYGROUND_FATAL — listing | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 829 | # Step 4: Execution is suppressed for listing-only targets. Listing | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 865 | # Step 2: Verify the report contains a "- listing" entry. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 872 | # Step 3: Feed the report back with --list-only (simulating Citadel | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 911 | # Step 1: Run with TPX_PLAYGROUND_FATAL=1 to make listing crash. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 926 | # Step 2: Verify the report has "- listing". | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 933 | # Step 3: Feed the report back with --list-only WITHOUT | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 967 | # Step 1: Run with TPX_PLAYGROUND_FATAL=1 to make listing crash. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 982 | # Step 2: Verify the report has "- listing". | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 989 | # Step 3: Feed the report back WITHOUT --list-only and WITHOUT | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 1004 | # Step 4: TPX must suppress execution for listing-only targets even | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 241 | # Step 3: Run with BRR retry — the fix converts "- main" to a prefix | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 257 | # Step 4: Assert tests actually ran (before the fix, this was "NO TESTS RAN") | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 320 | # Step 3: Base-revision retry with new-test detection enabled, capturing the | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 385 | # Step 1: target run — the unmanaged test FAILS on demand. Capture its run_id. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 396 | # Step 2: BRR file naming the suite-level `- unmanaged` entry that failed. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 416 | # Step 3: base-revision retry — still failing on base (BRR_SIM_FAIL=1). | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 485 | # Step 1: target run — the labeled unmanaged test FAILS on demand. Capture run_id. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 496 | # Step 2: BRR file naming the suite-level `- unmanaged` entry that failed. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 516 | # Step 3: base-revision retry — still failing on base (BRR_SIM_FAIL=1). | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 598 | # Step 3: base-revision retry with new-test detection enabled. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 649 | # Step 1: Run the broken run_as_bundle target and save the failure report. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 689 | # Step 4: The retry must reproduce the failure. Verify by | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 719 | # Step 1: Run the broken listing target and save the failure report. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 736 | # Step 2: Verify the report was written and contains a "- listing" entry. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 749 | # Step 3: Feed the report back as a BRR retry input, saving the retry | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 766 | # Step 4: The retry must reproduce the listing failure. Verify by | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 792 | # Step 1: Run with TPX_PLAYGROUND_FATAL=1 to make listing crash. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 850 | # Step 1: Run the broken listing target and save the failure report. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 891 | # Step 4: The retry must reproduce the listing failure with --list-only. | COMMENT |
| LOW | .claude/skills/buck2-rule-basics/SKILL.md | 144 | ### Step 0: Setup | COMMENT |
| LOW | .claude/skills/buck2-rule-basics/SKILL.md | 202 | ### Step 1: Create the Minimal Rule Stub | COMMENT |
| LOW | .claude/skills/buck2-rule-basics/SKILL.md | 262 | ### Step 2: Add Source File Attribute | COMMENT |
| LOW | .claude/skills/buck2-rule-basics/SKILL.md | 330 | ### Step 3: Declare Output Artifact | COMMENT |
| 33 more matches not shown… | ||||
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| HIGH | …l_api/test_incremental_remote_action_data/increment.py | 84 | except FileExistsError: | CODE |
| HIGH | tests/core/daemon/test_concurrency.py | 42 | except FileNotFoundError: | CODE |
| HIGH | tests/core/executor/test_cancellation.py | 72 | except OSError: | CODE |
| HIGH | tests/e2e_util/api/lsp.py | 43 | except ProcessLookupError: | CODE |
| HIGH | tests/e2e_util/api/lsp.py | 161 | except (IndexError, ValueError): | CODE |
| HIGH | tests/e2e/test/test_brr_suite_level_retry.py | 335 | except BuckException: | CODE |
| HIGH | tests/e2e/test/test_brr_suite_level_retry.py | 662 | except BuckException: | CODE |
| HIGH | tests/e2e/test/test_brr_suite_level_retry.py | 686 | except BuckException: | CODE |
| HIGH | tests/e2e/test/test_brr_suite_level_retry.py | 733 | except BuckException: | CODE |
| HIGH | tests/e2e/test/test_brr_suite_level_retry.py | 763 | except BuckException: | CODE |
| HIGH | tests/e2e/test/test_brr_suite_level_retry.py | 804 | except BuckException: | CODE |
| HIGH | tests/e2e/test/test_brr_suite_level_retry.py | 862 | except BuckException: | CODE |
| HIGH | tests/e2e/test/test_brr_suite_level_retry.py | 888 | except BuckException: | CODE |
| HIGH | tests/e2e/test/test_brr_suite_level_retry.py | 923 | except BuckException: | CODE |
| HIGH | tests/e2e/test/test_brr_suite_level_retry.py | 979 | except BuckException: | CODE |
| HIGH | tests/e2e/test/test_test_inplace.py | 714 | except OSError: | CODE |
| HIGH | prelude/apple/tools/info_plist_processor/process.py | 66 | except OSError: | CODE |
| HIGH | prelude/apple/tools/resource_broker/utils.py | 25 | except json.JSONDecodeError: | CODE |
| HIGH | prelude/python/tools/make_par/sitecustomize.py | 307 | except OSError: | CODE |
| HIGH | prelude/python/tools/make_par/sitecustomize.py | 455 | except OSError: | CODE |
| HIGH | prelude/python/tools/make_par/sitecustomize.py | 476 | except OSError: | CODE |
| HIGH | prelude/cxx/dist_lto/tools/dist_lto_opt_gnu.py | 311 | except IOError: | CODE |
| HIGH | prelude/cxx/tools/stub_header_unit.py | 107 | except OSError: | CODE |
| HIGH | prelude/cxx/tools/stub_header_unit.py | 160 | except OSError: | CODE |
| HIGH | prelude/cxx/tools/stderr_to_file.py | 68 | except asyncio.InvalidStateError: | CODE |
| HIGH | …/com/facebook/buck/jvm/java/testdata/prebuilt/unzip.py | 20 | except Exception: | CODE |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | app/buck2_trailcam/build_bundle.py | 43 | CODE | |
| LOW | website/gen_docs.py | 149 | CODE | |
| LOW | tests/core/resource_control/test_action_suspension.py | 50 | CODE | |
| LOW | tests/core/completion/test_completion.py | 26 | CODE | |
| LOW | tests/core/completion/test_completion.py | 41 | CODE | |
| LOW | tests/core/profile/test_profile.py | 331 | CODE | |
| LOW | tests/core/profile/test_profile.py | 368 | CODE | |
| LOW | tests/core/targets_command/test_targets_imports_toml.py | 19 | CODE | |
| LOW | tests/core/targets_command/test_targets_imports_json.py | 19 | CODE | |
| LOW | tests/core/targets_command/test_targets_imports.py | 19 | CODE | |
| LOW | tests/e2e_util/buck_workspace.py | 63 | CODE | |
| LOW | tests/e2e_util/buck_workspace.py | 480 | CODE | |
| LOW | tests/e2e_util/api/fixtures.py | 120 | CODE | |
| LOW | tests/e2e/test/test_configs.py | 260 | CODE | |
| LOW | tests/e2e/fdb/types.py | 32 | CODE | |
| LOW | tests/e2e/targets_command/test_targets.py | 152 | CODE | |
| LOW | docs/developers/perf/scripts/heap_aggregate.py | 101 | CODE | |
| LOW | docs/developers/perf/scripts/heap_aggregate.py | 180 | CODE | |
| LOW | docs/developers/perf/scripts/heap_diff.py | 89 | CODE | |
| LOW | docs/developers/perf/scripts/frag_symbolize.py | 163 | CODE | |
| LOW | docs/developers/perf/scripts/heap_stacks.py | 130 | CODE | |
| LOW | prelude/apple/tools/swift_exec.py | 262 | CODE | |
| LOW | prelude/apple/tools/make_swift_interface.py | 126 | CODE | |
| LOW | prelude/apple/tools/make_swift_comp_db.py | 22 | CODE | |
| LOW | prelude/apple/tools/info_plist_processor/process.py | 19 | CODE | |
| LOW | prelude/apple/tools/info_plist_processor/process.py | 40 | CODE | |
| LOW | prelude/apple/tools/info_plist_processor/process.py | 72 | CODE | |
| LOW | prelude/apple/tools/info_plist_processor/process.py | 215 | CODE | |
| LOW | prelude/apple/tools/selective_debugging/macho_parser.py | 59 | CODE | |
| LOW | …elude/apple/tools/selective_debugging/scrubber_test.py | 288 | CODE | |
| LOW | …ools/code_signing/prepare_code_signing_entitlements.py | 23 | CODE | |
| LOW | prelude/apple/tools/index/merge_index_store.py | 77 | CODE | |
| LOW | prelude/apple/tools/bundling/incremental_state.py | 97 | CODE | |
| LOW | prelude/apple/tools/bundling/signing_context.py | 178 | CODE | |
| LOW | prelude/python/tools/__test_main__.py | 695 | CODE | |
| LOW | prelude/python/tools/make_py_package_modules.py | 74 | CODE | |
| LOW | prelude/python/tools/make_py_package_modules.py | 189 | CODE | |
| LOW | prelude/python/tools/make_py_package_modules.py | 283 | CODE | |
| LOW | prelude/python/tools/create_link_tree.py | 16 | CODE | |
| LOW | prelude/python/tools/compile.py | 79 | CODE | |
| LOW | prelude/python/tools/compile.py | 136 | CODE | |
| LOW | prelude/python/tools/extract.py | 61 | CODE | |
| LOW | prelude/python/tools/extract.py | 97 | CODE | |
| LOW | prelude/python/tools/wheel.py | 186 | CODE | |
| LOW | prelude/python/tools/make_py_package_manifest_module.py | 78 | CODE | |
| LOW | prelude/python/tools/make_par/sitecustomize.py | 26 | CODE | |
| LOW | prelude/python/tools/make_par/sitecustomize.py | 301 | CODE | |
| LOW | prelude/python/tools/make_par/sitecustomize.py | 31 | CODE | |
| LOW | prelude/python/tools/make_par/live_builder.py | 54 | CODE | |
| LOW | prelude/go_bootstrap/tools/go_wrapper.py | 19 | CODE | |
| LOW | prelude/js/worker_runner/worker_tool_runner.py | 391 | CODE | |
| LOW | prelude/js/worker_runner/worker_tool_runner.py | 425 | CODE | |
| LOW | prelude/rust/tools/shared_libraries_symlink_tree.py | 68 | CODE | |
| LOW | prelude/rust/tools/rustc_action.py | 251 | CODE | |
| LOW | prelude/rust/tools/rustc_action.py | 324 | CODE | |
| LOW | prelude/rust/tools/rustc_action.py | 405 | CODE | |
| LOW | prelude/rust/tools/failure_filter_action.py | 54 | CODE | |
| LOW | prelude/rust/tools/extract_link_action.py | 85 | CODE | |
| LOW | prelude/rust/tools/extract_link_action.py | 123 | CODE | |
| LOW | prelude/rust/tools/buildscript_run.py | 211 | CODE | |
| 38 more matches not shown… | ||||
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | app/buck2_test/src/internal_runner.rs | 69 | // Step 1: Execute listing using the dedicated listing command | COMMENT |
| LOW⚡ | app/buck2_test/src/internal_runner.rs | 119 | // Step 2: Parse listing output via Starlark callback | COMMENT |
| LOW⚡ | app/buck2_test/src/internal_runner.rs | 124 | // Step 3: Report discovered tests | COMMENT |
| LOW | app/buck2_core/src/cells.rs | 212 | // TODO(bobyf) we need to check if cells changed | COMMENT |
| LOW⚡ | app/buck2_action_impl/src/context/dynamic_output.rs | 227 | /// # Step 1: Define the implementation function | COMMENT |
| LOW⚡ | app/buck2_action_impl/src/context/dynamic_output.rs | 236 | /// # Step 2: Create a factory | COMMENT |
| LOW⚡ | app/buck2_action_impl/src/context/unsorted.rs | 143 | /// # Step 1: Create a unique tag for tracking header dependencies | COMMENT |
| LOW⚡ | app/buck2_action_impl/src/context/unsorted.rs | 151 | /// # Step 2: Tag the inputs and depfile output | COMMENT |
| LOW⚡ | app/buck2_action_impl/src/context/unsorted.rs | 160 | /// # Step 3: Associate the tag with the "headers" label | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 69 | # Step 1: Run the test with a failure. TPX_PLAYGROUND_FAIL makes the | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 84 | # Step 2: Verify the report was written and contains the individual test | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 95 | # Step 3: Feed the report back as a BRR retry input (still with the | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 113 | # Step 4: The retry must actually run the test (not silently filter it | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 153 | # Step 1: Run with TPX_PLAYGROUND_FAIL=1 to get a failure. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_unmanaged_retry.py | 166 | # Step 2: Verify the report has the individual test name. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_unmanaged_retry.py | 173 | # Step 3: Feed the report back WITHOUT TPX_PLAYGROUND_FAIL — the test | COMMENT |
| LOW | tests/e2e/test/test_brr_unmanaged_retry.py | 190 | # Step 4: The retry must have produced a result — not "NO TESTS RAN". | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 218 | # Step 1: Run the test normally to get a valid run_id from the test infra | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 224 | # Step 2: Create BRR file with suite-level "- main" entry, simulating a | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 295 | # Step 1: Run the unmanaged type-check target normally to get a valid run_id. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 301 | # Step 2: BRR file with a real existing unmanaged entry plus a synthetic new | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 570 | # Step 1: a normal run of the real target just to get a valid run_id. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 577 | # Step 2: BRR file naming a `- unmanaged` entry for a target that does not | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 665 | # Step 2: Verify the report was written and contains a "- main" entry. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 672 | # Step 3: Feed the report back as a BRR retry input, saving the retry | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 807 | # Step 2: Verify the report has "- listing". | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 814 | # Step 3: Feed the report back WITHOUT TPX_PLAYGROUND_FATAL — listing | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 829 | # Step 4: Execution is suppressed for listing-only targets. Listing | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 865 | # Step 2: Verify the report contains a "- listing" entry. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 872 | # Step 3: Feed the report back with --list-only (simulating Citadel | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 911 | # Step 1: Run with TPX_PLAYGROUND_FATAL=1 to make listing crash. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 926 | # Step 2: Verify the report has "- listing". | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 933 | # Step 3: Feed the report back with --list-only WITHOUT | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 949 | # Step 4: --list-only must suppress execution even when listing succeeds. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 967 | # Step 1: Run with TPX_PLAYGROUND_FATAL=1 to make listing crash. | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 982 | # Step 2: Verify the report has "- listing". | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 989 | # Step 3: Feed the report back WITHOUT --list-only and WITHOUT | COMMENT |
| LOW⚡ | tests/e2e/test/test_brr_suite_level_retry.py | 1004 | # Step 4: TPX must suppress execution for listing-only targets even | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 241 | # Step 3: Run with BRR retry — the fix converts "- main" to a prefix | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 257 | # Step 4: Assert tests actually ran (before the fix, this was "NO TESTS RAN") | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 320 | # Step 3: Base-revision retry with new-test detection enabled, capturing the | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 385 | # Step 1: target run — the unmanaged test FAILS on demand. Capture its run_id. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 396 | # Step 2: BRR file naming the suite-level `- unmanaged` entry that failed. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 416 | # Step 3: base-revision retry — still failing on base (BRR_SIM_FAIL=1). | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 485 | # Step 1: target run — the labeled unmanaged test FAILS on demand. Capture run_id. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 496 | # Step 2: BRR file naming the suite-level `- unmanaged` entry that failed. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 516 | # Step 3: base-revision retry — still failing on base (BRR_SIM_FAIL=1). | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 598 | # Step 3: base-revision retry with new-test detection enabled. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 649 | # Step 1: Run the broken run_as_bundle target and save the failure report. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 689 | # Step 4: The retry must reproduce the failure. Verify by | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 719 | # Step 1: Run the broken listing target and save the failure report. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 736 | # Step 2: Verify the report was written and contains a "- listing" entry. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 749 | # Step 3: Feed the report back as a BRR retry input, saving the retry | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 766 | # Step 4: The retry must reproduce the listing failure. Verify by | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 792 | # Step 1: Run with TPX_PLAYGROUND_FATAL=1 to make listing crash. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 850 | # Step 1: Run the broken listing target and save the failure report. | COMMENT |
| LOW | tests/e2e/test/test_brr_suite_level_retry.py | 891 | # Step 4: The retry must reproduce the listing failure with --list-only. | COMMENT |
| LOW⚡ | …ebook/buck/android/exopackage/AndroidDeviceImplTest.kt | 441 | // Step 1: root, wait-for-device, remount | COMMENT |
| LOW⚡ | …ebook/buck/android/exopackage/AndroidDeviceImplTest.kt | 445 | // Step 5: push apex | COMMENT |
| LOW⚡ | …ebook/buck/android/exopackage/AndroidDeviceImplTest.kt | 449 | // Step 6: reboot | COMMENT |
| 6 more matches not shown… | ||||
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| MEDIUM | tools/starlark_fmt/lib/fuzz_starlark.rs | 25 | // ── AST types ──────────────────────────────────────────────────────────── | COMMENT |
| MEDIUM | tools/starlark_fmt/lib/fuzz_starlark.rs | 117 | // ── Leaf enums with fixed pools ────────────────────────────────────────── | COMMENT |
| MEDIUM | tools/starlark_fmt/lib/fuzz_starlark.rs | 198 | // ── Arbitrary impls ────────────────────────────────────────────────────── | COMMENT |
| MEDIUM | tools/starlark_fmt/lib/fuzz_starlark.rs | 488 | // ── Rendering ──────────────────────────────────────────────────────────── | COMMENT |
| MEDIUM⚡ | pagable/src/pagable_arc.rs | 67 | //! ┌─────────────────┐ | COMMENT |
| MEDIUM⚡ | pagable/src/pagable_arc.rs | 72 | //! └────────▲────────┘ | COMMENT |
| MEDIUM⚡ | pagable/src/pagable_arc.rs | 74 | //! ┌─────────────────┼─────────────────┐ | COMMENT |
| MEDIUM⚡ | pagable/src/pagable_arc.rs | 76 | //! ┌──────┴──────┐ ┌──────┴──────┐ ┌──────┴──────┐ | COMMENT |
| MEDIUM⚡ | pagable/src/pagable_arc.rs | 80 | //! └─────────────┘ └─────────────┘ └─────────────┘ | COMMENT |
| MEDIUM⚡ | pagable/src/pagable_arc.rs | 92 | //! ┌─────────┐ alloc_pinned ┌────────┐ release_pin ┌──────────┐ | COMMENT |
| MEDIUM⚡ | pagable/src/pagable_arc.rs | 93 | //! │ PagedOut│ ───────────────►│ Pinned │───────────────►│ Unpinned │ | COMMENT |
| MEDIUM⚡ | pagable/src/pagable_arc.rs | 94 | //! └─────────┘ (deserialize) └────────┘ (count→0, └──────────┘ | COMMENT |
| MEDIUM⚡ | pagable/src/pagable_arc.rs | 97 | //! └──────────────────────────────────────────────────────┘ | COMMENT |
| MEDIUM⚡ | …rlark-rust/starlark/src/values/layout/avalues/array.rs | 183 | /// ┌─────────────────────────────┐ ← me | COMMENT |
| MEDIUM⚡ | …rlark-rust/starlark/src/values/layout/avalues/array.rs | 185 | /// ├─────────────────────────────┤ ← + offset_of_payload() | COMMENT |
| MEDIUM⚡ | …rlark-rust/starlark/src/values/layout/avalues/array.rs | 187 | /// ├─────────────────────────────┤ ← + offset_of_extra() | COMMENT |
| MEDIUM⚡ | …rlark-rust/starlark/src/values/layout/avalues/array.rs | 189 | /// └─────────────────────────────┘ | COMMENT |
| MEDIUM | prelude/apple/tools/make_vfsoverlay.py | 17 | # ---------------------------------- | COMMENT |
| MEDIUM | prelude/cxx/tools/clang_tidy_wrapper.py | 37 | # --------------------------------------------------------------------------- | COMMENT |
| MEDIUM | prelude/cxx/tools/clang_tidy_wrapper.py | 39 | # --------------------------------------------------------------------------- | COMMENT |
| MEDIUM | prelude/cxx/tools/clang_tidy_wrapper.py | 77 | # --------------------------------------------------------------------------- | COMMENT |
| MEDIUM | prelude/cxx/tools/clang_tidy_wrapper.py | 79 | # --------------------------------------------------------------------------- | COMMENT |
| MEDIUM | prelude/cxx/tools/clang_tidy_wrapper.py | 97 | # --------------------------------------------------------------------------- | COMMENT |
| MEDIUM | prelude/cxx/tools/clang_tidy_wrapper.py | 99 | # --------------------------------------------------------------------------- | COMMENT |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| HIGH | tests/core/resource_control/test_memory_reporting.py | 46 | "BUCK2_TEST_RESOURCE_CONTROL_CONFIG": '{"status":"Off","init":"Systemd","memory_max":null,"memory_high":null,"me | CODE |
| HIGH | tests/core/common/io/file_watcher.py | 76 | # "incomplete_events_reason": null, | COMMENT |
| HIGH | tests/core/common/io/file_watcher.py | 78 | # "fresh_instance_data": null, | COMMENT |
| HIGH | prelude/python/tools/make_py_package_inplace.py | 62 | _link=$(readlink "$_self" 2>/dev/null) || break | CODE |
| HIGH | prelude/rust/tools/transitive_dependency_symlinks.py | 41 | # [ "../../libfoo.rlib", null ], | COMMENT |
| HIGH | prelude/rust/tools/transitive_dependency_symlinks.py | 50 | # If the cratename is null, then the artifact is simply symlinked from the basename | COMMENT |
| HIGH⚡ | prelude/cxx/dist_lto/tools/tests/test_dist_lto_opt.py | 281 | "-Wl,--undefined,Global", | CODE |
| HIGH⚡ | prelude/cxx/dist_lto/tools/tests/test_dist_lto_opt.py | 282 | "-Wl,--undefined,Local", | CODE |
| HIGH⚡ | prelude/cxx/dist_lto/tools/tests/test_dist_lto_opt.py | 283 | "-Wl,--undefined,MockConnection", | CODE |
| HIGH⚡ | prelude/cxx/dist_lto/tools/tests/test_dist_lto_opt.py | 284 | "-Wl,--undefined,Global", | CODE |
| HIGH⚡ | prelude/cxx/dist_lto/tools/tests/test_dist_lto_opt.py | 285 | "-Wl,--undefined,Local", | CODE |
| HIGH⚡ | prelude/cxx/dist_lto/tools/tests/test_dist_lto_opt.py | 286 | "-Wl,--undefined,MockConnection", | CODE |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | …core/incremental_api/test_incremental_remote_action.py | 12 | CODE | |
| LOW | tests/core/resource_control/test_action_suspension.py | 11 | CODE | |
| LOW | …urce_control/test_hybrid_execution_resource_control.py | 11 | CODE | |
| LOW | tests/core/vpnless/test_vpnless.py | 12 | CODE | |
| LOW | tests/core/http2/test_http2.py | 12 | CODE | |
| LOW | tests/core/executor/test_dep_files.py | 9 | CODE | |
| LOW | tests/core/ctargets_command/test_ctargets_transition.py | 9 | CODE | |
| LOW | …/core/ctargets_command/test_ctargets_target_hashing.py | 9 | CODE | |
| LOW | tests/core/trace_io/test_trace_io.py | 12 | CODE | |
| LOW | tests/core/client/test_agent_advice.py | 3 | CODE | |
| LOW | tests/core/client/test_agent_context.py | 9 | CODE | |
| LOW | tests/js_lockfiles/test_yarn_lockfiles.py | 11 | CODE | |
| LOW | tests/e2e_util/conftest.py | 13 | CODE | |
| LOW | tests/e2e/test_cxx_flags.py | 9 | CODE | |
| LOW | …le/tools/code_signing/provisioning_profile_metadata.py | 11 | CODE | |
| LOW | prelude/apple/tools/code_signing/info_plist_metadata.py | 11 | CODE | |
| LOW | …e/apple/tools/code_signing/list_codesign_identities.py | 11 | CODE | |
| LOW | …lude/apple/tools/code_signing/signing_context_types.py | 11 | CODE | |
| LOW | prelude/apple/tools/code_signing/identity.py | 11 | CODE | |
| LOW | …e/tools/code_signing/provisioning_profile_selection.py | 11 | CODE | |
| LOW | prelude/apple/tools/code_signing/app_id.py | 11 | CODE | |
| LOW | prelude/apple/tools/bundling/signing_info.py | 10 | CODE | |
| LOW | prelude/apple/tools/bundling/assemble_bundle_types.py | 11 | CODE | |
| LOW | prelude/apple/tools/bundling/incremental_state.py | 11 | CODE | |
| LOW | …ude/apple/tools/bundling/provisioning_manifest_main.py | 9 | CODE | |
| LOW | prelude/apple/tools/bundling/main.py | 9 | CODE | |
| LOW | prelude/apple/tools/bundling/signing_context.py | 9 | CODE | |
| LOW | prelude/apple/tools/bundling/signing_context_data.py | 9 | CODE | |
| LOW | prelude/apple/tools/bundling/logging_utils.py | 9 | CODE | |
| LOW | prelude/python/tools/gen_bytecode_bundle.py | 28 | CODE | |
| LOW | prelude/python/tools/wheel.py | 9 | CODE | |
| LOW | prelude/python/tools/sourcedb_merger/tests/__init__.py | 10 | CODE | |
| LOW | prelude/python/tools/sourcedb_merger/tests/__init__.py | 12 | CODE | |
| LOW | prelude/python/tools/sourcedb_merger/tests/__init__.py | 14 | CODE | |
| LOW | prelude/python/tools/make_par/sitecustomize.py | 11 | CODE | |
| LOW | prelude/python/tools/tests/gen_bytecode_bundle_test.py | 10 | CODE | |
| LOW | prelude/python/runtime/__par__/bootstrap.py | 11 | CODE | |
| LOW | prelude/python/sourcedb/tests/pyrefly_test.py | 9 | CODE | |
| LOW | prelude/cxx/tools/clang_tidy_wrapper.py | 27 | CODE | |
| LOW | prelude/java/tools/gen_class_to_source_map.py | 9 | CODE | |
| LOW | …/haskell/tools/tests/test_script_template_processor.py | 10 | CODE | |
| LOW | prelude/android/tools/create_jdk_system_image.py | 23 | CODE | |
| LOW | prelude/android/tools/sort_pre_dexed_files.py | 28 | CODE | |
| LOW | prelude/android/tools/merge_sequence.py | 106 | CODE | |
| LOW | prelude/android/tools/tests/test_filter_dex.py | 16 | CODE | |
| LOW | …oid/tools/tests/test_combine_apk_with_relinked_libs.py | 15 | CODE |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| MEDIUM | app/buck2_interpreter_for_build/src/nodes/attr_spec.rs | 183 | // For now `within_view` is always set, but let's make code more robust. | COMMENT |
| MEDIUM | app/buck2_action_impl/src/context/copy.rs | 248 | /// duplicating their bytes while staying robust to rebuilds. | COMMENT |
| MEDIUM | starlark-rust/starlark/src/values/types/function.rs | 321 | /// Essentially a `&dyn Fn(Value, Heap) -> Result<Value>`, but expanded out by hand, and | COMMENT |
| MEDIUM | starlark-rust/starlark/src/eval/bc/writer.rs | 491 | // Definitely assigned save/restore is redundant here, it is performed more precisely | COMMENT |
| MEDIUM | starlark-rust/starlark/src/eval/compiler/call.rs | 177 | // Definitely assigned local variable. | COMMENT |
| MEDIUM | tests/core/executor/test_hash_all_commands.py | 37 | # Disable remote cache lookup so we actually utilize the local depfile cache for this test | COMMENT |
| MEDIUM | tests/e2e_util/buck_workspace.py | 141 | # harness build real targets and stay on the use case their execution | COMMENT |
| MEDIUM | tests/e2e_util/helper/utils.py | 147 | # The test harness's extra external config is part of normal Buck config | COMMENT |
| MEDIUM | tests/lint_rules/no_inplace_true_in_build_isolated.py | 22 | # `fixit`'s own test harness lints every VALID/INVALID case under a synthetic | COMMENT |
| MEDIUM | prelude/python/tools/__test_main__.py | 232 | # the builtin python test harness). If we see one, recurse on it. | COMMENT |
| MEDIUM | prelude/python/tools/__test_main__.py | 236 | # The builtin python test harness sets test references to `None` | COMMENT |
| MEDIUM | …id/src/com/facebook/buck/util/zip/EntryAccounting.java | 169 | // Essentially, we're about to set bits 1 and 2 to indicate to tools such as zipinfo which | COMMENT |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | tests/core/interpreter/test_cancellation.py | 78 | except Exception: | CODE |
| LOW | tests/core/daemon/test_concurrency.py | 32 | except Exception as error: | CODE |
| LOW | tests/e2e_util/api/buck_result.py | 332 | except Exception as e: | CODE |
| LOW | tests/e2e_util/api/buck_result.py | 440 | except Exception as e: | CODE |
| LOW | prelude/apple/tools/selective_debugging/main.py | 59 | except Exception as e: | CODE |
| LOW | …ls/code_signing/provisioning_profile_selection_test.py | 118 | except Exception: | CODE |
| LOW | …ls/code_signing/provisioning_profile_selection_test.py | 170 | except Exception: | CODE |
| LOW | prelude/apple/tools/code_signing/app_id.py | 71 | except Exception as e: | CODE |
| LOW | prelude/apple/tools/bundling/main.py | 549 | except Exception: | STRING |
| LOW | prelude/apple/tools/bundling/main.py | 597 | except Exception: | STRING |
| LOW | prelude/apple/tools/bundling/main.py | 691 | except Exception: | STRING |
| LOW | prelude/python/tools/compile.py | 130 | except Exception: | CODE |
| LOW | prelude/python/tools/make_par/sitecustomize.py | 63 | except Exception: | CODE |
| LOW⚡ | prelude/python/tools/make_par/sitecustomize.py | 555 | except Exception: | CODE |
| LOW⚡ | prelude/python/tools/make_par/sitecustomize.py | 561 | except Exception: | CODE |
| MEDIUM | prelude/python/tools/make_par/sitecustomize.py | 536 | def __startup__() -> None: | CODE |
| LOW | prelude/js/worker_runner/worker_tool_runner.py | 469 | except Exception: | CODE |
| LOW | prelude/rust/tools/from_any_dir.py | 69 | except Exception: | CODE |
| MEDIUM | prelude/cxx/tools/stub_header_unit.py | 135 | print("Error: No output file specified with -o", file=sys.stderr) | CODE |
| MEDIUM | prelude/cxx/tools/check_nonempty_output.py | 34 | print("Error: Output file is empty.") | CODE |
| LOW | prelude/kotlin/tools/compile_kotlin/compile_kotlin.py | 260 | except Exception as e: | CODE |
| LOW | prelude/kotlin/tools/typechecker/typechecker.py | 288 | except Exception as e: | CODE |
| LOW | …/com/facebook/buck/jvm/java/testdata/prebuilt/unzip.py | 20 | except Exception: | CODE |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW⚡ | …rpreter/test_package_file_visibility_exempt_targets.py | 21 | def set_default_intersection(buck: Buck, mode: str) -> None: | CODE |
| LOW⚡ | …terpreter/test_package_file_visibility_intersection.py | 18 | def set_default_intersection(buck: Buck, mode: str) -> None: | CODE |
| LOW | tests/core/install/test_install.py | 22 | def _setup_sandbox(buck: Buck) -> None: | CODE |
| LOW | tests/core/trace_io/test_trace_io.py | 60 | def _setup_buckconfig_digest_algorithms(buck: Buck) -> None: | CODE |
| LOW | tests/core/external_cells/test_git.py | 40 | def _set_revision(rev: str, cwd: Path) -> None: | CODE |
| LOW | tests/e2e_util/api/buck.py | 50 | def set_buckd(self, toggle: bool) -> None: | CODE |
| LOW | tests/e2e_util/api/buck.py | 57 | def set_isolation_prefix(self, isolation_prefix: str) -> None: | CODE |
| LOW | tests/e2e_util/api/executable.py | 47 | def set_env(self, key: str, value: str) -> None: | CODE |
| LOW | tests/e2e_util/api/executable.py | 53 | def set_windows_cmd_option(self, key: WindowsCmdOption, value: bool) -> None: | CODE |
| LOW | prelude/python/tools/make_par/sitecustomize.py | 239 | def _setup_child_env() -> None: | CODE |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | …uck2_interpreter_for_build/src/interpreter/selector.rs | 661 | /// # Check if any branch has more than 2 items | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/targetset.rs | 272 | /// # Check if sets are equal | COMMENT |
| LOW | …k2_build_api/src/interpreter/rule_defs/cmd_args/typ.rs | 879 | /// # Check if command has any inputs | COMMENT |
| LOW | tests/e2e_util/buck_workspace.py | 287 | # Check if mkscratch is available, fall back to tempfile.gettempdir() if not | COMMENT |
| LOW | prelude/apple/tools/resource_broker/ios.py | 171 | # Check if device is a device type identifier | COMMENT |
| LOW | prelude/cxx/tools/check_nonempty_output.py | 32 | # Check if the output file is not empty | COMMENT |
| LOW | prelude/cxx/tools/makefile_to_dep_file.py | 67 | # Check if this was escaped by looking at the previous character. If it | COMMENT |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | …2_interpreter_for_build/src/attrs/visibility_record.rs | 38 | /// Example usage: | COMMENT |
| LOW | app/buck2_bxl/src/bxl/starlark_defs/nodes/configured.rs | 560 | /// Example usage: | COMMENT |
| LOW | app/buck2_query_derive/src/lib.rs | 24 | /// Example usage: | COMMENT |
| LOW | docs/developers/perf/scripts/peak_watch.sh | 16 | # Usage: | COMMENT |
| LOW | docs/developers/perf/scripts/measure.sh | 14 | # Usage: | COMMENT |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | app/buck2_event_log/src/utils.rs | 93 | // Don't forget to update these lists when this is updated: | COMMENT |
| LOW | starlark-rust/starlark/src/values/layout/heap/arena.rs | 472 | /// Don't forget to call this function to release memory. | COMMENT |
| MEDIUM | tests/core/cells/test_file_watcher_resolution.py | 37 | # This is just one example, there's a thousand other ways that you can change the `CellResolver` | COMMENT |
| LOW | tests/e2e_util/buck_workspace.py | 214 | # FYI: if you remove this, make sure to remove it from external_buckconfig tests too | COMMENT |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | app/buck2_cmd_log_client/src/what_ran.rs | 623 | digest: "placeholder", | CODE |
| LOW | app/buck2_cmd_log_client/src/what_ran.rs | 703 | "digest": "placeholder", | CODE |
| LOW | app/buck2_event_observer/src/what_ran.rs | 483 | action_digest: "placeholder".to_owned(), | CODE |
| LOW | app/buck2_http/src/proxy.rs | 368 | vec!["user@example.com"], | CODE |
| LOW | tests/core/executor/test_dep_files.py | 1708 | ("placeholder", "cannot be combined with placeholder output"), | CODE |
| LOW | …/test/java/com/facebook/demoapp/model/PostModelTest.kt | 22 | PostModel("Jane Doe", 123, "This is a post", 20) | CODE |
| LOW | …/test/java/com/facebook/demoapp/model/PostModelTest.kt | 32 | PostModel("Jane Doe", 0, "This is a post", 20) | CODE |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| MEDIUM | app/buck2_directory/src/directory/builder.rs | 1241 | // Empty scaffold ∪ X = X, marking included. | COMMENT |
| MEDIUM | app/buck2_directory/src/directory/builder.rs | 1248 | // Exhaustively-empty ∪ empty scaffold joins to exhaustively empty. (A non-empty RHS | COMMENT |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | tests/core/help/test_help.py | 34 | CODE | |
| LOW | tests/e2e_util/buck_workspace.py | 590 | CODE | |
| LOW | tests/e2e_util/helper/utils.py | 42 | CODE | |
| LOW | prelude/apple/tools/code_signing/codesign_bundle.py | 343 | CODE | |
| LOW | prelude/java/tools/fat_jar.py | 172 | CODE |
| Severity | File | Line | Snippet | Context |
|---|---|---|---|---|
| LOW | app/buck2_node/src/metadata/value.rs | 26 | // TODO: implement our own equality here that preserves ordering | COMMENT |