emberjs/ember.js

Pattern Findings

141 matches across 6 categories. Click a row to expand file-level details.

Hyper-Verbose Identifiers90 hits · 100 pts

Severity	File	Line	Snippet
LOW	blueprints/-utils.js	4	function generateComponentSignature(componentName) {
LOW	blueprints/component-test/index.js	14	function invocationForStrictComponentAuthoringFormat(options) {
LOW	…ke-tests/node-template/tests/node/helpers/setup-app.js	164	function registerApplicationClasses(app, registry) {
LOW	packages/router_js/tests/test_helpers.ts	54	function stubbedHandlerInfoFactory(name: string, props: Dict<unknown>) {
LOW	packages/router_js/tests/router_test.ts	4292	function setupAuthenticatedExample(assert: Assert) {
LOW	packages/router_js/tests/query_params_test.ts	75	function consumeAllFinalQueryParams(params: Dict<unknown>, finalParams: Dict<unknown>[]) {
LOW	packages/router_js/lib/route-info.ts	178	function createRouteInfoWithAttributes(
LOW	packages/router_js/lib/utils.ts	67	export function coerceQueryParamsToString(queryParams: Dict<unknown>) {
LOW	…uter_js/lib/transition-intent/url-transition-intent.ts	34	function checkHandlerAccessibility(handler: R) {
LOW	packages/internal-test-helpers/lib/element-helpers.ts	68	export function assertClassicComponentElement(
LOW	packages/internal-test-helpers/lib/element-helpers.ts	72	export function assertClassicComponentElement(shape: ClassicComponentShape): void;
LOW	packages/internal-test-helpers/lib/element-helpers.ts	73	export function assertClassicComponentElement(
LOW	packages/@ember/test/index.ts	14	export function registerTestImplementation(impl: typeof EmberTesting) {
LOW	packages/@ember/-internals/metal/tests/alias_test.js	172	function assertPropertyTagUnchanged(obj, keyName, callback) {
LOW	packages/@ember/-internals/metal/lib/property_get.ts	18	getPossibleMandatoryProxyValue = function getPossibleMandatoryProxyValue(obj, keyName): any {
LOW	packages/@ember/-internals/metal/lib/cached.ts	126	function throwCachedExtraneousParens(): never {
LOW	packages/@ember/-internals/metal/lib/cached.ts	132	function throwCachedGetterOnlyError(key: string): never {
LOW	packages/@ember/-internals/metal/lib/cached.ts	136	function throwCachedInvalidArgsError(args: unknown[] = []): never {
LOW	packages/@ember/-internals/metal/lib/observer.ts	84	function getOrCreateActiveObserversFor(target: object, sync: boolean) {
LOW	packages/@ember/-internals/metal/lib/observer.ts	84	function getOrCreateActiveObserversFor(target: object, sync: boolean) {
LOW	packages/@ember/-internals/metal/lib/observer.ts	142	export function suspendedObserverDeactivation() {
LOW	packages/@ember/-internals/metal/lib/observer.ts	146	export function resumeObserverDeactivation() {
LOW	packages/@ember/-internals/utils/lib/super.ts	44	function createObserverListenerMetaFor(fn: Function) {
LOW	…mer/tests/integration/custom-component-manager-test.js	31	function createInstrumentedManager(owner) {
LOW	…als/glimmer/tests/integration/event-dispatcher-test.js	8	function fireNativeWithDataTransfer(node, type, dataTransfer) {
LOW	…ckages/@ember/-internals/glimmer/lib/utils/bindings.ts	83	export function createClassNameBindingRef(
LOW	…ckages/@ember/-internals/glimmer/lib/utils/bindings.ts	113	export function createSimpleClassNameBindingRef(inner: Reference, path?: string) {
LOW	…ckages/@ember/-internals/glimmer/lib/utils/bindings.ts	134	function createColonClassNameBindingRef(
LOW	…ber/-internals/glimmer/lib/component-managers/curly.ts	487	export function processComponentInitializationAssertions(component: Component, props: any): void {
LOW	…ber/-internals/glimmer/lib/component-managers/curly.ts	538	export function initialRenderInstrumentDetails(component: any): any {
LOW	…ber/-internals/glimmer/lib/component-managers/curly.ts	542	function rerenderInstrumentDetails(component: any): any {
LOW	packages/@ember/-internals/views/lib/system/utils.ts	24	export function constructStyleDeprecationMessage(affectedStyle: string): string {
LOW	packages/@ember/-internals/views/lib/system/utils.ts	203	export function getViewBoundingClientRect(view: View): DOMRect {
LOW	packages/@ember/object/core.ts	1086	CoreObject._onLookup = function injectedPropertyAssertion(debugContainerKey: string) {
LOW	packages/@ember/object/mixin.ts	49	function concatenatedMixinProperties(
LOW	packages/@ember/object/mixin.ts	172	function applyConcatenatedProperties(key: string, value: any, values: { [key: string]: any }) {
LOW	packages/@ember/object/mixin.ts	372	function updateObserversAndListeners(obj: object, key: string, fn: Function, add: boolean) {
LOW	…s/@ember/object/lib/computed/reduce_computed_macros.ts	1292	function sortByNormalizedSortProperties(
LOW	packages/@ember/object/lib/computed/computed_macros.ts	35	function generateComputedWithPredicate(name: string, predicate: (value: unknown) => unknown) {
LOW	…ompiler/lib/plugins/transform-wrap-mount-and-outlet.ts	38	export default function transformWrapMountAndOutlet(env: EmberASTPluginEnvironment): ASTPlugin {
LOW	…e-compiler/lib/plugins/assert-against-named-outlets.ts	18	export default function assertAgainstNamedOutlets(env: EmberASTPluginEnvironment): ASTPlugin {
LOW	…ompiler/lib/plugins/assert-reserved-named-arguments.ts	7	export default function assertReservedNamedArguments(env: EmberASTPluginEnvironment): ASTPlugin {
LOW	…lugins/transform-quoted-bindings-into-just-bindings.ts	4	export default function transformQuotedBindingsIntoJustBindings(/* env */): ASTPlugin {
LOW	packages/@ember/routing/lib/generate_controller.ts	20	export function generateControllerFactory(
LOW	packages/@ember/routing/lib/utils.ts	192	export function normalizeControllerQueryParams(queryParams: Readonly<ControllerQueryParam[]>) {
LOW	packages/@ember/routing/lib/utils.ts	202	function accumulateQueryParamDescriptors(
LOW	packages/@ember/routing/lib/routing-service.ts	138	function numberOfContextsAcceptedByHandler(handlerName: string, handlerInfos: any[]) {
LOW	…glimmer-workspace/integration-tests/test/owner-test.ts	104	function defineCheckOwnerComponent(ownerToCheck: object \| undefined, assert: Assert) {
LOW	…rkspace/integration-tests/test/ember-component-test.ts	123	export function assertElementIsEmberishElement(
LOW	…rkspace/integration-tests/test/ember-component-test.ts	130	export function assertElementIsEmberishElement(
LOW	…rkspace/integration-tests/test/ember-component-test.ts	136	export function assertElementIsEmberishElement(
LOW	…rkspace/integration-tests/test/ember-component-test.ts	140	export function assertElementIsEmberishElement(
LOW	…-workspace/integration-tests/lib/modes/jit/register.ts	29	export function registerTemplateOnlyComponent(
LOW	…-workspace/integration-tests/lib/modes/jit/register.ts	42	export function registerEmberishCurlyComponent(
LOW	…-workspace/integration-tests/lib/modes/jit/register.ts	58	export function registerGlimmerishComponent(
LOW	…mmer-workspace/integration-tests/lib/dom/assertions.ts	179	export function assertSerializedInElement(result: string, expected: string, message?: string) {
LOW	…mmer-workspace/integration-tests/lib/dom/assertions.ts	245	export function processAssertComponentArgs(
LOW	…@glimmer/opcode-compiler/lib/opcode-builder/context.ts	5	export function templateCompilationContext(
LOW	…code-compiler/lib/opcode-builder/helpers/resolution.ts	27	function makeResolutionTypeVerifier(typeToVerify: SexpOpcode) {
LOW	…code-compiler/lib/opcode-builder/helpers/resolution.ts	347	export function resolveOptionalComponentOrHelper(
30 more matches not shown…

Over-Commented Block38 hits · 38 pts

Severity	File	Line	Snippet
LOW	…s/compiler-internals/02-program-compilation-context.md	1	#
LOW	packages/ember-template-compiler/minimal.ts	1	// The main entrypoint of ember-template-compiler is the fairly-crufty
LOW	packages/router_js/lib/router.ts	681	// route, the transition is aborted using replaceWith('/bar').
LOW	packages/internal-test-helpers/lib/ember-dev/warning.ts	61	};
LOW	…ges/internal-test-helpers/lib/ember-dev/deprecation.ts	121	true
LOW	packages/@ember/runloop/-private/backburner.ts	1	// This exists solely to provide a compatibility shim for `ember-test-helpers`
LOW	packages/@ember/runloop/tests/later_test.js	141	// later(this, fn, 5, 10);
LOW	packages/@ember/runloop/tests/later_test.js	161
LOW	packages/@ember/modifier/on.ts	1	import { on as glimmerOn } from '@glimmer/runtime/lib/modifiers/on';
LOW	…/components/runtime-template-compiler-implicit-test.ts	401	},
LOW	…immer/tests/integration/components/strict-mode-test.js	321	);
LOW	…/components/runtime-template-compiler-explicit-test.ts	301	// we specifically enable them when calling `precompile`)
LOW	…/tests/integration/components/render-component-test.ts	1081	// Ember currently uses AST plugins to implement certain features that
LOW	packages/@ember/-internals/glimmer/lib/helper.ts	321	// terms meaningful to them, while preserving the type behavior described on
LOW	packages/@ember/-internals/glimmer/lib/helper.ts	381	): FunctionBasedHelper<S>;
LOW	…ber/-internals/glimmer/lib/component-managers/curly.ts	281	// Set component instance's parentView property to point to nearest concrete
LOW	packages/@ember/-internals/glimmer/lib/helpers/mut.ts	81	*/
LOW	…ges/@ember/-internals/glimmer/lib/helpers/unique-id.ts	41	// From https://gist.github.com/selfish/fef2c0ba6cdfe07af76e64cecd74888b
LOW	packages/@ember/component/template-only.ts	41	// eslint-disable-next-line @typescript-eslint/no-empty-object-type
LOW	packages/@ember/utils/lib/compare.ts	21	};
LOW	packages/@ember/object/-internals.ts	1	export { getCachedValueFor as cacheFor } from '@ember/-internals/metal/lib/computed_cache';
LOW	packages/@ember/object/core.ts	461	}
LOW	packages/@ember/canary-features/index.ts	61	// }
LOW	packages/@ember/routing/router-service.ts	321	// get isBarActive() {
LOW	packages/@ember/routing/route.ts	381	// By default, changes to controller query param properties
LOW	packages/@ember/routing/tests/system/route_test.js	61	// By default, controller query param properties don't
LOW	…rkspace/integration-tests/test/collections/set-test.ts	301	// behavior is fixed
LOW	…pace/integration-tests/test/collections/object-test.ts	81	update() {
LOW	…pace/integration-tests/test/collections/object-test.ts	101	//
LOW	…ode-compiler/lib/opcode-builder/helpers/conditional.ts	141	// If the body invokes a block, its return will return to
LOW	…ode-compiler/lib/opcode-builder/helpers/conditional.ts	161
LOW	packages/@glimmer/validator/lib/validators.ts	181	} else {
LOW	packages/@glimmer/validator/lib/collections/array.ts	181	}
LOW	packages/@glimmer/runtime/lib/vm/element-builder.ts	481	// In general, you only need to clear the root of a hierarchy, and should never
LOW	packages/@glimmer/runtime/lib/dom/props.ts	41	return value;
LOW	packages/@glimmer/syntax/lib/v1/nodes-v1.ts	321	};
LOW	packages/@glimmer/compiler/test/compiler-test.ts	321
LOW	packages/@glimmer/compiler/lib/utils.ts	1	import type { Dict, WellKnownAttrName, WellKnownTagName } from '@glimmer/interfaces';

Cross-Language Confusion (JS/TS)2 hits · 10 pts

Severity	File	Line	Snippet
HIGH	packages/@glimmer/syntax/test/generation/print-test.ts	186	print(ast, { entityEncoding: 'raw' }),
HIGH	packages/@glimmer/syntax/lib/generation/printer.ts	536	print(node: ASTv1.Node): string {

Self-Referential Comments3 hits · 9 pts

Severity	File	Line	Snippet
MEDIUM	packages/@ember/-internals/glimmer/lib/component.ts	233	## Defining a Classic Component
MEDIUM	packages/@glimmer/component/src/index.ts	32	## Defining a Template-only Component
MEDIUM	packages/@glimmer/component/src/-private/component.ts	108	* ## Defining a Component

Fake / Example Data6 hits · 8 pts

Severity	File	Line	Snippet
LOW	type-tests/@ember/template-tests.ts	4	let trusted = htmlSafe('lorem ipsum...');
LOW	type-tests/@ember/object-test/proxy.ts	101	expectTypeOf(person.set('fullName', 'John Doe')).toBeString();
LOW	type-tests/@ember/object-test/proxy.ts	106	expectTypeOf(person.setProperties({ fullName: 'John Doe' })).toEqualTypeOf<{
LOW	type-tests/@ember/object-test/proxy.ts	107	fullName: 'John Doe';
LOW	type-tests/@ember/object-test/proxy.ts	109	expectTypeOf(person.setProperties({ fullName: 'John Doe' }).fullName).toBeString();
LOW	type-tests/@ember/object-test/proxy.ts	111	person.setProperties({ fullName: 'John Doe', invalid: true });

AI Slop Vocabulary2 hits · 5 pts

Severity	File	Line	Snippet
MEDIUM	…ber/-internals/glimmer/lib/component-managers/curly.ts	336	// Essentially we're saving off all the state we'll need in the future.
MEDIUM	.github/workflows/publish-to-npm.yml	27	use-node-modules-cache: false # Absolutely no cache should be used when publishing due to the potential of cac

Score History

Severity Breakdown

Pattern Findings