dolphin-emu/dolphin

Pattern Findings

3024 matches across 12 categories. Click a row to expand file-level details.

Over-Commented Block2985 hits · 2706 pts

Severity	File	Line	Snippet
LOW	CMakeLists.txt	601	endif()
LOW	BuildMacOSUniversalBinary.py	41	"dst_app": "universal/",
LOW	Tools/perf-disassemble.sh	1	#!/bin/bash
LOW	Tools/symbolicate-ppc.py	1	#!/usr/bin/python
LOW	Tools/symbolicate-ppc.py	21	# 0.57% JIT_PPC_zz_044141c_ (/tmp/perf-15936.map)
LOW	Source/PCH/pch.h	1	// Copyright 2013 Dolphin Emulator Project
LOW	Source/PCH/pch.h	21	#undef STRINGIFY_HELPER
LOW	Source/PCH/pch.h	41	#include <errno.h>
LOW	Source/PCH/pch.h	61	#include <list>
LOW	Source/PCH/pch.h	81	#include <stdlib.h>
LOW	Source/PCH/pch.cpp	1	// Copyright 2014 Dolphin Emulator Project
LOW	Source/PCH/nopch/pch.h	1	// dummy include to help with disabling pch for a single file
LOW	Source/DSPTool/DSPTool.cpp	1	// Copyright 2009 Dolphin Emulator Project
LOW	Source/DSPTool/DSPTool.cpp	361
LOW	Source/Core/Core/CheatSearch.cpp	1	// Copyright 2021 Dolphin Emulator Project
LOW	Source/Core/Core/PatchEngine.cpp	1	// Copyright 2008 Dolphin Emulator Project
LOW	Source/Core/Core/PatchEngine.cpp	21	#include "Common/Assert.h"
LOW	Source/Core/Core/NetPlayCommon.h	1	// Copyright 2021 Dolphin Emulator Project
LOW	Source/Core/Core/Core.h	1	// Copyright 2008 Dolphin Emulator Project
LOW	Source/Core/Core/NetworkCaptureLogger.cpp	1	// Copyright 2021 Dolphin Emulator Project
LOW	Source/Core/Core/NetworkCaptureLogger.h	1	// Copyright 2021 Dolphin Emulator Project
LOW	Source/Core/Core/Host.h	1	// Copyright 2008 Dolphin Emulator Project
LOW	Source/Core/Core/MachineContext.h	1	// Copyright 2008 Dolphin Emulator Project
LOW	Source/Core/Core/MachineContext.h	21	#define CTX_RDX Rdx
LOW	Source/Core/Core/MachineContext.h	41	#error No context definition for architecture
LOW	Source/Core/Core/MachineContext.h	61	#define CTX_R9 __r9
LOW	Source/Core/Core/MachineContext.h	81	#if _M_X86_64
LOW	Source/Core/Core/MachineContext.h	101	#define CTX_LR __ss.__lr
LOW	Source/Core/Core/MachineContext.h	121	#define CTX_RSP gregs[REG_RSP]
LOW	Source/Core/Core/MachineContext.h	141	typedef ucontext_t SContext;
LOW	Source/Core/Core/MachineContext.h	161	#define CTX_REG(x) sc_x[x]
LOW	Source/Core/Core/MachineContext.h	181	#define CTX_R9 __gregs[_REG_R9]
LOW	Source/Core/Core/MachineContext.h	201	#define CTX_RSI mc_rsi
LOW	Source/Core/Core/MachineContext.h	221	#elif defined(__HAIKU__)
LOW	Source/Core/Core/Core.cpp	1	// Copyright 2008 Dolphin Emulator Project
LOW	Source/Core/Core/Core.cpp	21	#endif
LOW	Source/Core/Core/Core.cpp	41	#include "Core/Boot/Boot.h"
LOW	Source/Core/Core/Core.cpp	61	#include "Core/HW/Wiimote.h"
LOW	Source/Core/Core/Core.cpp	81
LOW	Source/Core/Core/Movie.h	1	// Copyright 2008 Dolphin Emulator Project
LOW	Source/Core/Core/State.cpp	1	// Copyright 2008 Dolphin Emulator Project
LOW	Source/Core/Core/State.cpp	21
LOW	Source/Core/Core/State.cpp	41	#include "Core/HW/HW.h"
LOW	Source/Core/Core/NetPlayServer.h	1	// Copyright 2013 Dolphin Emulator Project
LOW	Source/Core/Core/BootManager.cpp	1	// Copyright 2011 Dolphin Emulator Project
LOW	Source/Core/Core/BootManager.cpp	21
LOW	Source/Core/Core/AchievementManager.cpp	1	// Copyright 2023 Dolphin Emulator Project
LOW	Source/Core/Core/AchievementManager.cpp	21	#include "Common/StringUtil.h"
LOW	Source/Core/Core/CoreTiming.cpp	1	// Copyright 2008 Dolphin Emulator Project
LOW	Source/Core/Core/CoreTiming.cpp	21	#include "Core/CPUThreadConfigCallback.h"
LOW	Source/Core/Core/DolphinAnalytics.cpp	1	// Copyright 2016 Dolphin Emulator Project
LOW	Source/Core/Core/DolphinAnalytics.cpp	21	#include <functional>
LOW	Source/Core/Core/AchievementManager.h	1	// Copyright 2023 Dolphin Emulator Project
LOW	Source/Core/Core/AchievementManager.h	21	#include <picojson.h>
LOW	Source/Core/Core/NetPlayClient.cpp	1	// Copyright 2010 Dolphin Emulator Project
LOW	Source/Core/Core/NetPlayClient.cpp	21	#include <fmt/ranges.h>
LOW	Source/Core/Core/NetPlayClient.cpp	41	#include "Core/Config/NetplaySettings.h"
LOW	Source/Core/Core/NetPlayClient.cpp	61	#include "Core/HW/Wiimote.h"
LOW	Source/Core/Core/NetPlayClient.cpp	2001	// that we hardcode the knowledge that they go in order, so if
LOW	Source/Core/Core/WiiUtils.cpp	1	// Copyright 2017 Dolphin Emulator Project
2925 more matches not shown…

Synthetic Comment Markers4 hits · 30 pts

Severity	File	Line	Snippet
HIGH	Externals/mbedtls/library/error.c	226	/* Begin Auto-Generated Code. */
HIGH	Externals/mbedtls/library/error.c	569	/* End Auto-Generated Code. */
HIGH	Externals/mbedtls/library/error.c	590	/* Begin Auto-Generated Code. */
HIGH	Externals/mbedtls/library/error.c	887	/* End Auto-Generated Code. */

AI Slop Vocabulary8 hits · 22 pts

Severity	File	Line	Snippet
LOW	BuildMacOSUniversalBinary.py	56	# be cryptographically signed/notarized but will instead just use a
MEDIUM	BuildMacOSUniversalBinary.py	79	# 2) Single architecture builds should utilize the normal generated cmake
MEDIUM	Source/Core/Core/HW/GCMemcard/GCMemcard.cpp	156	// whichever block has the higher value. Essentially, if (0.update_ctr >= 1.update_ctr) { use 0 }
MEDIUM	Source/Core/Core/HLE/HLE_Misc.cpp	44	// robust alternative would be to actually detect memory writes, but that
MEDIUM	Source/Core/Core/FifoPlayer/FifoRecorder.cpp	224	// The video thread may call into functions that utilize these
MEDIUM	Source/Core/VideoCommon/ShaderCache.cpp	1235	// - AMD, Nvidia: Definitely keyed on dual source blend, but the others seem more random
MEDIUM	Source/Core/VideoCommon/AbstractTexture.cpp	47	// Use a temporary staging texture for the download. Certainly not optimal,
MEDIUM	Source/Core/DolphinQt/Debugger/EditSymbolDialog.cpp	101	// Not sure what the max size should be. Definitely not a full 8, so set to 7.

Self-Referential Comments7 hits · 21 pts

Severity	File	Line	Snippet
MEDIUM	Externals/mbedtls/include/psa/crypto.h	967	* -# Initialize the operation object with one of the methods described in the
MEDIUM	Externals/mbedtls/include/psa/crypto.h	1341	* -# Initialize the operation object with one of the methods described in the
MEDIUM	Externals/mbedtls/include/psa/crypto.h	1402	* -# Initialize the operation object with one of the methods described in the
MEDIUM	Externals/mbedtls/include/psa/crypto.h	1761	* -# Initialize the operation object with one of the methods described in the
MEDIUM	Externals/mbedtls/include/psa/crypto.h	1825	* -# Initialize the operation object with one of the methods described in the
MEDIUM	Externals/mbedtls/include/psa/crypto.h	2290	* -# Initialize the operation object with one of the methods described in the
MEDIUM	Externals/mbedtls/include/psa/crypto.h	2360	* -# Initialize the operation object with one of the methods described in the

Decorative Section Separators4 hits · 12 pts

Severity	File	Line	Snippet
MEDIUM	Externals/liblzma/CMakeLists.txt	54	#============================================================================
MEDIUM	Externals/liblzma/CMakeLists.txt	56	#============================================================================
MEDIUM	Externals/bzip2/CMakeLists.txt	52	#============================================================================
MEDIUM	Externals/bzip2/CMakeLists.txt	54	#============================================================================

Slop Phrases3 hits · 4 pts

Severity	File	Line	Snippet
LOW	Source/Core/Core/State.cpp	97	// Don't forget to increase this after doing changes on the savestate system
LOW	Source/Core/DolphinQt/Config/SettingsWindow.cpp	193	// If you change the order, don't forget to update the SettingsWindowPaneIndex enum.
LOW	Externals/mbedtls/include/mbedtls/blowfish.h	40	#define MBEDTLS_BLOWFISH_ROUNDS 16 /**< Rounds to use. When increasing this value, make sure to extend the

Deep Nesting3 hits · 3 pts

Severity	File	Line
LOW	Tools/test-updater.py	56
LOW	Externals/mbedtls/scripts/config.py	439
LOW	Externals/discord-rpc/build.py	255

Example Usage Blocks2 hits · 3 pts

Severity	File	Line	Snippet
LOW	Tools/perf-disassemble.sh	11	# Example usage:
LOW	Source/Core/Common/Analytics.h	31	// Example usage:

Verbosity Indicators2 hits · 3 pts

Severity	File	Line	Snippet
LOW	Source/Core/Core/PowerPC/PPCAnalyst.cpp	395	// Step 1: Find all functions
LOW	Source/Core/Core/PowerPC/PPCAnalyst.cpp	400	// Step 2:

Hyper-Verbose Identifiers2 hits · 2 pts

Severity	File	Line	Snippet
LOW	Tools/test-updater.py	55	class HTTPRequestHandler(http.server.BaseHTTPRequestHandler):
LOW	Tools/find-includes-cycles.py	23	def strongly_connected_components(graph):

Unused Imports2 hits · 2 pts

Severity	File	Line	Snippet
LOW	Tools/test-updater.py	19
LOW	docs/DSP/free_dsp_rom/generate_coefs.py	1

Fake / Example Data2 hits · 2 pts

Severity	File	Line	Snippet
LOW	docs/ResourcePacks.md	61	"authors": ["John Doe", "Jane Doe"],
LOW	docs/ResourcePacks.md	61	"authors": ["John Doe", "Jane Doe"],

Score History

Severity Breakdown

Pattern Findings