dbcli/pgcli

Pattern Findings

371 matches across 8 categories. Click a row to expand file-level details.

Hyper-Verbose Identifiers323 hits · 317 pts

Severity	File	Line	Snippet
LOW	release.py	66	def create_distribution_files():
LOW	release.py	71	def upload_distribution_files():
LOW	pgcli/pgcompleter.py	605	def get_join_condition_matches(self, suggestion, word_before_cursor):
LOW	pgcli/pgcompleter.py	702	def get_from_clause_item_matches(self, suggestion, word_before_cursor):
LOW	pgcli/pyev.py	94	def calculate_planner_estimate(self, plan):
LOW	pgcli/pgtoolbar.py	19	def create_toolbar_tokens_func(pgcli):
LOW	pgcli/pgexecute.py	27	def remove_beginning_comments(command):
LOW	pgcli/main.py	320	def _is_named_query_execution(self, text):
LOW	pgcli/main.py	325	def register_special_commands(self):
LOW	pgcli/main.py	1228	def _handle_server_closed_connection(self, text):
LOW	pgcli/main.py	1262	def _on_completions_refreshed(self, new_completer, persist_priorities):
LOW	pgcli/main.py	1733	def obfuscate_process_password():
LOW	pgcli/main.py	927	def _check_ongoing_transaction_and_allow_quitting(self):
LOW	pgcli/packages/sqlcompletion.py	185	def _split_multiple_statements(full_text, text_before_cursor, parsed):
LOW	pgcli/packages/sqlcompletion.py	281	def suggest_based_on_last_token(token, stmt):
LOW	pgcli/packages/prompt_utils.py	6	def confirm_destructive_query(queries, keywords, alias):
LOW	pgcli/packages/parseutils/__init__.py	23	def query_is_unconditional_update(formatted_sql):
LOW	pgcli/packages/parseutils/__init__.py	41	def parse_destructive_warning(warning_level):
LOW	pgcli/packages/parseutils/tables.py	75	def extract_table_identifiers(token_stream, allow_functions=True):
LOW	tests/test_pgexecute.py	509	def test_multiple_queries_same_line(executor):
LOW	tests/test_pgexecute.py	517	def test_multiple_queries_with_special_command_same_line(executor, pgspecial):
LOW	tests/test_pgexecute.py	526	def test_multiple_queries_same_line_syntaxerror(executor, exception_formatter):
LOW	tests/test_pgexecute.py	542	def test_special_command_help(executor, pgspecial):
LOW	tests/test_pgexecute.py	549	def test_bytea_field_support_in_output(executor):
LOW	tests/test_pgexecute.py	557	def test_unicode_support_in_unknown_type(executor):
LOW	tests/test_pgexecute.py	562	def test_unicode_support_in_enum_type(executor):
LOW	tests/test_pgexecute.py	570	def test_json_renders_without_u_prefix(executor, expanded):
LOW	tests/test_pgexecute.py	579	def test_jsonb_renders_without_u_prefix(executor, expanded):
LOW	tests/test_pgexecute.py	74	def test_bools_are_treated_as_strings(executor):
LOW	tests/test_pgexecute.py	98	def test_schemata_table_views_and_columns_query(executor):
LOW	tests/test_pgexecute.py	227	def test_invalid_syntax_verbose(executor):
LOW	tests/test_pgexecute.py	277	def test_execute_from_file_no_arg(executor, pgspecial):
LOW	tests/test_pgexecute.py	288	def test_execute_from_file_io_error(os, executor, pgspecial):
LOW	tests/test_pgexecute.py	302	def test_execute_from_commented_file_that_executes_another_file(executor, pgspecial, tmpdir):
LOW	tests/test_pgexecute.py	320	def test_execute_commented_first_line_and_special(executor, pgspecial, tmpdir):
LOW	tests/test_pgexecute.py	418	def test_execute_commented_first_line_and_normal(executor, pgspecial, tmpdir):
LOW	tests/test_pgexecute.py	609	def test_large_numbers_render_directly(executor, value):
LOW	tests/test_pgexecute.py	628	def test_raises_with_no_formatter(executor, sql):
LOW	tests/test_pgexecute.py	655	def test_nonexistent_function_definition(executor):
LOW	tests/test_pgexecute.py	677	def test_function_notice_order(executor):
LOW	tests/test_pgexecute.py	722	def test_nonexistent_view_definition(executor):
LOW	tests/test_pgexecute.py	759	def test_exit_without_active_connection(executor):
LOW	tests/test_pgexecute.py	258	def test_unicode_support_in_output(executor, expanded):
LOW	tests/test_ssh_tunnel.py	14	def mock_ssh_tunnel_forwarder() -> MagicMock:
LOW	tests/test_rowlimit.py	71	def test_row_limit_on_non_select(over_limit):
LOW	tests/metadata.py	112	def columns_functions_and_keywords(self, tbl, parent="public", typ="tables", pos=0):
LOW	tests/metadata.py	118	def schemas_and_from_clause_items(self, parent="public", pos=0):
LOW	tests/test_auth.py	15	def test_keyring_get_password_ok():
LOW	tests/test_auth.py	21	def test_keyring_get_password_exception():
LOW	tests/test_auth.py	27	def test_keyring_set_password_ok():
LOW	tests/test_auth.py	33	def test_keyring_set_password_exception():
LOW	tests/test_fuzzy_completion.py	11	def test_ranking_ignores_identifier_quotes(completer):
LOW	tests/test_fuzzy_completion.py	31	def test_ranking_based_on_shortest_match(completer):
LOW	tests/test_fuzzy_completion.py	56	def test_should_break_ties_using_lexical_order(completer, collection):
LOW	tests/test_fuzzy_completion.py	76	def test_matching_should_be_case_insensitive(completer):
LOW	tests/test_smart_completion_multiple_schemata.py	248	def test_suggested_column_names_with_qualified_alias(completer):
LOW	tests/test_smart_completion_multiple_schemata.py	254	def test_suggested_multiple_column_names(completer):
LOW	tests/test_smart_completion_multiple_schemata.py	260	def test_suggested_multiple_column_names_with_alias(completer):
LOW	tests/test_smart_completion_multiple_schemata.py	286	def test_suggested_aliases_after_on_right_side(completer):
LOW	tests/test_smart_completion_multiple_schemata.py	293	def test_table_names_after_from(completer):
263 more matches not shown…

Cross-File Repetition7 hits · 35 pts

Severity	File	Snippet
HIGH	tests/features/steps/crud_database.py	steps for behavioral style tests are defined in this module. each step is defined by the string decorating it. this stri
HIGH	tests/features/steps/named_queries.py	steps for behavioral style tests are defined in this module. each step is defined by the string decorating it. this stri
HIGH	tests/features/steps/crud_table.py	steps for behavioral style tests are defined in this module. each step is defined by the string decorating it. this stri
HIGH	tests/features/steps/basic_commands.py	steps for behavioral style tests are defined in this module. each step is defined by the string decorating it. this stri
HIGH	tests/features/steps/pgbouncer.py	steps for behavioral style tests are defined in this module. each step is defined by the string decorating it. this stri
HIGH	tests/features/steps/specials.py	steps for behavioral style tests are defined in this module. each step is defined by the string decorating it. this stri
HIGH	tests/features/steps/expanded.py	steps for behavioral style tests are defined in this module. each step is defined by the string decorating it. this stri

Excessive Try-Catch Wrapping16 hits · 17 pts

Severity	File	Line	Snippet
LOW	pgcli/auth.py	39	except Exception as e:
LOW	pgcli/auth.py	51	except Exception as e:
MEDIUM	pgcli/auth.py	48	def keyring_set_password(key, passwd):
MEDIUM	pgcli/main.py	436	def change_table_format(self, pattern, **_):
LOW	pgcli/main.py	712	except Exception as e:
LOW	pgcli/main.py	765	except Exception as e: # Connecting to a database could fail.
LOW	pgcli/main.py	1544	except Exception:
LOW	pgcli/main.py	1603	except Exception:
LOW	pgcli/main.py	1708	except Exception:
LOW	pgcli/main.py	1750	except Exception:
LOW	pgcli/main.py	1762	except Exception:
LOW	pgcli/main.py	852	except Exception as e:
LOW	tests/utils.py	30	except Exception:
LOW	tests/utils.py	51	except Exception:
LOW	tests/features/environment.py	198	except Exception as x:
LOW	tests/features/db_utils.py	48	except Exception:

Deep Nesting15 hits · 14 pts

Severity	File	Line
LOW	pgcli/pgcompleter.py	885
LOW	pgcli/pyev.py	159
LOW	pgcli/pgexecute.py	317
LOW	pgcli/main.py	1491
LOW	pgcli/main.py	1857
LOW	pgcli/main.py	773
LOW	pgcli/main.py	811
LOW	pgcli/main.py	957
LOW	pgcli/main.py	1270
LOW	pgcli/packages/sqlcompletion.py	229
LOW	pgcli/packages/sqlcompletion.py	281
LOW	pgcli/packages/formatter/sqlformatter.py	26
LOW	pgcli/packages/parseutils/tables.py	36
LOW	pgcli/packages/parseutils/tables.py	75
LOW	pgcli/packages/parseutils/meta.py	24

Self-Referential Comments3 hits · 9 pts

Severity	File	Line	Snippet
MEDIUM	pgcli/completion_refresher.py	55	# Create a new pgexecute method to populate the completions.
MEDIUM	tests/test_init_commands_simple.py	54	# Create a temporary config file with init-commands
MEDIUM	tests/test_init_commands_simple.py	72	# Create a temporary config file with init-commands

Redundant / Tautological Comments3 hits · 3 pts

Severity	File	Line	Snippet
LOW	pgcli/main.py	638	# Check if DSN contains a password - if so, don't use PGPASSWORD
LOW	pgcli/main.py	912	# Check if we need to update completions, in order of most
LOW	tests/test_completion_refresher.py	91	# Set refreshers to 0: we're not testing refresh logic here

Over-Commented Block3 hits · 3 pts

Severity	File	Line	Snippet
LOW	pgcli/packages/sqlcompletion.py	281	def suggest_based_on_last_token(token, stmt):
LOW	pgcli/packages/sqlcompletion.py	321
LOW	pgcli/packages/parseutils/tables.py	141	# abc is the table name, but if we don't stop at the first lparen, then

Slop Phrases1 hit · 2 pts

Severity	File	Line	Snippet
LOW	pgcli/main.py	201	# make sure to use self.config_writer, not self.config

Score History

Severity Breakdown

Pattern Findings