cloudflare/cloudflared

Pattern Findings

85 matches across 11 categories. Click a row to expand file-level details.

Decorative Section Separators7 hits · 32 pts

Severity	File	Line	Snippet
MEDIUM	component-tests/test_prechecks.py	301	# ── table structure ──────────────────────────────────────────────────
MEDIUM	component-tests/test_prechecks.py	311	# ── row content ──────────────────────────────────────────────────────
MEDIUM	component-tests/test_prechecks.py	346	# ── no action lines ──────────────────────────────────────────────────
MEDIUM	component-tests/test_prechecks.py	350	# ── summary line ─────────────────────────────────────────────────────
MEDIUM	component-tests/test_prechecks.py	354	# ── structured log ───────────────────────────────────────────────────
MEDIUM	component-tests/test_prechecks.py	410	# ── table structure ──────────────────────────────────────────────────
MEDIUM	component-tests/test_prechecks.py	420	# ── row content ──────────────────────────────────────────────────────

Hyper-Verbose Identifiers29 hits · 29 pts

Severity	File	Line	Snippet
LOW	release_pkgs.py	172	def _setup_rpm_pkg_directories(self, artifacts_path, gpg_key_name, archs=["aarch64", "x86_64", "386"]):
LOW	component-tests/conftest.py	54	def wait_previous_cloudflared():
LOW	component-tests/test_termination.py	57	def test_shutdown_once_no_connection(self, tmp_path, component_tests_config, signal, protocol):
LOW	component-tests/test_termination.py	77	def test_no_connection_shutdown(self, tmp_path, component_tests_config, signal, protocol):
LOW	component-tests/test_tail.py	16	async def test_start_stop_streaming(self, tmp_path, component_tests_config):
LOW	component-tests/test_tail.py	62	async def test_streaming_logs_filters(self, tmp_path, component_tests_config):
LOW	component-tests/test_tail.py	90	async def test_streaming_logs_sampling(self, tmp_path, component_tests_config):
LOW	component-tests/test_tail.py	118	async def test_streaming_logs_actor_override(self, tmp_path, component_tests_config):
LOW	component-tests/test_tail.py	136	async def start_streaming_to_be_remotely_closed(url):
LOW	component-tests/test_tail.py	156	async def generate_and_validate_http_events(websocket: WebSocketClientProtocol, url: str, count_send: int):
LOW	component-tests/test_tail.py	174	async def generate_and_validate_no_log_event(websocket: WebSocketClientProtocol, url: str):
LOW	component-tests/test_service.py	26	def test_launchd_service_log_to_file(self, tmp_path, component_tests_config):
LOW	component-tests/test_service.py	43	def test_launchd_service_with_token(self, tmp_path, component_tests_config):
LOW	component-tests/test_service.py	58	def test_launchd_service_rotating_log(self, tmp_path, component_tests_config):
LOW	component-tests/test_service.py	89	def test_sysv_service_log_to_file(self, tmp_path, component_tests_config):
LOW	component-tests/test_service.py	106	def test_sysv_service_rotating_log(self, tmp_path, component_tests_config):
LOW	component-tests/test_service.py	125	def test_sysv_service_with_token(self, tmp_path, component_tests_config):
LOW	component-tests/util.py	138	def run_cloudflared_background(cmd, allow_input, capture_output):
LOW	component-tests/util.py	198	def check_tunnel_not_connected():
LOW	component-tests/test_prechecks.py	123	def _poll_log_file_for_precheck_complete(log_file: str, timeout: float) -> list[dict]:
LOW	component-tests/test_prechecks.py	144	def _read_precheck_log_lines_from_file(log_file: str) -> list[dict]:
LOW	component-tests/test_prechecks.py	238	def _assert_precheck_summary_log(
LOW	component-tests/test_prechecks.py	271	def test_prechecks_pass_on_healthy_connection(self, tmp_path, component_tests_config):
LOW	component-tests/test_prechecks.py	381	def test_prechecks_hard_fail_when_edge_unreachable(self, tmp_path, component_tests_config):
LOW	component-tests/test_prechecks.py	476	def test_diag_contains_prechecks_json(self, tmp_path, component_tests_config):
LOW	component-tests/test_management.py	93	def test_get_metrics_when_disabled(self, tmp_path, component_tests_config):
LOW	component-tests/test_edge_discovery.py	64	def expect_address_connections(self, tmp_path, component_tests_config, protocol, edge_ip_version, assert_address_typ
LOW	component-tests/test_token.py	18	def test_get_credentials_file(self, tmp_path, component_tests_config):
LOW	component-tests/test_config.py	7	def test_validate_ingress_rules(self, tmp_path, component_tests_config):

Over-Commented Block20 hits · 20 pts

Severity	File	Line	Snippet
LOW	.golangci.yaml	61	max-issues-per-linter: 50
LOW	.golangci.yaml	81	# Can use regexp here: `generated.*`, regexp is applied on full path,
LOW	.gitlab-ci.yml	41	#####################################################
LOW	.gitlab-ci.yml	61	#####################################################
LOW	token/encrypt.go	1	// Package encrypter is suitable for encrypting messages you would like to securely share between two points.
LOW	cmd/cloudflared/linux_service.go	101	// nolint: dupword
LOW	crypto/curves.go	21	// Canonical curve lists returned by GetCurvePreferences. They are kept
LOW	crypto/doc.go	1	// Package crypto centralizes the cryptographic primitives and TLS
LOW	crypto/doc.go	21	// CLI flag. No classical fallback is offered, so a peer that does not
LOW	ingress/config.go	301	// HTTP proxy timeout for closing an idle connection
LOW	config/configuration.go	181	OriginRequest OriginRequestConfig `yaml:"originRequest" json:"originRequest"`
LOW	config/configuration.go	201	KeepAliveConnections *int `yaml:"keepAliveConnections" json:"keepAliveConnections,omitempty"`
LOW	edgediscovery/allregions/discovery.go	81	TCP *net.TCPAddr
LOW	prechecks/types.go	81	// Addrs holds the resolved edge addresses for this target. May be empty
LOW	prechecks/checker.go	41
LOW	quic/v3/datagram.go	61
LOW	quic/v3/datagram.go	201	// The datagram structure for UDPSessionPayloadDatagram is:
LOW	quic/v3/datagram.go	281	// Session was received and is ready to proxy.
LOW	quic/v3/datagram.go	301	// 8\| (16 Bytes) \|
LOW	quic/v3/datagram.go	381

Hallucination Indicators2 hits · 20 pts

Severity	File	Line	Snippet
CRITICAL	connection/control.go	112	c.observer.metrics.localConfigMetrics.pushesErrors.Inc()
CRITICAL	connection/control.go	115	c.observer.metrics.localConfigMetrics.pushes.Inc()

AI Slop Vocabulary5 hits · 16 pts

Severity	File	Line	Snippet
LOW	.ci/release.gitlab-ci.yml	21	# we simply set both to the same value.
MEDIUM	ingress/origin_icmp_proxy.go	40	// response to utilize.
MEDIUM	ingress/origins/dns.go	206	// NewDNSDialer creates a custom dialer for the DNS resolver service to utilize.
MEDIUM	component-tests/test_prechecks.py	302	# zerolog writes to stderr which is merged into stdout by the harness.
MEDIUM	component-tests/test_prechecks.py	411	# zerolog writes to stderr which is merged into stdout by the harness.

Unused Imports8 hits · 8 pts

Severity	File	Line
LOW	github_release.py	15
LOW	component-tests/test_management.py	5
LOW	component-tests/test_management.py	8
LOW	component-tests/test_reconnect.py	2
LOW	component-tests/test_reconnect.py	9
LOW	component-tests/test_tunnel.py	6
LOW	component-tests/test_tunnel.py	7
LOW	component-tests/test_tunnel.py	8

Excessive Try-Catch Wrapping5 hits · 6 pts

Severity	File	Line	Snippet
LOW	github_release.py	311	except Exception as e:
LOW	release_pkgs.py	410	except Exception as e:
LOW	github_message.py	166	except Exception as e:
LOW	component-tests/util.py	162	except Exception as e:
MEDIUM	component-tests/util.py	159	def wait_tunnel_ready(tunnel_url=None, require_min_connections=1, cfd_logs=None)

Self-Referential Comments2 hits · 6 pts

Severity	File	Line	Snippet
MEDIUM	.ci/scripts/vuln-check.sh	4	# Define the file to store the list of vulnerabilities to ignore.
MEDIUM	.ci/scripts/component-tests.sh	16	# Define the cleanup function

Docstring Block Structure1 hit · 5 pts

Severity	File	Line	Snippet
HIGH	component-tests/util.py	245	Decode the payload section of a JWT token without signature verification. JWT Structure: =============

Redundant / Tautological Comments3 hits · 4 pts

Severity	File	Line	Snippet
LOW	.ci/scripts/vuln-check.sh	8	# Check if the ignored vulnerabilities file exists. If not, create an empty one.
LOW	.ci/scripts/release-target.sh	4	# Check if a make target is provided as an argument
LOW	.ci/scripts/linux/build-packages.sh	4	# Check if architecture argument is provided

Deep Nesting3 hits · 3 pts

Severity	File	Line
LOW	github_release.py	276
LOW	release_pkgs.py	172
LOW	component-tests/test_prechecks.py	144

Score History

Severity Breakdown

Pattern Findings