bitcoin/bitcoin

Pattern Findings

2215 matches across 15 categories. Click a row to expand file-level details.

Over-Commented Block1359 hits · 1358 pts

Severity	File	Line	Snippet
LOW	test/lint/lint-locale-dependence.py	1	#!/usr/bin/env python3
LOW	test/lint/lint-locale-dependence.py	21	#
LOW	test/lint/test_runner/src/util.rs	1	// Copyright (c) The Bitcoin Core developers
LOW	test/functional/mempool_packages.py	241
LOW	test/functional/wallet_fundrawtransaction.py	1121	self.nodes[0].sendtoaddress(addr1, 5, fee_rate=self.fee_rate_sats_per_vb)
LOW	test/functional/wallet_fundrawtransaction.py	1261	"fee_rate": self.fee_rate_sats_per_vb
LOW	test/functional/wallet_migration.py	1281
LOW	test/functional/mempool_package_limits.py	1	#!/usr/bin/env python3
LOW	test/functional/feature_taproot.py	121	# Whether or not to output generated test vectors, in JSON format.
LOW	test/functional/feature_taproot.py	141	#
LOW	test/functional/feature_taproot.py	441	"script_witv0": None,
LOW	test/functional/feature_taproot.py	701	# == Test involving an internal public key not on the curve ==
LOW	test/functional/wallet_groups.py	81
LOW	test/functional/wallet_resendwallettransactions.py	81	# Tell scheduler to call MaybeResendWalletTxs now.
LOW	test/functional/mining_basic.py	101	# Generate three transactions that must be mined in sequence
LOW	test/functional/test_runner.py	481	# in the ALL_SCRIPTS list. Accept names with or without a .py extension.
LOW	test/functional/feature_pruning.py	381	self.stop_node(3)
LOW	test/functional/feature_pruning.py	401	# repeat this process until you have 12 stale forks hanging off the
LOW	test/functional/feature_pruning.py	421	#
LOW	test/functional/feature_pruning.py	441	#
LOW	test/functional/rpc_decodescript.py	121	# OP_NOP2 is also known as OP_CHECKLOCKTIMEVERIFY.
LOW	test/functional/feature_bind_port_discover.py	21	# interface that is UP and not a loopback interface (IFF_LOOPBACK). To set these
LOW	test/functional/feature_block.py	481	b37 = self.update_block(37, [tx])
LOW	test/functional/feature_block.py	741
LOW	test/functional/feature_block.py	901
LOW	test/functional/feature_block.py	1001	tx2 = self.create_and_sign_transaction(tx1, 1)
LOW	test/functional/feature_block.py	1081	#
LOW	test/functional/wallet_balance.py	101	# First argument of getbalance must be set to "*"
LOW	test/functional/wallet_balance.py	121	#
LOW	test/functional/feature_cltv.py	41	tx.vin[0].nSequence = nsequence
LOW	test/functional/test_framework/script_util.py	41	assert_equal,
LOW	test/functional/test_framework/authproxy.py	1	# Copyright (c) 2011 Jeff Garzik
LOW	test/functional/test_framework/test_framework.py	361	def setup_network(self):
LOW	test/functional/test_framework/script.py	901
LOW	test/functional/test_framework/test_node.py	361	self.wait_until(lambda: rpc.getmempoolinfo()['loaded'])
LOW	test/functional/test_framework/test_node.py	841	if send_version:
LOW	ci/test/00_setup_env.sh	1	#!/usr/bin/env bash
LOW	contrib/tracing/log_raw_p2p_msgs.py	1	#!/usr/bin/env python3
LOW	contrib/tracing/log_raw_p2p_msgs.py	21	# VM's stack is limited to 512 bytes, and we can't allocate more than about 32kb
LOW	contrib/tracing/log_raw_p2p_msgs.py	41	program = """
LOW	contrib/tracing/p2p_monitor.py	1	#!/usr/bin/env python3
LOW	contrib/qos/tc.sh	1	#!/usr/bin/env bash
LOW	contrib/qos/tc.sh	41
LOW	contrib/asmap/asmap.py	161	# of failure the default instruction's argument is returned. It is followed by an
LOW	contrib/linearize/example-linearize.cfg	21
LOW	contrib/verify-commits/gpg.sh	1	#!/bin/sh
LOW	contrib/devtools/headerssync-params.py	21	MINCHAINWORK_HEADERS = 938343
LOW	contrib/devtools/headerssync-params.py	41	# Explanation:
LOW	contrib/devtools/headerssync-params.py	61	# - When redownloading, headers are fed through a per-peer queue that holds {bufsize} headers,
LOW	contrib/devtools/headerssync-params.py	81	# threshold, we will consume per-peer memory that is sufficient to store {n/period}
LOW	contrib/devtools/headerssync-params.py	161	max_rate = None
LOW	contrib/guix/symbol-check.py	21	# Ubuntu 20.04 (Focal) EOL: 2030. https://wiki.ubuntu.com/ReleaseTeam
LOW	contrib/guix/libexec/build.sh	1	#!/usr/bin/env bash
LOW	contrib/guix/libexec/codesign.sh	1	#!/usr/bin/env bash
LOW	.github/workflows/ci.yml	81	# are generally draft pull requests that merge in other
LOW	src/chain.h	1	// Copyright (c) 2009-2010 Satoshi Nakamoto
LOW	src/chain.h	121	//! reached the VALID_TRANSACTIONS level, and zero otherwise.
LOW	src/psbt.cpp	1	// Copyright (c) 2009-present The Bitcoin Core developers
LOW	src/protocol.h	1	// Copyright (c) 2009-2010 Satoshi Nakamoto
LOW	src/protocol.h	321	// NODE_COMPACT_FILTERS means the node will service basic block filter requests.
1299 more matches not shown…

Hyper-Verbose Identifiers515 hits · 513 pts

Severity	File	Line	Snippet
LOW	test/lint/lint-includes.py	101	def find_quote_syntax_inclusions():
LOW	test/lint/lint-tests.py	16	def grep_boost_fixture_test_suite():
LOW	test/lint/lint-tests.py	30	def check_matching_test_names(test_suite_list):
LOW	test/lint/lint-locale-dependence.py	212	def find_locale_dependent_function_uses():
LOW	test/lint/lint-files.py	123	def check_all_file_permissions(files) -> int:
LOW	test/lint/lint-files.py	168	def check_shebang_file_permissions(files_meta) -> int:
LOW	test/lint/check-doc.py	27	def lint_missing_argument_documentation():
LOW	test/lint/check-doc.py	46	def lint_missing_hidden_wallet_args():
LOW	test/fuzz/test_runner.py	204	def transform_process_message_target(targets, src_dir):
LOW	test/functional/rpc_signer.py	36	def skip_test_if_missing_module(self):
LOW	test/functional/tool_bitcoin_chainstate.py	27	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_backwards_compatibility.py	51	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_backwards_compatibility.py	162	def test_ignore_legacy_during_startup(self, legacy_nodes, node_master):
LOW	test/functional/wallet_listreceivedby.py	24	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_startup.py	28	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_startup.py	46	def test_load_unwritable_wallet(self, node):
LOW	test/functional/wallet_change_address.py	27	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_sendmany.py	12	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_sendmany.py	19	def test_sffo_repeated_address(self):
LOW	test/functional/wallet_keypool_topup.py	30	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_reorgsrestore.py	31	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_reorgsrestore.py	34	def test_coinbase_automatic_abandon_during_startup(self):
LOW	test/functional/wallet_reorgsrestore.py	93	def test_reorg_handling_during_unclean_shutdown(self):
LOW	test/functional/mempool_limit.py	35	def test_mid_package_eviction_success(self):
LOW	test/functional/mempool_limit.py	128	def test_mid_package_replacement(self):
LOW	test/functional/interface_ipc.py	26	def skip_test_if_missing_module(self):
LOW	test/functional/interface_ipc.py	71	def run_deprecated_mining_test(self):
LOW	test/functional/interface_ipc.py	86	def run_unclean_disconnect_test(self):
LOW	test/functional/wallet_assumeutxo.py	28	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_assumeutxo.py	69	def complete_background_validation(self, node):
LOW	test/functional/wallet_assumeutxo.py	79	def test_backup_during_background_sync_pruned_node(self, n3, dump_output, expected_error_message):
LOW	test/functional/wallet_assumeutxo.py	92	def test_restore_wallet_pruneheight(self, n3):
LOW	test/functional/wallet_gethdkeys.py	23	def skip_test_if_missing_module(self):
LOW	test/functional/mempool_datacarrier.py	37	def test_null_data_transaction(self, node: TestNode, data, success: bool) -> None:
LOW	test/functional/rpc_help.py	68	def test_client_conversion_table(self):
LOW	test/functional/rpc_help.py	99	def test_client_string_conversion_table(self):
LOW	test/functional/wallet_orphanedreward.py	15	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_musig.py	29	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_musig.py	33	def create_wallets_and_keys_from_pattern(self, pat):
LOW	test/functional/wallet_musig.py	70	def construct_and_import_musig_descriptor_in_wallets(self, pat, wallets, keys, only_one_musig_wallet=False):
LOW	test/functional/p2p_leak_tx.py	67	def test_notfound_on_replaced_tx(self):
LOW	test/functional/p2p_leak_tx.py	100	def test_notfound_on_unannounced_tx(self):
LOW	test/functional/wallet_anchor.py	31	def skip_test_if_missing_module(self):
LOW	test/functional/wallet_simulaterawtx.py	22	def skip_test_if_missing_module(self):
LOW	test/functional/feature_notifications.py	209	def large_work_invalid_chain_warning_in_alert_file(self):
LOW	test/functional/feature_maxuploadtarget.py	55	def assert_uploadtarget_state(self, *, target_reached, serve_historical_blocks):
LOW	test/functional/p2p_handshake.py	49	def test_desirable_service_flags(self, node, service_flag_tests, desirable_service_flags, expect_disconnect):
LOW	test/functional/wallet_basic.py	40	def skip_test_if_missing_module(self):
LOW	test/functional/p2p_invalid_messages.py	103	def test_duplicate_version_msg(self):
LOW	test/functional/p2p_invalid_messages.py	272	def test_oversized_getdata_msg(self):
LOW	test/functional/p2p_invalid_messages.py	276	def test_oversized_headers_msg(self):
LOW	test/functional/p2p_invalid_messages.py	280	def test_invalid_pow_headers_msg(self):
LOW	test/functional/p2p_invalid_messages.py	307	def test_noncontinuous_headers_msg(self):
LOW	test/functional/example_test.py	96	def skip_test_if_missing_module(self):
LOW	test/functional/feature_reindex.py	81	def continue_reindex_after_shutdown(self):
LOW	test/functional/rpc_packages.py	329	def assert_equal_package_results(self, node, testmempoolaccept_result, submitpackage_result):
LOW	test/functional/rpc_packages.py	347	def test_submit_child_with_parents(self, num_parents, partial_submit):
LOW	test/functional/rpc_packages.py	432	def test_maxfeerate_submitpackage(self):
LOW	test/functional/rpc_packages.py	488	def test_maxburn_submitpackage(self):
LOW	test/functional/rpc_packages.py	515	def test_submitpackage_with_ancestors(self):
455 more matches not shown…

Self-Referential Comments97 hits · 300 pts

Severity	File	Line	Snippet
MEDIUM	test/functional/wallet_backwards_compatibility.py	209	# Create a number of wallets and open them in older versions:
MEDIUM	test/functional/wallet_backwards_compatibility.py	218	# Create a confirmed transaction, receiving coins
MEDIUM	test/functional/wallet_backwards_compatibility.py	223	# Create a conflicting transaction using RBF
MEDIUM	test/functional/wallet_listreceivedby.py	172	# Create a new label named "mynewlabel" that has a 0 balance
MEDIUM	test/functional/wallet_reorgsrestore.py	48	# Create a new block in node0, coinbase going to wallet0
MEDIUM	test/functional/wallet_reorgsrestore.py	172	# Create a conflicted tx broadcast on node0 chain and conflicting tx broadcast on node1 chain. Both spend from t
MEDIUM	test/functional/mempool_limit.py	87	# Create a child spending everything with an insane fee, bumping the package above mempool_entry_minrate
MEDIUM	test/functional/mempool_limit.py	171	# Create a child spending everything, CPFPing the low-feerate parent.
MEDIUM	test/functional/wallet_assumeutxo.py	129	# Create a wallet that we will create a backup for later (at snapshot height)
MEDIUM	test/functional/wallet_anchor.py	37	# Create an anchor output, and spend it
MEDIUM	test/functional/wallet_basic.py	211	# Create a couple of transactions to send them to node2, submit them through
MEDIUM	test/functional/feature_assumevalid.py	92	# Create the first block with a coinbase output to our key
MEDIUM	test/functional/feature_assumevalid.py	112	# Create a transaction spending the coinbase output with an invalid (null) signature
MEDIUM	test/functional/rpc_packages.py	416	# Create a transaction chain such as only the parent gets accepted (by making the child's
MEDIUM	test/functional/wallet_rescan_unconfirmed.py	46	# Create an unconfirmed child transaction from the parent tx, sending all
MEDIUM	test/functional/wallet_bumpfee.py	203	# Create a tx with two outputs. recipient and change.
MEDIUM	test/functional/wallet_bumpfee.py	350	# Create a transaction with segwit output, then create an RBF transaction
MEDIUM	test/functional/wallet_bumpfee.py	553	# Create a wallet with private keys that can sign PSBTs
MEDIUM	test/functional/interface_rest.py	174	# Create a transaction, check that it's found with /checkmempool, but
MEDIUM	test/functional/wallet_listsinceblock.py	421	# Create a watchonly wallet tracking two multisig descriptors.
MEDIUM	test/functional/wallet_listsinceblock.py	459	# Create a UTxO paying to one of our change addresses.
MEDIUM	test/functional/wallet_fundrawtransaction.py	1493	# Create a replacement tx to 'final_tx1' that has 1 BTC target instead of 0.1.
MEDIUM	test/functional/feature_bip68_sequence.py	220	# Create a mempool tx.
MEDIUM	test/functional/feature_bip68_sequence.py	235	# Create a spend of the 0th output of orig_tx with a sequence lock
MEDIUM	test/functional/p2p_compactblocks.py	412	# Create a chain of transactions from given utxo, and add to a new block.
MEDIUM	test/functional/wallet_migration.py	1329	# Create a wsh(sh(pkh())) - P2SH inside of P2WSH is invalid
MEDIUM	test/functional/wallet_migration.py	1339	# Create a wsh(wsh(pkh())) - P2WSH inside of P2WSH is invalid
MEDIUM	test/functional/mempool_updatefromblock.py	77	# Create a new transaction.
MEDIUM	test/functional/feature_taproot.py	1335	# Create a list of scripts which will be built into a taptree
MEDIUM	test/functional/mempool_persist.py	108	# Create a tx and prioritise but don't submit until after the restart.
MEDIUM	test/functional/feature_segwit.py	237	# Create a 3-tx chain: tx1 (non-segwit input, paying to a segwit output) ->
MEDIUM	test/functional/wallet_abandonconflict.py	82	#Create a child tx spending AB1 and C
MEDIUM	test/functional/wallet_abandonconflict.py	91	# Create a child tx spending ABC2
MEDIUM	test/functional/wallet_abandonconflict.py	175	# Create a double spend of AB1 by spending again from only A's 10 output
MEDIUM	test/functional/feature_utxo_set_hash.py	36	# Create a spending transaction and mine a block which includes it
MEDIUM	test/functional/rpc_psbt.py	825	# Create a psbt spending outputs from nodes 1 and 2
MEDIUM	test/functional/rpc_psbt.py	1032	# Create a PSBT. None of the inputs are filled initially
MEDIUM	test/functional/rpc_signrawtransactionwithkey.py	77	# Create a new P2SH-P2WSH 1-of-1 multisig address:
MEDIUM	test/functional/feature_assumeutxo.py	268	# Create an alternative chain of 2 new blocks, forking off the main chain at the block before the snapshot block
MEDIUM	test/functional/feature_assumeutxo.py	427	# Create a stale block that forks off the main chain before the snapshot.
MEDIUM	test/functional/p2p_1p1c_network.py	107	# Create the transactions.
MEDIUM	test/functional/p2p_invalid_block.py	121	# Create a block that spends the output of a tx in a previous block.
MEDIUM	test/functional/feature_config_args.py	191	# Create a temporary directory that will be treated as the default data
MEDIUM	test/functional/feature_config_args.py	463	# Create a temporary directory that will be treated as the default data
MEDIUM	test/functional/feature_config_args.py	561	# Create the directory and ensure the config file now works
MEDIUM	test/functional/rpc_net.py	104	# Create a few getpeerinfo last_block/last_transaction values.
MEDIUM	test/functional/p2p_segwit.py	310	# Create a transaction that spends the coinbase
MEDIUM	test/functional/p2p_segwit.py	624	# Create the same output as tx3, but by replacing tx
MEDIUM	test/functional/p2p_segwit.py	890	# Create a P2WSH transaction.
MEDIUM	test/functional/p2p_segwit.py	1145	# Create a transaction that splits our utxo into many outputs
MEDIUM	test/functional/p2p_segwit.py	1616	# Create a slight bias for producing more utxos
MEDIUM	test/functional/p2p_segwit.py	1718	# Create a p2sh output -- this is so we can pass the standardness
MEDIUM	test/functional/p2p_segwit.py	2001	# Create a Segwit output from the latest UTXO
MEDIUM	test/functional/p2p_segwit.py	2010	# Create a Segwit transaction
MEDIUM	test/functional/mempool_cluster.py	132	# Create a package from the second to last transaction.
MEDIUM	test/functional/mempool_cluster.py	199	# Create a chain of transactions
MEDIUM	test/functional/mempool_cluster.py	259	# Create a transaction spending from all clusters that exceeds the cluster size limit.
MEDIUM	test/functional/p2p_private_broadcast.py	226	# Create a Python P2P listening node and instruct the SOCKS5 proxy to
MEDIUM	test/functional/wallet_avoidreuse.py	124	# Create a wallet with avoid reuse, and test that disabling it afterwards persists
MEDIUM	test/functional/wallet_avoidreuse.py	144	# Create a wallet with disable_private_keys set; this should work
37 more matches not shown…

Decorative Section Separators44 hits · 159 pts

Severity	File	Line	Snippet
MEDIUM	CMakeLists.txt	26	#=============================
MEDIUM	CMakeLists.txt	28	#=============================
MEDIUM	CMakeLists.txt	69	#=============================
MEDIUM	CMakeLists.txt	71	#=============================
MEDIUM	CMakeLists.txt	98	#=============================
MEDIUM	CMakeLists.txt	100	#=============================
MEDIUM	CMakeLists.txt	154	#=============================
MEDIUM	CMakeLists.txt	156	#=============================
MEDIUM	CMakeLists.txt	168	#=============================
MEDIUM	CMakeLists.txt	170	#=============================
MEDIUM	CMakeLists.txt	203	#=============================
MEDIUM	CMakeLists.txt	205	#=============================
MEDIUM	CMakeLists.txt	212	#=============================
MEDIUM	CMakeLists.txt	214	#=============================
MEDIUM	test/functional/wallet_conflicts.py	67	# ----------------
MEDIUM	test/functional/feature_assumeutxo.py	720	# -----------------------------
MEDIUM	src/CMakeLists.txt	10	#=============================
MEDIUM	src/CMakeLists.txt	12	#=============================
MEDIUM	src/secp256k1/CMakeLists.txt	3	#=============================
MEDIUM	src/secp256k1/CMakeLists.txt	5	#=============================
MEDIUM	src/secp256k1/CMakeLists.txt	28	#=============================
MEDIUM	src/secp256k1/CMakeLists.txt	30	#=============================
MEDIUM	src/secp256k1/CMakeLists.txt	34	#=============================
MEDIUM	src/secp256k1/CMakeLists.txt	36	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	3	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	5	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	13	# ============================================================
MEDIUM	src/minisketch/CMakeLists.txt	15	# ============================================================
MEDIUM	src/minisketch/CMakeLists.txt	34	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	36	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	49	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	51	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	83	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	85	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	96	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	98	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	115	#=============================
MEDIUM	src/minisketch/CMakeLists.txt	117	#=============================
MEDIUM	src/node/mini_miner.cpp	337	// ┌─────────────────┐
MEDIUM	src/node/mini_miner.cpp	344	// └──────▲───▲──────┘ P2_ASFR: 2.47 s/vB
MEDIUM	src/node/mini_miner.cpp	346	// ┌───────────────┐ │ │ ┌──────────────┐
MEDIUM	src/node/mini_miner.cpp	353	// └───────────▲───┘ └───▲──────────┘
MEDIUM	src/node/mini_miner.cpp	355	// │ ┌───────────┐ │
MEDIUM	src/node/mini_miner.cpp	362	// └───────────┘

Deep Nesting94 hits · 94 pts

Severity	File	Line
LOW	test/download_utils.py	12
LOW	test/get_previous_releases.py	107
LOW	test/lint/lint-files.py	123
LOW	test/lint/lint-files.py	168
LOW	test/functional/combine_logs.py	103
LOW	test/functional/combine_logs.py	145
LOW	test/functional/wallet_backwards_compatibility.py	88
LOW	test/functional/wallet_backwards_compatibility.py	194
LOW	test/functional/wallet_keypool_topup.py	33
LOW	test/functional/wallet_gethdkeys.py	78
LOW	test/functional/wallet_gethdkeys.py	132
LOW	test/functional/rpc_help.py	20
LOW	test/functional/wallet_musig.py	33
LOW	test/functional/wallet_musig.py	171
LOW	test/functional/p2p_v2_misbehaving.py	104
LOW	test/functional/p2p_v2_misbehaving.py	159
LOW	test/functional/wallet_address_types.py	98
LOW	test/functional/wallet_address_types.py	157
LOW	test/functional/wallet_address_types.py	224
LOW	test/functional/wallet_fundrawtransaction.py	66
LOW	test/functional/feature_bip68_sequence.py	129
LOW	test/functional/mempool_updatefromblock.py	33
LOW	test/functional/feature_taproot.py	510
LOW	test/functional/feature_taproot.py	677
LOW	test/functional/feature_taproot.py	1451
LOW	test/functional/feature_taproot.py	1653
LOW	test/functional/feature_taproot.py	1774
LOW	test/functional/feature_utxo_set_hash.py	22
LOW	test/functional/wallet_transactiontime_rescan.py	31
LOW	test/functional/rpc_psbt.py	535
LOW	test/functional/interface_bitcoin_cli.py	42
LOW	test/functional/p2p_private_broadcast.py	358
LOW	test/functional/p2p_private_broadcast.py	408
LOW	test/functional/interface_usdt_coinselection.py	139
LOW	test/functional/wallet_send.py	40
LOW	test/functional/test_runner.py	406
LOW	test/functional/test_runner.py	583
LOW	test/functional/test_runner.py	756
LOW	test/functional/p2p_tx_download.py	384
LOW	test/functional/wallet_taproot.py	308
LOW	test/functional/feature_reindex_readonly.py	22
LOW	test/functional/p2p_disconnect_ban.py	19
LOW	test/functional/interface_zmq.py	139
LOW	test/functional/interface_zmq.py	457
LOW	test/functional/feature_torcontrol.py	60
LOW	test/functional/feature_torcontrol.py	86
LOW	test/functional/p2p_sendheaders.py	257
LOW	test/functional/test_framework/v2_p2p.py	177
LOW	test/functional/test_framework/p2p.py	258
LOW	test/functional/test_framework/p2p.py	319
LOW	test/functional/test_framework/util.py	425
LOW	test/functional/test_framework/util.py	598
LOW	test/functional/test_framework/key.py	292
LOW	test/functional/test_framework/key.py	315
LOW	test/functional/test_framework/netutil.py	156
LOW	test/functional/test_framework/socks5.py	52
LOW	test/functional/test_framework/socks5.py	130
LOW	test/functional/test_framework/messages.py	358
LOW	test/functional/test_framework/messages.py	389
LOW	test/functional/test_framework/authproxy.py	126
34 more matches not shown…

Excessive Try-Catch Wrapping41 hits · 49 pts

Severity	File	Line	Snippet
LOW	test/download_utils.py	58	except Exception as e:
LOW	test/download_utils.py	64	except Exception as e2:
LOW	test/get_previous_releases.py	134	except Exception as e:
LOW	test/get_previous_releases.py	140	except Exception as e2:
LOW	test/get_previous_releases.py	172	except Exception as e:
LOW	test/functional/feature_dbcrash.py	87	except Exception:
LOW	test/functional/feature_dbcrash.py	111	except Exception as e:
LOW	test/functional/feature_dbcrash.py	171	except Exception:
LOW	test/functional/p2p_node_network_limited.py	143	except Exception:
LOW	test/functional/tool_utils.py	78	except Exception as e:
LOW	test/functional/tool_utils.py	83	except Exception as e:
LOW	test/functional/feature_reindex_readonly.py	57	except Exception:
LOW	test/functional/feature_reindex_readonly.py	74	except Exception:
LOW	test/functional/tool_bitcoin.py	60	except Exception as e:
LOW	test/functional/rpc_preciousblock.py	20	except Exception:
LOW	test/functional/test_framework/p2p.py	376	except Exception as e:
LOW	test/functional/test_framework/p2p.py	525	except Exception:
LOW	test/functional/test_framework/util.py	124	except Exception as e:
LOW	test/functional/test_framework/util.py	190	except Exception as e:
LOW	test/functional/test_framework/util.py	199	except Exception as e:
MEDIUM	test/functional/test_framework/util.py	115	def assert_raises_message(exc, message, fun, args, *kwds):
MEDIUM	test/functional/test_framework/util.py	196	def assert_is_hex_string(string):
LOW	test/functional/test_framework/socks5.py	207	except Exception as e:
LOW	test/functional/test_framework/socks5.py	246	except Exception as e:
MEDIUM	test/functional/test_framework/socks5.py	242	def try_join_daemon_thread(thread, timeout=0) -> bool:
LOW	ci/lint.py	19	except Exception as e:
LOW	ci/test/02_run_container.py	19	except Exception as e:
MEDIUM	ci/test/02_run_container.py	113	print(f"Error: Directory '{os.environ['CCACHE_DIR']}' must be created in advance.")
LOW	contrib/signet/getcoins.py	145	except Exception:
LOW	contrib/message-capture/message-capture-parser.py	148	except Exception:
MEDIUM	contrib/utxo-tools/utxo_to_sqlite.py	123	print(f"Error: provided input file '{args.infile}' doesn't exist.")
MEDIUM	contrib/utxo-tools/utxo_to_sqlite.py	127	print(f"Error: provided output file '{args.outfile}' already exists.")
MEDIUM	contrib/utxo-tools/utxo_to_sqlite.py	148	print(f"Error: provided input file '{args.infile}' is not an UTXO dump.")
MEDIUM	contrib/utxo-tools/utxo_to_sqlite.py	151	print(f"Error: provided input file '{args.infile}' has unknown UTXO dump version {version} "
LOW	contrib/guix/security-check.py	41	except Exception:
LOW	contrib/verify-binaries/test.py	19	except Exception:
LOW	contrib/verify-binaries/test.py	34	except Exception:
LOW	contrib/verify-binaries/verify.py	448	except Exception as e:
LOW	.github/ci-windows.py	23	except Exception as e:
LOW	.github/ci-test-each-commit-exec.py	16	except Exception as e:
LOW	.github/ci-windows-cross.py	22	except Exception as e:

AI Slop Vocabulary18 hits · 42 pts

Severity	File	Line	Snippet
MEDIUM	test/functional/p2p_v2_misbehaving.py	180	# Make a passing connection for more robust disconnection checking.
LOW	test/functional/rpc_createmultisig.py	64	expected_ms_script = keys_to_multisig_script(keys, k=nkeys) # simply use n-of-n
MEDIUM	test/functional/wallet_migration.py	1289	# In order to get the wsh(pkh()) into only mapScripts and not setWatchOnly, we need to utilize
LOW	test/functional/rpc_psbt.py	450	# The decodepsbt RPC is stateless and independent of any settings, we can always just call it on the first node
LOW	test/functional/mining_basic.py	490	# We know the header for this invalid block, so should just return early without error:
LOW	test/functional/mempool_package_rbf.py	73	# coins (to create conflicts), and perhaps giving them the same fee, we might accidentally just create the same
LOW	test/functional/mempool_truc.py	319	# tx_0fee_parent is our transaction "B"; just create it.
LOW	test/functional/mining_prioritisetransaction.py	341	# This is a less than 1000-byte transaction, so just set the fee
LOW	test/functional/test_framework/test_node.py	142	# For those callers that need more flexibility, they can just set the args property directly.
MEDIUM	test/functional/test_framework/test_node.py	374	# The wait is done here to make tests as robust as possible
LOW	contrib/devtools/gen-manpages.py	91	# Copyright is the same for all binaries, so just use the first.
MEDIUM	contrib/guix/libexec/build.sh	16	# time-machine to a commit which includes the aforementioned change, we can
MEDIUM	contrib/guix/libexec/codesign.sh	16	# time-machine to a commit which includes the aforementioned change, we can
MEDIUM	src/protocol.h	335	// unauthenticated advertisements, so your code must be robust against
MEDIUM	src/validation.cpp	1456	// N.B. this doesn't take into account CPFPs. Chunk-aware validation may be more robust.
MEDIUM	src/net.cpp	3759	// We also should be robust to those attacks which may not require scraping full victim's AddrMan
MEDIUM	src/test/key_io_tests.cpp	122	// Goal: check that base58 parsing code is robust against a variety of corrupted data
MEDIUM	src/policy/truc_policy.h	19	// RBF abilities more robust. A transaction with version=3 is treated as TRUC.

Cross-Language Confusion7 hits · 38 pts

Severity	File	Line	Snippet
HIGH	test/functional/feature_assumevalid.py	112	# Create a transaction spending the coinbase output with an invalid (null) signature
HIGH	test/functional/interface_usdt_coinselection.py	63	coin_selection_events.push(&data, 0);
HIGH	test/functional/interface_usdt_coinselection.py	77	coin_selection_events.push(&data, 0);
HIGH	test/functional/interface_usdt_coinselection.py	88	coin_selection_events.push(&data, 0);
HIGH	test/functional/interface_usdt_coinselection.py	103	coin_selection_events.push(&data, 0);
HIGH	test/functional/interface_http.py	298	assert b'{"result":"high-hash","error":null}\n' in response1
HIGH	.github/ci-windows.py	53	f'"{comspec}" /s /c ""{vsdevcmd}" -arch=x64 -no_logo && set"',

Cross-File Repetition6 hits · 30 pts

Severity	File	Snippet
HIGH	test/functional/tool_bitcoin_chainstate.py	use the pregenerated, deterministic chain up to height 199.
HIGH	test/functional/wallet_assumeutxo.py	use the pregenerated, deterministic chain up to height 199.
HIGH	test/functional/feature_assumeutxo.py	use the pregenerated, deterministic chain up to height 199.
HIGH	test/functional/tool_bitcoin_chainstate.py	start with the nodes disconnected so that one can generate a snapshot including blocks the other hasn't yet seen.
HIGH	test/functional/wallet_assumeutxo.py	start with the nodes disconnected so that one can generate a snapshot including blocks the other hasn't yet seen.
HIGH	test/functional/feature_assumeutxo.py	start with the nodes disconnected so that one can generate a snapshot including blocks the other hasn't yet seen.

Redundant / Tautological Comments10 hits · 14 pts

Severity	File	Line	Snippet
LOW	test/lint/lint-includes.py	133	# Check if code includes .cpp-files
LOW	test/lint/lint-includes.py	152	# Check if Boost dependencies are no longer used
LOW	test/functional/example_test.py	85	# Set setup_clean_chain to True to skip this and start from the Genesis
LOW	test/functional/interface_rest.py	396	# Check if the 3 tx show up in the new block
LOW	test/functional/rpc_invalidateblock.py	107	# Check if it's possible for an ancestor (with block data) to be the chain tip
LOW	test/functional/mempool_accept.py	190	tx.vin[0].prevout.n = 1 # Set vout to 1, to spend the other outpoint (49 coins) of the in-chain-tx we want to d
LOW	test/functional/wallet_txn_doublespend.py	51	# Assign coins to foo and bar addresses:
LOW	test/functional/feature_fee_estimation.py	342	# Verify if the string "Flushed fee estimates to fee_estimates.dat." is present in the debug log file.
LOW	test/functional/test_framework/util.py	345	# Set paths to bitcoin core binaries allowing overrides with environment
LOW	contrib/signet/getcoins.py	148	# Display the output as per the returned status code

Overly Generic Function Names12 hits · 14 pts

Severity	File	Line	Snippet
LOW	test/functional/p2p_orphan_handling.py	96	def test_function():
LOW	test/functional/test_framework/p2p.py	601	def test_function():
LOW	test/functional/test_framework/p2p.py	617	def test_function():
LOW	test/functional/test_framework/p2p.py	624	def test_function():
LOW	test/functional/test_framework/p2p.py	632	def test_function():
LOW	test/functional/test_framework/p2p.py	638	def test_function():
LOW	test/functional/test_framework/p2p.py	647	def test_function():
LOW	test/functional/test_framework/p2p.py	659	def test_function():
LOW	test/functional/test_framework/p2p.py	671	def test_function():
LOW	test/functional/test_framework/p2p.py	686	def test_function():
LOW	test/functional/test_framework/p2p.py	694	def test_function():
LOW	test/functional/test_framework/p2p.py	718	def test_function():

Unused Imports6 hits · 6 pts

Severity	File	Line
LOW	test/functional/test_framework/test_framework.py	875
LOW	test/functional/test_framework/test_framework.py	889
LOW	test/functional/test_framework/test_framework.py	896
LOW	contrib/devtools/clang-format-diff.py	24
LOW	contrib/devtools/clang-format-diff.py	24
LOW	contrib/devtools/clang-format-diff.py	24

Verbosity Indicators3 hits · 4 pts

Severity	File	Line	Snippet
LOW	src/cluster_linearize.h	1022	* This variable stores the tiebreak of the current best candidate. */
LOW	src/script/sign.cpp	783	// Note we need to check if the result stack is empty before, because it might be used even if the Script
LOW	src/secp256k1/include/secp256k1_preallocated.h	29	* The purpose of this function is to determine how much memory must be provided

Fake / Example Data2 hits · 2 pts

Severity	File	Line	Snippet
LOW	src/crypto/sha256.cpp	493	"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do "
LOW	src/crypto/sha256.cpp	493	"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do "

Slop Phrases1 hit · 2 pts

Severity	File	Line	Snippet
LOW	src/netbase.cpp	868	/* Don't forget to update doc/p2p-bad-ports.md if you change this list. */

Score History

Severity Breakdown

Pattern Findings