argoproj/argo-workflows

Pattern Findings

128 matches across 8 categories. Click a row to expand file-level details.

Over-Commented Block78 hits · 78 pts

Severity	File	Line	Snippet
LOW	.golangci.yml	121	# Check //go:build and // +build directives.
LOW	cmd/argoexec/commands/emissary.go	281	}
LOW	test/e2e/manifests/kubelet-configuration.yaml	1	# The E2E CI workflow passes this file to k3s using "--kubelet-arg=config=".
LOW	test/e2e/functional/secrets.yaml	1	# This example demonstrates how to reference kubernetes secrets in a workflow.
LOW	test/e2e/functional/dag-targets.yaml	1	# This workflow illustrates the use of DAG "targets". Targets can be thought of similarly to make
LOW	test/e2e/functional/dag-diamond-steps.yaml	1	# The following workflow executes a diamond workflow, with each
LOW	test/e2e/functional/output-parameter.yaml	1	# Output parameters provide a way to use the contents of a file,
LOW	util/grpc/mux.go	41	// From: https://pkg.go.dev/golang.org/x/net@v0.41.0/http2/h2c#NewHandler
LOW	config/config.go	41	// KubeConfig specifies a kube config file for the wait & init containers
LOW	config/config.go	121	// Synchronization via databases config
LOW	hack/manifests/crds.go	41	}
LOW	hack/manifests/crds.go	101	// steps:
LOW	hack/embeddoc/main.go	1	// embeddoc is a tool that extracts code snippets from source files and embeds them into documentation.
LOW	server/artifacts/artifact_server.go	61	//nolint:contextcheck
LOW	server/auth/sso/sso.go	361	if !isValidFinalRedirectURL(cookie.Value) {
LOW	docs/workflow-controller-configmap.yaml	1	# This file describes the config settings available in the workflow controller configmap
LOW	docs/workflow-controller-configmap.yaml	21	parallelism: "10"
LOW	docs/workflow-controller-configmap.yaml	41	nodeEvents: \|
LOW	docs/workflow-controller-configmap.yaml	101
LOW	docs/workflow-controller-configmap.yaml	121	# AWS: s3.amazonaws.com
LOW	docs/workflow-controller-configmap.yaml	161	# unless kmsKeyId or serverSideCustomerKeySecret is set
LOW	docs/workflow-controller-configmap.yaml	301	name: argo-postgres-config
LOW	docs/workflow-controller-configmap.yaml	321	# tableName: argo_workflows
LOW	docs/workflow-controller-configmap.yaml	381	# enabled: true
LOW	docs/workflow-controller-configmap.yaml	401	# podSpecLogStrategy: \|
LOW	docs/workflow-controller-configmap.yaml	441	# SSO Configuration for the Argo server.
LOW	docs/workflow-controller-configmap.yaml	481	# Current options:
LOW	docs/argo-server-sso.md	81	# * `iss` - the issuer ("argo-server")
LOW	examples/secrets.yaml	1	# This example demonstrates how to reference kubernetes secrets in a workflow.
LOW	examples/dag-targets.yaml	1	# This workflow illustrates the use of DAG "targets". Targets can be thought of similarly to make
LOW	examples/dag-diamond-steps.yaml	1	# The following workflow executes a diamond workflow, with each
LOW	examples/synchronization-wf-level.yaml	1	# This example demonstrates the use of a Synchronization lock on workflow execution. Synchronization lock limits
LOW	examples/hdfs-artifact.yaml	41	hdfsUser: root
LOW	examples/hdfs-artifact.yaml	61	path: /tmp/message
LOW	examples/input-artifact-git.yaml	21	# reference the secret keys in the secret selectors: usernameSecret, passwordSecret,
LOW	examples/input-artifact-git.yaml	41	#
LOW	examples/buildkit-template.yaml	1	# SUMMARY:
LOW	examples/template-on-exit.yaml	1	# Example showing a Step with an onExit template. The onExit template ("exitContainer")
LOW	examples/output-artifact-azure.yaml	21	path: /tmp
LOW	examples/input-artifact-s3.yaml	21	path: /my-artifact
LOW	examples/output-artifact-gcs.yaml	21	- name: message
LOW	examples/memoize-simple.yaml	1	# This example demonstrates the ability to memoize a template.
LOW	examples/output-artifact-s3.yaml	21	path: /tmp
LOW	examples/dag-custom-metrics.yaml	1	# The following workflow executes the tasks in parallel and emit the data for each task
LOW	examples/output-parameter.yaml	1	# Output parameters provide a way to use the contents of a file,
LOW	workflow/util/util_test.go	4661	assert.Equal(t, wfv1.NodeSucceeded, siblingNode.Phase,
LOW	workflow/controller/operator.go	81	controller *WorkflowController
LOW	workflow/controller/operator.go	2501	node = retryNode
LOW	workflow/controller/exit_handler_test.go	961	# displayName: step-1.onExit
LOW	workflow/controller/dag.go	41
LOW	workflow/controller/workflowpod.go	1161	// It is the responsibility of the init container to load all artifacts to the mounted emptydir location.
LOW	workflow/common/common.go	81	LabelKeyCreatorPreferredUsername = workflow.WorkflowFullName + "/creator-preferred-username"
LOW	workflow/executor/osspecific/signal_windows.go	81	return fmt.Errorf("failed to open remote thread in target process %d: %w", pid, err)
LOW	workflow/sync/sync_manager.go	161	// and template level keys. So upgrading is a bit tricky here.
LOW	.github/workflows/release.yaml	21
LOW	errors/errors.go	81	}
LOW	pkg/apis/workflow/v1alpha1/workflow_types.go	301	// +patchMergeKey=name
LOW	pkg/apis/workflow/v1alpha1/workflow_types.go	361	// in pods that reference this ServiceAccount. ImagePullSecrets are distinct from Secrets because Secrets
LOW	pkg/apis/workflow/v1alpha1/workflow_types.go	381	DNSConfig *apiv1.PodDNSConfig `json:"dnsConfig,omitempty" protobuf:"bytes,16,opt,name=dnsConfig"`
LOW	pkg/apis/workflow/v1alpha1/workflow_types.go	401
18 more matches not shown…

Hyper-Verbose Identifiers21 hits · 21 pts

Severity	File	Line	Snippet
LOW	ui/src/cron-workflows/cron-workflow-status-viewer.tsx	42	function getCronWorkflowActiveWorkflowList(active: kubernetes.ObjectReference[]) {
LOW	…nts/workflow-dag/workflow-dag-render-options-panel.tsx	5	export function WorkflowDagRenderOptionsPanel(props: WorkflowDagRenderOptions & {onChange: (changed: WorkflowDagRenderOp
LOW	…lows-summary-container/workflows-summary-container.tsx	11	export function WorkflowsSummaryContainer(props: {workflows: Workflow[]}) {
LOW	…rkflows/components/workflow-details/suspend-inputs.tsx	68	function renderInputContentIfApplicable() {
LOW	…flows/components/workflow-details/workflow-details.tsx	137	function getInputParametersForNode(selectedWorkflowNodeId: string): Parameter[] {
LOW	…flows/components/workflow-details/workflow-details.tsx	456	function getParametersAsJsonString() {
LOW	…flows/components/workflow-details/workflow-details.tsx	464	function updateOutputParametersForNodeIfRequired() {
LOW	…ows/components/workflows-toolbar/workflows-toolbar.tsx	69	async function performActionOnSelectedWorkflows(title: string, action: WorkflowOperationAction, deleteArchived: bool
LOW	ui/src/shared/pod-name.ts	40	export function ensurePodNamePrefixLength(prefix: string): string {
LOW	ui/src/shared/get_workflow_params.ts	18	export function getWorkflowParametersFromQuery(history: History): {[key: string]: string} {
LOW	ui/src/shared/components/parameters-input.tsx	29	function displaySelectFieldForEnumValues(parameter: Parameter) {
LOW	ui/src/shared/components/parameters-input.tsx	43	function displayInputFieldForSingleValue(parameter: Parameter) {
LOW	ui/src/shared/components/links.tsx	26	function splitWithMetadataKnowledge(replaceable: string) {
LOW	ui/src/shared/components/editors/graph-viewer.tsx	114	function populateGraphFromWorkflow(workflow: Workflow, name: string): Graph {
LOW	…d/components/editors/labels-and-annotations-editor.tsx	6	export function LabelsAndAnnotationsEditor({value, onChange}: {value: kubernetes.ObjectMeta; onChange: (value: kubernete
LOW	ui/src/shared/components/graph/graph-panel.tsx	104	function getNodeMapWithAllNodesSetToValue(nodeSelectionMap: INodeSelectionMap, value: boolean) {
LOW	…rkflow-templates/cluster-workflow-template-creator.tsx	14	export function ClusterWorkflowTemplateCreator({onCreate}: {onCreate: (workflow: ClusterWorkflowTemplate) => void}) {
LOW	…rkflow-templates/cluster-workflow-template-details.tsx	27	export function ClusterWorkflowTemplateDetails({history, location, match}: RouteComponentProps<any>) {
LOW	…kflow-templates/cluster-workflow-template-markdown.tsx	14	export function ClusterWorkflowTemplateMarkdown(props: ClusterWorkflowTemplateMarkdownProps) {
LOW	…-workflow-templates/cluster-workflow-template-list.tsx	26	export function ClusterWorkflowTemplateList({history, location}: RouteComponentProps<any>) {
LOW	…-workflow-templates/cluster-workflow-template-list.tsx	33	async function fetchClusterWorkflowTemplates() {

Self-Referential Comments5 hits · 18 pts

Severity	File	Line	Snippet
MEDIUM	cmd/argo/commands/clustertemplate/create.go	24	Example: `# Create a Cluster Workflow Template:
MEDIUM	cmd/argo/commands/clustertemplate/create.go	27	# Create a Cluster Workflow Template and print it as YAML:
MEDIUM	cmd/argo/commands/clustertemplate/create.go	30	# Create a Cluster Workflow Template with relaxed validation:
MEDIUM	cmd/argo/commands/sync/create.go	29	# Create a database sync limit:
MEDIUM	cmd/argo/commands/sync/create.go	32	# Create a configmap sync limit:

AI Slop Vocabulary6 hits · 18 pts

Severity	File	Line	Snippet
MEDIUM	test/e2e/functional/testvolume.yaml	1	# This PVC manifest is to be used in conjunction with the
MEDIUM	util/grpc/mux.go	45	// any HTTP server that does not handle h2c. Therefore we leverage the HTTP/1
MEDIUM	hack/proto-export/main.go	84	// Sequence for robust shallow fetch of a specific ref (branch, tag, or SHA)
MEDIUM	examples/testvolume.yaml	1	# This PVC manifest is to be used in conjunction with the
MEDIUM	examples/cron-backfill.yaml	81	# making this more robust
MEDIUM	pkg/apis/workflow/v1alpha1/workflow_types.go	2519	// For every invocation of a template, there are nodes which we considered as "outbound". Essentially,

Verbosity Indicators10 hits · 15 pts

Severity	File	Line	Snippet
LOW	sdks/go/workflow-template/main.go	44	// Step 1: Create a WorkflowTemplate
LOW	sdks/go/workflow-template/main.go	102	// Step 2: Submit workflow from template with default parameters
LOW	sdks/go/workflow-template/main.go	125	// Step 3: Submit workflow with custom parameters
LOW	sdks/go/workflow-template/main.go	154	// Step 4: List workflows created from this template
LOW	sdks/go/workflow-template/main.go	174	// Step 5: Get template details
LOW	workflow/controller/steps.go	441	// Step 0: replace all parameter scope references for volumes
LOW	workflow/controller/steps.go	449	// Step 1: replace all parameter scope references in the step
LOW	workflow/controller/steps.go	515	// Step 2: replace all artifact references
LOW	workflow/controller/operator.go	1409	// if the pod is succeeded, we need to check if it is a daemoned step or not
LOW	workflow/controller/exit_handler.go	83	// Step 2: replace all artifact references

Hallucination Indicators1 hit · 10 pts

Severity	File	Line	Snippet
CRITICAL	workflow/controller/operator.go	4393	return woc.wf.Status.FinishedAt.Time.Sub(woc.wf.Status.StartedAt.Time).Seconds()

Redundant / Tautological Comments6 hits · 8 pts

Severity	File	Line	Snippet
LOW	ui/test/ui/ui-wacky-workflow.yaml	29	# Iterate over the list of numbers generated by the generate step above
LOW	cmd/argo/commands/node.go	29	Example: `# Set outputs to a node within a workflow:
LOW	hack/test-go-sdk.sh	27	# Check if this example should be skipped
LOW	hack/test-go-sdk.sh	33	# Check if this example has custom configurations
LOW	hack/docs/clean_swagger_md.py	147	# Check if this is a table row
LOW	.github/workflows/cherry-pick-single.yml	64	# Check if target branch exists

Slop Phrases1 hit · 3 pts

Severity	File	Line	Snippet
MEDIUM	examples/k8s-resource-log-selector.yaml	44	# For example, you can use `argo logs -c tensorflow -l replica-index=0` to see the first worker pod's

Score History

Severity Breakdown

Pattern Findings