argoproj/argo-cd

Pattern Findings

225 matches across 11 categories. Click a row to expand file-level details.

Over-Commented Block134 hits · 134 pts

Severity	File	Line	Snippet
LOW	cmd/argocd/commands/app.go	2461	app, err := appClient.Get(ctx, &application.ApplicationQuery{
LOW	test/manifests/cmp/app/subdir/sidecar.yaml	1	# This yaml is used mainly to trigger the CMP plugin
LOW	util/webhook/webhook.go	481	// the given webURL. webURL is expected to be a URL from an SCM webhook payload pointing to the web
LOW	util/webhook/registry.go	21	// content digest. This structure is produced by registry-specific parsers
LOW	util/metrics/kubectl/kubectl_metrics.go	21	LabelCallStatus = "call_status"
LOW	util/settings/resources_filter.go	41
LOW	util/settings/settings.go	81	// Certificate holds the certificate/private key for the Argo CD API server.
LOW	util/settings/settings.go	121	BinaryUrls map[string]string `json:"binaryUrls,omitempty"`
LOW	util/askpass/server.go	21	AskPassServiceServer
LOW	util/io/path/resolved.go	81
LOW	util/io/path/resolved.go	101	// specified by allowedURLSchemes.
LOW	util/io/files/util.go	21	//
LOW	util/db/certificate.go	41	// CertificateListSelector is a helper struct for certificate selection.
LOW	util/helm/testdata/redis/values.yaml	1	## Bitnami Redis image version
LOW	util/helm/testdata/redis/values.yaml	41	## Optionally specify an array of imagePullSecrets.
LOW	util/helm/testdata/redis/values.yaml	61	## client label will have network access to the port Redis is listening
LOW	util/helm/testdata/redis/values.yaml	81	# - apiGroups:
LOW	util/helm/testdata/redis/values.yaml	101	persistence: {}
LOW	util/helm/testdata/redis/values.yaml	121	## Redis additional command line flags
LOW	util/helm/testdata/redis/values.yaml	141	## Redis Master resource requests and limits
LOW	util/helm/testdata/redis/values.yaml	201	enabled: true
LOW	util/helm/testdata/redis/values.yaml	221
LOW	util/helm/testdata/redis/values.yaml	241	## Specify the nodePort value for the LoadBalancer and NodePort service types.
LOW	util/helm/testdata/redis/values.yaml	261
LOW	util/helm/testdata/redis/values.yaml	281
LOW	util/helm/testdata/redis/values.yaml	301
LOW	util/helm/testdata/redis/values-production.yaml	41	# pullSecrets:
LOW	util/helm/testdata/redis/values-production.yaml	61	## Redis password (both master and slave)
LOW	util/helm/testdata/redis/values-production.yaml	81	## - "redis-server"
LOW	util/helm/testdata/redis/values-production.yaml	161	path: /bitnami/redis/data
LOW	util/helm/testdata/redis/values-production.yaml	181	updateStrategy: OnDelete
LOW	util/helm/testdata/redis/values-production.yaml	201	## Provide any additional annotations which may be required. This can be used to
LOW	util/helm/testdata/redis/values-production.yaml	221	## Redis slave Liveness Probe
LOW	util/helm/testdata/redis/values-production.yaml	241	# requests:
LOW	util/helm/testdata/dependency/values.yaml	1	## Bitnami WordPress image version
LOW	util/helm/testdata/dependency/values.yaml	21	## ref: https://github.com/bitnami/bitnami-docker-wordpress#environment-variables
LOW	util/helm/testdata/dependency/values.yaml	41	## Last name
LOW	util/helm/testdata/dependency/values.yaml	61	## ref: https://github.com/bitnami/bitnami-docker-wordpress/#smtp-configuration
LOW	util/helm/testdata/dependency/values.yaml	101	##
LOW	util/helm/testdata/dependency/values.yaml	121	## mariadb data Persistent Volume Storage Class
LOW	util/helm/testdata/dependency/values.yaml	181	## A side effect of this will be that the backend wordpress service will be connected at port 443
LOW	util/helm/testdata/dependency/values.yaml	201	## key and certificate should start with -----BEGIN CERTIFICATE----- or
LOW	util/helm/testdata/dependency/values.yaml	221	## If undefined (the default) or set to null, no storageClassName spec is
LOW	util/helm/testdata/dependency/values.yaml	241	## Node labels for pod assignment
LOW	util/helm/testdata/minio/values.yaml	41
LOW	util/git/client.go	61	"gc.autoDetach": "false",
LOW	util/git/client.go	141	// Deprecated: To be removed in the next major version when Signature verification is replaced with Source Integrity.
LOW	applicationset/utils/template_functions.go	41	// This has been copied from helm and may be removed as soon as it is retrofited in sprig
LOW	applicationset/utils/selector.go	141	return field.Invalid(path, k, strings.Join(errs, "; "))
LOW	applicationset/utils/utils.go	501
LOW	applicationset/utils/createOrUpdate.go	61	Build()
LOW	…xamples/design-doc/git-files-literal-fasttemplate.yaml	1	# This example demonstrates a git file generator which produces its items based on one or
LOW	…xamples/design-doc/git-files-literal-fasttemplate.yaml	21	# "account": "123456",
LOW	…s/design-doc/git-directory-discovery-fasttemplate.yaml	1	# This example demonstrates the git directory generator, which produces an items list
LOW	…mples/design-doc/git-files-discovery-fasttemplate.yaml	1	# This example demonstrates a git file generator which traverses the directory structure of a git
LOW	…mples/design-doc/git-files-discovery-fasttemplate.yaml	21	# └── config.json
LOW	…cationset/examples/design-doc/git-files-discovery.yaml	1	# This example demonstrates a git file generator which traverses the directory structure of a git
LOW	…cationset/examples/design-doc/git-files-discovery.yaml	21	# └── config.json
LOW	…onset/examples/design-doc/git-directory-discovery.yaml	1	# This example demonstrates the git directory generator, which produces an items list
LOW	…licationset/examples/design-doc/git-files-literal.yaml	1	# This example demonstrates a git file generator which produces its items based on one or
74 more matches not shown…

Self-Referential Comments20 hits · 70 pts

Severity	File	Line	Snippet
MEDIUM	cmd/argocd/commands/applicationset.go	38	# Create an ApplicationSet from a YAML stored in a file or at given URL
MEDIUM	cmd/argocd/commands/app.go	128	Example: ` # Create a directory app
MEDIUM	cmd/argocd/commands/app.go	131	# Create a Jsonnet app
MEDIUM	cmd/argocd/commands/app.go	134	# Create a Helm app
MEDIUM	cmd/argocd/commands/app.go	137	# Create a Helm app from a Helm repo
MEDIUM	cmd/argocd/commands/app.go	140	# Create a Kustomize app
MEDIUM	cmd/argocd/commands/app.go	143	# Create a MultiSource app while yaml file contains an application with multiple sources
MEDIUM	cmd/argocd/commands/app.go	146	# Create a app using a custom tool:
MEDIUM	cmd/argocd/commands/project.go	51	# Create a new project with name PROJECT
MEDIUM	cmd/argocd/commands/project.go	115	# Create a new project with name PROJECT
MEDIUM	cmd/argocd/commands/project.go	118	# Create a new project with name PROJECT from a file or URL to a Kubernetes manifest
MEDIUM	cmd/argocd/commands/project_role.go	227	# Create a project role in the "my-project" project with the name "my-role".
MEDIUM	cmd/argocd/commands/project_role.go	453	# Create a role associated with test-project
MEDIUM	util/helm/testdata/dependency/values.yaml	99	## Create a database and a database user
MEDIUM	util/helm/testdata/minio/values.yaml	108	## Create a bucket after minio install
MEDIUM	hack/generate-proto.sh	113	# This file is generated but should not be checked in.
MEDIUM	hack/admonitions-to-alerts.sh	26	# Create a temporary file to store the converted content.
MEDIUM	hack/tool-versions.sh	3	# This file defines the versions of the tools that are installed in the CI
MEDIUM	hack/migrate-gitops-engine/replace-vendor.sh	20	# Create a backup and replace
MEDIUM	docs/operator-manual/argocd-cm.yaml	285	# The following methods are available:

Hallucination Indicators4 hits · 40 pts

Severity	File	Line	Snippet
CRITICAL	…ettings/components/project-details/project-details.tsx	800	formApi.values.spec.orphanedResources.ignore.map((_: Project, i: number) => (
CRITICAL	cmd/argocd/commands/app.go	2330	app.Status.SourceHydrator.CurrentOperation.SourceHydrator.DeepEquals(app.Status.SourceHydrator.LastSuccessfulOperation
CRITICAL	docs/operator-manual/user-management/zitadel.md	122	ctx.v1.user.grants.grants.forEach((claim) => {
CRITICAL	controller/appcontroller.go	1468	retryAt, err := app.Status.OperationState.Operation.Retry.NextRetryAt(state.FinishedAt.Time, state.RetryCount)

Hyper-Verbose Identifiers34 hits · 34 pts

Severity	File	Line	Snippet
LOW	ui/src/app/settings/components/utils.ts	1	export function convertExpiresInToSeconds(expiresIn: string): number {
LOW	…gs/components/project-details/resource-lists-panel.tsx	121	function viewSourceNamespacesInfoList(type: field, proj: Project) {
LOW	…gs/components/project-details/resource-lists-panel.tsx	186	function viewDestinationServiceAccountsInfoList(type: field, proj: Project) {
LOW	ui/src/app/shared/services/extensions-service.ts	41	function registerResourceExtension(component: ExtensionComponent, group: string, kind: string, tabTitle: string, opts?:
LOW	ui/src/app/shared/services/extensions-service.ts	47	function registerSystemLevelExtension(component: ExtensionComponent, title: string, path: string, icon: string) {
LOW	ui/src/app/shared/services/extensions-service.ts	59	function registerStatusPanelExtension(component: StatusPanelExtensionComponent, title: string, id: string, flyout?: Exte
LOW	ui/src/app/shared/services/extensions-service.ts	65	function registerTopBarActionMenuExt(
LOW	ui/src/app/applications/components/utils.tsx	42	export function resourceStatusToResourceNode(res: appModels.ResourceStatus): appModels.ResourceNode {
LOW	ui/src/app/applications/components/utils.tsx	632	export async function getResourceActionsMenuItems(resource: ResourceTreeNode, metadata: models.ObjectMeta, apis: Context
LOW	ui/src/app/applications/components/utils.tsx	933	export function getSyncRevisionLabelSuffix(repoUrl: string, targetRevision: string, revision: string, chart?: string) {
LOW	ui/src/app/applications/components/utils.tsx	1268	function isPodInitializedConditionTrue(status: any): boolean {
LOW	ui/src/app/applications/components/utils.tsx	1442	export function getAppSetConditionCategory(condition: appModels.ApplicationSetCondition): 'error' \| 'warning' \| 'info' {
LOW	ui/src/app/applications/components/utils.tsx	1466	export function getApplicationSetOwnerRef(application: appModels.Application) {
LOW	ui/src/app/applications/components/utils.tsx	1506	export function getHydratorSyncSourceRepoURL(sourceHydrator: appModels.SourceHydrator): string {
LOW	ui/src/app/applications/components/utils.tsx	1542	export function getAppDefaultSyncRevision(app?: appModels.Application) {
LOW	ui/src/app/applications/components/utils.tsx	1551	export function getAppDefaultOperationSyncRevision(app?: appModels.Application) {
LOW	ui/src/app/applications/components/utils.tsx	1570	export function getAppDefaultSyncRevisionExtra(app?: appModels.Application) {
LOW	ui/src/app/applications/components/utils.tsx	1584	export function getAppDefaultOperationSyncRevisionExtra(app?: appModels.Application) {
LOW	ui/src/app/applications/components/utils.tsx	1936	export function formatApplicationSetProgressiveSyncStep(step: string \| undefined): string {
LOW	ui/src/app/applications/components/utils.tsx	2061	export function getApplicationLinkURLFromNode(node: any, baseHref: string): {url: string; isExternal: boolean} {
LOW	…ents/application-parameters/application-parameters.tsx	306	function getEditablePanelForSources(index: number, appSource: models.ApplicationSource): React.ReactElement {
LOW	…ents/application-parameters/application-parameters.tsx	444	function getEditablePanelForOneSource(repoAppDetails: models.RepoAppDetails, ind: number, src: models.ApplicationSou
LOW	…/app/applications/components/shared/app-source-edit.ts	16	export function normalizeTypeFieldsForSource(formApi: FormApi, type: models.AppSourceType, sourceIndex?: number): void {
LOW	…tion-create-panel/collapsible-multi-source-section.tsx	7	export function CollapsibleMultiSourceSection(props: {
LOW	…s/components/applications-list/applications-filter.tsx	63	function getOperationStateTitleForFilter(app: Application): OperationStateTitle {
LOW	…components/applications-list/application-sets-list.tsx	384	function onAppSetFilterPrefChanged(ctx: ContextApis, newPref: AppSetsListPreferences) {
LOW	docs/assets/versions.js	32	function initializeVersionDropdown() {
LOW	…omizations/promoter.argoproj.io/PullRequest/health.lua	4	local function formatDeletingWithFinalizers(base, finalizers, catalog)
LOW	…s/promoter.argoproj.io/ChangeTransferPolicy/health.lua	4	local function formatDeletingWithFinalizers(base, finalizers, catalog)
LOW	…izations/promoter.argoproj.io/GitRepository/health.lua	4	local function formatDeletingWithFinalizers(base, finalizers, catalog)
LOW	…omizations/promoter.argoproj.io/ScmProvider/health.lua	4	local function formatDeletingWithFinalizers(base, finalizers, catalog)
LOW	…ons/promoter.argoproj.io/ClusterScmProvider/health.lua	4	local function formatDeletingWithFinalizers(base, finalizers, catalog)
LOW	resource_customizations/argoproj.io/Rollout/health.lua	71	function isWorkloadGenerationObserved(obj)
LOW	…zations/gateway.networking.k8s.io/HTTPRoute/health.lua	14	function isParentGenerationObserved(obj, parent)

AI Slop Vocabulary8 hits · 18 pts

Severity	File	Line	Snippet
MEDIUM	hack/installers/install-codegen-go-tools.sh	44	# We still install openapi-gen from go.mod since upstream does not utilize release tags. Use go install in order for
MEDIUM	docs/operator-manual/argocd-cmd-params-cm.yaml	400	# Enable self-service notifications config. Used in conjunction with apps-in-any-namespace. (default "false")
MEDIUM	…ublic.ecr.aws_docker_library_haproxy_3.0.8-alpine.html	2315	a 'no_proxy' environment variable set. For the aforementioned reasons the
MEDIUM	docs/snyk/v3.3.10/ghcr.io_dexidp_dex_v2.43.0.html	5771	a 'no_proxy' environment variable set. For the aforementioned reasons the
MEDIUM	…ublic.ecr.aws_docker_library_haproxy_3.0.8-alpine.html	2315	a 'no_proxy' environment variable set. For the aforementioned reasons the
MEDIUM	…ublic.ecr.aws_docker_library_haproxy_3.0.8-alpine.html	2315	a 'no_proxy' environment variable set. For the aforementioned reasons the
MEDIUM	…ublic.ecr.aws_docker_library_haproxy_3.0.8-alpine.html	2315	a 'no_proxy' environment variable set. For the aforementioned reasons the
MEDIUM	docs/snyk/v3.2.12/ghcr.io_dexidp_dex_v2.43.0.html	5771	a 'no_proxy' environment variable set. For the aforementioned reasons the

Redundant / Tautological Comments7 hits · 12 pts

Severity	File	Line	Snippet
LOW	test/remote/run-e2e-remote.sh	18	# Set ARGOCD_E2E_NAMESPACE to the namespace the Argo CD we're testing against is
LOW	util/helm/testdata/dependency/values.yaml	180	## Set this to true in order to enable TLS on the ingress record
LOW	hack/admonitions-to-alerts.sh	29	# Read the file line by line.
LOW	hack/admonitions-to-alerts.sh	32	# Check if the line starts with an admonition (!!!).
LOW	hack/migrate-gitops-engine/update-dockerfile.sh	8	# Check if Dockerfile exists
LOW	.github/workflows/release.yaml	72	# Check if latest tag is a pre-release
LOW	.github/workflows/cherry-pick-single.yml	71	# Check if target branch exists

Decorative Section Separators3 hits · 9 pts

Severity	File	Line	Snippet
MEDIUM	test/remote/run-e2e-remote.sh	40	## ====================================================
MEDIUM	test/remote/run-e2e-remote.sh	42	## ====================================================
MEDIUM	hack/generate-ui-pnpm-sbom.sh	9	# =============================================================================

Fake / Example Data9 hits · 9 pts

Severity	File	Line	Snippet
LOW	util/webhook/testdata/gitlab-event.json	41	"email": "user@example.com"
LOW	util/test/testutil.go	278	"name": "John Doe",
LOW	util/git/client_test.go	1354	Name: "John Doe",
LOW	applicationset/webhook/testdata/gitlab-event.json	41	"email": "user@example.com"
LOW	…/webhook/testdata/gitlab-merge-request-open-event.json	9	"email": "admin@example.com"
LOW	…hook/testdata/gitlab-merge-request-approval-event.json	9	"email": "admin@example.com"
LOW	.github/workflows/ci-build.yaml	203	git config --global user.name "John Doe"
LOW	.github/workflows/ci-build.yaml	276	git config --global user.name "John Doe"
LOW	.github/workflows/ci-build.yaml	573	git config --global user.name "John Doe"

Synthetic Comment Markers1 hit · 5 pts

Severity	File	Line	Snippet
HIGH	docs/developer-guide/development-cycle.md	66	> There are a few non-obvious assets that are auto-generated. You should not change the autogenerated assets, as they wi

Verbosity Indicators3 hits · 4 pts

Severity	File	Line	Snippet
LOW	util/git/client.go	1638	// Step 1: Is it UNTRACKED? (file is new to git)
LOW	applicationset/services/scm_provider/gitlab_test.go	1828	// We need to check if the request is for listing branches (returns array) or getting one (returns object)
LOW	gitops-engine/pkg/utils/kube/resource_ops.go	249	// not want. We need to check if the namespace exists, before know if it is safe to run this

Slop Phrases2 hits · 4 pts

Severity	File	Line	Snippet
LOW	util/session/sessionmanager.go	243	// Don't forget to validate the alg is what you expect:
MEDIUM	docs/operator-manual/application.yaml	11	# Alternatively, you can use background cascading deletion

Score History

Severity Breakdown

Pattern Findings