apache/brpc

Pattern Findings

1960 matches across 10 categories. Click a row to expand file-level details.

Over-Commented Block1919 hits · 1894 pts

Severity	File	Line	Snippet
LOW	CMakeLists.txt	1	# Licensed to the Apache Software Foundation (ASF) under one
LOW	config_brpc.sh	1	#!/usr/bin/env sh
LOW	.licenserc.yaml	1	# Licensed to the Apache Software Foundation (ASF) under one
LOW	CHANGES.md	1	<!--
LOW	tools/print_gcc_version.sh	1	#!/usr/bin/env bash
LOW	tools/CMakeLists.txt	1	# Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/lldb_bthread_stack.py	1	#!/usr/bin/env python
LOW	tools/get_brpc_revision.sh	1	#!/usr/bin/env bash
LOW	tools/gdb_bthread_stack.py	1	#!/usr/bin/env python
LOW	tools/add_syntax_equal_proto2_to_all.sh	1	#!/usr/bin/env bash
LOW	tools/rpc_replay/CMakeLists.txt	1	# Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_replay/info_thread.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_replay/info_thread.h	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_replay/rpc_replay.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_replay/rpc_replay.cpp	21	#include <butil/time.h>
LOW	tools/parallel_http/CMakeLists.txt	1	# Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/parallel_http/parallel_http.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/trackme_server/CMakeLists.txt	1	# Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/trackme_server/trackme_server.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/pb_util.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/CMakeLists.txt	1	# Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/pb_util.h	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/json_loader.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/client.py	1	# Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/rpc_press_impl.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/rpc_press_impl.cpp	21	#include <sys/time.h>
LOW	tools/rpc_press/info_thread.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/rpc_press.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/json_loader.h	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/rpc_press_impl.h	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_press/info_thread.h	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_view/rpc_view.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	tools/rpc_view/CMakeLists.txt	1	# Licensed to the Apache Software Foundation (ASF) under one
LOW	test/bvar_mvariable_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/bvar_mvariable_unittest.cpp	21	#include <string_view>
LOW	test/brpc_http_message_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/brpc_channel_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/brpc_channel_unittest.cpp	21
LOW	test/bthread_setconcurrency_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/bvar_multi_dimension_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/bvar_multi_dimension_unittest.cpp	21	#include <cstddef>
LOW	test/bthread_id_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/baidu_thread_local_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/bvar_status_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/brpc_http_rpc_protocol_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/brpc_http_rpc_protocol_unittest.cpp	21
LOW	test/brpc_http_rpc_protocol_unittest.cpp	41	#include "butil/files/scoped_file.h"
LOW	test/bvar_lock_timer_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/brpc_load_balancer_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/brpc_load_balancer_unittest.cpp	21
LOW	test/brpc_load_balancer_unittest.cpp	1301	bthread_usleep(500000 /* sleep longer than timeout of channel */);
LOW	test/brpc_load_balancer_unittest.cpp	1321	// if (latency <= 0) { /* time skews, ignore the sample */ return 0; }
LOW	test/CMakeLists.txt	1	# Licensed to the Apache Software Foundation (ASF) under one
LOW	test/string_splitter_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/brpc_hulu_pbrpc_protocol_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/brpc_hulu_pbrpc_protocol_unittest.cpp	21
LOW	test/brpc_snappy_compress_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/bvar_variable_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/object_pool_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
LOW	test/recordio_unittest.cpp	1	// Licensed to the Apache Software Foundation (ASF) under one
1859 more matches not shown…

Example Usage Blocks10 hits · 15 pts

Severity	File	Line	Snippet
LOW	test/multiprocess_func_list.h	20	// Example usage:
LOW	src/brpc/versioned_ref_with_id.h	146	// Example usage:
LOW	src/butil/lazy_instance.h	26	// Example usage:
LOW	src/butil/gtest_prod_util.h	33	// Example usage:
LOW	src/butil/gtest_prod_util.h	63	// Example usage:
LOW	src/butil/compiler_specific.h	47	// Example usage:
LOW	src/butil/memory/singleton.h	168	// Example usage:
LOW	src/butil/mac/foundation_util.h	251	// Example usage:
LOW	src/butil/mac/foundation_util.h	312	// Example usage:
LOW	src/butil/threading/thread_local.h	32	// Example usage:

Slop Phrases9 hits · 14 pts

Severity	File	Line	Snippet
LOW	example/dynamic_partition_echo_c++/server.cpp	162	// Don't forget to stop and join the server otherwise still-running
LOW	example/selective_echo_c++/server.cpp	161	// Don't forget to stop and join the server otherwise still-running
LOW	example/multi_threaded_echo_fns_c++/server.cpp	177	// Don't forget to stop and join the server otherwise still-running
LOW	example/partition_echo_c++/server.cpp	162	// Don't forget to stop and join the server otherwise still-running
LOW	src/bthread/task_group.cpp	225	// Don't forget to add elapse of last wait_task.
LOW	src/brpc/parallel_channel.cpp	315	// NOTE: Don't forget to set "nfailed = _ndone" when the _cntl is set
LOW	src/brpc/health_reporter.h	35	// Don't forget to call done->Run() at the end.
LOW	src/brpc/controller.cpp	1221	// Don't forget to signal waiters on authentication
LOW	src/brpc/http_header.cpp	34	// NOTE: don't forget to clear the field in Clear() as well.

AI Slop Vocabulary7 hits · 11 pts

Severity	File	Line	Snippet
MEDIUM	src/brpc/span.h	192	// However, returning by value is more robust: it prevents potential data races if
LOW	src/brpc/builtin/pprof_perl.cpp	1210	"# names. You show the name the first time, and just use its number\n"
LOW	src/brpc/builtin/pprof_perl.cpp	3642	" # Since we know one of the pair is 0, it's fine to just add them.\n"
LOW	src/brpc/builtin/pprof_perl.cpp	4264	"# If all else fails, just return the name of the library unmodified.\n"
LOW	src/brpc/builtin/pprof_perl.cpp	4753	" # If \"addr2line\" isn't installed on the system at all, just use\n"
LOW	src/brpc/builtin/pprof_perl.cpp	4885	" # No symbols: just use addresses\n"
MEDIUM	src/butil/safe_strerror_posix.h	34	// more robust in the case of heap corruption errors, since it doesn't need to

Fake / Example Data5 hits · 5 pts

Severity	File	Line	Snippet
LOW	example/couchbase_c++/couchbase_client.cpp	34	R"({"name": "John Doe", "age": 30, "email": "john@example.com"})";
LOW	example/couchbase_c++/couchbase_client.cpp	121	R"({"name": "Jane Doe", "age": 28, "email": "jane.doe@example.com"})";
LOW	…le/couchbase_c++/traditional_brpc_couchbase_client.cpp	93	R"({"name": "John Doe", "age": 30, "email": "john@example.com"})",
LOW	docs/en/couchbase_example.md	328	R"({"name": "John Doe", "age": 30, "email": "john@example.com"})", // value
LOW	docs/en/couchbase_example.md	519	std::string add_value = R"({"name": "John Doe", "age": 30, "email": "john@example.com"})";

Verbosity Indicators3 hits · 4 pts

Severity	File	Line	Snippet
LOW	src/bthread/rwlock.cpp	235	// Step 1: announce ourselves before doing anything else, so that
LOW	src/bthread/rwlock.cpp	251	// Step 2: serialize with other writers. At most one writer holds
LOW	src/bthread/rwlock.cpp	275	// Step 3: with `writer_queue_mutex' held, wait for all readers to drain

Deep Nesting2 hits · 2 pts

Severity	File	Line	Snippet
LOW	tools/lldb_bthread_stack.py	128
LOW	tools/gdb_bthread_stack.py	73

Redundant / Tautological Comments2 hits · 2 pts

Severity	File	Line	Snippet
LOW	src/brpc/builtin/pprof_perl.cpp	3753	" # Check if the file contains a symbol-section marker.\n"
LOW	src/brpc/builtin/pprof_perl.cpp	5178	" # Verify if addr2line can find the $sep_symbol. If not, we use objdump\n"

Hyper-Verbose Identifiers2 hits · 2 pts

Severity	File	Line	Snippet
LOW	src/brpc/builtin/flot_min_js.cpp	46	return "(function($){$.color={};$.color.make=function(r,g,b,a){var o={};o.r=r\|\|0;o.g=g\|\|0;o.b=b\|\|0;o.a=a!=null?a:1;o
LOW	src/brpc/builtin/flot_min_js.cpp	46	return "(function($){$.color={};$.color.make=function(r,g,b,a){var o={};o.r=r\|\|0;o.g=g\|\|0;o.b=b\|\|0;o.a=a!=null?a:1;o

Excessive Try-Catch Wrapping1 hit · 1 pts

Severity	File	Line	Snippet
LOW	tools/gdb_bthread_stack.py	173	except Exception as e:

Score History

Severity Breakdown

Pattern Findings