CleverRaven/Cataclysm-DDA

Pattern Findings

2579 matches across 15 categories. Click a row to expand file-level details.

Over-Commented Block2285 hits · 2096 pts

Severity	File	Line	Snippet
LOW	LICENSE.txt	61
LOW	.cmake-format.yml	1	# options affecting formatting
LOW	.cmake-format.yml	21	# enable comment markup parsing and reflow
LOW	pch/main-pch.hpp	1	// Workaround to a bug in libstdc++ prior to GCC 11 causing
LOW	pch/main-pch.hpp	21	#include <cfloat>
LOW	pch/main-pch.hpp	41	#include <exception>
LOW	pch/main-pch.hpp	61	#include <optional>
LOW	pch/main-pch.hpp	81	#include <unordered_map>
LOW	tools/generate_changelog.py	621	f'{commit_hash}'
LOW	tools/generate_changelog.py	1321	# for c in commits
LOW	tools/macos-market-share.py	1	#!/usr/bin/env python3
LOW	tools/repeat_clang_tidy.sh	1	#!/bin/bash
LOW	tools/clang-tidy-plugin/Utils.h	1	#ifndef CATA_TOOLS_CLANG_TIDY_PLUGIN_UTILS_H
LOW	tools/clang-tidy-plugin/SerializeCheck.cpp	1	#include "SerializeCheck.h"
LOW	tools/clang-tidy-plugin/UnsequencedCallsCheck.cpp	1	#include "UnsequencedCallsCheck.h"
LOW	tools/clang-tidy-plugin/UsePointArithmeticCheck.cpp	1	#include "UsePointArithmeticCheck.h"
LOW	tools/clang-tidy-plugin/UsePointArithmeticCheck.cpp	21	#include <map>
LOW	tools/clang-tidy-plugin/UseMdarrayCheck.cpp	1	#include "UseMdarrayCheck.h"
LOW	tools/clang-tidy-plugin/StringLiteralIterator.h	21
LOW	tools/clang-tidy-plugin/CataTidyModule.cpp	1	#include <clang/Basic/Version.h>
LOW	tools/clang-tidy-plugin/CataTidyModule.cpp	21	#include "RedundantParenthesesCheck.h"
LOW	tools/clang-tidy-plugin/UseNamedPointConstantsCheck.cpp	1	#include "UseNamedPointConstantsCheck.h"
LOW	tools/clang-tidy-plugin/TranslatorCommentsCheck.cpp	1	#include "TranslatorCommentsCheck.h"
LOW	tools/clang-tidy-plugin/TranslatorCommentsCheck.cpp	321	// error here for simplicity.
LOW	tools/clang-tidy-plugin/RedundantParenthesesCheck.cpp	1	#include "RedundantParenthesesCheck.h"
LOW	tools/clang-tidy-plugin/TextStyleCheck.cpp	1	#include "TextStyleCheck.h"
LOW	tools/clang-tidy-plugin/NoLongCheck.cpp	1	#include "NoLongCheck.h"
LOW	tools/clang-tidy-plugin/HeaderGuardCheck.cpp	1	#include "HeaderGuardCheck.h"
LOW	…clang-tidy-plugin/TestsMustRestoreGlobalStateCheck.cpp	1	#include "TestsMustRestoreGlobalStateCheck.h"
LOW	tools/clang-tidy-plugin/UseLocalizedSortingCheck.cpp	1	#include "UseLocalizedSortingCheck.h"
LOW	…s/clang-tidy-plugin/SimplifyPointConstructorsCheck.cpp	1	#include "SimplifyPointConstructorsCheck.h"
LOW	tools/clang-tidy-plugin/CombineLocalsIntoPointCheck.cpp	1	#include "CombineLocalsIntoPointCheck.h"
LOW	tools/clang-tidy-plugin/UsePointApisCheck.cpp	1	#include "UsePointApisCheck.h"
LOW	tools/clang-tidy-plugin/OtMatchCheck.cpp	1	#include "OtMatchCheck.h"
LOW	tools/clang-tidy-plugin/LargeStackObjectCheck.cpp	1	#include "LargeStackObjectCheck.h"
LOW	tools/clang-tidy-plugin/UseStringViewCheck.cpp	1	#include "UseStringViewCheck.h"
LOW	tools/clang-tidy-plugin/AlmostNeverAutoCheck.cpp	1	#include "AlmostNeverAutoCheck.h"
LOW	tools/clang-tidy-plugin/test/header-guard-3.h	1	// RUN: %check_clang_tidy %s cata-header-guard %t -- --load=%cata_plugin --
LOW	tools/clang-tidy-plugin/test/check_clang_tidy.py	1	#!/usr/bin/env python3
LOW	tools/clang-tidy-plugin/test/text-style.cpp	61	foo( "\t" );
LOW	tools/clang-tidy-plugin/test/text-style.cpp	81	// CHECK-MESSAGES: [[@LINE-2]]:25: warning: single quote preferred over right single quote.
LOW	tools/clang-tidy-plugin/test/text-style.cpp	101	// CHECK-FIXES: foo( "Three; Two; One;" );
LOW	tools/clang-tidy-plugin/test/header-guard-5.h	1	// RUN: %check_clang_tidy %s cata-header-guard %t -- --load=%cata_plugin --
LOW	tools/clang-tidy-plugin/test/header-guard-1.h	1	// RUN: %check_clang_tidy %s cata-header-guard %t -- --load=%cata_plugin --
LOW	tools/clang-tidy-plugin/test/header-guard-4.cpp	1	// RUN: %check_clang_tidy %s cata-header-guard,cata-no-long %t -- --load=%cata_plugin --
LOW	tools/clang-tidy-plugin/test/header-guard-2.h	1	// RUN: %check_clang_tidy %s cata-header-guard %t -- --load=%cata_plugin --
LOW	tools/json_tools/gun_variant_validator.py	561	return False
LOW	tools/format/format_main.cpp	1	#include "format.h"
LOW	tools/save/zzip_main.cpp	1	#include <array>
LOW	tests/cata_catch.h	1	#pragma once
LOW	tests/active_item_test.cpp	1	#include <list>
LOW	tests/catacharset_test.cpp	1	#include <clocale>
LOW	tests/pathfinding_test.cpp	1	#include <algorithm>
LOW	tests/vehicle_interact_test.cpp	1	#include <functional>
LOW	tests/roof_test.cpp	1	#include <algorithm>
LOW	tests/char_sight_test.cpp	1	#include <memory>
LOW	tests/char_sight_test.cpp	41	// Character::fine_detail_vision_mod
LOW	tests/char_sight_test.cpp	161	SECTION( "NPC on a different z-level" ) {
LOW	tests/char_sight_test.cpp	261	// Special case of impaired sight - URSINE_EYES mutation causes severely reduced daytime vision
LOW	tests/mapgen_helpers.cpp	1	#include "mapgen_helpers.h"
2225 more matches not shown…

Decorative Section Separators42 hits · 107 pts

Severity	File	Line	Snippet
MEDIUM	doxygen_doc/doxygen_conf.txt	1573	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1575	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1585	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1587	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	15	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	17	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	422	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	424	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	674	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	676	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	725	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	727	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	861	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	863	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	917	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	919	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	940	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	942	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1359	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1361	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1465	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1467	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1507	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1509	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1535	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1537	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1558	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1560	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1620	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1622	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1686	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1688	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1733	#---------------------------------------------------------------------------
MEDIUM	doxygen_doc/doxygen_conf.txt	1735	#---------------------------------------------------------------------------
MEDIUM	.devcontainer/cross-compile/reinstall-cmake.sh	2	#-------------------------------------------------------------------------------------------------------------
MEDIUM	.devcontainer/cross-compile/reinstall-cmake.sh	5	#-------------------------------------------------------------------------------------------------------------
MEDIUM	data/json/ascii_art/generic_ascii.json	1113	" <color_white>\|\|</color><color_dark_gray>/////</color><color_white>/</color> <color_dark_gray>╔═══════╗
MEDIUM	data/json/ascii_art/generic_ascii.json	1115	" <color_white>\|\|</color><color_dark_gray>////</color><color_white>\|</color> <color_dark_gray>╚═══════╝
MEDIUM	data/json/ascii_art/generic_ascii.json	1129	" <color_white>\|\|</color><color_dark_gray>////</color><color_white>\|</color> <color_dark_gray>╔═══════╗
MEDIUM	data/json/ascii_art/generic_ascii.json	1131	" <color_white>\|\|</color><color_dark_gray>////</color><color_white>\|</color> <color_dark_gray>╚═══════╝
MEDIUM	src/output.h	825	// ┌──────┐ ┌──────┐
MEDIUM	src/output.h	827	// ┌─┴──────┴─┘ └───────────┐

AI Slop Vocabulary32 hits · 84 pts

Severity	File	Line	Snippet
LOW	tools/json_tools/util.py	251	# With no dots, just use the plain key
MEDIUM	tools/json_tools/cddaUpdateJsonVolume.js	96	if (fullText.includes('musical_instrument') && whiteSpace.length === 6) // ugly and not robust, but works for now
MEDIUM	build-data/web/index.html	250	// application robust, you may want to override this behavior before shipping!
MEDIUM	data/json/materials.json	824	"//1": "It's rather difficult to find citeable data on how well arbitrary volumes of human flesh burns, so I've sett
MEDIUM	data/json/flags.json	1309	"//": "Applies robust genetic bonus - mutations give only 1 unit of instability for all traits instead of 1 unit for
MEDIUM	data/json/requirements/toolsets.json	454	"///": "The farrier's nail_puller can't be used with a hammer, but it probably has enough leverage on its own.",
MEDIUM	data/json/recipes/recipe_ammo.json	79	"//": "Essentially a ball of glued-together string with some leather around it"
MEDIUM	data/json/recipes/armor/other.json	63	"//": "Based off of the quickest internet suggestions, which utilize sewing machines.",
MEDIUM	data/json/items/tool_armor.json	4904	"//": "This is based on the Sarcos Guardian, a production model with independent battery power, all weather operatio
MEDIUM	data/json/items/resources/metal.json	22	"//": "Based on https://en.stainlesseurope.com/en_US/p/Stainless-steel-acid-resistant-seamless-tube-DN20-OD-28-mm-x-
MEDIUM	data/json/items/armor/robofac_armor.json	11	"//2": "Why no PALS? Fundamentally PALS is a decent system but adds a pile of additional weight in straps and fasten
MEDIUM	data/json/items/tool/cooking.json	714	"//": "Should be 20 but currently recipes do not utilize this value",
MEDIUM	src/basecamp.cpp	874	// Absolutely no safety checks, factions don't exist until you've encountered them but we sometimes set the owner be
MEDIUM	src/mutation_ui.cpp	494	// Essentially, up-down navigation adapted from the bionics_ui.cpp, with a bunch of extra workarounds to kee
MEDIUM	src/vehicle.cpp	5772	// Cap output at what we can achieve and utilize
MEDIUM	src/map.h	147	// Essentially infinite bash strength + some
MEDIUM	src/character.cpp	2846	// but for lifting, its effective strength is even higher, due to its sturdy construction, leverage,
MEDIUM	src/activity_actor.cpp	14050	// Definitely wasteful, but I am not paid enough to figure out a better way.
MEDIUM	src/tileray.h	28	// This class is used with bubble and relative coordinates. Fundamentally the
MEDIUM	src/overmap.cpp	1605	// TODO: nuanced move costs.
MEDIUM	src/mapgen_functions.cpp	1265	// mapgen, and while things don't have to be seamless, I did want the lake shores to fairly smoothly
MEDIUM	src/lightmap.cpp	1301	// We can utilize the current state of the seen cache to determine
MEDIUM	src/consumption.cpp	294	// TODO: put this loop into a function and utilize it again for bionics
MEDIUM	src/input_context.cpp	91	// Operator overload required to leverage std functional interface.
MEDIUM	src/melee.cpp	823	// being prone affects how much leverage you can use to deal damage
MEDIUM	src/melee.cpp	1498	// this could be more robust but for now it should work fine
MEDIUM	src/game.cpp	3046	// Operator overload required to leverage sort API.
MEDIUM	src/character_attire.h	59	// Operator overload required to leverage vector equality operator.
MEDIUM	src/third-party/fmt/format.h	3397	// Compilers are not aware of how to leverage the maximum value of
MEDIUM	src/third-party/imgui/imgui.cpp	6783	// FIXME: Essentially we want to restrict manual resizing to WindowMinSize+Decoration, and allow api resizing to be
MEDIUM	src/third-party/imgui/imgui.cpp	9207	// FIXME-NEWATLAS-V2: perhaps we can now leverage ImFontAtlasUpdateDrawListsTextures() ?
MEDIUM	src/third-party/flatbuffers/flatbuffers.h	863	// Essentially, this supports 2 std::vectors in a single buffer.

Deep Nesting83 hits · 83 pts

Severity	File	Line
LOW	tools/check_translation_tags.py	104
LOW	tools/check_translation_tags.py	168
LOW	tools/generate_changelog.py	938
LOW	tools/generate_changelog.py	1198
LOW	tools/generate_changelog.py	1283
LOW	tools/fix-compilation-database.py	23
LOW	tools/vehicle_reformatter.py	12
LOW	tools/vehicle_reformatter.py	44
LOW	tools/copy_from.py	9
LOW	tools/merge_maps.py	44
LOW	tools/update_blueprint_needs.py	28
LOW	tools/vehicleDef.py	42
LOW	tools/tileset_test.py	47
LOW	tools/tileset_test.py	284
LOW	tools/dialogue_validator.py	29
LOW	tools/dialogue_validator.py	69
LOW	tools/dialogue_validator.py	99
LOW	tools/auto_doc_mutations.py	13
LOW	tools/auto_doc_mutations.py	113
LOW	tools/auto_doc_mutations.py	193
LOW	tools/json_tools/extend_itemgroups.py	31
LOW	tools/json_tools/pocket_mags.py	14
LOW	tools/json_tools/update_proficiencies.py	12
LOW	tools/json_tools/gun_variant_validator.py	245
LOW	tools/json_tools/gun_variant_validator.py	427
LOW	tools/json_tools/gun_variant_validator.py	467
LOW	tools/json_tools/gun_variant_validator.py	611
LOW	tools/json_tools/gun_variant_validator.py	668
LOW	tools/json_tools/gun_variant_validator.py	792
LOW	tools/json_tools/gun_variant_validator.py	847
LOW	tools/json_tools/util.py	19
LOW	tools/json_tools/util.py	72
LOW	tools/json_tools/util.py	165
LOW	tools/json_tools/util.py	202
LOW	tools/json_tools/util.py	235
LOW	tools/json_tools/monstergroup_name_to_id.py	41
LOW	tools/json_tools/convert_armor.py	59
LOW	tools/json_tools/convert_armor.py	236
LOW	tools/json_tools/remove_charges.py	45
LOW	tools/json_tools/remove_charges.py	315
LOW	tools/json_tools/remove_charges.py	464
LOW	tools/json_tools/remove_charges.py	525
LOW	tools/json_tools/generate_overmap_sprites.py	271
LOW	tools/json_tools/generate_overmap_sprites.py	457
LOW	tools/json_tools/itemgroups.py	46
LOW	tools/json_tools/itemgroups.py	82
LOW	tools/json_tools/name_strings_to_objects.py	14
LOW	tools/json_tools/name_strings_to_objects.py	62
LOW	tools/json_tools/monfaction_array-ify.py	12
LOW	tools/json_tools/generic_guns_validator.py	109
LOW	tools/json_tools/table.py	67
LOW	tools/json_tools/recipe_activity.py	15
LOW	tools/json_tools/convert_to_portions.py	38
LOW	tools/json_tools/cddatags.py	41
LOW	tools/gfx_tools/compose.py	310
LOW	tools/gfx_tools/compose.py	580
LOW	tools/gfx_tools/compose.py	750
LOW	tools/gfx_tools/compose.py	826
LOW	tools/gfx_tools/decompose.py	137
LOW	tools/gfx_tools/decompose.py	342
23 more matches not shown…

Hyper-Verbose Identifiers41 hits · 41 pts

Severity	File	Line	Snippet
LOW	tools/generate_changelog.py	294	def traverse_commits_by_first_parent(self, initial_hash=None):
LOW	tools/generate_changelog.py	381	def get_merged_pr_list_by_date(self, latest_dttm, oldest_dttm):
LOW	tools/generate_changelog.py	419	def get_previous_successful_build(self, build_number):
LOW	tools/generate_changelog.py	477	def _create_build_from_api_data(self, build_data):
LOW	tools/generate_changelog.py	545	def _process_commit_data_callback(self, results_queue):
LOW	tools/generate_changelog.py	548	def _process_commit_data_callback_closure(json_data, request_generator,
LOW	tools/generate_changelog.py	562	def _create_commit_from_api_data(self, commit_data):
LOW	tools/generate_changelog.py	684	def _process_pr_data_callback(self, results_queue, min_dttm):
LOW	tools/generate_changelog.py	687	def _process_pr_data_callback_closure(json_data, request_generator,
LOW	tools/generate_changelog.py	771	def _process_api_requests_on_threads(request_generator, callback):
LOW	tools/generate_changelog.py	929	def exit_on_exception_closure(args, *kwargs):
LOW	tools/generate_changelog.py	1014	def validate_file_for_writing(filepath):
LOW	tools/windows_limit_memory.py	389	def _create_io_completion_port(self) -> HANDLE:
LOW	tools/windows_limit_memory.py	409	def _query_information_job_object(self, structure: ctypes.Structure,
LOW	tools/windows_limit_memory.py	468	def _set_information_job_object(self, structure: ctypes.Structure,
LOW	tools/json_tools/generate_overmap_sprites.py	179	def read_overmap_terrain_data() -> None:
LOW	tools/json_tools/generate_overmap_sprites.py	271	def write_image_with_rotations(
LOW	tools/json_tools/generate_overmap_sprites.py	431	def handle_single_color_sprites(
LOW	tools/json_tools/generic_guns_validator.py	154	def items_for_which_any_ancestor(items, pred):
LOW	tools/json_tools/generic_guns_validator.py	163	def items_for_which_all_ancestors(items, pred):
LOW	tools/json_tools/generic_guns_validator.py	229	def is_not_whitelisted_ammo_type(i):
LOW	tools/json_tools/table.py	146	def get_format_class_by_extension(format_string):
LOW	tools/gfx_tools/compose.py	369	def create_tile_entries_for_unused(
LOW	tools/gfx_tools/compose.py	490	def handle_unreferenced_sprites(
LOW	tools/gfx_tools/compose.py	855	def convert_random_variations(
LOW	tools/gfx_tools/decompose.py	411	def convert_pngnum_to_pngname(self, tile_entry):
LOW	lang/string_extractor/parsers/overmap_land_use_code.py	5	def parse_overmap_land_use_code(json, origin):
LOW	lang/string_extractor/parsers/shop_whitelist.py	4	def parse_shopkeeper_whitelist(json, origin):
LOW	lang/string_extractor/parsers/vehicle_part_category.py	5	def parse_vehicle_part_category(json, origin):
LOW	lang/string_extractor/parsers/proficiency_category.py	5	def parse_proficiency_category(json, origin):
LOW	lang/string_extractor/parsers/shop_blacklist.py	4	def parse_shopkeeper_blacklist(json, origin):
LOW	lang/string_extractor/parsers/construction_category.py	4	def parse_construction_category(json, origin):
LOW	lang/string_extractor/parsers/effect.py	4	def parse_effect_on_condition(json, origin, comment=""):
LOW	lang/string_extractor/parsers/vehicle_part_location.py	5	def parse_vehicle_part_location(json, origin):
LOW	data/mods/Sorcerer/tools/generate_code.py	322	def write_pick_favorite_spell():
LOW	build-scripts/get_affected_files.py	51	def parse_includes_files_from(
LOW	build-scripts/get_affected_files.py	92	def get_changed_files_from_list(changed_files_list):
LOW	build-scripts/get_affected_files.py	98	def get_changed_files_from_git(merge_target):
LOW	build-scripts/ci-iwyu-run.py	138	def generate_global_file_list() -> list[Path]:
LOW	src/iuse.cpp	450	static item::extended_photo_def photo_def_for_camera_point( const tripoint_bub_ms &aim_point,
LOW	src/iuse.cpp	6184	static item::extended_photo_def photo_def_for_camera_point( const tripoint_bub_ms &aim_point,

Fake / Example Data26 hits · 37 pts

Severity	File	Line	Snippet
LOW	tools/spell_checker/__init__.py	100	("Lorem ipsum dolor sit amet",
LOW	tools/spell_checker/__init__.py	100	("Lorem ipsum dolor sit amet",
LOW	tools/spell_checker/__init__.py	102	("'Lorem ipsum dolor sit amet, consectetur adipiscing elit'",
LOW	tools/spell_checker/__init__.py	102	("'Lorem ipsum dolor sit amet, consectetur adipiscing elit'",
LOW	tools/spell_checker/__init__.py	107	("Lorem ipsum, 'dolor?' sit!?", ["Lorem", "ipsum", "dolor", "sit"]),
LOW	tools/spell_checker/__init__.py	111	("«Lorem ipsum»", ["Lorem", "ipsum"]), # used in some NPC dialogue
LOW	tools/spell_checker/__init__.py	112	("Lorem ipsum", ["Lorem", "ipsum"]),
LOW	tools/spell_checker/__init__.py	113	("&Lorem ipsum", ["Lorem", "ipsum"]), # used in some NPC dialogue
LOW	tools/spell_checker/__init__.py	115	("'…Lorem ipsum…'", ["Lorem", "ipsum"]),
LOW	tools/spell_checker/__init__.py	120	("Lorem ipsum/dolor/sit amet",
LOW	tests/fold_string_test.cpp	24	SECTION( "Case 1 - test wrapping of lorem ipsum" ) {
LOW	tests/fold_string_test.cpp	26	"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque a.",
LOW	tests/fold_string_test.cpp	26	"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque a.",
LOW	tests/fold_string_test.cpp	33	"Lorem ipsum dolor",
LOW	tests/fold_string_test.cpp	79	"<color_red>Lorem ipsum dolor sit amet, <color_green>consectetur adipiscing elit</color>
LOW	tests/fold_string_test.cpp	79	"<color_red>Lorem ipsum dolor sit amet, <color_green>consectetur adipiscing elit</color>
LOW	tests/fold_string_test.cpp	83	"<color_red>Lorem ipsum dolor </color>",
LOW	src/proficiency_ui.cpp	45	// \| Proficiency 9 \| Lorem ipsum etc........ \|
LOW	src/third-party/imgui/imgui_demo.cpp	7655	ImGui::TextWrapped("Lorem ipsum dolor sit amet");
LOW	src/third-party/imgui/imgui_demo.cpp	7655	ImGui::TextWrapped("Lorem ipsum dolor sit amet");
LOW	src/third-party/imgui/imgui_demo.cpp	7657	ImGui::Text("Lorem ipsum dolor sit amet");
LOW	src/third-party/imgui/imgui_demo.cpp	7657	ImGui::Text("Lorem ipsum dolor sit amet");
LOW	src/third-party/imgui/imgui_demo.cpp	9555	ImGui::TextWrapped("Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor i
LOW	src/third-party/imgui/imgui_demo.cpp	9555	ImGui::TextWrapped("Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor i
LOW	src/third-party/imgui/imgui_demo.cpp	10516	ImGui::TextWrapped("Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut
LOW	src/third-party/imgui/imgui_demo.cpp	10516	ImGui::TextWrapped("Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut

Cross-File Repetition7 hits · 35 pts

Severity	File	Snippet
HIGH	data/json/mapgen/stadium_football.json	''`│,, g g g g g g g g g g g g g g g g g g g g g ,,│`
HIGH	data/json/mapgen/stadium_football.json	''`│,, g g g g g g g g g g g g g g g g g g g g g ,,│`
HIGH	data/json/mapgen/stadium_football.json	''`│,, g g g g g g g g g g g g g g g g g g g g g ,,│`
HIGH	data/json/mapgen/stadium_football.json	''`│,, g g g g g g g g g g g g g g g g g g g g g ,,│`
HIGH	data/json/mapgen/stadium_baseball.json	'a\|..b_b_b_r****************************************************************r_b_b_b..\|a
HIGH	data/json/mapgen/stadium_baseball.json	'a\|..b_b_b_r****************************************************************r_b_b_b..\|a
HIGH	data/json/mapgen/stadium_baseball.json	'a\|..b_b_b_r****************************************************************r_b_b_b..\|a

Excessive Try-Catch Wrapping20 hits · 29 pts

Severity	File	Line	Snippet
LOW	tools/generate_changelog.py	932	except Exception as err:
MEDIUM	tools/generate_changelog.py	929	def exit_on_exception_closure(args, *kwargs):
LOW	tools/update_blueprint_needs.py	106	except Exception:
MEDIUM	tools/json_tools/values.py	58	print("Error loading JSON data.")
LOW	tools/json_tools/util.py	38	except Exception as err:
LOW	tools/json_tools/util.py	159	except Exception:
MEDIUM	tools/json_tools/util.py	152	def __call__(self, parser, namespace, values, option_string=None):
MEDIUM	tools/json_tools/splitter.py	38	print("Error loading JSON data.")
MEDIUM	tools/json_tools/keys.py	48	print("Error loading JSON data.")
MEDIUM	tools/json_tools/pluck.py	39	print("Error loading JSON data.")
LOW	tools/json_tools/lister.py	48	except Exception:
LOW	tools/json_tools/update-translate-dialogue-mod.py	80	except Exception as err:
MEDIUM	tools/json_tools/update-translate-dialogue-mod.py	81	print(f"Error: {err}")
LOW	tools/json_tools/cddatags.py	71	except Exception as err:
LOW	tools/gfx_tools/compose.py	693	except Exception:
LOW	lang/string_extractor/parse.py	18	except Exception as E:
LOW	lang/string_extractor/parse.py	34	except Exception:
MEDIUM	lang/string_extractor/parse.py	35	print("Error in JSON object\n'{0}'\nfrom file: '{1}'".format(
MEDIUM	build-scripts/validate_json.py	22	print("Error opening {}: {}".format(file_path, e))
MEDIUM	build-scripts/validate_json.py	25	print("Error parsing {}: {}".format(file_path, e))

Docstring Block Structure5 hits · 25 pts

Severity	File	Line	Snippet
HIGH	tools/windows_limit_memory.py	282	Get an attribute from the class. Args: item: The attribute to get. Raises: Att
HIGH	tools/windows_limit_memory.py	390	[Internal] Create an I/O completion port. Notes: The I/O port is used later in the `wait_for_job()`
HIGH	tools/windows_limit_memory.py	411	[Internal] Retrieves limit and job state information from the job object. Args: structu
HIGH	tools/windows_limit_memory.py	506	Create a job. Args: job_name: The optional job name; can be `None`. Notes: Thi
HIGH	tools/windows_limit_memory.py	539	Create a new process object to be associated with the main job. Args: process_path: The path to the

Slop Phrases19 hits · 24 pts

Severity	File	Line	Snippet
LOW	tests/mondefense_test.cpp	112	// Don't forget to turn it on...
LOW	data/json/starting_missions.json	337	"description": "You have always had good social abilities. Go and recruit 2 followers and establish your leadership
LOW	data/json/snippets/radio.json	24	"What's up, people of <the_cataclysm>? I'm DJ Dustbowl, this is my canine partner in crime, Sam, and you're liste
LOW	data/json/npcs/missiondef.json	850	"accepted": "Great! <color_yellow>This bag should be big enough to hold all of the stalks we'll need. Don't forg
LOW	data/json/npcs/missiondef.json	853	"inquire": "Got those cattail stalks yet? Don't forget to <color_yellow>bring back my bag with the stalks in them
LOW	data/json/npcs/missiondef.json	863	"description": "Bring the pyromaniac to <color_light_blue>their rival's house</color> and don't forget to <color_yel
LOW	data/json/npcs/holdouts/Mr_Lapin.json	200	"accepted": "Don't forget to tell me when you have them.",
LOW	data/json/npcs/other/NPC_pizzaiolo.json	96	"description": "Bring the pizzaiolo to <color_light_blue>their rival's house</color> and don't forget to <color_yell
LOW	data/json/npcs/godco/godco_missions.json	17	"accepted": "Don't forget to tell me when you have them.",
LOW	data/json/items/armor/storage.json	1423	"description": "This is a plain, hard-sided black briefcase with a trigger in the handle and a concealed hole in the
LOW	data/mods/innawood/npcs/missiondef.json	451	"accepted": "Great! This bag should be big enough to hold all of the stalks we'll need. Don't forget to bring it
LOW	data/mods/innawood/npcs/missiondef.json	454	"inquire": "Got those cattail stalks yet? Don't forget to bring back my bag and to work on improving your surviva
LOW	…/aftershock_exoplanet/npcs/milly_whately_dialogue.json	106	"accepted": "Don't forget to tell me when you have them.",
LOW	…a/mods/aftershock_exoplanet/npcs/prepnet_dialogue.json	140	"accepted": "Don't forget to tell me when you have them.",
LOW	data/mods/aftershock_exoplanet/npcs/cyrus_whately.json	106	"accepted": "Don't forget to tell me when you have them.",
LOW	src/character_body.cpp	1545	//Incredibly annoying debug function - don't forget to comment out before merge!
LOW	src/field.h	164	* Don't forget to update field count in submap!
MEDIUM	src/third-party/imgui/imgui_widgets.cpp	7540	// Tip: pass a non-visible label (e.g. "##hello") then you can use the space to draw other text or image.
LOW	src/third-party/imgui/imgui.cpp	1020	- 2017/08/25 (1.52) - io.MousePos needs to be set to ImVec2(-FLT_MAX,-FLT_MAX) when mouse is unavailable/missing. Previ

Verbosity Indicators9 hits · 14 pts

Severity	File	Line	Snippet
LOW	tests/npc_test.cpp	6604	// Step 1: Run the executor for 5 turns to hit the no-progress timeout.
LOW	tests/npc_test.cpp	6626	// Step 2: Remove the glass walls and recommit. The NPC should
LOW	tests/recipe_steps_test.cpp	1056	// Step 0: MODERATE_EXERCISE
LOW	tests/catch/catch.hpp	12661	// No children have started. We need to check if they _can_
LOW	src/third-party/fmt/format-inl.h	1267	// Step 1: integer promotion & Schubfach multiplier calculation.
LOW	src/third-party/fmt/format-inl.h	1322	// Step 2: Try larger divisor; remove trailing zeros if necessary.
LOW	src/third-party/fmt/format-inl.h	1354	// Step 3: Find the significand with the smaller divisor.
LOW	src/third-party/imgui/imgui.cpp	3439	// Step 0: Let you process the first element (regardless of it being visible or not, so we can measure the element h
LOW	src/third-party/imgui/imgui.cpp	3456	// Step 1: Let the clipper infer height from first range

Hallucination Indicators1 hit · 10 pts

Severity	File	Line	Snippet
CRITICAL	.github/workflows/label-first-time-contributor.yml	23	const opts = github.rest.pulls.list.endpoint.merge({

Self-Referential Comments3 hits · 7 pts

Severity	File	Line	Snippet
MEDIUM	tools/setuphgamelaunch.sh	85	# Creating the directories for ttrecs in progress
MEDIUM	tools/clang-tidy-plugin/test/check_clang_tidy.py	68	# This class represents the appearance of a message prefix in a file.
MEDIUM	build-scripts/ci-iwyu-run.py	1	# This file is intended to be run on github CI, not locally

Redundant / Tautological Comments3 hits · 4 pts

Severity	File	Line	Snippet
LOW	tools/json_tools/gun_variant_validator.py	695	# Check if they've got a good token
LOW	lang/strip_line_numbers.py	27	# Write the file back out with the line numbers stripped
LOW	build-data/osx/dmgsettings.py	109	# Set these to True to force inclusion of icon/list view settings (otherwise

Unused Imports3 hits · 3 pts

Severity	File	Line
LOW	tools/build_shaders.py	21
LOW	lang/unicode_check.py	2
LOW	lang/strip_line_numbers.py	4

Score History

Severity Breakdown

Pattern Findings