AlexsJones/llmfit

Pattern Findings

233 matches across 9 categories. Click a row to expand file-level details.

Decorative Section Separators163 hits · 474 pts

Severity	File	Line	Snippet
MEDIUM	llmfit-tui/src/tui_ui.rs	4476	// ── Live inference-bench view ─────────────────────────────────────────────
MEDIUM	llmfit-tui/src/display.rs	477	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-tui/src/display.rs	479	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-tui/src/display.rs	857	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-tui/src/display.rs	859	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-tui/src/main.rs	1690	// ── --status ──────────────────────────────────────────────────────────
MEDIUM	llmfit-tui/src/main.rs	1724	// ── --clear ───────────────────────────────────────────────────────────
MEDIUM	llmfit-tui/src/main.rs	1734	// ── fetch ─────────────────────────────────────────────────────────────
MEDIUM	llmfit-tui/src/main.rs	1951	// ── bench helpers ──────────────────────────────────────────────────────────
MEDIUM	llmfit-tui/src/main.rs	2536	// ── main ───────────────────────────────────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	917	// ── Restore persisted filters ────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	1904	// ── Benchmarks view ──────────────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	2349	// ── Visual mode ──────────────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	2418	// ── Select mode ─────────────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	2484	// ── Quant popup ─────────────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	2518	// ── RunMode popup ───────────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	2553	// ── Params bucket popup ─────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	2588	// ── License popup ───────────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	2673	// ── Hardware simulation ──────────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	2827	// ── Advanced Config Popup ──────────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	2854	// ── Filter Popup ─────────────────────────────────────────────
MEDIUM	llmfit-tui/src/tui_app.rs	3803	// ── Live inference-bench view ─────────────────────────────────────────
MEDIUM	scripts/scrape_hf_models.py	932	# ---------------------------------------------------------------------------
MEDIUM	scripts/scrape_hf_models.py	934	# ---------------------------------------------------------------------------
MEDIUM	scripts/scrape_hf_models.py	1093	# ---------------------------------------------------------------------------
MEDIUM	scripts/scrape_hf_models.py	1095	# ---------------------------------------------------------------------------
MEDIUM	scripts/verify_models.py	42	# ---------------------------------------------------------------------------
MEDIUM	scripts/verify_models.py	44	# ---------------------------------------------------------------------------
MEDIUM	scripts/verify_models.py	69	# ---------------------------------------------------------------------------
MEDIUM	scripts/verify_models.py	71	# ---------------------------------------------------------------------------
MEDIUM	scripts/verify_models.py	116	# ---------------------------------------------------------------------------
MEDIUM	scripts/verify_models.py	118	# ---------------------------------------------------------------------------
MEDIUM	llmfit-core/src/fit.rs	928	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	930	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1009	// ── Bandwidth-based estimation (preferred) ─────────────────────
MEDIUM	llmfit-core/src/fit.rs	1225	// ── Fallback: fixed-constant approach ──────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1302	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1304	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1468	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1470	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1533	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1535	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1590	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1592	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1763	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1765	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1821	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	1823	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	2161	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	2163	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	2216	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	2218	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	2466	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	2468	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	2738	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	2746	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	3006	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/fit.rs	3016	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/models.rs	1416	// ────────────────────────────────────────────────────────────────────
MEDIUM	llmfit-core/src/models.rs	1418	// ────────────────────────────────────────────────────────────────────
103 more matches not shown…

Over-Commented Block29 hits · 20 pts

Severity	File	Line	Snippet
LOW	llmfit-tui/src/main.rs	41	enum SortArg {
LOW	llmfit-tui/src/main.rs	161	/// Override detected CPU core count.
LOW	llmfit-tui/src/main.rs	461	/// Limit number of recommendations
LOW	llmfit-tui/src/main.rs	581	/// Models are saved to ~/.llmfit/hf_models_cache.json and automatically
LOW	llmfit-core/src/fit.rs	1	use crate::hardware::{GpuBackend, SystemSpecs};
LOW	llmfit-core/src/fit.rs	921	}
LOW	llmfit-core/src/fit.rs	941	/// In practice, real throughput is ~50–70% of this ceiling due to kernel
LOW	llmfit-core/src/fit.rs	1001	// use active parameters when known; fit/memory paths still use full model size.
LOW	llmfit-core/src/fit.rs	1041	// MoE expert speed estimation: the per-token cost is dominated by
LOW	llmfit-core/src/fit.rs	1081	expert_read_time,
LOW	llmfit-core/src/fit.rs	1101	// Formula: tps = bw / (active_ffn_bytes + fixed_equivalent_bytes)
LOW	llmfit-core/src/fit.rs	1121	// - VRAM utilization above 60% (below 60%, model fits easily)
LOW	llmfit-core/src/fit.rs	2821	#[test]
LOW	llmfit-core/src/fit.rs	3001	tps_small > tps_large,
LOW	llmfit-core/src/models.rs	461	pub num_experts: Option<u32>,
LOW	llmfit-core/src/models.rs	481	#[serde(default)]
LOW	llmfit-core/src/models.rs	501	#[serde(default)]
LOW	llmfit-core/src/models.rs	721	/// Effective bytes-per-param for the compute-bound fixed component of MoE
LOW	llmfit-core/src/models.rs	801	/// Uses the precise per layer formula when `num_hidden_layers`,
LOW	llmfit-core/src/models.rs	1241	}
LOW	llmfit-core/src/update.rs	1	//! Online model database updates via the HuggingFace Hub API.
LOW	llmfit-core/src/update.rs	321	hidden_size: Option<u32>,
LOW	llmfit-core/src/update.rs	421	}
LOW	llmfit-core/src/hardware.rs	1741	fn is_amd_unified_memory_apu(cpu_name: &str) -> bool {
LOW	llmfit-core/src/hardware.rs	1801	}
LOW	llmfit-core/src/providers.rs	681
LOW	llmfit-core/src/providers.rs	901	.filter(\|(_, s)\| s > 0 && s <= budget_bytes)
LOW	llmfit-core/src/providers.rs	2141	let (filename, _) = LlamaCppProvider::select_best_gguf(&files, budget_gb)?;
LOW	llmfit-core/src/bench.rs	1	//! LLM inference benchmarking against Ollama, vLLM, and MLX endpoints.

Excessive Try-Catch Wrapping10 hits · 12 pts

Severity	File	Line	Snippet
MEDIUM	scripts/scrape_docker_models.py	168	print(f"Error fetching {url}: {e}", file=sys.stderr)
LOW	scripts/scrape_hf_models.py	365	except Exception as e:
LOW	scripts/scrape_hf_models.py	663	except Exception:
LOW	scripts/scrape_hf_models.py	996	except Exception:
LOW	scripts/scrape_hf_models.py	1310	except Exception as e:
LOW	scripts/test_api.py	183	except Exception:
LOW	scripts/test_api.py	263	except Exception as exc:
LOW	scripts/test_api.py	271	except Exception:
LOW	scripts/verify_models.py	38	except Exception:
LOW	scripts/scrape_benchmarks.py	104	except Exception as e:

Hyper-Verbose Identifiers8 hits · 10 pts

Severity	File	Line	Snippet
LOW	llmfit-python/tests/test_llmfit.py	15	def test_find_llmfit_bin_raises_when_missing(monkeypatch: pytest.MonkeyPatch) -> None:
LOW	scripts/scrape_docker_models.py	194	def ollama_tag_to_docker_repo(ollama_tag: str) -> str:
LOW	scripts/scrape_hf_models.py	534	def estimate_params_from_arch(config: dict \| None) -> int \| None:
LOW	scripts/scrape_hf_models.py	972	def _model_gguf_repo_candidates(repo_id: str) -> list[tuple[str, str]]:
LOW	scripts/scrape_hf_models.py	1152	def _estimate_params_from_config(config: dict) -> int \| None:
LOW	scripts/test_api.py	74	def test_models_envelope_and_limit(base_url: str) -> None:
LOW	scripts/test_api.py	83	def test_top_endpoint_excludes_too_tight(base_url: str) -> None:
LOW	scripts/test_api.py	91	def test_filters_runtime_and_use_case(base_url: str) -> None:

Deep Nesting9 hits · 9 pts

Severity	File	Line
LOW	scripts/validate_generation_scoring.py	15
LOW	scripts/validate_generation_scoring.py	169
LOW	scripts/validate_generation_scoring.py	204
LOW	scripts/validate_generation_scoring.py	241
LOW	scripts/scrape_hf_models.py	735
LOW	scripts/scrape_hf_models.py	1016
LOW	scripts/scrape_hf_models.py	1255
LOW	scripts/scrape_hf_models.py	1446
LOW	scripts/test_api.py	235

Redundant / Tautological Comments4 hits · 6 pts

Severity	File	Line	Snippet
LOW	install.sh	171	# Check if install dir is in PATH
LOW	scripts/update_models.sh	27	# Check if Python 3 is available
LOW	scripts/update_models.sh	75	# Check if cargo is available
LOW	scripts/scrape_hf_models.py	499	# Check if architecture is in known MoE configs

Unused Imports6 hits · 6 pts

Severity	File	Line
LOW	llmfit-python/hatch_build.py	27
LOW	llmfit-python/tests/test_llmfit.py	3
LOW	llmfit-python/src/llmfit/__init__.py	1
LOW	llmfit-python/src/llmfit/__main__.py	1
LOW	scripts/validate_generation_scoring.py	11
LOW	scripts/test_api.py	13

Fake / Example Data2 hits · 2 pts

Severity	File	Line	Snippet
LOW	llmfit-core/data/benchmarks.yaml	974	- { pattern: '"company"\\s:\\s"Acme Corp"', weight: 1, case_insensitive: true }
LOW	llmfit-core/data/benchmarks.yaml	976	- { pattern: '"phone"\\s:\\s"555-0123"', weight: 1 }

Verbosity Indicators2 hits · 2 pts

Severity	File	Line	Snippet
LOW	llmfit-core/src/fit.rs	313	// Step 1: pick the best available execution path
LOW	llmfit-core/src/fit.rs	314	// Step 2: score memory fit purely on headroom in that path's memory pool

Score History

Severity Breakdown

Pattern Findings